Re: [PATCH] dax: Fix missed PMD wakeups

2019-07-11 Thread Jan Kara
On Wed 10-07-19 20:08:55, Matthew Wilcox wrote: > On Wed, Jul 10, 2019 at 09:02:04PM +0200, Jan Kara wrote: > > @@ -848,7 +853,7 @@ static int dax_writeback_one(struct xa_state *xas, > > struct dax_device *dax_dev, > > if (unlikely(dax_is_locked(entry))) { > > void *old_entry = ent

Re: [PATCH] dax: Fix missed PMD wakeups

2019-07-11 Thread Jan Kara
On Wed 10-07-19 13:15:39, Matthew Wilcox wrote: > On Wed, Jul 10, 2019 at 09:02:04PM +0200, Jan Kara wrote: > > +#define DAX_ENTRY_CONFLICT dax_make_entry(pfn_to_pfn_t(1), DAX_EMPTY) > > I was hoping to get rid of DAX_EMPTY ... it's almost unused now. Once > we switch to having a single DAX_LOCK

Re: [PATCH] dax: Fix missed PMD wakeups

2019-07-11 Thread Jan Kara
On Wed 10-07-19 20:35:55, Matthew Wilcox wrote: > On Wed, Jul 10, 2019 at 09:02:04PM +0200, Jan Kara wrote: > > So how about the attached patch? That keeps the interface sane and passes a > > smoketest for me (full fstest run running). Obviously it also needs a > > proper changelog... > > Changelo

Re: [PATCH] dax: Fix missed PMD wakeups

2019-07-11 Thread Matthew Wilcox
On Thu, Jul 11, 2019 at 09:48:59AM +0200, Jan Kara wrote: > On Wed 10-07-19 20:08:55, Matthew Wilcox wrote: > > On Wed, Jul 10, 2019 at 09:02:04PM +0200, Jan Kara wrote: > > > @@ -848,7 +853,7 @@ static int dax_writeback_one(struct xa_state *xas, > > > struct dax_device *dax_dev, > > > if (unlik

Re: [PATCH] dax: Fix missed PMD wakeups

2019-07-11 Thread Matthew Wilcox
On Wed, Jul 10, 2019 at 10:26:47PM +0200, Jan Kara wrote: > On Wed 10-07-19 13:15:39, Matthew Wilcox wrote: > > On Wed, Jul 10, 2019 at 09:02:04PM +0200, Jan Kara wrote: > > > +#define DAX_ENTRY_CONFLICT dax_make_entry(pfn_to_pfn_t(1), DAX_EMPTY) > > > > I was hoping to get rid of DAX_EMPTY ... it

Re: [PATCH] dax: Fix missed PMD wakeups

2019-07-11 Thread Matthew Wilcox
On Thu, Jul 11, 2019 at 07:13:50AM -0700, Matthew Wilcox wrote: > However, the XA_RETRY_ENTRY might be a good choice. It doesn't normally > appear in an XArray (it may appear if you're looking at a deleted node, > but since we're holding the lock, we can't see deleted nodes). Updated patch (also

Re: [PATCH] virtio_pmem: fix sparse warning

2019-07-11 Thread Michael S. Tsirkin
On Wed, Jul 10, 2019 at 07:57:00PM +0530, Pankaj Gupta wrote: > This patch fixes below sparse warning related to __virtio > type in virtio pmem driver. This is reported by Intel test > bot on linux-next tree. > > nd_virtio.c:56:28: warning: incorrect type in assignment (different base > types) >

Re: [PATCH v2] virtio_pmem: fix sparse warning

2019-07-11 Thread Michael S. Tsirkin
On Wed, Jul 10, 2019 at 11:28:32PM +0530, Pankaj Gupta wrote: > This patch fixes below sparse warning related to __virtio > type in virtio pmem driver. This is reported by Intel test > bot on linux-next tree. > > nd_virtio.c:56:28: warning: incorrect type in assignment >

Re: [PATCH] virtio_pmem: fix sparse warning

2019-07-11 Thread Pankaj Gupta
> > On Wed, Jul 10, 2019 at 07:57:00PM +0530, Pankaj Gupta wrote: > > This patch fixes below sparse warning related to __virtio > > type in virtio pmem driver. This is reported by Intel test > > bot on linux-next tree. > > > > nd_virtio.c:56:28: warning: incorrect type in assignment (different

Re: [PATCH v2] virtio_pmem: fix sparse warning

2019-07-11 Thread Pankaj Gupta
> > On Wed, Jul 10, 2019 at 11:28:32PM +0530, Pankaj Gupta wrote: > > This patch fixes below sparse warning related to __virtio > > type in virtio pmem driver. This is reported by Intel test > > bot on linux-next tree. > > > > nd_virtio.c:56:28: warning: incorrect type in assignment > >

[PATCH v3] virtio_pmem: fix sparse warning

2019-07-11 Thread Pankaj Gupta
This patch fixes below sparse warning related to __virtio type in virtio pmem driver. This is reported by Intel test bot on linux-next tree. nd_virtio.c:56:28: warning: incorrect type in assignment (different base types) nd_virtio.c:56:28:expected unsigned int [