Re: [PATCH] memremap: move from kernel/ to mm/

2019-07-22 Thread Dan Williams
On Mon, Jul 22, 2019 at 2:42 AM Christoph Hellwig wrote: > > memremap.c implements MM functionality for ZONE_DEVICE, so it really > should be in the mm/ directory, not the kernel/ one. > > Signed-off-by: Christoph Hellwig Acked-by: Dan Williams ___ Li

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Brendan Higgins
On Mon, Jul 22, 2019 at 4:54 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-07-22 15:30:49) > > On Mon, Jul 22, 2019 at 1:03 PM Stephen Boyd wrote: > > > > > > > > > What's the calling context of the assertions and expectations? I still > > > don't like the fact that string stream needs

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-22 15:30:49) > On Mon, Jul 22, 2019 at 1:03 PM Stephen Boyd wrote: > > > > > > What's the calling context of the assertions and expectations? I still > > don't like the fact that string stream needs to allocate buffers and > > throw them into a list somewhere becau

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Brendan Higgins
On Mon, Jul 22, 2019 at 1:03 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-07-18 17:08:34) > > On Thu, Jul 18, 2019 at 12:22:33PM -0700, Brendan Higgins wrote: > > > > I started poking around with your suggestion while we are waiting. A > > couple early observations: > > > > 1) It is ac

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-18 17:08:34) > On Thu, Jul 18, 2019 at 12:22:33PM -0700, Brendan Higgins wrote: > > I started poking around with your suggestion while we are waiting. A > couple early observations: > > 1) It is actually easier to do than I previously thought and will probably >

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Brendan Higgins
On Thu, Jul 18, 2019 at 5:08 PM Brendan Higgins wrote: > > On Thu, Jul 18, 2019 at 12:22:33PM -0700, Brendan Higgins wrote: > > On Thu, Jul 18, 2019 at 10:50 AM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-07-16 11:52:01) > > > > On Tue, Jul 16, 2019 at 10:50 AM Stephen Boyd wro

Re: [PATCH v2 18/30] virtio_fs, dax: Set up virtio_fs dax_device

2019-07-22 Thread David Hildenbrand
On 22.07.19 14:00, Christian Borntraeger wrote: > > > On 22.07.19 13:43, Cornelia Huck wrote: >> On Mon, 22 Jul 2019 13:20:18 +0200 >> Christian Borntraeger wrote: >> >>> On 22.07.19 12:56, Dr. David Alan Gilbert wrote: * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > >

Re: [PATCH v2 18/30] virtio_fs, dax: Set up virtio_fs dax_device

2019-07-22 Thread Christian Borntraeger
On 22.07.19 13:43, Cornelia Huck wrote: > On Mon, 22 Jul 2019 13:20:18 +0200 > Christian Borntraeger wrote: > >> On 22.07.19 12:56, Dr. David Alan Gilbert wrote: >>> * Christian Borntraeger (borntrae...@de.ibm.com) wrote: On 18.07.19 16:30, Dan Williams wrote: > On Thu,

Re: [PATCH v2 18/30] virtio_fs, dax: Set up virtio_fs dax_device

2019-07-22 Thread Cornelia Huck
On Mon, 22 Jul 2019 13:20:18 +0200 Christian Borntraeger wrote: > On 22.07.19 12:56, Dr. David Alan Gilbert wrote: > > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > >> > >> > >> On 18.07.19 16:30, Dan Williams wrote: > >>> On Thu, Jul 18, 2019 at 6:15 AM Vivek Goyal wrote: > >>

Re: [PATCH v2 18/30] virtio_fs, dax: Set up virtio_fs dax_device

2019-07-22 Thread Christian Borntraeger
On 22.07.19 12:56, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >> >> >> On 18.07.19 16:30, Dan Williams wrote: >>> On Thu, Jul 18, 2019 at 6:15 AM Vivek Goyal wrote: On Wed, Jul 17, 2019 at 07:27:25PM +0200, Halil Pasic wrote: > On Wed,

Re: [PATCH v2 18/30] virtio_fs, dax: Set up virtio_fs dax_device

2019-07-22 Thread Dr. David Alan Gilbert
* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > > On 18.07.19 16:30, Dan Williams wrote: > > On Thu, Jul 18, 2019 at 6:15 AM Vivek Goyal wrote: > >> > >> On Wed, Jul 17, 2019 at 07:27:25PM +0200, Halil Pasic wrote: > >>> On Wed, 15 May 2019 15:27:03 -0400 > >>> Vivek Goyal wrote: >

Re: [PATCH v2 18/30] virtio_fs, dax: Set up virtio_fs dax_device

2019-07-22 Thread Christian Borntraeger
On 18.07.19 16:30, Dan Williams wrote: > On Thu, Jul 18, 2019 at 6:15 AM Vivek Goyal wrote: >> >> On Wed, Jul 17, 2019 at 07:27:25PM +0200, Halil Pasic wrote: >>> On Wed, 15 May 2019 15:27:03 -0400 >>> Vivek Goyal wrote: >>> From: Stefan Hajnoczi Setup a dax device. U

Re: [PATCH] memremap: move from kernel/ to mm/

2019-07-22 Thread Anshuman Khandual
On 07/22/2019 03:11 PM, Christoph Hellwig wrote: > memremap.c implements MM functionality for ZONE_DEVICE, so it really > should be in the mm/ directory, not the kernel/ one. > > Signed-off-by: Christoph Hellwig This always made sense. FWIW Reviewed-by: Anshuman Khandual __

[PATCH] memremap: move from kernel/ to mm/

2019-07-22 Thread Christoph Hellwig
memremap.c implements MM functionality for ZONE_DEVICE, so it really should be in the mm/ directory, not the kernel/ one. Signed-off-by: Christoph Hellwig --- Sending for applying just after -rc1 preferably to avoid conflicts later in the merge window kernel/Makefile | 1 - mm/Makefi