This patch fixes the compiling error when BCACHE_NVM_PAGES is disabled.
The change could be added into previous nvm-pages patches, so that this
patch can be dropped in next nvm-pages series.
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
drivers/md/bcache/nvm-pages.c | 4
merged into previous nvm-pages patches, and dropped
in next version series.
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
drivers/md/bcache/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
index fdec9905ef40..0996e3
Kernel test robot reports the built-in u64/u32 in init_owner_info()
doesn't work for m68k arch, the explicit div_u64() should be used.
This patch explicit uses div_u64() to do the u64/u32 division on
32bit m68k arch.
Reported-by: kernel test robot
Signed-off-by: Coly Li
Cc: Jianpeng M
che/register_nvdimm_meta
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
drivers/md/bcache/super.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 9640bfb85571..d95a9a3c2041 100644
--- a/drivers/md/bca
pages.
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
drivers/md/bcache/journal.c | 93 +++--
1 file changed, 69 insertions(+), 24 deletions(-)
diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c
index 9a542e6c2152..4f09ad5b994b
es the linear addresses
from NVDIMM pages (no more bucket index), in journal_reclaim() the
journaling location in c->journal.key.ptr[0] should also be updated by
linear address from NVDIMM pages (no more LBA combined by sectors offset
and bucket index).
Signed-off-by: Coly Li
Cc: Jianpe
IMM linear address stored (and updated) in sb.d[i].ptr[0] can be used
directly in memory copy from DRAM pages into NVDIMM pages.
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
drivers/md/bcache/journal.c | 105
drivers/md/bcache/journal.h | 2 +-
incompat feature set, bcache will ask the nvm-pages
allocator for NVDIMM space to store the meta data.
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
drivers/md/bcache/features.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/md/bcache/features.h b/drivers/md
.
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
drivers/md/bcache/btree.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index fe6dce125aba..28edd884bd5d 100644
--- a/drivers/md/bcache/btree.c
+++ b/d
There are two minor fixes in nvm-pages code, which can be added in next
nvm-pages series. Then I can drop this patch.
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
drivers/md/bcache/nvm-pages.c | 29 +
drivers/md/bcache/nvm-pages.h | 1 +
2 files
From: Jianpeng Ma
This patch implements bch_get_allocated_pages() of the buddy to be used to
get allocated pages from specific owner.
Signed-off-by: Jianpeng Ma
Co-authored-by: Qiaowei Ren
---
drivers/md/bcache/nvm-pages.c | 6 ++
drivers/md/bcache/nvm-pages.h | 7 ++-
2 files changed
From: Jianpeng Ma
This patch implements the bch_nvm_free_pages() of the buddy.
Signed-off-by: Jianpeng Ma
Co-authored-by: Qiaowei Ren
---
drivers/md/bcache/nvm-pages.c | 158 +-
drivers/md/bcache/nvm-pages.h | 3 +
2 files changed, 157 insertions(+), 4 deleti
From: Jianpeng Ma
This patch implements the bch_nvm_alloc_pages() of the buddy.
Signed-off-by: Jianpeng Ma
Co-authored-by: Qiaowei Ren
---
drivers/md/bcache/nvm-pages.c | 157 ++
drivers/md/bcache/nvm-pages.h | 6 ++
2 files changed, 163 insertions(+)
diff -
From: Jianpeng Ma
This nvm pages allocator will implement the simple buddy to manage the
nvm address space. This patch initializes this buddy for new namespace.
the unit of alloc/free of the buddy is page. DAX device has their
struct page(in dram or PMEM).
struct {/* ZONE_DEVICE
From: Jianpeng Ma
This patch define the prototype data structures in memory and initializes
the nvm pages allocator.
The nv address space which is managed by this allocatior can consist of
many nvm namespaces, and some namespaces can compose into one nvm set,
like cache set. For this initial imp
ge size,
which is large enough currently.
Signed-off-by: Coly Li
Cc: Jianpeng Ma
Cc: Qiaowei Ren
---
include/uapi/linux/bcache-nvm.h | 202
1 file changed, 202 insertions(+)
create mode 100644 include/uapi/linux/bcache-nvm.h
diff --git a/include/uapi/linux/bcache-nvm
node I/Os into NVDIMM.
All the code is EXPERIMENTAL, they won't be enabled by default until we
feel the NVDIMM support is completed and stable.
Any comments and suggestion is warmly welcome :-)
Thank you in advance.
Coly Li
---
Changelog:
v7: Refine nvm-pages allocator code to operate owner list
91f32959b..f154c89d1326 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -16,6 +16,7 @@
> #include "features.h"
>
> #include
> +#include
> #include
> #include
> #include [snipped]
For bcache part, Acked-by: Coly Li
On 3/3/21 4:20 PM, Hannes Reinecke wrote:
> On 3/2/21 5:02 AM, Coly Li wrote:
>> This patch adds the following helper structure and routines into
>> badblocks.h,
>> - struct bad_context
>> This structure is used in improved badblocks code for bad table
>>
() and _badblocks_check().
This patch only contains the changes of old code deletion, new added
code for the improved algorithms are in previous patches.
Signed-off-by: Coly Li
---
block/badblocks.c | 310 +-
1 file changed, 3 insertions(+), 307
eview.
Signed-off-by: Coly Li
---
block/badblocks.c | 99 +++
1 file changed, 99 insertions(+)
diff --git a/block/badblocks.c b/block/badblocks.c
index 4db6d1adff42..304b91159a42 100644
--- a/block/badblocks.c
+++ b/block/badblocks.c
@@ -1249,6 +124
_badblock_clear() for the improvement.
Later patch will delete current code of badblock_clear() and make it as
a wrapper to _badblock_clear(), so the code change can be much clear for
review.
Signed-off-by: Coly Li
---
block/badblocks.c | 319 ++
1 file
badblocks_set(), and just add a new
one named _badblocks_set(). Later patch will remove current existing
badblocks_set() code and make it as a wrapper of _badblocks_set(). So
the new added change won't be mixed with deleted code, the code review
can be easier.
Signed-off-by: Coly Li
---
ks_set()/badblocks_clear()/badblocks_check().
Signed-off-by: Coly Li
---
block/badblocks.c | 374 ++
1 file changed, 374 insertions(+)
diff --git a/block/badblocks.c b/block/badblocks.c
index d39056630d9c..fd76bbe7b5a2 100644
--- a/block/badblocks.c
+++
e improved badblocks code in following
patches.
Signed-off-by: Coly Li
---
include/linux/badblocks.h | 32
1 file changed, 32 insertions(+)
diff --git a/include/linux/badblocks.h b/include/linux/badblocks.h
index 2426276b9bd3..166161842d1f 100644
--- a/inc
ce for any review comment and suggestion.
Coly Li (6):
badblocks: add more helper structure and routines in badblocks.h
badblocks: add helper routines for badblock ranges handling
badblocks: improvement badblocks_set() for multiple ranges handling
badblocks: improve badblocks_clear() fo
On 12/18/20 11:25 AM, Dan Williams wrote:
> [ add Neil, original gooodguy who wrote badblocks ]
>
>
> On Thu, Dec 3, 2020 at 9:16 AM Coly Li wrote:
>>
>> Recently I received a bug report that current badblocks code does not
>> properly handl
On 12/20/20 4:02 AM, antlists wrote:
> On 03/12/2020 17:15, Coly Li wrote:
>> This patch is an initial effort to improve badblocks_set() for setting
>> bad blocks range when it covers multiple already set bad ranges in the
>> bad blocks table, and to do it as fast as possib
u in advance for any review or comments on this patch.
Signed-off-by: Coly Li
---
block/badblocks.c | 1041 ++---
include/linux/badblocks.h | 33 ++
2 files changed, 881 insertions(+), 193 deletions(-)
diff --git a/block/badblocks.c b/block/badblocks.
On 2020/10/12 13:28, Ira Weiny wrote:
> On Sat, Oct 10, 2020 at 10:20:34AM +0800, Coly Li wrote:
>> On 2020/10/10 03:50, ira.we...@intel.com wrote:
>>> From: Ira Weiny
>>>
>>> These kmap() calls are localized to a single thread. To avoid the over
>>
d like to be
supportive to option 2) introduce a flag to kmap(), then we won't forget
the new thread-localized kmap method, and people won't ask why a
_thread() function is called but no kthread created.
Thanks.
Coly Li
> Cc: Coly Li (maintainer:BCACHE (BLOCK LAYER CACHE))
> Cc:
: error: unaligned partition for dax
> kernel: sda3: error: unaligned partition for dax
>
Aha, yes you are right, I agree with you.
Coly Li
> Reviewed-by: John Pittman
>
> On Thu, Sep 3, 2020 at 12:12 PM Coly Li wrote:
>>
>> On 2020/9/4 00:06, Ira Weiny wrote:
>&
e for the above purpose.
Fixes: c2affe920b0e ("dax: do not print error message for non-persistent memory
block device")
Signed-off-by: Coly Li
Reviewed-and-tested-by: Adrian Huang
Reviewed-by: Ira Weiny
Reviewed-by: Mike Snitzer
Reviewed-by: Pankaj Gupta
Cc: Jan Kara
Cc: Vishal
On 2020/9/4 00:00, Mike Snitzer wrote:
> On Thu, Sep 03 2020 at 11:28am -0400,
> Coly Li wrote:
>
>> When calling __generic_fsdax_supported(), a dax-unsupported device may
>> not have dax_dev as NULL, e.g. the dax related code block is not enabled
>> by
On 2020/9/4 00:06, Ira Weiny wrote:
> On Thu, Sep 03, 2020 at 07:55:49PM +0800, Coly Li wrote:
>> When calling __generic_fsdax_supported(), a dax-unsupported device may
>> not have dax_dev as NULL, e.g. the dax related code block is not enabled
>> by Kconfi
wing change for the above purpose,
- if (!dax_dev && !bdev_dax_supported(bdev, blocksize)) {
+ if (!dax_dev || !bdev_dax_supported(bdev, blocksize)) {
Fixes: c2affe920b0e ("dax: do not print error message for non-persistent memory
block device")
Signed-off-by
wing change for the above purpose,
- if (!dax_dev && !bdev_dax_supported(bdev, blocksize)) {
+ if (!dax_dev || !bdev_dax_supported(bdev, blocksize)) {
Fixes: c2affe920b0e ("dax: do not print error message for non-persistent memory
block device")
Signed-off-by
wing change for the above purpose,
- if (!dax_dev && !bdev_dax_supported(bdev, blocksize)) {
+ if (!dax_dev || !bdev_dax_supported(bdev, blocksize)) {
Fixes: c2affe920b0e ("dax: do not print error message for non-persistent memory
block device")
Signed-off-
On 2020/9/3 19:24, Adrian Huang12 wrote:
>
>> -Original Message-
>> From: Coly Li
>> Sent: Thursday, September 3, 2020 4:37 PM
>> To: Mike Snitzer
>> Cc: Jan Kara ; Ira Weiny ; Pankaj Gupta
>> ; Vishal Verma ;
>> linux-nvdimm@lists.01.o
On 2020/9/3 19:09, Adrian Huang12 wrote:
> Hi Coly,
>
>> -Original Message-----
>> From: Coly Li
>> Sent: Thursday, September 3, 2020 1:20 PM
>> To: Mike Snitzer
>> Cc: Jan Kara ; Ira Weiny ; Pankaj Gupta
>> ; Vishal Verma ;
>> linux
On 2020/9/3 13:20, Coly Li wrote:
> On 2020/9/3 00:51, Mike Snitzer wrote:
>> On Wed, Sep 02 2020 at 12:46pm -0400,
>> Coly Li wrote:
>>
>>> On 2020/9/3 00:44, Mike Snitzer wrote:
>>>> On Wed, Sep 02 2020 at 12:40pm -0400,
>>>> Coly Li w
On 2020/9/3 00:51, Mike Snitzer wrote:
> On Wed, Sep 02 2020 at 12:46pm -0400,
> Coly Li wrote:
>
>> On 2020/9/3 00:44, Mike Snitzer wrote:
>>> On Wed, Sep 02 2020 at 12:40pm -0400,
>>> Coly Li wrote:
>>>
>>>> On 2020/9/3 00:04, Mike Snit
On 2020/9/3 00:51, Mike Snitzer wrote:
> On Wed, Sep 02 2020 at 12:46pm -0400,
> Coly Li wrote:
>
>> On 2020/9/3 00:44, Mike Snitzer wrote:
>>> On Wed, Sep 02 2020 at 12:40pm -0400,
>>> Coly Li wrote:
>>>
>>>> On 2020/9/3 00:04, Mike Snit
On 2020/9/3 07:05, Verma, Vishal L wrote:
> On Thu, 2020-09-03 at 00:40 +0800, Coly Li wrote:
>> On 2020/9/3 00:04, Mike Snitzer wrote:
>>> 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in
>>> __generic_fsdax_supported()") switched from
On 2020/9/3 00:51, Mike Snitzer wrote:
> On Wed, Sep 02 2020 at 12:46pm -0400,
> Coly Li wrote:
>
>> On 2020/9/3 00:44, Mike Snitzer wrote:
>>> On Wed, Sep 02 2020 at 12:40pm -0400,
>>> Coly Li wrote:
>>>
>>>> On 2020/9/3 00:04, Mike Snit
On 2020/9/3 00:44, Mike Snitzer wrote:
> On Wed, Sep 02 2020 at 12:40pm -0400,
> Coly Li wrote:
>
>> On 2020/9/3 00:04, Mike Snitzer wrote:
>>> 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in
>>> __generic_fsdax_supported()") switche
ss failed (-95)
> [66567.503693] dm-2: error: dax access failed (-95)
>
> commit 231609785cbfb must be reverted.
>
> Please advise, thanks.
Adrian Huang from Lenovo posted a patch, which titled: dax: do not print
error message for non-persistent memory block devic
of the block devices 'sdb3' and 'sdk3'
> (configured by device mapper) is NULL in function
> generic_fsdax_supported() because the member is configured in
> function open_table_device().
>
> To prevent the confusing error messages in this scenario (this is
> norma
eported-by: Michal Suchanek
Suggested-by: Jan Kara
Signed-off-by: Coly Li
Reviewed-by: Jan Kara
Reviewed-by: Ira Weiny
Reviewed-by: Pankaj Gupta
Cc: Dan Williams
Cc: Anthony Iliopoulos
---
Changelog:
v3: Fix a typo in commit log, add reviewed-by from Ira Weiny and
Pankaj Gupta.
v2: Add review
eported-by: Michal Suchanek
Suggested-by: Jan Kara
Signed-off-by: Coly Li
Reviewed-by: Jan Kara
Cc: Dan Williams
Cc: Anthony Iliopoulos
---
Changelog:
v2: Add reviewed-by from Jan Kara
v1: initial version.
drivers/dax/super.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
di
eported-by: Michal Suchanek
Suggested-by: Jan Kara
Signed-off-by: Coly Li
Reviewed-by: Jan Kara
Cc: Dan Williams
Cc: Anthony Iliopoulos
---
Changelog:
v2: Add reviewed-by from Jan Kara
v1: initial version.
drivers/dax/super.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
di
eported-by: Michal Suchanek
Suggested-by: Jan Kara
Signed-off-by: Coly Li
Cc: Dan Williams
Cc: Anthony Iliopoulos
---
drivers/dax/super.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 8e32345be0f7..de0d02ec0347 10
ic_make_request(). Anyway, if it is decided, for bcache
part,
Acked-by: Coly Li
> ---
> Documentation/block/biodoc.rst| 2 +-
> .../fault-injection/fault-injection.rst | 2 +-
> Documentation/trace/ftrace.rst| 4 +--
> block/bio.c
Also remove the request_queue argument to it, as
> the queue can be derived pretty trivially from the bio.
>
> Signed-off-by: Christoph Hellwig
For the bcache part,
Acked-by: Coly Li
> ---
> Documentation/block/biodoc.rst| 2 +-
> .../block/writeback_
On 2020/7/1 16:59, Christoph Hellwig wrote:
> Nothing in bcache actually uses the ->queuedata field.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Coly Li
> ---
> drivers/md/bcache/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/
Dan Williams
> Cc: Vishal Verma
> Cc: Dave Jiang
> Cc: Ira Weiny
> Cc: linux-nvdimm@lists.01.org
> Cc: linux-ker...@vger.kernel.org
> Cc: Coly Li
> Signed-off-by: Richard Palethorpe
Reviewed-by: Coly Li
Thanks.
Coly Li
> ---
>
> V2:
> + Reviewed by Coly a
On 2020/5/25 19:30, Christoph Hellwig wrote:
> Switch bcache to use the nicer bio accounting helpers, and call the
> routines where we also sample the start time to give coherent accounting
> results.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Coly Li
Coly Li
> ---
&g
with "PAGE_SECTORS_SHIFT" too
> and rename SECTOR_MASK to PAGE_SECTORS_MASK.
>
> Signed-off-by: Matteo Croce
Hi Matteo,
For the bcache part, it looks good to me.
Acked-by: Coly Li
> ---
> v3:
> As Guoqing Jiang suggested, replace "PAGE_SHIFT - 9"
58 matches
Mail list logo
