Re: [PATCH v4 0/2] ext4: fix DAX dma vs truncate/hole-punch

2018-09-11 Thread Eric Sandeen
On 9/11/18 12:28 PM, Theodore Y. Ts'o wrote: > On Tue, Sep 11, 2018 at 05:20:24PM +0200, Jan Kara wrote: >>> Hum, it seems Ted never picked this patch up. I guess I'll gather the two >>> fixes you pointed out and resend them to Ted. >> >> Actually only one patch when looking into it now. > > I bel

Re: [PATCH v4 0/2] ext4: fix DAX dma vs truncate/hole-punch

2018-09-10 Thread Eric Sandeen
On 8/7/18 3:45 AM, Jan Kara wrote: > On Fri 27-07-18 10:28:51, Ross Zwisler wrote: >> + fsdevel and the xfs list. >> >> On Wed, Jul 25, 2018 at 4:28 PM Ross Zwisler >> wrote: >>> On Wed, Jul 11, 2018 at 10:17:41AM +0200, Jan Kara wrote: On Tue 10-07-18 13:10:29, Ross Zwisler wrote: > Chan

Re: [PATCH v2 1/2] ext4: Close race between direct IO and ext4_break_layouts()

2018-09-10 Thread Eric Sandeen
On 8/8/18 12:25 PM, Dave Jiang wrote: > From: Ross Zwisler > > If the refcount of a page is lowered between the time that it is returned > by dax_busy_page() and when the refcount is again checked in > ext4_break_layouts() => ___wait_var_event(), the waiting function > ext4_wait_dax_page() will n

Re: [PATCH v4 1/2] dax: dax_layout_busy_page() warn on !exceptional

2018-08-10 Thread Eric Sandeen
On 7/10/18 2:10 PM, Ross Zwisler wrote: > Inodes using DAX should only ever have exceptional entries in their page > caches. Make this clear by warning if the iteration in > dax_layout_busy_page() ever sees a non-exceptional entry, and by adding a > comment for the pagevec_release() call which onl

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Eric Sandeen
On 8/10/18 2:24 PM, Ross Zwisler wrote: > On Fri, Aug 10, 2018 at 9:23 AM Dave Jiang wrote: >> On 08/10/2018 11:31 AM, Eric Sandeen wrote: >>> On 8/8/18 12:31 PM, Dave Jiang wrote: >>>> This patch is the duplicate of ross's fix for ext4 for xfs. >>>

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Eric Sandeen
On 8/8/18 12:31 PM, Dave Jiang wrote: > This patch is the duplicate of ross's fix for ext4 for xfs. > > If the refcount of a page is lowered between the time that it is returned > by dax_busy_page() and when the refcount is again checked in > xfs_break_layouts() => ___wait_var_event(), the waiting

Re: [PATCH] mm: reject MAP_SHARED_VALIDATE without new flags

2018-06-27 Thread Eric Sandeen
On 6/27/18 9:37 PM, Linus Torvalds wrote: > On Wed, Jun 27, 2018 at 7:17 PM Eric Sandeen wrote: >> >> What broke is that mmap(MAP_SHARED|MAP_PRIVATE) now succeeds without error, >> whereas before it rightly returned -EINVAL. > > You're still confusing *behavi

Re: [PATCH] mm: reject MAP_SHARED_VALIDATE without new flags

2018-06-27 Thread Eric Sandeen
On 6/27/18 9:10 PM, Linus Torvalds wrote: > On Wed, Jun 27, 2018 at 6:45 PM Eric Sandeen wrote: >> >> Thus the invalid flag combination of (MAP_SHARED|MAP_PRIVATE) now >> passes without error, which is a regression. > > It's not a regression, it's just ne

[PATCH] mm: reject MAP_SHARED_VALIDATE without new flags

2018-06-27 Thread Eric Sandeen
knows when to use the VALIDATE flag. I'm not super happy with this, because it also means that code which explicitly asks for mmap(MAP_SHARED|MAP_PRIVATE|MAP_SYNC) will also pass, but I'm not sure there's anything to do about that. Reported-by: Zhibin Li Signed-off-by: Eric Sandeen

Re: [PATCH resend 1/7] fs: allow per-device dax status checking for filesystems

2018-05-25 Thread Eric Sandeen
is wrinkle, i.e. mount -o dax means at least /one/ of the devices must support it, and then at runtime whichever file you try to use dax on still needs to be on a device that supports it ... but ok, anyway this seems fine functionally. you've assured me that xfstests are coming ;) Revie

Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code

2017-12-06 Thread Eric Sandeen
On 12/5/17 6:27 PM, Dave Chinner wrote: > FYI, I posted a fix for this weeks ago. I think Eric has already > picked it up, but it hasn't been pushed out into the for-next branch > yet. Yes, sorry for the delay. Will be pushed out soon. > Cheers, > > Dave. > __

Re: [xfsprogs PATCH 2/2] xfs_io: add a new 'log_writes' command

2017-11-17 Thread Eric Sandeen
On 11/17/17 3:14 PM, Ross Zwisler wrote: > On Fri, Nov 17, 2017 at 03:03:39PM -0600, Eric Sandeen wrote: >> On 11/17/17 2:48 PM, Ross Zwisler wrote: >>> On Fri, Nov 17, 2017 at 02:39:07PM -0600, Eric Sandeen wrote: >>>> On 11/17/17 2:25 PM, Ross Zwisler wrot

Re: [xfsprogs PATCH 2/2] xfs_io: add a new 'log_writes' command

2017-11-17 Thread Eric Sandeen
On 11/17/17 2:48 PM, Ross Zwisler wrote: > On Fri, Nov 17, 2017 at 02:39:07PM -0600, Eric Sandeen wrote: >> On 11/17/17 2:25 PM, Ross Zwisler wrote: >>> Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes >>> log marks via the external &

Re: [xfsprogs PATCH 2/2] xfs_io: add a new 'log_writes' command

2017-11-17 Thread Eric Sandeen
On 11/17/17 2:25 PM, Ross Zwisler wrote: > Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes > log marks via the external 'dmsetup' executable. It's helpful to allow > users of xfs_io to adds these marks from within xfs_io instead of waiting > until after xfs_io exits becau

Re: [PATCH 1/7] xfs: always use DAX if mount option is used

2017-09-26 Thread Eric Sandeen
On 9/26/17 6:09 AM, Dave Chinner wrote: > On Tue, Sep 26, 2017 at 11:35:48AM +0200, Jan Kara wrote: >> On Tue 26-09-17 09:38:12, Dave Chinner wrote: >>> On Mon, Sep 25, 2017 at 05:13:58PM -0600, Ross Zwisler wrote: Before support for the per-inode DAX flag was disabled the XFS the code had >

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-05 Thread Eric Sandeen
On 9/5/17 5:35 PM, Ross Zwisler wrote: > The original intent of this series was to add a per-inode DAX flag to ext4 > so that it would be consistent with XFS. In my travels I found and fixed > several related issues in both ext4 and XFS. Hi Ross - hch had a lot of reasons to nuke the dax flag fr