Re: [fstests PATCH v2 1/2] src/: add license and copyright info to files

2018-07-14 Thread Eryu Guan
On Tue, Jul 10, 2018 at 04:09:41PM -0600, Ross Zwisler wrote: > Add copyright and license info to files that I've authored in src/. > > Signed-off-by: Ross Zwisler Thanks for the copyright and license update, I've applied it for next update. Thanks, Eryu

Re: [fstests PATCH v2 2/2] generic/999: test DAX DMA vs truncate/hole-punch

2018-07-14 Thread Eryu Guan
On Tue, Jul 10, 2018 at 04:09:42PM -0600, Ross Zwisler wrote: > This adds a regression test for the following series: > > https://lists.01.org/pipermail/linux-nvdimm/2018-July/016842.html > > which adds synchronization between DAX DMA in ext4 and truncate/hole-punch. > The intention of the test i

Re: [fstests PATCH 1/2] src/: fix up mmap() error checking

2018-06-21 Thread Eryu Guan
On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > I noticed that in some of my C tests in src/ I was incorrectly checking for > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > clean up some places where we were testing against -1 (the actual value of > MAP_F

Re: [fstests PATCH 2/2] generic/999: test DAX DMA vs truncate/hole-punch

2018-06-20 Thread Eryu Guan
On Wed, Jun 20, 2018 at 04:51:47PM -0600, Ross Zwisler wrote: > This adds a regression test for the following series: > > https://lists.01.org/pipermail/linux-nvdimm/2018-June/016431.html > > which added synchronization between DAX DMA in ext4 and > truncate/hole-punch. The intention of the test

Re: [fstests PATCH 2/2] generic/347: dm-thin lacks DAX support

2018-01-17 Thread Eryu Guan
On Wed, Jan 17, 2018 at 04:23:51PM -0700, Ross Zwisler wrote: > generic/347 currently fails when run in cojunction with the DAX mount > option: > > generic/347 72s ... - output mismatch (see > /root/project/xfstests/results//generic/347.out.bad) > --- tests/generic/347.out 2016-05-12 11:56:32.

Re: [fstests PATCH v6 2/2] generic: add test for DAX MAP_SYNC support

2017-12-09 Thread Eryu Guan
On Fri, Dec 08, 2017 at 10:47:47AM -0700, Ross Zwisler wrote: > On Fri, Dec 08, 2017 at 02:36:10PM +0800, Eryu Guan wrote: > > > (Test was re-numbered as generic/470, BTW.) > > Thanks! For future reference, does the pattern of us submitting tests with > high numbers (generi

Re: [fstests PATCH v6 2/2] generic: add test for DAX MAP_SYNC support

2017-12-07 Thread Eryu Guan
On Thu, Dec 07, 2017 at 04:19:50PM -0700, Ross Zwisler wrote: > This test creates a file and writes to it via an mmap(), but never syncs > via fsync/msync. This process is tracked via dm-log-writes, then replayed. > > If MAP_SYNC is working the dm-log-writes replay will show the test file > with

Re: [fstests PATCH v5 2/2] generic: add test for DAX MAP_SYNC support

2017-12-07 Thread Eryu Guan
On Tue, Dec 05, 2017 at 05:37:44PM -0700, Ross Zwisler wrote: > This test creates a file and writes to it via an mmap(), but never syncs > via fsync/msync. This process is tracked via dm-log-writes, then replayed. > > If MAP_SYNC is working the dm-log-writes replay will show the test file > with

Re: [fstests PATCH v4 3/4] dm-log-writes: allow DAX to be used when possible

2017-11-17 Thread Eryu Guan
On Fri, Nov 17, 2017 at 01:28:27PM -0700, Ross Zwisler wrote: > Enhance _require_dm_target so that a user can request a minimum version of a > given dm target. > > DAX support was added to v1.1.0 of the dm-log-writes kernel module, so > allow the DAX mount option starting with that version. Is is

Re: [fstests PATCH v4 2/4] dm-log-writes: only replay log to marks that exist

2017-11-17 Thread Eryu Guan
On Fri, Nov 17, 2017 at 01:28:26PM -0700, Ross Zwisler wrote: > The 'replay-log' executable will replay the dm-log-writes log until the > given mark, or until the end of the log if the mark isn't found. > > This means that if the mark you're looking for was never inserted in the > log or if you gi

Re: [fstests PATCH v2] xfs: add regression test for DAX mount option usage

2017-09-13 Thread Eryu Guan
Hi Ross, On Mon, Sep 11, 2017 at 02:01:03PM -0600, Ross Zwisler wrote: > This adds a regression test for the following kernel patch: > > xfs: always use DAX if mount option is used > > This test will also pass with kernel v4.14-rc1 and beyond because the XFS > DAX I/O mount option has been dis

Re: [PATCH 3/3] ext4: test for inline data + DAX corruption

2017-09-13 Thread Eryu Guan
On Mon, Sep 11, 2017 at 10:45:21PM -0600, Ross Zwisler wrote: > Add a regression test for the following kernel commit: > > ext4: prevent data corruption with inline data + DAX > > The test passes either if we don't encounter corruption, or if mounting > with DAX + inline data fails. The latter

Re: [PATCH 2/3] ext4: test for DAX + journaling corruption

2017-09-13 Thread Eryu Guan
On Mon, Sep 11, 2017 at 10:45:20PM -0600, Ross Zwisler wrote: > Add a regression test for the following kernel commit: > > ext4: prevent data corruption with journaling + DAX > > The test passes if either we successfully compare the data between the mmap > with journaling turned on and the one

Re: [fstests PATCH] generic: add test for executables on read-only DAX mounts

2017-08-30 Thread Eryu Guan
On Tue, Aug 29, 2017 at 04:37:15PM -0600, Ross Zwisler wrote: > This adds a regression test for the following kernel patch: > > commit 42d4a99b09cb ("ext4: fix fault handling when mounted with -o dax,ro") > > The above patch fixes an issue with ext4 where executables cannot be run on > read-only

Re: [PATCH v2 2/2] dax: add regression test for stale mmap reads

2017-04-26 Thread Eryu Guan
On Tue, Apr 25, 2017 at 02:51:06PM -0600, Ross Zwisler wrote: > This adds a regression test for the following kernel patch: > > dax: fix data corruption due to stale mmap reads > > The above patch fixes an issue where users of DAX can suffer data > corruption from stale mmap reads via the follo

Re: [PATCH 2/2] dax: add regression test for stale mmap reads

2017-04-25 Thread Eryu Guan
On Tue, Apr 25, 2017 at 02:39:11PM -0600, Ross Zwisler wrote: > On Tue, Apr 25, 2017 at 07:27:39PM +0800, Eryu Guan wrote: > > On Mon, Apr 24, 2017 at 11:49:32AM -0600, Ross Zwisler wrote: > > > This adds a regression test for the following kernel patch: > > > > >

Re: [PATCH 2/2] dax: add regression test for stale mmap reads

2017-04-25 Thread Eryu Guan
On Mon, Apr 24, 2017 at 11:49:32AM -0600, Ross Zwisler wrote: > This adds a regression test for the following kernel patch: > > dax: fix data corruption due to stale mmap reads > Seems that this patch hasn't been merged into linus tree, thus 4.11-rc8 kernel should fail this test, but it passed

Re: [PATCH] test: add fio test for device-dax

2017-03-30 Thread Eryu Guan
On Thu, Mar 30, 2017 at 02:16:00PM +0800, Xiong Zhou wrote: > Ccing Eryu > > On Wed, Mar 29, 2017 at 02:12:25PM -0700, Dan Williams wrote: > > On Wed, Mar 29, 2017 at 2:04 PM, Jeff Moyer wrote: > > > Dan Williams writes: > > > > > >>> Can we stop with this kernel version checking, please? T

Re: [PATCH v6 2/2] generic: test mmap io through DAX and non-DAX

2017-02-16 Thread Eryu Guan
On Wed, Feb 08, 2017 at 12:11:18PM +0800, Xiong Zhou wrote: > Mount TEST_DEV as non-DAX, SCRATCH_DEV as DAX, then > do some IO between them. In this case we use mmap > and dio/buffered IO read/write test programme. > > Signed-off-by: Ross Zwisler > Signed-off-by: Xiong Zhou > --- > tests/generi

Re: [PATCH v4 0/2] mmap dio and DAX

2017-02-02 Thread Eryu Guan
On Fri, Feb 03, 2017 at 01:57:17PM +0800, Xiong Zhou wrote: > > I just wanted to let you know that I'm testing with these new xfstests right > > now, and so far I've been unable to successfully get any PMD faults. I'm > > looking into why that is right now, and should hopefully have some changes

Re: [PATCH 4/4] generic: test mmap dio through DAX and non-DAX

2017-01-18 Thread Eryu Guan
On Wed, Jan 18, 2017 at 11:07:06AM +0800, Xiong Zhou wrote: > Signed-off-by: Xiong Zhou Better to have detailed commit log. > --- > tests/generic/405 | 100 > ++ > tests/generic/405.out | 2 + > tests/generic/group | 1 + > 3 files chan

Re: [PATCH 3/4] xfs: test per-inode DAX flag by IO

2017-01-18 Thread Eryu Guan
On Wed, Jan 18, 2017 at 11:07:05AM +0800, Xiong Zhou wrote: > We do mmap and O_DIRECT read/write, through files > with and without DAX flag. > > Signed-off-by: Xiong Zhou I think patch 1/4 and 2/4 could be folded into this patch, where the new helper and test program are used for the first time.

Re: [PATCH 1/4] common/rc: add _require_scratch_dax

2017-01-18 Thread Eryu Guan
On Wed, Jan 18, 2017 at 11:07:03AM +0800, Xiong Zhou wrote: > To make sure we can test DAX feature on SCRATCH_DEV. > > Signed-off-by: Xiong Zhou > --- > common/rc | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/common/rc b/common/rc > index 892c46e..ea7956b 100644 > --- a/c