Re: [PATCH v2] nvdimm: Avoid race between probe and reading device attributes

2021-01-07 Thread Michal Suchánek
Ping? On Mon, Jun 15, 2020 at 08:47:23AM +0100, Richard Palethorpe wrote: > It is possible to cause a division error and use-after-free by querying the > nmem device before the driver data is fully initialised in nvdimm_probe. E.g > by doing > > (while true; do > cat /sys/bus/nd/devices/nmem

Re: Feedback requested: Exposing NVDIMM performance statistics in a generic way

2020-10-23 Thread Michal Suchánek
Hello, On Thu, May 28, 2020 at 11:59 AM Vaibhav Jain wrote: > > Thanks for this taking time to look into this Dan, > > Agree with the points you have made earlier that I am summarizing below: > > * This is better done in ndctl rather than ipmctl. > * Should only expose general performance metrics

Re: [RFC PATCH 0/4] powerpc/papr_scm: Add support for reporting NVDIMM performance statistics

2020-10-21 Thread Michal Suchánek
Hello, apparently this has not received any (public) comments. Maybe resend without the RFC status? Clearly the kernel interface must be defined first, and then ndctl can follow and make use of it. Thanks Michal On Mon, May 18, 2020 at 04:38:10PM +0530, Vaibhav Jain wrote: > The patch-set pro

Re: [PATCH 3/3] namespace-action: Drop zero namespace checks.

2020-09-01 Thread Michal Suchánek
On Fri, Aug 28, 2020 at 11:51:05AM +0200, Michal Suchanek wrote: > From: Santosh Sivaraj > > With seed namespaces catched early on these checks for sizes in enable > and destroy namespace code path are not needed. Effectively reverts the two below commits: Fixes: b9cb03f6d5a8 ("ndctl/namespace:

Re: dm writecache: reject asynchronous pmem.

2020-06-30 Thread Michal Suchánek
On Tue, Jun 30, 2020 at 09:36:33AM -0400, Mike Snitzer wrote: > On Tue, Jun 30 2020 at 10:10am -0400, > Michal Suchánek wrote: > > > On Tue, Jun 30, 2020 at 09:32:01AM -0400, Mikulas Patocka wrote: > > > > > > > > > On Tue, 30 Jun 2020, Michal Suc

Re: [PATCH] dm writecache: reject asynchronous pmem.

2020-06-30 Thread Michal Suchánek
On Tue, Jun 30, 2020 at 09:32:01AM -0400, Mikulas Patocka wrote: > > > On Tue, 30 Jun 2020, Michal Suchanek wrote: > > > The writecache driver does not handle asynchronous pmem. Reject it when > > supplied as cache. > > > > Link: https://lore.kernel.org/linux-nvdimm/87lfk5hahc@linux.ibm.com

Re: [PATCH v6 6/8] powerpc/pmem: Avoid the barrier in flush routines

2020-06-30 Thread Michal Suchánek
On Mon, Jun 29, 2020 at 06:50:15PM -0700, Dan Williams wrote: > On Mon, Jun 29, 2020 at 1:41 PM Aneesh Kumar K.V > wrote: > > > > Michal Suchánek writes: > > > > > Hello, > > > > > > On Mon, Jun 29, 2020 at 07:27:20PM +0530, Aneesh Kumar K.V wro

Re: [PATCH v6 6/8] powerpc/pmem: Avoid the barrier in flush routines

2020-06-29 Thread Michal Suchánek
Hello, On Mon, Jun 29, 2020 at 07:27:20PM +0530, Aneesh Kumar K.V wrote: > nvdimm expect the flush routines to just mark the cache clean. The barrier > that mark the store globally visible is done in nvdimm_flush(). > > Update the papr_scm driver to a simplified nvdim_flush callback that do > onl

Re: [PATCH v2 3/5] libnvdimm/nvdimm/flush: Allow architecture to override the flush barrier

2020-06-26 Thread Michal Suchánek
On Fri, May 22, 2020 at 09:01:17AM -0400, Mikulas Patocka wrote: > > > On Fri, 22 May 2020, Aneesh Kumar K.V wrote: > > > On 5/22/20 3:01 PM, Michal Suchánek wrote: > > > On Thu, May 21, 2020 at 02:52:30PM -0400, Mikulas Patocka wrote: > > > > > > > > > > > > On Thu, 21 May 2020, Dan Williams

Re: [RFC PATCH 1/2] libnvdimm: Add prctl control for disabling synchronous fault support.

2020-06-01 Thread Michal Suchánek
; > > > Thanks Michal. I also missed Jeff in this email thread. > > > > > > > > And I think you'll also need some of the sched maintainers for the prctl > > > > bits... > > > > > > > > > On 5/29/20 3:03 PM, Michal Suchánek

Re: [RFC PATCH 1/2] libnvdimm: Add prctl control for disabling synchronous fault support.

2020-05-29 Thread Michal Suchánek
Adding Jan On Fri, May 29, 2020 at 11:11:39AM +0530, Aneesh Kumar K.V wrote: > With POWER10, architecture is adding new pmem flush and sync instructions. > The kernel should prevent the usage of MAP_SYNC if applications are not using > the new instructions on newer hardware. > > This patch adds a

Re: [PATCH v2 3/5] libnvdimm/nvdimm/flush: Allow architecture to override the flush barrier

2020-05-22 Thread Michal Suchánek
On Thu, May 21, 2020 at 02:52:30PM -0400, Mikulas Patocka wrote: > > > On Thu, 21 May 2020, Dan Williams wrote: > > > On Thu, May 21, 2020 at 10:03 AM Aneesh Kumar K.V > > wrote: > > > > > > > Moving on to the patch itself--Aneesh, have you audited other persistent > > > > memory users in the k

Re: [ndctl PATCH v2 14/26] ndctl/namespace: Handle 'create-namespace' in label-less mode

2019-08-21 Thread Michal Suchánek
On Wed, 21 Aug 2019 18:03:18 + "Verma, Vishal L" wrote: > On Wed, 2019-08-21 at 14:56 +0200, Michal Suchánek wrote: > > Hello, > > > > this patch is marked as superseded in the patchwork. > > > > What is the intended replacement? > > &g

Re: [ndctl PATCH v2 14/26] ndctl/namespace: Handle 'create-namespace' in label-less mode

2019-08-21 Thread Michal Suchánek
Hello, this patch is marked as superseded in the patchwork. What is the intended replacement? Thanks Michal On Sat, 27 Jul 2019 14:40:36 -0700 Dan Williams wrote: > A common confusion with ndctl is that 'create-namespace' does not work > in the label-less case. In the label-less case there i

Re: [PATCH 2/2] mm/dax: Don't enable huge dax mapping by default

2019-03-06 Thread Michal Suchánek
On Wed, 06 Mar 2019 14:47:33 +0530 "Aneesh Kumar K.V" wrote: > Dan Williams writes: > > > On Thu, Feb 28, 2019 at 1:40 AM Oliver wrote: > >> > >> On Thu, Feb 28, 2019 at 7:35 PM Aneesh Kumar K.V > >> wrote: > Also even if the user decided to not use THP, by > echo "never" > transparent_