[PATCH ndctl] dimm: re-fix potential fd leakage in dimm_action()

2021-01-06 Thread Michal Suchanek
ware activation") Signed-off-by: Michal Suchanek --- ndctl/dimm.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/ndctl/dimm.c b/ndctl/dimm.c index 09ce49e1d2ca..1c177b5494ec 100644 --- a/ndctl/dimm.c +++ b/ndctl/dimm.c @@ -1333,12 +1333,15 @@ static int

[PATCH ndctl rebased 3/3] namespace-action: Drop zero namespace checks.

2021-01-06 Thread Michal Suchanek
chwork.kernel.org/patch/11739975/ Signed-off-by: Santosh Sivaraj [rebased on top of the previous patches] Signed-off-by: Michal Suchanek --- ndctl/lib/libndctl.c | 5 - ndctl/namespace.c| 10 -- 2 files changed, 15 deletions(-) diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/lib

[PATCH ndctl rebased 2/3] ndctl/namespace: Suppress -ENXIO when processing all namespaces.

2021-01-06 Thread Michal Suchanek
# ndctl destroy-namespace all destroyed 0 namespaces Note: this does change the return value from -ENXIO to 0 in the cases when no namespaces exist and processing all namespaces was requested. Link: https://patchwork.kernel.org/patch/11681431/ Signed-off-by: Michal Suchanek Reviewed-by: Santosh S

[PATCH ndctl rebased 1/3] ndctl/namespace: Skip seed namespaces when processing all namespaces.

2021-01-06 Thread Michal Suchanek
skipping namespaces with zero size and UUID is a good heuristic. The user can still specify the namespace by name directly in case processing it is desirable. Fixes: #41 Link: https://patchwork.kernel.org/patch/11473645/ Reviewed-by: Santosh S Tested-by: Harish Sriram Signed-off-by: Michal Suchanek

[PATCH 1/3] ndctl/namespace: Skip seed namespaces when processing all namespaces.

2020-08-28 Thread Michal Suchanek
skipping namespaces with zero size and UUID is a good heuristic. The user can still specify the namespace by name directly in case processing it is desirable. Fixes: #41 Link: https://patchwork.kernel.org/patch/11473645/ Reviewed-by: Santosh S Tested-by: Harish Sriram Signed-off-by: Michal Suchanek

[PATCH 3/3] namespace-action: Drop zero namespace checks.

2020-08-28 Thread Michal Suchanek
From: Santosh Sivaraj With seed namespaces catched early on these checks for sizes in enable and destroy namespace code path are not needed. Link: https://patchwork.kernel.org/patch/11739975/ Signed-off-by: Santosh Sivaraj [rebased on top of the previous patches] Signed-off-by: Michal Suchanek

[PATCH 2/3] ndctl/namespace: Suppress -ENXIO when processing all namespaces.

2020-08-28 Thread Michal Suchanek
# ndctl destroy-namespace all destroyed 0 namespaces Note: this does change the return value from -ENXIO to 0 in the cases when no namespaces exist and processing all namespaces was requested. Link: https://patchwork.kernel.org/patch/11681431/ Signed-off-by: Michal Suchanek Reviewed-by: Santosh S

[PATCH 2/2] ndctl/namespace: Suppress ENODEV when processing all namespaces.

2020-07-23 Thread Michal Suchanek
# ndctl destroy-namespace all destroyed 0 namespaces Note: this does change the return value from -ENOENT to 0 in the cases when no namespaces exist and processing all namespaces was requested. Signed-off-by: Michal Suchanek --- ndctl/namespace.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 1/2] ndctl/namespace: skip zero namespaces when processing all namespaces.

2020-07-23 Thread Michal Suchanek
: #41 Reviewed-by: Santosh S Tested-by: Harish Sriram Signed-off-by: Michal Suchanek --- ndctl/namespace.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/ndctl/namespace.c b/ndctl/namespace.c index e734248c9752..3fabe4799d75 100644 --- a/ndctl/namespace.c +++ b

[PATCH] Documentation: use includes in more ndctl command pages.

2020-07-14 Thread Michal Suchanek
uot;) Signed-off-by: Michal Suchanek --- Documentation/ndctl/labels-options.txt | 7 ++- Documentation/ndctl/ndctl-inject-smart.txt | 4 +--- Documentation/ndctl/ndctl-monitor.txt | 11 +++ 3 files changed, 6 insertions(+), 16 deletions(-) diff --git a/Documentation/ndctl/l

[PATCH v3] dm writecache: reject asynchronous pmem.

2020-06-30 Thread Michal Suchanek
The writecache driver does not handle asynchronous pmem. Reject it when supplied as cache. Link: https://lore.kernel.org/linux-nvdimm/87lfk5hahc@linux.ibm.com/ Fixes: 6e84200c0a29 ("virtio-pmem: Add virtio pmem driver") Signed-off-by: Michal Suchanek --- drivers/md/dm-writec

[PATCH v2] dm writecache: reject asynchronous pmem.

2020-06-30 Thread Michal Suchanek
The writecache driver does not handle asynchronous pmem. Reject it when supplied as cache. Link: https://lore.kernel.org/linux-nvdimm/87lfk5hahc@linux.ibm.com/ Fixes: 6e84200c0a29 ("virtio-pmem: Add virtio pmem driver") Signed-off-by: Michal Suchanek --- drivers/md/dm-writec

[PATCH] dm writecache: reject asynchronous pmem.

2020-06-30 Thread Michal Suchanek
The writecache driver does not handle asynchronous pmem. Reject it when supplied as cache. Link: https://lore.kernel.org/linux-nvdimm/87lfk5hahc@linux.ibm.com/ Fixes: 6e84200c0a29 ("virtio-pmem: Add virtio pmem driver") Signed-off-by: Michal Suchanek --- drivers/md/dm-writec

[PATCH] doc: nvdimm: remove reference to non-existent CONFIG_NFIT_TEST

2020-04-15 Thread Michal Suchanek
The test driver is in tools/testing/nvdimm and cannot be selected by a config option. Signed-off-by: Michal Suchanek --- Documentation/driver-api/nvdimm/nvdimm.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/driver-api/nvdimm/nvdimm.rst b/Documentation

[PATCH] ndctl/namespace: skip zero namespaces when processing

2020-04-03 Thread Michal Suchanek
n each region. When processing all namespaces the user gets confusing errors from ndctl trying to process this namespace. Skip it. The user can still specify the namespace by name directly in case processing it is desirable. Fixes: #41 Signed-off-by: Michal Suchanek --- ndctl/namespace.