Re: [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section

2019-05-03 Thread Robin Murphy
On 03/05/2019 01:41, Dan Williams wrote: On Thu, May 2, 2019 at 7:53 AM Pavel Tatashin wrote: On Wed, Apr 17, 2019 at 2:52 PM Dan Williams wrote: Up-level the local section size and mask from kernel/memremap.c to global definitions. These will be used by the new sub-section hotplug

Re: arch_wb_cache_pmem on ARM64

2018-05-30 Thread Robin Murphy
On 30/05/18 18:00, Mikulas Patocka wrote: Hi I'd like to ask what's the purpose of dmb(osh) in the function arch_wb_cache_pmem in arch/arm64/mm/flush.c? void arch_wb_cache_pmem(void *addr, size_t size) { /* Ensure order against any prior non-cacheable writes */ dmb(osh);

Re: [PATCH v8] dma-mapping: introduce dma_get_iommu_domain()

2017-10-09 Thread Robin Murphy
in particular that those two drivers happen to be the *only* place this approach could work - everyone else is going to have to fall back to the generic IOMMU API function anyway. Robin. > Cc: Marek Szyprowski <m.szyprow...@samsung.com> > Cc: Robin Murphy <robin.mur...@arm.com>

[PATCH v2] nd_blk: Remove mmio_flush_range()

2017-08-31 Thread Robin Murphy
o they can be shared by NFIT as well. This allows NFIT to be enabled for arm64. Signed-off-by: Robin Murphy <robin.mur...@arm.com> --- arch/x86/Kconfig | 1 - arch/x86/include/asm/cacheflush.h | 2 -- drivers/acpi/nfit/Kconfig | 2 +- drivers/acpi/nfit/core.c

Re: [v6,2/8] dmaengine: Add DMA_MEMCPY_SG transaction op

2017-08-31 Thread Robin Murphy
On 30/08/17 19:25, Dave Jiang wrote: > On 08/30/2017 11:18 AM, Robin Murphy wrote: >> On 25/08/17 21:59, Dave Jiang wrote: >>> Adding a dmaengine transaction operation that allows copy to/from a >>> scatterlist and a flat buffer. >> >> Apologies if I'm late t

Re: [v6,2/8] dmaengine: Add DMA_MEMCPY_SG transaction op

2017-08-30 Thread Robin Murphy
On 25/08/17 21:59, Dave Jiang wrote: > Adding a dmaengine transaction operation that allows copy to/from a > scatterlist and a flat buffer. Apologies if I'm late to the party, but doesn't DMA_SG already cover this use-case? As far as I can see, all this does is save the caller from setting up a

Re: [PATCH 5/6] arm64: Implement pmem API support

2017-08-04 Thread Robin Murphy
On 04/08/17 19:09, Dan Williams wrote: > On Fri, Aug 4, 2017 at 10:43 AM, Robin Murphy <robin.mur...@arm.com> wrote: >> On 04/08/17 16:25, Catalin Marinas wrote: >>> Two minor comments below. >>> >>> On Tue, Jul 25, 2017 at 11:55:42AM +0100, Robin M

Re: [PATCH 5/6] arm64: Implement pmem API support

2017-08-04 Thread Robin Murphy
On 04/08/17 16:25, Catalin Marinas wrote: > Two minor comments below. > > On Tue, Jul 25, 2017 at 11:55:42AM +0100, Robin Murphy wrote: >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -960,6 +960,17 @@ config ARM64_UAO >>regular load/s

[PATCH 0/6] arm64 pmem support

2017-07-25 Thread Robin Murphy
suitable hardware to put them in, so this is written purely to spec - the extent of testing has been the feature detection on a v8.2 Fast Model vs. v8.0 systems. Patch #1 could go in as a fix ahead of the rest; it just needs to come before patch #5 to prevent that blowing up the build. Robin. Robin

[PATCH 2/6] arm64: Convert __inval_cache_range() to area-based

2017-07-25 Thread Robin Murphy
, and to make its relationship with __dma_inv_area() neatly mirror that of __clean_dcache_area_poc() and __dma_clean_area(). The loop clearing the early page tables gets mildly massaged in the process for the sake of consistency. Signed-off-by: Robin Murphy <robin.mur...@arm.com> --- arch

[PATCH 3/6] arm64: Expose DC CVAP to userspace

2017-07-25 Thread Robin Murphy
The ARMv8.2-DCPoP feature introduces persistent memory support to the architecture, by defining a point of persistence in the memory hierarchy, and a corresponding cache maintenance operation, DC CVAP. Expose the support via HWCAP and MRS emulation. Signed-off-by: Robin Murphy <robin.

[PATCH 6/6] arm64: uaccess: Implement *_flushcache variants

2017-07-25 Thread Robin Murphy
Implement the set of copy functions with guarantees of a clean cache upon completion necessary to support the pmem driver. Signed-off-by: Robin Murphy <robin.mur...@arm.com> --- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/string.h | 4 arch/arm64/inclu

[PATCH 1/6] arm64: mm: Fix set_memory_valid() declaration

2017-07-25 Thread Robin Murphy
Clearly, set_memory_valid() has never been seen in the same room as its declaration... Whilst the type mismatch is such that kexec probably wasn't broken in practice, fix it to match the definition as it should. Fixes: 9b0aa14e3155 ("arm64: mm: add set_memory_valid()") Signed-off-by: Ro

[PATCH 5/6] arm64: Implement pmem API support

2017-07-25 Thread Robin Murphy
Add a clean-to-point-of-persistence cache maintenance helper, and wire up the basic architectural support for the pmem driver based on it. Signed-off-by: Robin Murphy <robin.mur...@arm.com> --- arch/arm64/Kconfig | 11 +++ arch/arm64/include/asm/assembler.h