Re: [PATCH] ext4/xfs: add page refcount helper

2020-10-07 Thread Dan Williams
On Wed, Oct 7, 2020 at 1:25 AM Jan Kara wrote: > > On Tue 06-10-20 16:09:30, Ralph Campbell wrote: > > There are several places where ZONE_DEVICE struct pages assume a reference > > count == 1 means the page is idle and free. Instead of open coding this, > > add a helper function to hide this deta

Re: [PATCH] ext4/xfs: add page refcount helper

2020-10-07 Thread Ralph Campbell
On 10/7/20 1:25 AM, Jan Kara wrote: On Tue 06-10-20 16:09:30, Ralph Campbell wrote: There are several places where ZONE_DEVICE struct pages assume a reference count == 1 means the page is idle and free. Instead of open coding this, add a helper function to hide this detail. Signed-off-by: Ral

Re: [PATCH] ext4/xfs: add page refcount helper

2020-10-07 Thread Darrick J. Wong
On Tue, Oct 06, 2020 at 04:09:30PM -0700, Ralph Campbell wrote: > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell >

Re: [PATCH] ext4/xfs: add page refcount helper

2020-10-07 Thread Theodore Y. Ts'o
On Tue, Oct 06, 2020 at 07:40:05PM -0700, Dan Williams wrote: > On Tue, Oct 6, 2020 at 4:09 PM Ralph Campbell wrote: > > > > There are several places where ZONE_DEVICE struct pages assume a reference > > count == 1 means the page is idle and free. Instead of open coding this, > > add a helper func

Re: [PATCH] ext4/xfs: add page refcount helper

2020-10-07 Thread Jan Kara
On Tue 06-10-20 16:09:30, Ralph Campbell wrote: > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell > Reviewed-by: Chr

Re: [PATCH] ext4/xfs: add page refcount helper

2020-10-06 Thread Dan Williams
On Tue, Oct 6, 2020 at 4:09 PM Ralph Campbell wrote: > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell > Reviewed-

[PATCH] ext4/xfs: add page refcount helper

2020-10-06 Thread Ralph Campbell
There are several places where ZONE_DEVICE struct pages assume a reference count == 1 means the page is idle and free. Instead of open coding this, add a helper function to hide this detail. Signed-off-by: Ralph Campbell Reviewed-by: Christoph Hellwig --- I'm resending this as a separate patch