Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-24 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

[PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-23 Thread Ralph Campbell
commit 6f42193fd86e ("memremap: don't use a separate devm action for devmap_managed_enable_get") changed the static key updates such that we now call devmap_managed_enable_put() without doing the equivalent devmap_managed_enable_get(). devmap_managed_enable_get() is only called for

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-23 Thread Ralph Campbell
On 10/22/20 11:46 PM, Christoph Hellwig wrote: On Thu, Oct 22, 2020 at 11:19:43AM -0700, Ralph Campbell wrote: On 10/22/20 8:41 AM, Ira Weiny wrote: On Thu, Oct 22, 2020 at 11:37:53AM +0530, Aneesh Kumar K.V wrote: commit 6f42193fd86e ("memremap: don't use a separate devm action for

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-23 Thread Christoph Hellwig
On Thu, Oct 22, 2020 at 11:19:43AM -0700, Ralph Campbell wrote: > > On 10/22/20 8:41 AM, Ira Weiny wrote: > > On Thu, Oct 22, 2020 at 11:37:53AM +0530, Aneesh Kumar K.V wrote: > > > commit 6f42193fd86e ("memremap: don't use a separate devm action for > > > devmap_managed_enable_get") changed the

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-23 Thread Sachin Sant
>> Is it overkill to avoid duplicating this switch logic in >> page_is_devmap_managed() by creating another call which can be used here? > > Perhaps. I can imagine a helper defined in include/linux/mm.h which > page_is_devmap_managed() could also call but that would impact a lot of > places that

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-22 Thread Aneesh Kumar K.V
On 10/23/20 12:40 AM, Ira Weiny wrote: On Thu, Oct 22, 2020 at 11:19:43AM -0700, Ralph Campbell wrote: On 10/22/20 8:41 AM, Ira Weiny wrote: On Thu, Oct 22, 2020 at 11:37:53AM +0530, Aneesh Kumar K.V wrote: commit 6f42193fd86e ("memremap: don't use a separate devm action for

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-22 Thread Ira Weiny
On Thu, Oct 22, 2020 at 11:19:43AM -0700, Ralph Campbell wrote: > > On 10/22/20 8:41 AM, Ira Weiny wrote: > > On Thu, Oct 22, 2020 at 11:37:53AM +0530, Aneesh Kumar K.V wrote: > > > commit 6f42193fd86e ("memremap: don't use a separate devm action for > > > devmap_managed_enable_get") changed the

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-22 Thread Ralph Campbell
On 10/22/20 8:41 AM, Ira Weiny wrote: On Thu, Oct 22, 2020 at 11:37:53AM +0530, Aneesh Kumar K.V wrote: commit 6f42193fd86e ("memremap: don't use a separate devm action for devmap_managed_enable_get") changed the static key updates such that we now call devmap_managed_enable_put() without

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-22 Thread Ira Weiny
On Thu, Oct 22, 2020 at 11:37:53AM +0530, Aneesh Kumar K.V wrote: > commit 6f42193fd86e ("memremap: don't use a separate devm action for > devmap_managed_enable_get") changed the static key updates such that we > now call devmap_managed_enable_put() without doing the equivalent >

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-22 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-22 Thread Sachin Sant
> jump label: negative count! > WARNING: CPU: 52 PID: 1335 at kernel/jump_label.c:235 > static_key_slow_try_dec+0x88/0xa0 > Modules linked in: > …. > > Cc: Christoph Hellwig > Cc: Dan Williams > Cc: Sachin Sant > Cc: linux-nvdimm@lists.01.org > Cc: Ira Weiny > Cc: Jason Gunthorpe >

[PATCH] mm/mremap_pages: Fix static key devmap_managed_key updates

2020-10-22 Thread Aneesh Kumar K.V
commit 6f42193fd86e ("memremap: don't use a separate devm action for devmap_managed_enable_get") changed the static key updates such that we now call devmap_managed_enable_put() without doing the equivalent devmap_managed_enable_get(). devmap_managed_enable_get() is only called for