[PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-04-16 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues The IOMAP_DAX_COW is a iomap type which performs copy of edges of data while performing a write if start/end are not page aligned. The source address is expected in iomap->inline_data. dax_copy_edges() is a helper functions performs a copy from one part of the device to a

[PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-04-29 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues The IOMAP_DAX_COW is a iomap type which performs copy of edges of data while performing a write if start/end are not page aligned. The source address is expected in iomap->inline_data. dax_copy_edges() is a helper functions performs a copy from one part of the device to a

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-21 Thread Darrick J. Wong
On Mon, Apr 29, 2019 at 12:26:35PM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > The IOMAP_DAX_COW is a iomap type which performs copy of > edges of data while performing a write if start/end are > not page aligned. The source address is expected in > iomap->inline_data. > > dax_

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-22 Thread Goldwyn Rodrigues
On 9:51 21/05, Darrick J. Wong wrote: > On Mon, Apr 29, 2019 at 12:26:35PM -0500, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues > > > > The IOMAP_DAX_COW is a iomap type which performs copy of > > edges of data while performing a write if start/end are > > not page aligned. The source add

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-22 Thread Dave Chinner
On Wed, May 22, 2019 at 03:14:47PM -0500, Goldwyn Rodrigues wrote: > On 9:51 21/05, Darrick J. Wong wrote: > > On Mon, Apr 29, 2019 at 12:26:35PM -0500, Goldwyn Rodrigues wrote: > > We cannot use @inline_data to convey the source address. @inline_data > > (so far) is used to point to the in-memor

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-23 Thread Shiyang Ruan
On 5/22/19 12:51 AM, Darrick J. Wong wrote: On Mon, Apr 29, 2019 at 12:26:35PM -0500, Goldwyn Rodrigues wrote: From: Goldwyn Rodrigues The IOMAP_DAX_COW is a iomap type which performs copy of edges of data while performing a write if start/end are not page aligned. The source address is exp

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-23 Thread Goldwyn Rodrigues
On 17:05 23/05, Shiyang Ruan wrote: > > > On 5/22/19 12:51 AM, Darrick J. Wong wrote: > > On Mon, Apr 29, 2019 at 12:26:35PM -0500, Goldwyn Rodrigues wrote: > > > From: Goldwyn Rodrigues > > > > > > The IOMAP_DAX_COW is a iomap type which performs copy of > > > edges of data while performing a

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-27 Thread Shiyang Ruan
On 5/23/19 7:51 PM, Goldwyn Rodrigues wrote: Hi, I'm working on reflink & dax in XFS, here are some thoughts on this: As mentioned above: the second iomap's offset and length must match the first. I thought so at the beginning, but later found that the only difference between these two iom

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-28 Thread Jan Kara
On Mon 27-05-19 16:25:41, Shiyang Ruan wrote: > On 5/23/19 7:51 PM, Goldwyn Rodrigues wrote: > > > > > > Hi, > > > > > > I'm working on reflink & dax in XFS, here are some thoughts on this: > > > > > > As mentioned above: the second iomap's offset and length must match the > > > first. I though

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-28 Thread Shiyang Ruan
On 5/28/19 5:17 PM, Jan Kara wrote: On Mon 27-05-19 16:25:41, Shiyang Ruan wrote: On 5/23/19 7:51 PM, Goldwyn Rodrigues wrote: Hi, I'm working on reflink & dax in XFS, here are some thoughts on this: As mentioned above: the second iomap's offset and length must match the first. I thought

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-28 Thread Dave Chinner
On Wed, May 29, 2019 at 10:01:58AM +0800, Shiyang Ruan wrote: > > On 5/28/19 5:17 PM, Jan Kara wrote: > > On Mon 27-05-19 16:25:41, Shiyang Ruan wrote: > > > On 5/23/19 7:51 PM, Goldwyn Rodrigues wrote: > > > > > > > > > > Hi, > > > > > > > > > > I'm working on reflink & dax in XFS, here are som

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-28 Thread Shiyang Ruan
On 5/29/19 10:47 AM, Dave Chinner wrote: On Wed, May 29, 2019 at 10:01:58AM +0800, Shiyang Ruan wrote: On 5/28/19 5:17 PM, Jan Kara wrote: On Mon 27-05-19 16:25:41, Shiyang Ruan wrote: On 5/23/19 7:51 PM, Goldwyn Rodrigues wrote: Hi, I'm working on reflink & dax in XFS, here are some th

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-28 Thread Darrick J. Wong
On Wed, May 29, 2019 at 12:02:40PM +0800, Shiyang Ruan wrote: > > > On 5/29/19 10:47 AM, Dave Chinner wrote: > > On Wed, May 29, 2019 at 10:01:58AM +0800, Shiyang Ruan wrote: > > > > > > On 5/28/19 5:17 PM, Jan Kara wrote: > > > > On Mon 27-05-19 16:25:41, Shiyang Ruan wrote: > > > > > On 5/23/1

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-28 Thread Dave Chinner
On Tue, May 28, 2019 at 09:07:19PM -0700, Darrick J. Wong wrote: > On Wed, May 29, 2019 at 12:02:40PM +0800, Shiyang Ruan wrote: > > On 5/29/19 10:47 AM, Dave Chinner wrote: > > > On Wed, May 29, 2019 at 10:01:58AM +0800, Shiyang Ruan wrote: > > > > On 5/28/19 5:17 PM, Jan Kara wrote: > > > > > I'm

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-29 Thread Jan Kara
On Wed 29-05-19 14:46:58, Dave Chinner wrote: > On Tue, May 28, 2019 at 09:07:19PM -0700, Darrick J. Wong wrote: > > On Wed, May 29, 2019 at 12:02:40PM +0800, Shiyang Ruan wrote: > > > On 5/29/19 10:47 AM, Dave Chinner wrote: > > > > On Wed, May 29, 2019 at 10:01:58AM +0800, Shiyang Ruan wrote: > >

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-29 Thread Dave Chinner
On Wed, May 29, 2019 at 03:46:29PM +0200, Jan Kara wrote: > On Wed 29-05-19 14:46:58, Dave Chinner wrote: > > iomap_apply() > > > > ->iomap_begin() > > map old data extent that we copy from > > > > allocate new data extent we copy to in data fork, > > imme

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-30 Thread Jan Kara
On Thu 30-05-19 08:14:45, Dave Chinner wrote: > On Wed, May 29, 2019 at 03:46:29PM +0200, Jan Kara wrote: > > On Wed 29-05-19 14:46:58, Dave Chinner wrote: > > > iomap_apply() > > > > > > ->iomap_begin() > > > map old data extent that we copy from > > > > > > allocate new d

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-05-30 Thread Dave Chinner
On Thu, May 30, 2019 at 01:16:05PM +0200, Jan Kara wrote: > On Thu 30-05-19 08:14:45, Dave Chinner wrote: > > On Wed, May 29, 2019 at 03:46:29PM +0200, Jan Kara wrote: > > > On Wed 29-05-19 14:46:58, Dave Chinner wrote: > > > > iomap_apply() > > > > > > > > ->iomap_begin() > > > >

Re: [PATCH 04/18] dax: Introduce IOMAP_DAX_COW to CoW edges during writes

2019-04-17 Thread Darrick J. Wong
On Tue, Apr 16, 2019 at 11:41:40AM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > The IOMAP_DAX_COW is a iomap type which performs copy of > edges of data while performing a write if start/end are > not page aligned. The source address is expected in > iomap->inline_data. > > dax_