[PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-03 Thread Vivek Goyal
Add a dax operation zero_page_range, to zero a range of memory. This will also clear any poison in the range being zeroed. As of now, zeroing of up to one page is allowed in a single call. There are no callers which are trying to zero more than a page in a single call. Once we grow the callers wh

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-05 Thread Christoph Hellwig
> + /* > + * There are no users as of now. Once users are there, fix dm code > + * to be able to split a long range across targets. > + */ This comment confused me. I think this wants to say something like: /* * There are now callers that want to zero across a

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-05 Thread Vivek Goyal
On Wed, Feb 05, 2020 at 10:30:50AM -0800, Christoph Hellwig wrote: > > + /* > > +* There are no users as of now. Once users are there, fix dm code > > +* to be able to split a long range across targets. > > +*/ > > This comment confused me. I think this wants to say something like:

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-05 Thread Dan Williams
On Wed, Feb 5, 2020 at 12:03 PM Vivek Goyal wrote: > > On Wed, Feb 05, 2020 at 10:30:50AM -0800, Christoph Hellwig wrote: > > > + /* > > > +* There are no users as of now. Once users are there, fix dm code > > > +* to be able to split a long range across targets. > > > +*/ > > > > Th

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-05 Thread Christoph Hellwig
On Wed, Feb 05, 2020 at 04:40:44PM -0800, Dan Williams wrote: > > I don't have any reason not to pass phys_addr_t. If that sounds better, > > will make changes. > > The problem is device-mapper. That wants to use offset to route > through the map to the leaf device. If it weren't for the firmware

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-06 Thread Vivek Goyal
On Wed, Feb 05, 2020 at 04:40:44PM -0800, Dan Williams wrote: > On Wed, Feb 5, 2020 at 12:03 PM Vivek Goyal wrote: > > > > On Wed, Feb 05, 2020 at 10:30:50AM -0800, Christoph Hellwig wrote: > > > > + /* > > > > +* There are no users as of now. Once users are there, fix dm code > > > > +*

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-07 Thread Dan Williams
On Wed, Feb 5, 2020 at 11:41 PM Christoph Hellwig wrote: > > On Wed, Feb 05, 2020 at 04:40:44PM -0800, Dan Williams wrote: > > > I don't have any reason not to pass phys_addr_t. If that sounds better, > > > will make changes. > > > > The problem is device-mapper. That wants to use offset to route

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-07 Thread Dan Williams
On Thu, Feb 6, 2020 at 6:35 AM Vivek Goyal wrote: > > On Wed, Feb 05, 2020 at 04:40:44PM -0800, Dan Williams wrote: > > On Wed, Feb 5, 2020 at 12:03 PM Vivek Goyal wrote: > > > > > > On Wed, Feb 05, 2020 at 10:30:50AM -0800, Christoph Hellwig wrote: > > > > > + /* > > > > > +* There are no

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-07 Thread Vivek Goyal
On Fri, Feb 07, 2020 at 08:57:39AM -0800, Dan Williams wrote: > On Wed, Feb 5, 2020 at 11:41 PM Christoph Hellwig wrote: > > > > On Wed, Feb 05, 2020 at 04:40:44PM -0800, Dan Williams wrote: > > > > I don't have any reason not to pass phys_addr_t. If that sounds better, > > > > will make changes.

Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range

2020-02-07 Thread Dan Williams
On Fri, Feb 7, 2020 at 9:02 AM Vivek Goyal wrote: > > On Fri, Feb 07, 2020 at 08:57:39AM -0800, Dan Williams wrote: > > On Wed, Feb 5, 2020 at 11:41 PM Christoph Hellwig > > wrote: > > > > > > On Wed, Feb 05, 2020 at 04:40:44PM -0800, Dan Williams wrote: > > > > > I don't have any reason not to