Re: [PATCH 12/12] ext2: use iomap to implement DAX

2016-09-26 Thread Jan Kara
When looking through this patch I've noticed one bug: On Fri 16-09-16 13:27:14, Christoph Hellwig wrote: > +static int ext2_iomap_begin(struct inode *inode, loff_t offset, loff_t > length, > + unsigned flags, struct iomap *iomap) > +{ ... > + iomap->offset = first_block << blkbits

[PATCH 12/12] ext2: use iomap to implement DAX

2016-09-16 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Ross Zwisler --- fs/ext2/Kconfig | 1 + fs/ext2/ext2.h | 1 + fs/ext2/file.c | 76 +++-- fs/ext2/inode.c | 63 +++ 4 files changed, 129 insertions(+),

Re: [PATCH 12/12] ext2: use iomap to implement DAX

2016-09-14 Thread Christoph Hellwig
On Wed, Sep 14, 2016 at 04:51:05PM -0600, Ross Zwisler wrote: > diff --git a/fs/ext2/Kconfig b/fs/ext2/Kconfig > index c634874e..3391f48 100644 > --- a/fs/ext2/Kconfig > +++ b/fs/ext2/Kconfig > @@ -1,5 +1,6 @@ > config EXT2_FS > tristate "Second extended fs support" > + select FS_IOMAP

Re: [PATCH 12/12] ext2: use iomap to implement DAX

2016-09-14 Thread Ross Zwisler
On Wed, Sep 14, 2016 at 12:01:31PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Now that ext2 is using IOMAP, we need to select FS_IOMAP when EXT2_FS is selected else we get a build error: fs/built-in.o: In function `ext2_dax_fault': /home/rzwisler/project/review/fs/ext2/fi

[PATCH 12/12] ext2: use iomap to implement DAX

2016-09-14 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/ext2/ext2.h | 1 + fs/ext2/file.c | 72 +++-- fs/ext2/inode.c | 63 ++ 3 files changed, 124 insertions(+), 12 deletions(-) diff --git a/fs/ext2/ext2.h b/