RE: [External] Re: [PATCH 3/5] s390, dcssblk: Allow a NULL-kaddr to ->direct_access()

2018-07-24 Thread Huaisheng HS1 Ye
From: Christian Borntraeger Sent: Tuesday, July 24, 2018 7:16 PM > >> So you are trading of a load + add (dev_info->start should be cache hot) > >> against a > >> compare+branch . Not sure that this is always a win. > > > > Hmm...the calculation process of pfn is more complicated than kaddr. I

Re: [External] Re: [PATCH 3/5] s390, dcssblk: Allow a NULL-kaddr to ->direct_access()

2018-07-24 Thread Christian Borntraeger
On 07/24/2018 11:46 AM, Huaisheng HS1 Ye wrote: > From: Christian Borntraeger > Sent: Tuesday, July 24, 2018 4:54 PM >> On 07/24/2018 10:45 AM, Huaisheng Ye wrote: >>> From: Huaisheng Ye >>> >>> dcssblk_direct_access() needs to check the validity of second rank >>> pointer kaddr for NULL

RE: [External] Re: [PATCH 3/5] s390, dcssblk: Allow a NULL-kaddr to ->direct_access()

2018-07-24 Thread Huaisheng HS1 Ye
From: Christian Borntraeger Sent: Tuesday, July 24, 2018 4:54 PM > On 07/24/2018 10:45 AM, Huaisheng Ye wrote: > > From: Huaisheng Ye > > > > dcssblk_direct_access() needs to check the validity of second rank > > pointer kaddr for NULL assignment. If kaddr equals to NULL, it > > doesn't need to

Re: [PATCH 3/5] s390, dcssblk: Allow a NULL-kaddr to ->direct_access()

2018-07-24 Thread Christian Borntraeger
On 07/24/2018 10:45 AM, Huaisheng Ye wrote: > From: Huaisheng Ye > > dcssblk_direct_access() needs to check the validity of second rank > pointer kaddr for NULL assignment. If kaddr equals to NULL, it > doesn't need to calculate the value. > > Signed-off-by: Huaisheng Ye > --- >

[PATCH 3/5] s390, dcssblk: Allow a NULL-kaddr to ->direct_access()

2018-07-24 Thread Huaisheng Ye
From: Huaisheng Ye dcssblk_direct_access() needs to check the validity of second rank pointer kaddr for NULL assignment. If kaddr equals to NULL, it doesn't need to calculate the value. Signed-off-by: Huaisheng Ye --- drivers/s390/block/dcssblk.c | 3 ++- 1 file changed, 2 insertions(+), 1