Re: [PATCH v2] libnvdimm: Notify disk drivers to revalidate region read-only

2021-03-10 Thread Dan Williams
On Tue, Mar 9, 2021 at 10:54 PM Christoph Hellwig wrote: > > Looks good to me: > > Reviewed-by: Christoph Hellwig > > Question on the pre-existing code: given that nvdimm_check_and_set_ro is > the only caller of set_disk_ro for nvdimm devices, we'll also get > the message when initially setting u

Re: [PATCH v2] libnvdimm: Notify disk drivers to revalidate region read-only

2021-03-10 Thread Verma, Vishal L
On Tue, 2021-03-09 at 17:43 -0800, Dan Williams wrote: > Previous kernels allowed the BLKROSET to override the disk's read-only > status. With that situation fixed the pmem driver needs to rely on > notification events to reevaluate the disk read-only status after the > host region has been marked

Re: [PATCH v2] libnvdimm: Notify disk drivers to revalidate region read-only

2021-03-09 Thread Christoph Hellwig
Looks good to me: Reviewed-by: Christoph Hellwig Question on the pre-existing code: given that nvdimm_check_and_set_ro is the only caller of set_disk_ro for nvdimm devices, we'll also get the message when initially setting up any read-only disk. Is that intentional?

[PATCH v2] libnvdimm: Notify disk drivers to revalidate region read-only

2021-03-09 Thread Dan Williams
Previous kernels allowed the BLKROSET to override the disk's read-only status. With that situation fixed the pmem driver needs to rely on notification events to reevaluate the disk read-only status after the host region has been marked read-write. Recall that when libnvdimm determines that the per