Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-09-10 Thread Alexander Duyck
On Mon, Sep 10, 2018 at 12:06 PM Dan Williams wrote: > > [ adding Alex ] > > On Tue, Jul 24, 2018 at 12:29 AM, Michal Hocko wrote: > > On Mon 23-07-18 09:15:32, Dave Hansen wrote: > >> On 07/23/2018 04:09 AM, Michal Hocko wrote: > >> > On Thu 19-07-18 11:41:10, Dave Hansen wrote: > >> >> Are you

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-09-10 Thread Dan Williams
[ adding Alex ] On Tue, Jul 24, 2018 at 12:29 AM, Michal Hocko wrote: > On Mon 23-07-18 09:15:32, Dave Hansen wrote: >> On 07/23/2018 04:09 AM, Michal Hocko wrote: >> > On Thu 19-07-18 11:41:10, Dave Hansen wrote: >> >> Are you looking for the actual end-user reports? This was more of a >> >> ca

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-24 Thread Michal Hocko
On Mon 23-07-18 09:15:32, Dave Hansen wrote: > On 07/23/2018 04:09 AM, Michal Hocko wrote: > > On Thu 19-07-18 11:41:10, Dave Hansen wrote: > >> Are you looking for the actual end-user reports? This was more of a > >> case of the customer plugging in some persistent memory DIMMs, noticing > >> the

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-23 Thread Dave Hansen
On 07/23/2018 04:09 AM, Michal Hocko wrote: > On Thu 19-07-18 11:41:10, Dave Hansen wrote: >> Are you looking for the actual end-user reports? This was more of a >> case of the customer plugging in some persistent memory DIMMs, noticing >> the boot delta and calling the folks who sold them the DIM

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-23 Thread Michal Hocko
On Thu 19-07-18 11:41:10, Dave Hansen wrote: > On 07/18/2018 05:05 AM, Michal Hocko wrote: > > On Tue 17-07-18 10:32:32, Dan Williams wrote: > >> On Tue, Jul 17, 2018 at 8:50 AM Michal Hocko wrote: > > [...] > >>> Is there any reason that this work has to target the next merge window? > >>> The ch

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-19 Thread Dave Hansen
On 07/18/2018 05:05 AM, Michal Hocko wrote: > On Tue 17-07-18 10:32:32, Dan Williams wrote: >> On Tue, Jul 17, 2018 at 8:50 AM Michal Hocko wrote: > [...] >>> Is there any reason that this work has to target the next merge window? >>> The changelog is not really specific about that. >> >> Same rea

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-18 Thread Michal Hocko
On Tue 17-07-18 10:32:32, Dan Williams wrote: > On Tue, Jul 17, 2018 at 8:50 AM Michal Hocko wrote: [...] > > Is there any reason that this work has to target the next merge window? > > The changelog is not really specific about that. > > Same reason as any other change in this space, hardware av

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-17 Thread Dan Williams
On Tue, Jul 17, 2018 at 8:50 AM Michal Hocko wrote: > > On Tue 17-07-18 10:46:39, Pavel Tatashin wrote: > > > > Hi Dan, > > > > > > > > I am worried that this work adds another way to multi-thread struct > > > > page initialization without re-use of already existing method. The > > > > code is alr

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-17 Thread Michal Hocko
On Tue 17-07-18 10:46:39, Pavel Tatashin wrote: > > > Hi Dan, > > > > > > I am worried that this work adds another way to multi-thread struct > > > page initialization without re-use of already existing method. The > > > code is already a mess, and leads to bugs [1] because of the number of > > > d

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-17 Thread Pavel Tatashin
> > Hi Dan, > > > > I am worried that this work adds another way to multi-thread struct > > page initialization without re-use of already existing method. The > > code is already a mess, and leads to bugs [1] because of the number of > > different memory layouts, architecture specific quirks, and d

Re: [PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-16 Thread Dan Williams
On Mon, Jul 16, 2018 at 12:12 PM, Pavel Tatashin wrote: > On Mon, Jul 16, 2018 at 1:10 PM Dan Williams wrote: >> >> Changes since v1 [1]: >> * Teach memmap_sync() to take over a sub-set of memmap initialization in >> the foreground. This foreground work still needs to await the >> completion

[PATCH v2 00/14] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE

2018-07-16 Thread Dan Williams
Changes since v1 [1]: * Teach memmap_sync() to take over a sub-set of memmap initialization in the foreground. This foreground work still needs to await the completion of vmemmap_populate_hugepages(), but it will otherwise steal 1/1024th of the 'struct page' init work for the given range. (