Re: [PATCH v2 05/10] fsdax: Replace mmap entry in case of CoW

2021-03-03 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH v2 05/10] fsdax: Replace mmap entry in case of CoW

2021-03-03 Thread Christoph Hellwig
On Wed, Mar 03, 2021 at 09:41:54AM +, ruansy.f...@fujitsu.com wrote: > > > > > > > if (dirty) > > > __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); > > > > I still think the __mark_inode_dirty should just be moved into the one > > caller that needs it. > > I found that

Re: [PATCH v2 05/10] fsdax: Replace mmap entry in case of CoW

2021-03-03 Thread ruansy.f...@fujitsu.com
> > > > if (dirty) > > __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); > > I still think the __mark_inode_dirty should just be moved into the one > caller that needs it. I found that the dirty flag will be used in the next few lines, so I keep this function inside. If I mo

Re: [PATCH v2 05/10] fsdax: Replace mmap entry in case of CoW

2021-03-03 Thread Christoph Hellwig
On Fri, Feb 26, 2021 at 08:20:25AM +0800, Shiyang Ruan wrote: > We replace the existing entry to the newly allocated one in case of CoW. > Also, we mark the entry as PAGECACHE_TAG_TOWRITE so writeback marks this > entry as writeprotected. This helps us snapshots so new write > pagefaults after sna

[PATCH v2 05/10] fsdax: Replace mmap entry in case of CoW

2021-02-25 Thread Shiyang Ruan
We replace the existing entry to the newly allocated one in case of CoW. Also, we mark the entry as PAGECACHE_TAG_TOWRITE so writeback marks this entry as writeprotected. This helps us snapshots so new write pagefaults after snapshots trigger a CoW. Signed-off-by: Goldwyn Rodrigues Signed-off-by