Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Eric Sandeen
On 8/10/18 2:24 PM, Ross Zwisler wrote: > On Fri, Aug 10, 2018 at 9:23 AM Dave Jiang wrote: >> On 08/10/2018 11:31 AM, Eric Sandeen wrote: >>> On 8/8/18 12:31 PM, Dave Jiang wrote: This patch is the duplicate of ross's fix for ext4 for xfs. If the refcount of a page is lowered betwe

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Ross Zwisler
On Fri, Aug 10, 2018 at 9:23 AM Dave Jiang wrote: > On 08/10/2018 11:31 AM, Eric Sandeen wrote: > > On 8/8/18 12:31 PM, Dave Jiang wrote: > >> This patch is the duplicate of ross's fix for ext4 for xfs. > >> > >> If the refcount of a page is lowered between the time that it is returned > >> by dax

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Dave Jiang
On 08/10/2018 11:31 AM, Eric Sandeen wrote: > On 8/8/18 12:31 PM, Dave Jiang wrote: >> This patch is the duplicate of ross's fix for ext4 for xfs. >> >> If the refcount of a page is lowered between the time that it is returned >> by dax_busy_page() and when the refcount is again checked in >> xf

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Eric Sandeen
On 8/8/18 12:31 PM, Dave Jiang wrote: > This patch is the duplicate of ross's fix for ext4 for xfs. > > If the refcount of a page is lowered between the time that it is returned > by dax_busy_page() and when the refcount is again checked in > xfs_break_layouts() => ___wait_var_event(), the waiting

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Dave Jiang
On 08/10/2018 09:02 AM, Darrick J. Wong wrote: > On Fri, Aug 10, 2018 at 08:54:00AM -0700, Dave Jiang wrote: >> >> >> On 08/10/2018 08:48 AM, Darrick J. Wong wrote: >>> On Wed, Aug 08, 2018 at 10:31:40AM -0700, Dave Jiang wrote: This patch is the duplicate of ross's fix for ext4 for xfs. >>

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Darrick J. Wong
On Fri, Aug 10, 2018 at 08:54:00AM -0700, Dave Jiang wrote: > > > On 08/10/2018 08:48 AM, Darrick J. Wong wrote: > > On Wed, Aug 08, 2018 at 10:31:40AM -0700, Dave Jiang wrote: > >> This patch is the duplicate of ross's fix for ext4 for xfs. > >> > >> If the refcount of a page is lowered between

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Dave Jiang
On 08/10/2018 08:48 AM, Darrick J. Wong wrote: > On Wed, Aug 08, 2018 at 10:31:40AM -0700, Dave Jiang wrote: >> This patch is the duplicate of ross's fix for ext4 for xfs. >> >> If the refcount of a page is lowered between the time that it is returned >> by dax_busy_page() and when the refcount

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-10 Thread Darrick J. Wong
On Wed, Aug 08, 2018 at 10:31:40AM -0700, Dave Jiang wrote: > This patch is the duplicate of ross's fix for ext4 for xfs. > > If the refcount of a page is lowered between the time that it is returned > by dax_busy_page() and when the refcount is again checked in > xfs_break_layouts() => ___wait_va

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-09 Thread Dave Jiang
On 08/09/2018 01:57 AM, Jan Kara wrote: > On Wed 08-08-18 10:26:36, Dave Jiang wrote: >> This patch is the duplicate of ross's fix for ext4 for xfs. >> >> If the refcount of a page is lowered between the time that it is returned >> by dax_busy_page() and when the refcount is again checked in >>

Re: [PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-09 Thread Jan Kara
On Wed 08-08-18 10:26:36, Dave Jiang wrote: > This patch is the duplicate of ross's fix for ext4 for xfs. > > If the refcount of a page is lowered between the time that it is returned > by dax_busy_page() and when the refcount is again checked in > xfs_break_layouts() => ___wait_var_event(), the w

[PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-08 Thread Dave Jiang
This patch is the duplicate of ross's fix for ext4 for xfs. If the refcount of a page is lowered between the time that it is returned by dax_busy_page() and when the refcount is again checked in xfs_break_layouts() => ___wait_var_event(), the waiting function xfs_wait_dax_page() will never be call

[PATCH v2 2/2] [PATCH] xfs: Close race between direct IO and xfs_break_layouts()

2018-08-08 Thread Dave Jiang
This patch is the duplicate of ross's fix for ext4 for xfs. If the refcount of a page is lowered between the time that it is returned by dax_busy_page() and when the refcount is again checked in xfs_break_layouts() => ___wait_var_event(), the waiting function xfs_wait_dax_page() will never be call