Re: [PATCH v3 01/16] chardev: add helper function to register char devs with a struct device

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 11:38:40AM -0600, Logan Gunthorpe wrote: > > I don't know why kbuild didn't catch these before, but it looks like we > > really need to include device.h in cdev.h now to fix up these build > > warnings, right? > > > I'll try that out and rebase the char-misc-testing tree

Re: [PATCH v3 01/16] chardev: add helper function to register char devs with a struct device

2017-03-16 Thread Logan Gunthorpe
> I don't know why kbuild didn't catch these before, but it looks like we > really need to include device.h in cdev.h now to fix up these build > warnings, right? > I'll try that out and rebase the char-misc-testing tree in the morning > to see if that fixes the build problems... Yeah, I think

Re: [PATCH v3 01/16] chardev: add helper function to register char devs with a struct device

2017-03-16 Thread Greg Kroah-Hartman
On Mon, Mar 06, 2017 at 12:04:17AM -0700, Logan Gunthorpe wrote: > Credit for this patch goes is shared with Dan Williams [1]. I've > taken things one step further to make the helper function more > useful and clean up calling code. > > There's a common pattern in the kernel whereby a struct cdev

[PATCH v3 01/16] chardev: add helper function to register char devs with a struct device

2017-03-05 Thread Logan Gunthorpe
Credit for this patch goes is shared with Dan Williams [1]. I've taken things one step further to make the helper function more useful and clean up calling code. There's a common pattern in the kernel whereby a struct cdev is placed in a structure along side a struct device which manages the