[PATCH v3 2/2] nfit, mce: validate the mce->addr before using it

2018-10-25 Thread Vishal Verma
The NFIT machine check handler uses the physical address from the 'mce' structure, and compares it against information in the ACPI NFIT table to determine whether that location lies on an NVDIMM. The mce->addr field however may not always be valid, and this is indicated by the MCI_STATUS_ADDRV bit

Re: [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it

2018-11-06 Thread Borislav Petkov
On Thu, Oct 25, 2018 at 06:37:29PM -0600, Vishal Verma wrote: > The NFIT machine check handler uses the physical address from the 'mce' > structure, and compares it against information in the ACPI NFIT table to > determine whether that location lies on an NVDIMM. The mce->addr field > however may n

Re: [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it

2018-11-06 Thread Dan Williams
On Tue, Nov 6, 2018 at 6:51 AM Borislav Petkov wrote: > > On Thu, Oct 25, 2018 at 06:37:29PM -0600, Vishal Verma wrote: > > The NFIT machine check handler uses the physical address from the 'mce' > > structure, and compares it against information in the ACPI NFIT table to > > determine whether tha

Re: [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it

2018-11-06 Thread Borislav Petkov
On Tue, Nov 06, 2018 at 08:20:38AM -0800, Dan Williams wrote: > I recommended the split so the fixes can be tracked and / or reverted > independently if they cause problems. Do you have anything concrete in mind that might go wrong or just a general cautiousness? Or do you think the hw might not

Re: [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it

2018-11-06 Thread Dan Williams
On Tue, Nov 6, 2018 at 9:53 AM Borislav Petkov wrote: > > On Tue, Nov 06, 2018 at 08:20:38AM -0800, Dan Williams wrote: > > I recommended the split so the fixes can be tracked and / or reverted > > independently if they cause problems. > > Do you have anything concrete in mind that might go wrong

Re: [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it

2018-11-06 Thread Borislav Petkov
On Tue, Nov 06, 2018 at 10:02:46AM -0800, Dan Williams wrote: > Just general cautiousness, I'm not opposed to squashing them. Nah, I can keep them separate - I was just wondering why. > mce_usable_address() should not have any sensitivity to NVDIMM vs DRAM > MCEs. Ok. Thx. -- Regards/Gruss,