Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-28 Thread Brendan Higgins
On Thu, Jun 27, 2019 at 11:16 AM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-06-26 16:00:40) > > On Tue, Jun 25, 2019 at 8:41 PM Stephen Boyd wrote: > > > > > scenario like below, but where it is a problem. There could be three > > > CPUs, or even one CPU and three threads if you want t

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-27 Thread Stephen Boyd
Quoting Brendan Higgins (2019-06-26 16:00:40) > On Tue, Jun 25, 2019 at 8:41 PM Stephen Boyd wrote: > > > scenario like below, but where it is a problem. There could be three > > CPUs, or even one CPU and three threads if you want to describe the > > extra thread scenario. > > > > Here's my scena

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-26 Thread Brendan Higgins
On Wed, Jun 26, 2019 at 3:02 PM Luis Chamberlain wrote: > > On Tue, Jun 25, 2019 at 11:41:47PM -0700, Brendan Higgins wrote: > > On Tue, Jun 25, 2019 at 4:02 PM Luis Chamberlain wrote: > > > > > > On Tue, Jun 25, 2019 at 03:14:45PM -0700, Brendan Higgins wrote: > > > > On Tue, Jun 25, 2019 at 2:4

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-26 Thread Brendan Higgins
On Tue, Jun 25, 2019 at 8:41 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-06-25 13:28:25) > > On Wed, Jun 19, 2019 at 5:15 PM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-06-17 01:25:56) > > > > diff --git a/kunit/test.c b/kunit/test.c > > > > new file mode 100644 > >

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-26 Thread Brendan Higgins
On Tue, Jun 25, 2019 at 8:36 PM Luis Chamberlain wrote: > > On Tue, Jun 25, 2019 at 05:07:32PM -0700, Brendan Higgins wrote: > > On Tue, Jun 25, 2019 at 3:33 PM Luis Chamberlain wrote: > > > > > > On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote: > > > > +/** > > > > + * module_tes

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-26 Thread Luis Chamberlain
On Tue, Jun 25, 2019 at 11:41:47PM -0700, Brendan Higgins wrote: > On Tue, Jun 25, 2019 at 4:02 PM Luis Chamberlain wrote: > > > > On Tue, Jun 25, 2019 at 03:14:45PM -0700, Brendan Higgins wrote: > > > On Tue, Jun 25, 2019 at 2:44 PM Luis Chamberlain > > > wrote: > > > > Since its a new architec

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Brendan Higgins
On Tue, Jun 25, 2019 at 4:02 PM Luis Chamberlain wrote: > > On Tue, Jun 25, 2019 at 03:14:45PM -0700, Brendan Higgins wrote: > > On Tue, Jun 25, 2019 at 2:44 PM Luis Chamberlain wrote: > > > Since its a new architecture and since you seem to imply most tests > > > don't require locking or even IR

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Stephen Boyd
Quoting Brendan Higgins (2019-06-25 13:28:25) > On Wed, Jun 19, 2019 at 5:15 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-06-17 01:25:56) > > > diff --git a/kunit/test.c b/kunit/test.c > > > new file mode 100644 > > > index 0..d05d254f1521f > > > --- /dev/null > > > +++

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Luis Chamberlain
On Tue, Jun 25, 2019 at 05:07:32PM -0700, Brendan Higgins wrote: > On Tue, Jun 25, 2019 at 3:33 PM Luis Chamberlain wrote: > > > > On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote: > > > +/** > > > + * module_test() - used to register a &struct kunit_module with KUnit. > > > + * @mo

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Brendan Higgins
On Tue, Jun 25, 2019 at 3:33 PM Luis Chamberlain wrote: > > On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote: > > +/** > > + * module_test() - used to register a &struct kunit_module with KUnit. > > + * @module: a statically allocated &struct kunit_module. > > + * > > + * Registers

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Luis Chamberlain
On Tue, Jun 25, 2019 at 03:14:45PM -0700, Brendan Higgins wrote: > On Tue, Jun 25, 2019 at 2:44 PM Luis Chamberlain wrote: > > Since its a new architecture and since you seem to imply most tests > > don't require locking or even IRQs disabled, I think its worth to > > consider the impact of adding

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Luis Chamberlain
On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote: > +/** > + * module_test() - used to register a &struct kunit_module with KUnit. > + * @module: a statically allocated &struct kunit_module. > + * > + * Registers @module with the test framework. See &struct kunit_module for > more >

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Brendan Higgins
On Tue, Jun 25, 2019 at 2:44 PM Luis Chamberlain wrote: > > On Tue, Jun 25, 2019 at 01:28:25PM -0700, Brendan Higgins wrote: > > On Wed, Jun 19, 2019 at 5:15 PM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-06-17 01:25:56) > > > > diff --git a/kunit/test.c b/kunit/test.c > > > > n

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Luis Chamberlain
On Tue, Jun 25, 2019 at 01:28:25PM -0700, Brendan Higgins wrote: > On Wed, Jun 19, 2019 at 5:15 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-06-17 01:25:56) > > > diff --git a/kunit/test.c b/kunit/test.c > > > new file mode 100644 > > > index 0..d05d254f1521f > > > ---

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Brendan Higgins
On Wed, Jun 19, 2019 at 5:15 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-06-17 01:25:56) > > diff --git a/kunit/test.c b/kunit/test.c > > new file mode 100644 > > index 0..d05d254f1521f > > --- /dev/null > > +++ b/kunit/test.c > > @@ -0,0 +1,210 @@ > > +// SPDX-License-Ide

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-19 Thread Stephen Boyd
Quoting Brendan Higgins (2019-06-17 01:25:56) > diff --git a/kunit/test.c b/kunit/test.c > new file mode 100644 > index 0..d05d254f1521f > --- /dev/null > +++ b/kunit/test.c > @@ -0,0 +1,210 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Base unit test (KUnit) API. > + * > + * Co

[PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-17 Thread Brendan Higgins
Add core facilities for defining unit tests; this provides a common way to define test cases, functions that execute code which is under test and determine whether the code under test behaves as expected; this also provides a way to group together related test cases in test suites (here we call the