Re: [RFC PATCH 4/4] EDAC, skx_edac: Detect non-volatile DIMMs

2017-12-06 Thread Borislav Petkov
On Tue, Dec 05, 2017 at 02:24:29PM -0800, Luck, Tony wrote: > So this is what that would look like (on top of existing patches, > but would be folded into them for next version): > > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig > index 5c0c4a358f67..7f0bc4cd5086 100644 > --- a/drivers/

Re: [RFC PATCH 4/4] EDAC, skx_edac: Detect non-volatile DIMMs

2017-12-05 Thread Luck, Tony
On Tue, Dec 05, 2017 at 10:44:41PM +0100, Borislav Petkov wrote: > On Tue, Dec 05, 2017 at 12:03:37PM -0800, Luck, Tony wrote: > > I could. But what happens when someone ends up on a system with > > an edac driver configured without ACPI_NFIT that does have NVDIMMs? > > Same thing when you land on

Re: [RFC PATCH 4/4] EDAC, skx_edac: Detect non-volatile DIMMs

2017-12-05 Thread Borislav Petkov
On Tue, Dec 05, 2017 at 12:03:37PM -0800, Luck, Tony wrote: > I could. But what happens when someone ends up on a system with > an edac driver configured without ACPI_NFIT that does have NVDIMMs? Same thing when you land on a system with a kernel where the driver for a piece of hw is not enabled.

Re: [RFC PATCH 4/4] EDAC, skx_edac: Detect non-volatile DIMMs

2017-12-05 Thread Luck, Tony
On Tue, Dec 05, 2017 at 11:54:51AM +0100, Borislav Petkov wrote: > On Thu, Nov 30, 2017 at 12:40:42PM -0800, Tony Luck wrote: > > config EDAC_SKX > > tristate "Intel Skylake server Integrated MC" > > depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG > > + select DMI > > + selec

Re: [RFC PATCH 4/4] EDAC, skx_edac: Detect non-volatile DIMMs

2017-12-05 Thread Borislav Petkov
On Thu, Nov 30, 2017 at 12:40:42PM -0800, Tony Luck wrote: > This just covers the topology function of the EDAC driver. > We locate which DIMM slots are populated with NVDIMMs and > query the NFIT and SMBIOS tables to get the size. > > Signed-off-by: Tony Luck > --- > drivers/edac/Kconfig|

[RFC PATCH 4/4] EDAC, skx_edac: Detect non-volatile DIMMs

2017-11-30 Thread Tony Luck
This just covers the topology function of the EDAC driver. We locate which DIMM slots are populated with NVDIMMs and query the NFIT and SMBIOS tables to get the size. Signed-off-by: Tony Luck --- drivers/edac/Kconfig| 2 ++ drivers/edac/skx_edac.c | 56 ++