Re: [fstests PATCH 1/2] src/: fix up mmap() error checking

2018-06-22 Thread Ross Zwisler
On Fri, Jun 22, 2018 at 10:28:38AM +0800, Eryu Guan wrote: > On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > > I noticed that in some of my C tests in src/ I was incorrectly checking for > > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > > clean up some p

Re: [fstests PATCH 1/2] src/: fix up mmap() error checking

2018-06-21 Thread Eryu Guan
On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > I noticed that in some of my C tests in src/ I was incorrectly checking for > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > clean up some places where we were testing against -1 (the actual value of > MAP_F

[fstests PATCH 1/2] src/: fix up mmap() error checking

2018-06-20 Thread Ross Zwisler
I noticed that in some of my C tests in src/ I was incorrectly checking for mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and clean up some places where we were testing against -1 (the actual value of MAP_FAILED) which was manually being cast to a pointer. Signed-off-by: Ros