Re: [mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2019-03-13 Thread Alexander Duyck
On Wed, 2019-03-13 at 09:33 -0700, Andrew Morton wrote: > On Tue, 12 Mar 2019 15:50:36 -0700 Alexander Duyck > wrote: > > > On Tue, 2019-03-12 at 15:07 -0700, Andrew Morton wrote: > > > On Wed, 5 Dec 2018 21:42:47 +0100 Michal Hocko wrote: > > > > > > > > I got your explanation. However Andrew

Re: [mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2019-03-13 Thread Andrew Morton
On Tue, 12 Mar 2019 15:50:36 -0700 Alexander Duyck wrote: > On Tue, 2019-03-12 at 15:07 -0700, Andrew Morton wrote: > > On Wed, 5 Dec 2018 21:42:47 +0100 Michal Hocko wrote: > > > > > > I got your explanation. However Andrew had already applied the patches > > > > and I had some outstanding is

Re: [mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2019-03-12 Thread Alexander Duyck
On Tue, 2019-03-12 at 15:07 -0700, Andrew Morton wrote: > On Wed, 5 Dec 2018 21:42:47 +0100 Michal Hocko wrote: > > > > I got your explanation. However Andrew had already applied the patches > > > and I had some outstanding issues in them that needed to be addressed. > > > So I thought it best to

Re: [mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2019-03-12 Thread Andrew Morton
On Wed, 5 Dec 2018 21:42:47 +0100 Michal Hocko wrote: > > I got your explanation. However Andrew had already applied the patches > > and I had some outstanding issues in them that needed to be addressed. > > So I thought it best to send out this set of patches with those fixes > > before the code

Re: [mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 09:55:17, Alexander Duyck wrote: > On Wed, 2018-12-05 at 18:22 +0100, Michal Hocko wrote: > > On Fri 30-11-18 13:53:18, Alexander Duyck wrote: > > > Modify the set_page_links function to include the setting of the reserved > > > flag via a simple AND and OR operation. The motivation

Re: [mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2018-12-05 Thread Alexander Duyck
On Wed, 2018-12-05 at 18:22 +0100, Michal Hocko wrote: > On Fri 30-11-18 13:53:18, Alexander Duyck wrote: > > Modify the set_page_links function to include the setting of the reserved > > flag via a simple AND and OR operation. The motivation for this is the fact > > that the existing __set_bit cal

Re: [mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2018-12-05 Thread Michal Hocko
On Fri 30-11-18 13:53:18, Alexander Duyck wrote: > Modify the set_page_links function to include the setting of the reserved > flag via a simple AND and OR operation. The motivation for this is the fact > that the existing __set_bit call still seems to have effects on performance > as replacing the

[mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2018-11-30 Thread Alexander Duyck
Modify the set_page_links function to include the setting of the reserved flag via a simple AND and OR operation. The motivation for this is the fact that the existing __set_bit call still seems to have effects on performance as replacing the call with the AND and OR can reduce initialization time.