Changes in v3: - Patch 2: Also fix open coded get_firmware_status (Dan) - Patch 4: Change rc to an int as it is only used for the return status of cmd_submit. - Patch 4: Fix another open coded get_firmware_status in test/ack-shutdown-count-set.c
Changes in v2: - For the new helper, return original positive rc when we can (Dan) - Convert previously missed locations to the new submission helper (patch 2) - Add a new patch (4/4) to fix up all callers of ndctl_cmd_submit to the correct return convention. There were several places in ndctl where we neglected to check the firmware_status from a command submission. Add an ndctl_dimm_op target to perform error translation for a DSM family, and provide a new helper - ndctl_cmd_submit_xlat - that will submit the command and call an error translation routine if one has been registered. Switch the call sites in ndctl/inject-smart.c and ndctl/monitor.c over to the new command submission helper. Finally, clean up all remaining callers of ndctl_cmd_submit to use the correct return convention, i.e. only treat negative returns as an error, and accept positive return codes as OK. Vishal Verma (4): libndctl, intel: Add infrastructure for firmware_status translation ndctl, inject-smart: switch to ndctl_cmd_submit_xlat ndctl, monitor: switch to ndctl_cmd_submit_xlat ndctl: clean up usage of ndctl_cmd_submit ndctl/inject-smart.c | 16 ++++++------ ndctl/lib/dimm.c | 6 ++--- ndctl/lib/inject.c | 8 +++--- ndctl/lib/intel.c | 49 +++++++++++++++++++++++++++++++++++ ndctl/lib/intel.h | 1 + ndctl/lib/libndctl.c | 28 ++++++++++++++++++++ ndctl/lib/libndctl.sym | 6 +++++ ndctl/lib/nfit.c | 2 +- ndctl/lib/private.h | 1 + ndctl/libndctl.h | 3 +++ ndctl/monitor.c | 6 ++--- ndctl/util/json-firmware.c | 2 +- ndctl/util/json-smart.c | 8 +++--- test/ack-shutdown-count-set.c | 8 ++---- test/daxdev-errors.c | 8 +++--- test/libndctl.c | 32 +++++++++++------------ test/smart-notify.c | 8 +++--- 17 files changed, 138 insertions(+), 54 deletions(-) -- 2.17.2 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
