Re: [v2 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM

2019-04-25 Thread David Hildenbrand
On 25.04.19 14:30, Pavel Tatashin wrote: >> >> Yes, also I think you can let go of the device_lock in >> check_memblocks_offline_cb, lock_device_hotplug() should take care of >> this (see Documentation/core-api/memory-hotplug.rst - "locking internals") >> > Hi David, > > Thank you for your

Re: [v2 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM

2019-04-25 Thread Pavel Tatashin
> > Yes, also I think you can let go of the device_lock in > check_memblocks_offline_cb, lock_device_hotplug() should take care of > this (see Documentation/core-api/memory-hotplug.rst - "locking internals") > Hi David, Thank you for your comments. I went through memory-hotplug.rst, and I still

Re: [v2 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM

2019-04-25 Thread David Hildenbrand
On 24.04.19 23:34, Pavel Tatashin wrote: +static int +offline_memblock_cb(struct memory_block *mem, void *arg) >>> >>> Function name suggests that you are actually trying to offline memory >>> here. Maybe check_memblocks_offline_cb(), just like we have in >>> mm/memory_hotplug.c. > >

Re: [v2 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM

2019-04-24 Thread Pavel Tatashin
> > > +static int > > > +offline_memblock_cb(struct memory_block *mem, void *arg) > > > > Function name suggests that you are actually trying to offline memory > > here. Maybe check_memblocks_offline_cb(), just like we have in > > mm/memory_hotplug.c. Makes sense, I will rename to

Re: [v2 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM

2019-04-24 Thread Dan Williams
On Wed, Apr 24, 2019 at 1:55 PM David Hildenbrand wrote: > > On 21.04.19 03:44, Pavel Tatashin wrote: > > It is now allowed to use persistent memory like a regular RAM, but > > currently there is no way to remove this memory until machine is > > rebooted. > > > > This work expands the

Re: [v2 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM

2019-04-24 Thread David Hildenbrand
On 21.04.19 03:44, Pavel Tatashin wrote: > It is now allowed to use persistent memory like a regular RAM, but > currently there is no way to remove this memory until machine is > rebooted. > > This work expands the functionality to also allows hotremoving > previously hotplugged persistent

[v2 2/2] device-dax: "Hotremove" persistent memory that is used like normal RAM

2019-04-20 Thread Pavel Tatashin
It is now allowed to use persistent memory like a regular RAM, but currently there is no way to remove this memory until machine is rebooted. This work expands the functionality to also allows hotremoving previously hotplugged persistent memory, and recover the device for use for other purposes.