RE: [PATCH] mm: disallow mapping that conflict for devm_memremap_pages()

[Elliott, Robert (Persistent Memory)]

> -----Original Message-----
> From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of
> Dave Jiang
> Sent: Thursday, June 14, 2018 1:25 PM
> Subject: [PATCH] mm: disallow mapping that conflict for
> devm_memremap_pages()
...
> +     conflict_pgmap = get_dev_pagemap(PHYS_PFN(align_start), NULL);
> +     if (conflict_pgmap) {
> +             dev_warn(dev, "Conflicting mapping in same section\n");
> +             put_dev_pagemap(conflict_pgmap);
> +             return ERR_PTR(-ENOMEM);
> +     }
> +
> +     conflict_pgmap = get_dev_pagemap(PHYS_PFN(align_end), NULL);
> +     if (conflict_pgmap) {
> +             dev_warn(dev, "Conflicting mapping in same section\n");
> +             put_dev_pagemap(conflict_pgmap);
> +             return ERR_PTR(-ENOMEM);
> +     }

Unique warning messages would help narrow down the problem.

dev_WARN is one way to make them unique, if a backtrace is also appropriate.


---
Robert Elliott, HPE Persistent Memory


_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm