RE: [ndctl PATCH v2 1/2] ndctl: add the ciniparser tool from ccan

2019-01-09 Thread qi.f...@fujitsu.com
> > > > > > > > > > Hi Qi, > > > > > > > > > > Thanks for these patches, and also for rebasing to the latest! > > > > > > > > > > ciniparser.c adds a new warning (see below). Could you fix that > > > > > up in a new patch on top of the initial import (i.e. we retain > > > > > the as-is import, and

Re: [ndctl PATCH v2 1/2] ndctl: add the ciniparser tool from ccan

2019-01-07 Thread Verma, Vishal L
On Mon, 2019-01-07 at 12:41 -0800, Dan Williams wrote: > On Mon, Jan 7, 2019 at 11:03 AM Verma, Vishal L > wrote: > > > > > > On Mon, 2019-01-07 at 10:56 -0800, Dan Williams wrote: > > > On Mon, Jan 7, 2019 at 10:49 AM Verma, Vishal L > > > wrote: > > > > > > > > > > > > On Mon, 2019-01-07 a

Re: [ndctl PATCH v2 1/2] ndctl: add the ciniparser tool from ccan

2019-01-07 Thread Dan Williams
On Mon, Jan 7, 2019 at 11:03 AM Verma, Vishal L wrote: > > > On Mon, 2019-01-07 at 10:56 -0800, Dan Williams wrote: > > On Mon, Jan 7, 2019 at 10:49 AM Verma, Vishal L > > wrote: > > > > > > > > > On Mon, 2019-01-07 at 17:38 +0900, QI Fuli wrote: > > > > Import ciniparser tool from ccan [1], ther

Re: [ndctl PATCH v2 1/2] ndctl: add the ciniparser tool from ccan

2019-01-07 Thread Verma, Vishal L
On Mon, 2019-01-07 at 10:56 -0800, Dan Williams wrote: > On Mon, Jan 7, 2019 at 10:49 AM Verma, Vishal L > wrote: > > > > > > On Mon, 2019-01-07 at 17:38 +0900, QI Fuli wrote: > > > Import ciniparser tool from ccan [1], therefore, the ndctl > > > monitor can > > > read the configuration file by

Re: [ndctl PATCH v2 1/2] ndctl: add the ciniparser tool from ccan

2019-01-07 Thread Dan Williams
On Mon, Jan 7, 2019 at 10:49 AM Verma, Vishal L wrote: > > > On Mon, 2019-01-07 at 17:38 +0900, QI Fuli wrote: > > Import ciniparser tool from ccan [1], therefore, the ndctl monitor can > > read the configuration file by using this library. > > > > [1]: https://ccodearchive.net/info/ciniparser.htm

Re: [ndctl PATCH v2 1/2] ndctl: add the ciniparser tool from ccan

2019-01-07 Thread Verma, Vishal L
On Mon, 2019-01-07 at 17:38 +0900, QI Fuli wrote: > Import ciniparser tool from ccan [1], therefore, the ndctl monitor can > read the configuration file by using this library. > > [1]: https://ccodearchive.net/info/ciniparser.html > > Signed-off-by: QI Fuli > --- > Makefile.am