Re: open sets ext4_da_aops for DAX existing files

2018-09-11 Thread Kani, Toshi
ni, Toshi > > > Sent: Monday, September 10, 2018 9:52 AM > > > To: j...@suse.cz > > > Cc: linux-fsde...@vger.kernel.org; linux-nvdimm@lists.01.org > > > Subject: Re: open sets ext4_da_aops for DAX existing files > > > > ... > > > > Good c

Re: open sets ext4_da_aops for DAX existing files

2018-09-11 Thread Jan Kara
To: j...@suse.cz > > Cc: linux-fsde...@vger.kernel.org; linux-nvdimm@lists.01.org > > Subject: Re: open sets ext4_da_aops for DAX existing files > ... > > > Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier > > > in the ext4_iget()? Did this bug h

RE: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > Kani, Toshi > Sent: Monday, September 10, 2018 9:52 AM > To: j...@suse.cz > Cc: linux-fsde...@vger.kernel.org; linux-nvdimm@lists.01.org > Subject: Re: open sets

Re: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Jan Kara
On Fri 07-09-18 21:23:19, Kani, Toshi wrote: > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX > mounted ext4 files. Looking at open() path: > > New file > > lookup_open > ext4_create > __ext4_new_inode > ext4_set_inode_flags // Set S_DAX flag >

Re: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Dan Williams
On Mon, Sep 10, 2018 at 7:21 AM, Kani, Toshi wrote: > On Mon, 2018-09-10 at 08:54 -0400, Jeff Moyer wrote: >> "Kani, Toshi" writes: >> >> > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX >> > mounted ext4 files. Looking at open() path: >> >> Eek. How did you notice this? >

Re: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Kani, Toshi
On Mon, 2018-09-10 at 08:54 -0400, Jeff Moyer wrote: > "Kani, Toshi" writes: > > > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX > > mounted ext4 files. Looking at open() path: > > Eek. How did you notice this? I tested sync path on DAX files to see if it flushes

Re: open sets ext4_da_aops for DAX existing files

2018-09-10 Thread Jeff Moyer
"Kani, Toshi" writes: > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX > mounted ext4 files. Looking at open() path: Eek. How did you notice this? -Jeff ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org