The i2c_driver in twl4030-core.c and platform_driver of twl4030-usb.c
both has the name twl4030_driver. This leads to unnecessary confusion.
So rename the usb platform_driver appropriately to:
twl4030_usb_driver.
Signed-off-by: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
Index:
On Tue, Oct 14, 2008 at 01:27:45PM +1100, Stephen Rothwell wrote:
Hi Russell,
Today's linux-next merge of the arm tree got a conflict in
arch/arm/plat-omap/devices.c between commit
2817142f31bfbf26c216bf4f9192540c81b2d071 ([WATCHDOG] omap_wdt.c: sync
linux-omap changes) from Linus' tree and
On Tuesday 14 October 2008, Russell King wrote:
Since the OMAP updates I merged from Tony are already broken due to
missing definitions, and I'm not getting any response from Tony on
fixing those,
Probably has to do with his travel plans, which he mentioned
last week (Thursday?). I think he's
The following patches updates a few nokia drivers. These
4 drivers are ready to go upstream and a patch will be
made as soon as they get applied to linux-omap.
Felipe Balbi (8):
i2c: lp5521: remove dead code
i2c: lp5521: cosmetic fixes
lp5521: move to drivers/leds
leds: lp5521: simplify
get rid of omap-specific gpio calls and switch over
to gpiolib.
Cc: Dmitry Torokhov [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/input/touchscreen/tsc2005.c | 15 ---
1 files changed, 4 insertions(+), 11 deletions(-)
diff --git
Register three separate leds for lp5521 and allow
them to be controlled separately while keeping
backwards compatibility with userspace programs
based on old implementation.
Cc: Richard Purdie [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/leds/leds-lp5521.c | 146
Avoid using string magic and use integer for comparisson
Cc: Richard Purdie [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/leds/leds-lp5521.c | 52 ---
1 files changed, 38 insertions(+), 14 deletions(-)
diff --git
General cleanup to the code. Preparing to send it to
mainline.
Cc: Richard Purdie [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/i2c/chips/lp5521.c | 159
1 files changed, 73 insertions(+), 86 deletions(-)
diff --git
This driver should be sitting together with the other
led drivers.
Cc: Richard Purdie [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/i2c/chips/Kconfig |7 ---
drivers/i2c/chips/Makefile |1 -
That LED_CONNECTED_WRONG was never defined so removing.
If someone needs those hooks, add back via proper
platform_data instead of nasty ifdefery.
Cc: Richard Purdie [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/i2c/chips/lp5521.c | 22 --
1
Moving the driver to where it should sit. No functional
changes.
Cc: Jean Delvare [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/hwmon/Kconfig | 10 ++
drivers/hwmon/Makefile |1 +
drivers/{i2c/chips = hwmon}/tsl2563.c |
pdata is only used during probe to initialize a few fields
from lm8323 device structure. Moving pdata pointer to probe
won't harm anybody.
Cc: Dmitry Torokhov [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/input/keyboard/lm8323.c |4 +---
1 files changed, 1
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Kevin Hilman
Sent: Thursday, October 09, 2008 8:15 PM
To: Rajendra Nayak
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/05] OMAP3: CPUidle driver
Kevin Hilman [EMAIL PROTECTED] writes:
On Tue, Oct 14, 2008 at 3:23 PM, Tero Kristo [EMAIL PROTECTED] wrote:
Signed-off-by: Tero Kristo [EMAIL PROTECTED]
---
arch/arm/plat-omap/sram.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
mode change 100644 = 100755 arch/arm/plat-omap/sram.c
diff --git
On Tue, Oct 14, 2008 at 03:38:24PM +0200, ext Jean Delvare wrote:
Hi Felipe,
On Tue, 14 Oct 2008 16:01:38 +0300, Felipe Balbi wrote:
Moving the driver to where it should sit. No functional
changes.
Cc: Jean Delvare [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
On Tue, Oct 14, 2008 at 04:14:26PM +0200, ext Jean Delvare wrote:
I've implied a sysfs interface with my tsl2550 driver, essentially
derived from the hwmon sysfs interface. I hope you followed it in your
driver if possible. When these drivers have a new home, we can document
the sysfs
Make the powerdomain code call the new hook for updating the time.
Also implement the updated pwrdm_for_each.
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
arch/arm/mach-omap2/powerdomain.c | 24
1 files changed, 16 insertions(+), 8 deletions(-)
diff
First add some infrastructure to easily iterate over clock and power domains.
Also add extra fields to the powerdomain struct to keep the time info.
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
arch/arm/mach-omap2/clockdomain.c |5 +++--
This patchset adds 2 debugfs entries for power management counters.
pm_debug/count indicates how many times each powerdomain entered each state
(On, Inactive, Retention, Off).
pm_debug/time indicates how much time each powerdomain spent per state.
Peter 'p2' De Schrijver (3):
Add closures to
On Tue, Oct 14, 2008 at 07:30:58AM -0700, Andrew Morton ([EMAIL PROTECTED])
wrote:
Why not just skipping the waiting and returning error pretending user
really sent a signal?
Better than nothing, but because signal_pending() isn't actually true,
upper layers wil behave differently.
If
On Tuesday 14 October 2008, Felipe Balbi wrote:
@@ -23,7 +24,9 @@
#include linux/module.h
#include linux/init.h
#include linux/i2c.h
+#include linux/leds.h
#include linux/mutex.h
+#include linux/workqueue.h
#define LP5521_DRIVER_NAME lp5521
Ah, *here* it converts to
On Monday 13 October 2008, Peter 'p2' De Schrijver wrote:
+extern struct twl4030_power_data generic3430_t2scripts_data;
Such extern decls should as a rule be in header files...
In this case the rule is appropriate, since you've got the
same decl in three different places. That's
On Monday 13 October 2008, Peter 'p2' De Schrijver wrote:
On Fri, Oct 10, 2008 at 10:53:22AM -0700, ext David Brownell wrote:
On Friday 10 October 2008, Peter 'p2' De Schrijver wrote:
The TI 3430dsp and ldp boards have a custom power script.
And for those of us less conversant in this
Hi,
between omap_clk_associate() and vclk, my preference is for the
omap_clk_associate() approach.
The core problem is that the vclk patches create clocks with multiple
parents in a way that is hidden from the clock framework. This causes
both semantic and practical problems.
Semantically,
On Tuesday 14 October 2008, Felipe Balbi wrote:
This driver should be sitting together with the other
led drivers.
... iff it actually uses the LED framework. Which it
doesn't, yet, even for simple operations.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
Hi Felipe,
so I'll put most of my comments here.
On Tue, 7 Oct 2008, Felipe Balbi wrote:
Introduce a new mechanism to omap's clk implementation to
associate the device with its clock during platform_device
registration. Also gives the clock a function name (like
mmc_fck, uart_fck, ehci_fck,
On Tue, Oct 14, 2008 at 08:55:21AM -0700, David Brownell wrote:
On Tuesday 14 October 2008, Felipe Balbi wrote:
@@ -23,7 +24,9 @@
#include linux/module.h
#include linux/init.h
#include linux/i2c.h
+#include linux/leds.h
#include linux/mutex.h
+#include linux/workqueue.h
On Tue, Oct 14, 2008 at 08:53:28AM -0700, David Brownell wrote:
On Tuesday 14 October 2008, Felipe Balbi wrote:
This driver should be sitting together with the other
led drivers.
... iff it actually uses the LED framework. Which it
doesn't, yet, even for simple operations.
Should I
* Russell King - ARM Linux [EMAIL PROTECTED] [081013 09:15]:
On Fri, Oct 10, 2008 at 02:35:34PM +0300, Tony Lindgren wrote:
* Tony Lindgren [EMAIL PROTECTED] [081010 12:41]:
* Tony Lindgren [EMAIL PROTECTED] [081010 12:15]:
* Russell King - ARM Linux [EMAIL PROTECTED] [081010 11:42]:
On Tuesday 14 October 2008, Felipe Balbi wrote:
On Tue, Oct 14, 2008 at 08:53:28AM -0700, David Brownell wrote:
On Tuesday 14 October 2008, Felipe Balbi wrote:
This driver should be sitting together with the other
led drivers.
... iff it actually uses the LED framework. Which it
Hello,
these patches implement a few minor optimizations on the
omap_dm_timer_set_load() and omap_dm_timer_set_load_start() functions for
OMAP2/3. Gory details in the patch descriptions.
Tested on 2430SDP and 3430SDP.
- Paul
---
textdata bss dec hex filename
3099539
The GPTIMER TLDR register does not need to be written if the GPTIMER
is not in autoreload mode. This is the usual case for dynamic tick-enabled
kernels.
Simulation data indicate that skipping the read that occurs as part of
the write should save at least 300-320 ns for each GPTIMER1 timer
From: David Brownell [EMAIL PROTECTED]
Replace stubbed-out card-detect support for twl4030 GPIOs with
a simpler platform_data mechanism. As before, no current users.
Sanity tested by enabling this on Beagle; it booted OK with
root on MMC.
Signed-off-by: David Brownell [EMAIL PROTECTED]
---
omap_dm_timer_write_reg(timer, OMAP_TIMER_COUNTER_REG, load);
- omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
omap_dm_timer_write_reg(timer, OMAP_TIMER_CTRL_REG, l);
}
I seem to recall there was a missed interrupt condition which this worked
around.
IIRC, the
Hi Peter
a few quick comments...
On Tue, 14 Oct 2008, Peter 'p2' De Schrijver wrote:
This patch provides the debugfs entries and a function which will be called
by the PM code to register the time spent per domain per state.
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
Hello Peter,
one very minor comment:
On Tue, 14 Oct 2008, Peter 'p2' De Schrijver wrote:
diff --git a/arch/arm/plat-omap/include/mach/powerdomain.h
b/arch/arm/plat-omap/include/mach/powerdomain.h
index 52663fc..6271d85 100644
--- a/arch/arm/plat-omap/include/mach/powerdomain.h
+++
* David Brownell [EMAIL PROTECTED] [081014 11:53]:
On Tuesday 14 October 2008, Russell King wrote:
Since the OMAP updates I merged from Tony are already broken due to
missing definitions, and I'm not getting any response from Tony on
fixing those,
I just sent you a fix for that few hours
Hi Paul,
I understood both points you explained below, while I still think that
standardizing clock names may be a little bit rigid.
Thank you for your review and comments.
Hiroshi DOYU
From: ext Paul Walmsley [EMAIL PROTECTED]
Subject: Re: [PATCH 1/3] [RFC] clk: introduce clk_associate
On Tue, Oct 14, 2008 at 01:30:24PM -0700, Tony Lindgren wrote:
And here's the patch for Russell to avoid the merge conflict.
Also in Russell's patch tracking system as patch 5302/1.
This evening, only now having the time to investigate what's going
on there (as a result of added your other
- DMA interrupt disable routine added
- Added DMA controller reset to DMA context restore
Signed-off-by: Tero Kristo [EMAIL PROTECTED]
---
arch/arm/plat-omap/dma.c | 14 ++
arch/arm/plat-omap/include/mach/dma.h |2 ++
2 files changed, 16 insertions(+), 0
The I2C controller clears its OCP_SYSCONFIG register after an OCP soft reset.
Reprogram OCP_SYSCONFIG for maximum power savings on rev3.6 controllers
and beyond. On 2430, this involves setting the module AUTOIDLE bit.
On 3430, this includes module AUTOIDLE, wakeup enable, slave smart-idle,
and
* Tony Lindgren [EMAIL PROTECTED] [081014 13:37]:
* Russell King - ARM Linux [EMAIL PROTECTED] [081014 12:39]:
On Tue, Oct 14, 2008 at 10:19:08AM -0700, Tony Lindgren wrote:
* Russell King - ARM Linux [EMAIL PROTECTED] [081013 09:15]:
There's something wrong with one of the sets I've
* Felipe Balbi [EMAIL PROTECTED] [081014 12:31]:
On Tue, Oct 14, 2008 at 10:47:44AM -0700, David Brownell wrote:
On Tuesday 14 October 2008, Felipe Balbi wrote:
I didn't quite get you here. The idea of mmc_fck is so that
clk_get(dev, mmc_fck);
works fine and returns the correct
Hi Felipe,
On Tue, 14 Oct 2008 16:01:38 +0300, Felipe Balbi wrote:
Moving the driver to where it should sit. No functional
changes.
Cc: Jean Delvare [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/hwmon/Kconfig | 10 ++
Added SDRC_EMR2_* and SDRC_MANUAL_*
Signed-off-by: Tero Kristo [EMAIL PROTECTED]
---
arch/arm/plat-omap/include/mach/sdrc.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/mach/sdrc.h
b/arch/arm/plat-omap/include/mach/sdrc.h
index
Signed-off-by: Tero Kristo [EMAIL PROTECTED]
---
arch/arm/plat-omap/sram.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
mode change 100644 = 100755 arch/arm/plat-omap/sram.c
diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
old mode 100644
new mode
On Tue, 2008-10-14 at 13:59 -0700, ext Tony Lindgren wrote:
And that we can use same naming in the driver no matter which omap :)
Wasn't that one of the main features of the clock FW, when it was
designed?
--
Cheers, Igor
---
Igor Stoppa
Maemo Software - Nokia Devices RD - Helsinki
--
To
On Tue, 14 Oct 2008 14:21:50 +0530 Madhusudhan Chikkature [EMAIL
PROTECTED] wrote:
- Original Message -
From: Andrew Morton [EMAIL PROTECTED]
To: Madhusudhan Chikkature [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];
linux-omap@vger.kernel.org
* Russell King - ARM Linux [EMAIL PROTECTED] [081014 12:39]:
On Tue, Oct 14, 2008 at 10:19:08AM -0700, Tony Lindgren wrote:
* Russell King - ARM Linux [EMAIL PROTECTED] [081013 09:15]:
There's something wrong with one of the sets I've pulled from you:
arch/arm/mach-omap2/mcbsp.c:253:
On Tue, 14 Oct 2008 16:52:30 +0300, Felipe Balbi wrote:
On Tue, Oct 14, 2008 at 03:38:24PM +0200, ext Jean Delvare wrote:
Hi Felipe,
On Tue, 14 Oct 2008 16:01:38 +0300, Felipe Balbi wrote:
Moving the driver to where it should sit. No functional
changes.
Cc: Jean Delvare [EMAIL
From: Felipe Balbi [EMAIL PROTECTED]
Preparing few drivers for integration upstream.
At least lp5521 should be in good shape for going
upstream. lm8323 and tsc2005 might need some more
work.
Felipe Balbi (7):
input: lm8323: get rid of global pdata pointer
input: tsc2005: move to gpiolib
From: Felipe Balbi [EMAIL PROTECTED]
pdata is only used during probe to initialize a few fields
from lm8323 device structure. Moving pdata pointer to probe
won't harm anybody.
Cc: Dmitry Torokhov [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/input/keyboard/lm8323.c
From: Felipe Balbi [EMAIL PROTECTED]
Get rid of omap-specific gpio calls and switch over
to gpiolib.
Cc: David Brownell [EMAIL PROTECTED]
Cc: Dmitry Torokhov [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/input/touchscreen/tsc2005.c | 15 ---
1 files
From: Felipe Balbi [EMAIL PROTECTED]
That LED_CONNECTED_WRONG was never defined so removing.
If someone needs those hooks, add back via proper
platform_data instead of nasty ifdefery.
Cc: Richard Purdie [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
From: Felipe Balbi [EMAIL PROTECTED]
Avoid using string magic and use integer for comparisson
Cc: Richard Purdie [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/i2c/chips/lp5521.c | 52 ---
1 files changed, 38 insertions(+),
From: Felipe Balbi [EMAIL PROTECTED]
This driver should be sitting together with the other
led drivers.
Cc: Richard Purdie [EMAIL PROTECTED]
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/i2c/chips/Kconfig |7 ---
drivers/i2c/chips/Makefile
Signed-off-by: Tero Kristo [EMAIL PROTECTED]
---
arch/arm/mach-omap2/pm34xx.c |5 ++-
arch/arm/mach-omap2/sleep34xx.S | 84 +-
arch/arm/plat-omap/include/mach/pm.h |1 +
3 files changed, 88 insertions(+), 2 deletions(-)
diff --git
On Tuesday 14 October 2008, Felipe Balbi wrote:
I'd say that if it goes to the wrong place and doesn't bother anyone,
will get forgotten. Just like the whole bunch of other drivers sitting
in linux-omap...
I thought the point was to have them sit in mainline. ;)
Funny that most of such
On Tue, 14 Oct 2008 17:42:49 +0400 Evgeniy Polyakov [EMAIL PROTECTED] wrote:
Hi.
On Tue, Oct 14, 2008 at 05:50:02AM -0700, Andrew Morton ([EMAIL PROTECTED])
wrote:
I think it's reasonable to permit the driver's operations to be interrupted
in this manner. It's done in quite a few other
On Tue, Oct 14, 2008 at 02:44:51PM -0700, David Brownell wrote:
On Tuesday 14 October 2008, Felipe Balbi wrote:
I'd say that if it goes to the wrong place and doesn't bother anyone,
will get forgotten. Just like the whole bunch of other drivers sitting
in linux-omap...
I thought the
Hi.
On Tue, Oct 14, 2008 at 05:50:02AM -0700, Andrew Morton ([EMAIL PROTECTED])
wrote:
I think it's reasonable to permit the driver's operations to be interrupted
in this manner. It's done in quite a few other places. But the problem is
actually *testing* it.
Why not just skipping the
- Original Message -
From: Andrew Morton [EMAIL PROTECTED]
To: Madhusudhan Chikkature [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];
linux-omap@vger.kernel.org
Sent: Monday, October 13, 2008 9:23 PM
Subject: Re: [PATCH 1/5] HDQ Driver for OMAP2430/3430
Hello,
This patch set programs the I2C controller OCP_SYSCONFIG register
after the driver resets the device. It is derived from the changes
mentioned by Richard Woodruff [EMAIL PROTECTED] at
This patchset provides off-mode support for OMAP3 HS/EMU devices. Due to
secure environment in these devices, wake-up from off-mode is slightly
different than in GP devices. This code has been tested on following chip
versions: ES2.1GP, ES3.0EMU, ES3.0HS.
--
To unsubscribe from this list: send
Fix for ES3.0 bug: SDRC not sending auto-refresh when OMAP wakes-up from OFF
mode (warning for HS devices.)
Signed-off-by: Tero Kristo [EMAIL PROTECTED]
---
arch/arm/mach-omap2/pm34xx.c | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git
Signed-off-by: Tero Kristo [EMAIL PROTECTED]
---
arch/arm/mach-omap2/pm34xx.c | 58 +-
arch/arm/mach-omap2/sleep34xx.S | 74 ++
arch/arm/plat-omap/include/mach/pm.h |2 +
3 files changed, 132 insertions(+), 2
On Tuesday 14 October 2008, Felipe Balbi wrote:
- omap_set_gpio_direction(dav_gpio, 1);
+ gpio_direction_input(dav_gpio);
ts-irq = OMAP_GPIO_IRQ(dav_gpio);
That should be ts-irq = gpio_to_irq(dav_gpio) ...
--
To unsubscribe from this list: send the line unsubscribe
67 matches
Mail list logo
