[PATCH 3/3] OMAP3 powerdomains: make USBTLL SAR only available on ES3.1 and beyond

2009-02-05 Thread Paul Walmsley
Richard Woodruff writes that chip errata prevent USBTLL SAR from working on OMAP3 ES levels before ES3.1: http://marc.info/?l=linux-arm-kernel&m=123319614808833&w=2 Update the OMAP3 powerdomain structures appropriately. Signed-off-by: Paul Walmsley Cc: Richard Woodruff --- arch/arm/mach-omap2

[PATCH 0/3] OMAP3: add ES3.1 support; disable USBTLL SAR < ES3.1

2009-02-05 Thread Paul Walmsley
Hello Russell, this series adds OMAP3 ES3.1 support, including boot-time TAP detection and omap_chip updates. It also blocks USBTLL hardware save-and-restore (SAR) support on revisions < ES3.1, due to chip errata. To do this, the semantics of the omap_chip system had to be altered slightly. Prev

[PATCH 2/3] OMAP3: update ES level flags to discriminate between post-ES2 revisions

2009-02-05 Thread Paul Walmsley
Some OMAP3 chip behaviors change in ES levels after ES2. Modify the existing omap_chip flags to add options for ES3.0 and ES3.1. Add a new macro, CHIP_GE_OMAP3430ES2, to cover ES levels from ES2 onwards - a common pattern for OMAP3 features. Update all current users of the omap_chip macros to us

[PATCH 1/3] ARM: OMAP: Fix omap34xx revision detection for ES3.1

2009-02-05 Thread Paul Walmsley
From: Tony Lindgren Fix omap34xx revision detection for ES3.1 linux-omap source commit is 1bafdfd33cc7a2b053ca705cf8623e1ae6cd4c52. Signed-off-by: Tony Lindgren Signed-off-by: Paul Walmsley --- arch/arm/mach-omap2/id.c |6 +- arch/arm/plat-omap/include/mach/cpu.h |1

Re: [PATCH B 06/10] OMAP3 pwrdm: add CORE SAR handling (for USBTLL module)

2009-02-05 Thread Paul Walmsley
Hello Russell, On Sat, 31 Jan 2009, Russell King - ARM Linux wrote: > On Thu, Jan 29, 2009 at 02:15:44AM -0700, Paul Walmsley wrote: > > Hi Richard, > > > > On Thu, 29 Jan 2009, Paul Walmsley wrote: > > > > > > TLLSAR is not functional till ES3.1 (and beyound). Is it possible to > > > > flag

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-05 Thread DongSoo Kim
Hello. This could be something trivial. On Tue, Jan 13, 2009 at 11:03 AM, Aguirre Rodriguez, Sergio Alberto wrote: > +/** > + * struct omap34xxcam_hw_config - struct for vidioc_int_g_priv ioctl > + * @xclk: OMAP34XXCAM_XCLK_A or OMAP34XXCAM_XCLK_B > + * @sensor_isp: Is sensor smart/SOC or raw >

Re: [patch/rfc 2.6.28-rc2] input: twl4030_keypad driver

2009-02-05 Thread David Brownell
On Friday 30 January 2009, hartleys wrote: > > I'd support an overall cleanup patch that fixes all those things at once. > > How's this for a starting point?  I'm willing to create a cleanup patch > for all the mach-omap1, mach-omap2, and mach-pxa users. > > Signed-off-by: H Hartley Sweeten I t

Re: [patch 2.6.29-rc1-omap git] twl4030_keypad cleanup

2009-02-05 Thread David Brownell
On Wednesday 04 February 2009, Tony Lindgren wrote: > > > Start cleaning up the twl4030 keypad driver to become more > > suitable for mainline. > > > >  - Remove false OMAP dependencies:  names, , Kconfig > >  - We don't need a miniature header file > >  - Add missing input_sync() > >  - ... > >

Re: [PATCH] OMAP: MMC: recover from transfer failures - Resend

2009-02-05 Thread Paul Walmsley
On Thu, 5 Feb 2009, Andrew Morton wrote: > On Tue, 3 Feb 2009 15:05:58 +0100 > Jean Pihet wrote: > > > + while (OMAP_HSMMC_READ(host->base, > > + SYSCTL) & SRD) > > + ; > > Is a __raw_readl() sufficient to prevent the cpu from burning up here, > or should we add cp

Re: [PATCH] OMAP: MMC: recover from transfer failures - Resend

2009-02-05 Thread Andrew Morton
On Tue, 3 Feb 2009 15:05:58 +0100 Jean Pihet wrote: > + while (OMAP_HSMMC_READ(host->base, > + SYSCTL) & SRD) > + ; Is a __raw_readl() sufficient to prevent the cpu from burning up here, or should we add cpu_relax()? An infinite loop which assumes the hardwar

[PATCH 0/1] Board specific prm timings

2009-02-05 Thread Peter 'p2' De Schrijver
This patch allows for boardspecific prm timings such as voltage and clock setup delays. By default it will use the very conservative timings which were used previously. Peter 'p2' De Schrijver (1): per board prm timings arch/arm/mach-omap2/pm.h |9 + arch/arm/mach-omap2/pm34xx.

[PATCH 1/1] per board prm timings

2009-02-05 Thread Peter 'p2' De Schrijver
API definition to set prm setup times Signed-off-by: Peter 'p2' De Schrijver --- arch/arm/mach-omap2/pm.h |9 + arch/arm/mach-omap2/pm34xx.c | 39 +-- 2 files changed, 42 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-omap2/pm.h b/

Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore

2009-02-05 Thread Kevin Hilman
"Hemanth V" writes: > - Original Message - > From: "Kevin Hilman" > To: "Hemanth V" > Cc: "Aaro Koskinen" ; > Sent: Thursday, February 05, 2009 7:59 PM > Subject: Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore > > >> "Hemanth V" writes: >> Fix context save/restore to wo

Re: PM branch updates: 3430sdp and omap3evm results

2009-02-05 Thread Ramesh Gupta Guntha
Kevin, I applied the patch maually at my end and tested, this works fine for me. anyway I will try with pm branch . thanks Ramesh Gupta G On 2/5/09, Kevin Hilman wrote: > Ramesh Gupta Guntha writes: > > > Hi Kevin, > > > > > > On 2/4/09, Kevin Hilman wrote: > >> Ramesh Gupta Guntha writes: > >

Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore

2009-02-05 Thread Högander Jouni
ext Hemanth V writes: > - Original Message - > From: "Kevin Hilman" > To: "Hemanth V" > Cc: "Aaro Koskinen" ; > Sent: Thursday, February 05, 2009 7:59 PM > Subject: Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore > > >> "Hemanth V" writes: >> Fix context save/restore to w

Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore

2009-02-05 Thread Hemanth V
- Original Message - From: "Kevin Hilman" To: "Hemanth V" Cc: "Aaro Koskinen" ; Sent: Thursday, February 05, 2009 7:59 PM Subject: Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore "Hemanth V" writes: Fix context save/restore to work with chip select. Also update the shadow

Re: PM branch updates: 3430sdp and omap3evm results

2009-02-05 Thread Kevin Hilman
Ramesh Gupta Guntha writes: > Hi Kevin, > > > On 2/4/09, Kevin Hilman wrote: >> Ramesh Gupta Guntha writes: >> >> > Kevin, >> > >> > >> > On 2/4/09, Kevin Hilman wrote: >> >> Ramesh Gupta Guntha writes: >> >> >> >> > Hi, >> >> > >> >> > I am able to resolve all other issues with this pm bran

Re: [PATCH PM 1/1] OMAP3: PM: Save and restore also CM_CLKSEL1_PLL_IVA2

2009-02-05 Thread Kevin Hilman
Jouni Hogander writes: > CM_CLKSEL1_PLL_IVA2 is not saved/restored currently. This patch is > adding save and restore for it. > > Signed-off-by: Jouni Hogander > --- > arch/arm/mach-omap2/prcm.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) Thanks, pushed to pm branch. Kevi

Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore

2009-02-05 Thread Kevin Hilman
"Hemanth V" writes: >> Fix context save/restore to work with chip select. Also update the shadow >> CHCONF0 register on every write and eliminate register reads. > > I believe the shadow CHCONF register need to have only the default > configuration as initialized by omap2_mcspi_setup_transfer(),

Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore

2009-02-05 Thread Hemanth V
> Fix context save/restore to work with chip select. Also update the shadow > CHCONF0 register on every write and eliminate register reads. I believe the shadow CHCONF register need to have only the default configuration as initialized by omap2_mcspi_setup_transfer(), since other other bits are in

[PATCH PM 1/1] OMAP3: PM: Save and restore also CM_CLKSEL1_PLL_IVA2

2009-02-05 Thread Jouni Hogander
CM_CLKSEL1_PLL_IVA2 is not saved/restored currently. This patch is adding save and restore for it. Signed-off-by: Jouni Hogander --- arch/arm/mach-omap2/prcm.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/prcm.c b/arch/arm/mach-omap2/prcm.c ind

[PATCH PM 0/1] OMAP3: PM: Fix to prcm save/restore

2009-02-05 Thread Jouni Hogander
This patch should fix the problem in locking DPLL2 after wake-up from OFF mode: clock: dpll2_ck failed transition to 'locked' clock: dpll2_ck failed transition to 'locked' clock: dpll2_ck failed transition to 'locked' clock: dpll2_ck failed transition to 'locked' prcm.c |6 +- 1 file chang

[PATCH PM 2/2] OMAP McSPI: spin_unlock_irq() missing

2009-02-05 Thread Aaro Koskinen
spin_unlock_irq() not called on failure path Signed-off-by: Aaro Koskinen --- drivers/spi/omap2_mcspi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c index 4d09777..56e91a4 100644 --- a/drivers/spi/omap2_mcspi.c +

[PATCH PM 1/2] OMAP McSPI: Fix context save/restore

2009-02-05 Thread Aaro Koskinen
Fix context save/restore to work with chip select. Also update the shadow CHCONF0 register on every write and eliminate register reads. Signed-off-by: Aaro Koskinen --- drivers/spi/omap2_mcspi.c | 51 +--- 1 files changed, 29 insertions(+), 22 deletions(

[PATCH PM 0/2] OMAP McSPI: Fixes to save/restore

2009-02-05 Thread Aaro Koskinen
Hello, Here's two fixes for the recent save/restore change (OMAP3 McSPI: Adds context save/restore), which does not seem to work with chip select. Jouni Hogander already sent one patch, but it does not solve all the problems. This patch updates the shadow value on every write, and uses it ins

RE: [PATCH F 06/12] OMAP2/3 clock: every clock must have a clkdm

2009-02-05 Thread Paul Walmsley
Hi Richard, On Tue, 3 Feb 2009, Woodruff, Richard wrote: > > Virtual clocks should soon be eliminated from the OMAP clock tree. ( > > "Virtual clocks" is here used to refer a clock that does not have a > > referent in the hardware; the usage of the term in the code is loose.) > > So far as I kno

[PATCH] OMAP2/3 clock: fix CONFIG_OMAP_RESET_CLOCKS

2009-02-05 Thread Paul Walmsley
Hello Russell, Kevin Hilman kindly alerted me to a bugfix patch that I had omitted from the sets that I sent to you recently. It's inserted below. Perhaps you might consider merging it along with the other sets that you are working on? Without it, chip power management won't work correctly.