RE: 2.6.29 and SDP3430

2009-04-17 Thread Woodruff, Richard
> > > > I wonder if the timer stopped ticking. If you connect with emulator take > > > a look at GPT1 registers and see if time base is moving. > > > > > > Another quick test is to shut off tickles, nohz=off. > > nohz=off did not work with either 2007q3 or 2008q3.. have'nt looked at the > GPT > >

n800 build error in clock24xx.c: 'secure_32k_ck' undeclared

2009-04-17 Thread Kalle Valo
Hello, I'm trying to compile n800 kernel with latest linux-omap tree. First I got strange build error: arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait': arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc' arch/arm/kernel/sys_oabi-compat.c:

RE: [PATCH][UPDATED] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

2009-04-17 Thread Kanigeri, Hari
> Artem Bityutskiy wrote: > > > >I'm sorry. Authors of the code may delete this e-mail. > >More flame and suggestions. > > > > Thanks for your suggestions; it is true that bridge code has been out for > a while, almost a year I think, and we are still trying to enhance it and > clean it up along t

RE: [PATCH][UPDATED] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

2009-04-17 Thread Ramirez Luna, Omar
Hi, Artem Bityutskiy wrote: > >I'm sorry. Authors of the code may delete this e-mail. >More flame and suggestions. > Thanks for your suggestions; it is true that bridge code has been out for a while, almost a year I think, and we are still trying to enhance it and clean it up along the way, alt

[PATCH][Take 2] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

2009-04-17 Thread Ameya Palande
This patch does following things: 1. Instead of GT_2trace() use pr_err(), since failure to enable or disable a clock is error which should be notified. 2. There is no need to check the return value of CLK_Enable and CLK_Disable and print error message, since these functions internally print t

Re: [PATCH][UPDATED] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

2009-04-17 Thread Artem Bityutskiy
I'm sorry. Authors of the code may delete this e-mail. More flame and suggestions. Ameya Palande wrote: diff --git a/drivers/dsp/bridge/services/clk.c b/drivers/dsp/bridge/services/clk.c index 440706f..b45603f 100644 --- a/drivers/dsp/bridge/services/clk.c +++ b/drivers/dsp/bridge/services/clk.

Re: [PATCH][UPDATED] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

2009-04-17 Thread Artem Bityutskiy
Ameya Palande wrote: } - return status; + return ((int_clk_status | fun_clk_status) != DSP_SOK) ? DSP_EFAIL : + DSP_SOK; } Side note: Is it possible to rework the code and remove thse insane DSP_EFAIL and DSP_SO

Re: [PATCH] ARM: OMAP: Update contact address of I2C registration helper

2009-04-17 Thread Riku Voipio
On Fri, Apr 17, 2009 at 02:15:05PM +0300, Jarkko Nikula wrote: > This email address is going to expire soon so update it. You'll want to send this to the "trivial changes" git tree by Jiri Kosina > Signed-off-by: Jarkko Nikula > --- > arch/arm/plat-omap/i2c.c |2 +- > 1 files changed, 1 ins

[PATCH][UPDATED] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

2009-04-17 Thread Ameya Palande
From: Ameya Palande This patch does following things: 1. Instead of GT_2trace() use pr_err(), since failure to enable or disable a clock is error which should be notified. 2. There is no need to check the return value of CLK_Enable and CLK_Disable and print error message, since these functi

Re: [PATCH] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

2009-04-17 Thread Artem Bityutskiy
Ameya Palande wrote: - GT_2trace(CLK_debugMask, GT_7CLASS, "CLK_Disable: CLK %s, " - "CLK dev id= %d is already disabled\n", - SERVICES_Clks[clk_id].clk_name, - SERVICES_Clks[clk_id].id); + pr_err("CLK_Di

Re: [PATCH] OMAP3: lessen amount of noisy messages

2009-04-17 Thread Artem Bityutskiy
Kevin Hilman wrote: Artem Bityutskiy writes: Hi, On Wed, 2009-04-15 at 09:22 -0600, Paul Walmsley wrote: stil thinking about it. These messages have made it easy to catch bugs with the PM code in the past (e.g., sad2d). Making them debug-level will require booting a kernel with clock debu

RE: [PATCH] [DSPBRIDGE] Various compile warning fixes

2009-04-17 Thread Kanigeri, Hari
Ameya, - if (!(chnlId >= 0) || !(chnlId < CHNL_MAXCHANNELS)) { + if (chnlId >= CHNL_MAXCHANNELS) { -- How about declaring chnlId as s32 so that the checks can be extended to negative values too ? Thank you, Best regards, Hari -- To unsubscribe from this list: send the line "unsubsc

RE: [PATCH] [DSPBRIDGE] Various compile warning fixes

2009-04-17 Thread Gupta, Ramesh
Hi Ameya, Ack, This patch looks good. I tested and not seen any issues. Regards Ramesh Gupta G > -Original Message- > From: linux-omap-ow...@vger.kernel.org > [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Ameya Palande > Sent: Friday, April 17, 2009 3:00 PM > To: linux-omap@vge

[PATCH] omap_iommu: Correct function name in the comment

2009-04-17 Thread Ameya Palande
From: Ameya Palande Signed-off-by: Ameya Palande --- arch/arm/plat-omap/iommu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c index 40e089f..0cec3f0 100644 --- a/arch/arm/plat-omap/iommu.c +++ b/arch/arm/plat-om

Re: [PATCH] OMAP3: lessen amount of noisy messages

2009-04-17 Thread Kevin Hilman
Artem Bityutskiy writes: > Hi, > > On Wed, 2009-04-15 at 09:22 -0600, Paul Walmsley wrote: >> stil thinking about it. These messages have made it easy to catch bugs >> with the PM code in the past (e.g., sad2d). Making them debug-level will >> require booting a kernel with clock debugging spe

Re: [PATCH 00/10] OMAP3: SR: Fixes in Smartreflex driver

2009-04-17 Thread Kevin Hilman
"Nayak, Rajendra" writes: > Re-sending this patch-set with some mailer issues resolved. They now apply > cleanly > with a git-am/git-apply. > > Hi, > > This series fixes a set of defects/issues in Smartreflex driver. SR > autocompensation is now > functional and is validated with these patches

RE: [PATCH] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

2009-04-17 Thread Kanigeri, Hari
Ameya, Patch looks good to me. Thank you, Best regards, Hari > -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Ameya Palande > Sent: Wednesday, April 15, 2009 7:19 AM > To: linux-omap@vger.kernel.org > Subject: [PATCH]

[PATCH] ARM: OMAP: Update contact address of I2C registration helper

2009-04-17 Thread Jarkko Nikula
This email address is going to expire soon so update it. Signed-off-by: Jarkko Nikula --- arch/arm/plat-omap/i2c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/i2c.c b/arch/arm/plat-omap/i2c.c index a303071..8b84839 100644 --- a/arch/arm/plat-omap/

[PATCH] OMAP: Make sure all resources used by the gpio-switch IRQ handler are initialized before use.

2009-04-17 Thread Peter 'p2' De Schrijver
Initialize the workqueue and timer used by the gpio-switch IRQ handler before we register the IRQ handler itself. Signed-off-by: Peter 'p2' De Schrijver --- arch/arm/plat-omap/gpio-switch.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/arm/plat-omap/gp

[PATCH] [DSPBRIDGE] Various compile warning fixes

2009-04-17 Thread Ameya Palande
From: Mika Kukkonen This patch cleans up various warnings uncovered with extra warning flags: - empty if() bodies - incorrect use of unsigned variables - bad comparison of pointer value - pointless check of unsigned value being smaller than zero - keyword 'extern' has to be first one in

Re: [PATCH] OMAP3: lessen amount of noisy messages

2009-04-17 Thread Paul Walmsley
Hi Artem, On Wed, 15 Apr 2009, Artem Bityutskiy wrote: > If you do not want re-compilation, I may send a different patch > like this: > > - printk(KERN_INFO "Disabling unused clock \"%s\"\n", clk->name); > + printk(KERN_DEBUG "Disabling unused clock \"%s\"\n", clk->name); > > in which c