Incorporating LCD backlight driver off and on functionality into OMAP-PM code

2009-07-20 Thread Elvis Dowson
Hi Kevin, Could you tell me which omap-pm methods I need to update, in order to add code to turn off and turn on the LCD backlight driver, when the system attempts to go to suspend mode and wake up from suspend mode. BTW, I'm still trying to get proper pm suspend functionality w

RE: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use

2009-07-20 Thread Shilimkar, Santosh
> -Original Message- > From: Felipe Balbi [mailto:m...@felipebalbi.com] > Sent: Tuesday, July 21, 2009 10:55 AM > To: Shilimkar, Santosh > Cc: m...@felipebalbi.com; Krishnamoorthy, Balaji T; > linux-ker...@vger.kernel.org; t...@atomide.com; > khil...@deeprootsystems.com; davi...@pacbell.

RE: android-omap-2.6.29 for gumstix overo

2009-07-20 Thread Elvis Dowson
Hi Vikram, I am now looking at the android-omap-2.6.29 branch, and after having looked at the zoom2_defconfig file, I notice that power management is not enabled in the zoom2_defconfg file. Do you know if anyone managed to get a working PM implementation for android-2.6.29 for

Re: [RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework

2009-07-20 Thread Felipe Balbi
hi, please send text mails and break your lines at 80 characters! On Tue, Jul 21, 2009 at 10:45:04AM +0530, Shilimkar, Santosh wrote: > Here is summary of Major difference between Triton(TWL4030) and > Phoenix(TWL6030_ chips are: > -GPIO, Keypad is not present in Phoenix > -I2C Chips addr

Re: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use

2009-07-20 Thread Felipe Balbi
hi, On Tue, Jul 21, 2009 at 10:01:06AM +0530, Shilimkar, Santosh wrote: > > So IMO, renaming the files is unnecessary. > Well tps* are just catalog names of the twl4* family. So you can keep adding > whatever names there as long it's a same IC. > > Perhaps you look in hurry to comment about this

RE: [RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework

2009-07-20 Thread Shilimkar, Santosh
Felipe, Thanks for the review. > -Original Message- > From: Felipe Balbi [mailto:m...@felipebalbi.com] > Sent: Tuesday, July 21, 2009 12:37 AM > To: Krishnamoorthy, Balaji T > Cc: linux-ker...@vger.kernel.org; t...@atomide.com; > khil...@deeprootsystems.com; davi...@pacbell.net; > linux

RE: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use

2009-07-20 Thread Shilimkar, Santosh
> -Original Message- > From: Felipe Balbi [mailto:m...@felipebalbi.com] > Sent: Tuesday, July 21, 2009 12:23 AM > To: Krishnamoorthy, Balaji T > Cc: linux-ker...@vger.kernel.org; t...@atomide.com; > khil...@deeprootsystems.com; davi...@pacbell.net; > linux-omap@vger.kernel.org; linux-...

PM branch update: rebase to .31-rc, added omap_hwmod/omap_device

2009-07-20 Thread Kevin Hilman
The PM branch hosted in my linux-omap-pm repo[1] has been updated. Significant changes: - rebased to omap/master (currently v2.6.31-rc1) - Using new omap_hwmod and omap_device infrastructure from Paul Walmsley - more reorg into groups of commits for easier submission upstream Tested on the follo

Re: [RFC][PATCH 2/4] OMAP4: PMIC: Add support for twl6030 RTC

2009-07-20 Thread Felipe Balbi
hi, On Mon, Jul 20, 2009 at 07:06:47PM +0530, balaj...@ti.com wrote: > @@ -257,15 +257,15 @@ config RTC_DRV_TWL92330 > platforms. The support is integrated with the rest of > the Menelaus driver; it's not separate module. > > -config RTC_DRV_TWL4030 > - tristate "TI TWL4030/T

Re: [PATCH 2/4] ARM: OMAP: Rename all twl4030_i2c*.

2009-07-20 Thread Felipe Balbi
On Mon, Jul 20, 2009 at 07:02:16PM +0530, balaj...@ti.com wrote: > From: Balaji T K > > This patch renames function names like twl4030_i2c_write_u8, > twl4030_i2c_read_u8 to twl_i2c_write_u8, twl_i2c_read_u8. > I2C address for modules(MADC, Battery Charger, Audio, RTC) > have changed between

Re: [PATCH 3/4] ARM: OMAP: Rename twl4030_ in rtc-twl.c to make it generic rtc

2009-07-20 Thread Felipe Balbi
On Mon, Jul 20, 2009 at 07:02:31PM +0530, balaj...@ti.com wrote: > From: Balaji T K > > This patch renames all twl4030_ functions to twl_ so that RTC driver can be > shared between Triton and Phoenix. Register addresses which have changed > will > be selected with COMPILATION FLAG > > Signe

Re: [PATCH 4/4] ARM: OMAP: Rename twl4030_ to twl_ in twl-regulator.c to make it generic reg

2009-07-20 Thread Felipe Balbi
On Mon, Jul 20, 2009 at 07:02:45PM +0530, balaj...@ti.com wrote: > From: Rajendra Nayak > > This patch renames all twl4030_ functions to twl so that regulator driver > can be reused by Triton - TWL4030 and Phoenix - TWL6030. > > Signed-off-by: Rajendra Nayak > Signed-off-by: Balaji T K > Sig

Re: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use

2009-07-20 Thread Felipe Balbi
Hi, On Mon, Jul 20, 2009 at 07:01:11PM +0530, balaj...@ti.com wrote: > From: Santosh Shilimkar > > The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 > for OMAP3. The common modules like RTC, Regulator creates opportunity > to re-use the most of the code from twl4030. > >

Re: [RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework

2009-07-20 Thread Felipe Balbi
hi, On Mon, Jul 20, 2009 at 07:06:32PM +0530, balaj...@ti.com wrote: > diff --git a/arch/arm/plat-omap/include/mach/irqs.h > b/arch/arm/plat-omap/include/mach/irqs.h > index fb7cb77..009cf4d 100644 > --- a/arch/arm/plat-omap/include/mach/irqs.h > +++ b/arch/arm/plat-omap/include/mach/irqs.h > @@

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-20 Thread Sonasath, Moiz
> Sonasath, Moiz wrote: > > When an XRDY/XDR is hit, wait for XUDF before writing data to DATA_REG. > > Otherwise some data bytes can be lost while transferring them from the > > memory to the I2C interface. > > > > Do a Busy-wait for XUDF, before writing data to DATA_REG. While waiting > > if the

Re: How to properly enable omap-pm functionality

2009-07-20 Thread Kevin Hilman
Elvis Dowson writes: > Which board file (e.g. board-3430sdp.c, etc), > can I use as the basis for studying how to properly implement PM for > the gumstix overo? SDP, omap3evm, Beagle and RX51 are all good example. But for PM, the board files only come into play for DVFS,

Re: PM: off mode

2009-07-20 Thread Kevin Hilman
Roger Quadros writes: > Roger Quadros wrote: >> ext Roger Quadros wrote: >>> ext Kevin Hilman wrote: Roger Quadros writes: > ext Roger Quadros wrote: >> ext Kevin Hilman wrote: >>> Roger Quadros writes: >>> Hi Kevin, Off mode does not seem t

[RFC][PATCH 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators

2009-07-20 Thread balajitk
From: Rajendra Nayak This patch adds initial support for creating twl6030 PMIC specific voltage regulators in the twl mfd driver. Board specific regulator configurations will have to be passed from respective board files. Signed-off-by: Rajendra Nayak --- drivers/mfd/twl-core.c | 64 ++

[RFC][PATCH 3/4] OMAP4: PMIC: Add support for twl6030 regulators

2009-07-20 Thread balajitk
From: Rajendra Nayak This patch updates the regulator driver to add support for TWL6030 PMIC specific LDO regulators. SMPS resources are not yet supported for TWL6030 and also .set_mode and .get_status for LDO's are yet to be implemented. Signed-off-by: Rajendra Nayak --- drivers/regulator/Kco

[RFC][PATCH 2/4] OMAP4: PMIC: Add support for twl6030 RTC

2009-07-20 Thread balajitk
From: Balaji T K This patch adds support for RTC in phoenix TWL6030. Register offset addresses which have changed in TWL6030 are defined under CONFIG_TWL6030_CORE and CONFIG_TWL4030_CORE. rtc-twl.c will hence forth support all twl RTC (4030, 5030, 6030 ..) Signed-off-by: Balaji T K Signed-off-b

[RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework

2009-07-20 Thread balajitk
From: Balaji T K This patch adds support for phoenix interrupt framework. New Interrupt status register A, B, C are introduced in Phoenix and are cleared on write. Due to difference in interrupt handling with respect to TWL4030, twl6030-irq.c is created for TWL6030 PMIC Signed-off-by: Rajendra N

[RFC][PATCH 0/4] TWL6030 patch series

2009-07-20 Thread Krishnamoorthy, Balaji T
The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and

[PATCH 4/4] ARM: OMAP: Rename twl4030_ to twl_ in twl-regulator.c to make it generic reg

2009-07-20 Thread balajitk
From: Rajendra Nayak This patch renames all twl4030_ functions to twl so that regulator driver can be reused by Triton - TWL4030 and Phoenix - TWL6030. Signed-off-by: Rajendra Nayak Signed-off-by: Balaji T K Signed-off-by: Santosh Shilimkar --- drivers/mfd/twl-core.c|3 +-

[PATCH 3/4] ARM: OMAP: Rename twl4030_ in rtc-twl.c to make it generic rtc

2009-07-20 Thread balajitk
From: Balaji T K This patch renames all twl4030_ functions to twl_ so that RTC driver can be shared between Triton and Phoenix. Register addresses which have changed will be selected with COMPILATION FLAG Signed-off-by: Balaji T K Signed-off-by: Nayak Rajendra Signed-off-by: Santosh Shilim

[PATCH 2/4] ARM: OMAP: Rename all twl4030_i2c*.

2009-07-20 Thread balajitk
From: Balaji T K This patch renames function names like twl4030_i2c_write_u8, twl4030_i2c_read_u8 to twl_i2c_write_u8, twl_i2c_read_u8. I2C address for modules(MADC, Battery Charger, Audio, RTC) have changed between 4030 and 6030. Base address of these module register also changed. Thus twl4

[PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use

2009-07-20 Thread balajitk
From: Santosh Shilimkar The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. The common modules like RTC, Regulator creates opportunity to re-use the most of the code from twl4030. This patch renames few common drivers twl4030* files to twl* to enable the code re-

RE: [RFC][PATCH 0/4] TWL6030 patch series

2009-07-20 Thread Krishnamoorthy, Balaji T
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: Monday, July 20, 2009 5:45 PM > To: Felipe Balbi > Cc: Krishnamoorthy, Balaji T; linux-omap@vger.kernel.org; > t...@atomide.com; khil...@deeprootsystems.com; > davi...@pacbell.net; Shilimkar, San

Re: [PATCH 9/10] drivers/mmc: Move a dereference below a NULL test

2009-07-20 Thread Alan Cox
> It is not a "NULL check" it is an assertion, which can be compiled out. > On some platforms BUG is implemented as a null dereference anyway > e.g. on ARM it is *(int *)0 = 0; It's a bogus check because the struct mmc_omap_host *host = slot->host; has already been executed before you check fo

Re: [PATCH 9/10] drivers/mmc: Move a dereference below a NULL test

2009-07-20 Thread Adrian Hunter
arun c wrote: On Mon, Jul 20, 2009 at 1:31 PM, Adrian Hunter wrote: Julia Lawall wrote: From: Julia Lawall If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/)

Re: [PATCH 9/10] drivers/mmc: Move a dereference below a NULL test

2009-07-20 Thread arun c
On Mon, Jul 20, 2009 at 1:31 PM, Adrian Hunter wrote: > Julia Lawall wrote: >> >> From: Julia Lawall >> >> If the NULL test is necessary, then the dereference should be moved below >> the NULL test. >> >> The semantic patch that makes this change is as follows: >> (http://www.emn.fr/x-info/coccine

Re: [RFC][PATCH 0/4] TWL6030 patch series

2009-07-20 Thread Mark Brown
On Mon, Jul 20, 2009 at 03:11:57PM +0300, Felipe Balbi wrote: > send these to lkml and Cc linux-omap. Also add to Cc: > Samuel Ortiz > Wim Van Sebroeck > Timo Kokkonen > Ben Dooks > linux-...@vger.kernel.org > linux-ker...@vger.kernel.org Plus me and Liam Girdwood for the regulator stuff. -

Re: [RFC][PATCH 0/4] TWL6030 patch series

2009-07-20 Thread Felipe Balbi
Hi, On Mon, Jul 20, 2009 at 01:59:41PM +0200, ext Krishnamoorthy, Balaji T wrote: > The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 > for OMAP3. This patch series adds support for TWL6030 irq framework, and > driver support for RTC and regulator. > > drivers/mfd/t

[RFC][PATCH 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators

2009-07-20 Thread balajitk
From: Rajendra Nayak This patch adds initial support for creating twl6030 PMIC specific voltage regulators in the twl mfd driver. Board specific regulator configurations will have to be passed from respective board files. Signed-off-by: Rajendra Nayak --- drivers/mfd/twl-core.c | 64 ++

[RFC][PATCH 3/4] OMAP4: PMIC: Add support for twl6030 regulators

2009-07-20 Thread balajitk
From: Rajendra Nayak This patch updates the regulator driver to add support for TWL6030 PMIC specific LDO regulators. SMPS resources are not yet supported for TWL6030 and also .set_mode and .get_status for LDO's are yet to be implemented. Signed-off-by: Rajendra Nayak --- drivers/regulator/Kco

[RFC][PATCH 2/4] OMAP4: PMIC: Add support for twl6030 RTC

2009-07-20 Thread balajitk
From: Balaji T K This patch adds support for RTC in phoenix TWL6030. Register offset addresses which have changed in TWL6030 are defined under CONFIG_TWL6030_CORE and CONFIG_TWL4030_CORE. rtc-twl.c will hence forth support all twl RTC (4030, 5030, 6030 ..) Signed-off-by: Balaji T K Signed-off-b

[RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework

2009-07-20 Thread balajitk
From: Balaji T K This patch adds support for phoenix interrupt framework. New Interrupt status register A, B, C are introduced in Phoenix and are cleared on write. Due to difference in interrupt handling with respect to TWL4030, twl6030-irq.c is created for TWL6030 PMIC Signed-off-by: Rajendra N

[RFC][PATCH 0/4] TWL6030 patch series

2009-07-20 Thread Krishnamoorthy, Balaji T
The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and

Re: PM: off mode

2009-07-20 Thread Roger Quadros
Roger Quadros wrote: ext Roger Quadros wrote: ext Kevin Hilman wrote: Roger Quadros writes: ext Roger Quadros wrote: ext Kevin Hilman wrote: Roger Quadros writes: Hi Kevin, Off mode does not seem to work on RX51 on latest PM branch. I get a reboot if I set enable_off_mode and sleep_wh

Re: [RFC][PATCH 1/1] DSPBRIDGE: workaround for SR with inappropriate OPP

2009-07-20 Thread Hiroshi DOYU
From: "Doyu Hiroshi (Nokia-D/Helsinki)" Subject: [RFC][PATCH 1/1] DSPBRIDGE: workaround for SR with inappropriate OPP Date: Mon, 20 Jul 2009 09:55:52 +0200 > From: Hiroshi DOYU > > It seems that we have had some cases where SR may not work with some > OPP level. This patch will introduce a work

Re: [PATCH 9/10] drivers/mmc: Move a dereference below a NULL test

2009-07-20 Thread Adrian Hunter
Julia Lawall wrote: From: Julia Lawall If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ type T; expression E,E1; identifier i,fld; statement S; @@ -

[RFC][PATCH 1/1] DSPBRIDGE: workaround for SR with inappropriate OPP

2009-07-20 Thread Hiroshi DOYU
From: Hiroshi DOYU It seems that we have had some cases where SR may not work with some OPP level. This patch will introduce a workaround to turn off SR with specific OPP, in this case it's OPP2. With this patch, we can use all OPP but can disable SR on problematic OPP2 case. It seems that this w

Re: N8x0 to mainline patches

2009-07-20 Thread Arnaud Ebalard
Hi, "Luke-Jr" writes: >> When the rx44 keymap support is added back in your quilt set, can we >> discuss it. IIRC, the same kind of value (i.e. > 255) is also in the >> rx-51. Any specific reason? > > I presume the reason is that the "standard" code for the "Fn" key is 464... > so > it is only

Re: [PATCH] TWL4030:TWL5030:TPS659x0: add keypad support

2009-07-20 Thread Trilok Soni
Hi Vikram, > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include One empty line between above two headers. I hope you are aware of earlier comments posted for this driver when it was submitted few months back and had long discussion on thread