Re: [PATCH 0/10] OPP layer and additional cleanups.

2010-01-07 Thread Romit Dasgupta
>> >> Only point I see that may disfavor list based implementation is the fact >> that we >> do not expect high number of OPPs. > yes + overhead of CPU cycles walking thru the list Vs indexing off an array. True there is overhead but the downside of an array is reallocing (as is the case in the pr

Re: [RFC/PATCH 1/2] usb_otg: compile fix

2010-01-07 Thread Felipe Balbi
Hi, On Fri, Jan 08, 2010 at 07:43:09AM +0200, Felipe Balbi wrote: > On Thu, Jan 07, 2010 at 09:03:11PM -0400, Francisco Alecrim wrote: > > From: Francisco Alecrim > > > > include/linux/usb.h: In function 'usb_mark_last_busy': > > include/linux/usb.h:561: error: 'struct usb_device' has no member

RE: [PATCH v3 1/2] USB: Add empty functions in otg.h

2010-01-07 Thread Maulik
Greg, Are you going to include this patch in your queue? Thanks, Maulik -Original Message- From: Olof Johansson [mailto:o...@lixom.net] Sent: Tuesday, January 05, 2010 11:23 PM To: Felipe Balbi Cc: ext Maulik Mankad; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Tony Lindgren;

RE: [PATCH v3 0/2] ARM : OMAP patches

2010-01-07 Thread Maulik
Felipe, Do you have any comments on Version 3 of this patch series as per the below link. http://marc.info/?l=linux-usb&m=126226571531540&w=2 This series applies cleanly on top of your for-tony branch. Also note that the series depends on the 2 patch series as below. [PATCH 1/2] USB : Add empt

Re: [RFC/PATCH 1/2] usb_otg: compile fix

2010-01-07 Thread Felipe Balbi
On Thu, Jan 07, 2010 at 09:03:11PM -0400, Francisco Alecrim wrote: > From: Francisco Alecrim > > include/linux/usb.h: In function 'usb_mark_last_busy': > include/linux/usb.h:561: error: 'struct usb_device' has no member named > 'last_busy' > > Option USB_OTG selects USB_SUSPEND but doesn't selec

RE: [PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB

2010-01-07 Thread Kanigeri, Hari
Nishant, With 64MB we were seeing cases of running out of DSP virtual memory when running multiple Multimedia use cases in parallel at a time. Thank you, Best regards, Hari -Original Message- From: Menon, Nishanth Sent: Friday, January 08, 2010 7:48 AM To: Ramirez Luna, Omar Cc: lin

Re: rt2x00 support not available for beagleboard

2010-01-07 Thread Sid Boyce
On 07/01/10 22:40, Sid Boyce wrote: > That's the same on all recent kernels. > # grep RT2X00 arch/arm/configs/omap3_beagle_defconfig > # > # grep RT2X00 arch/arm/configs/* > arch/arm/configs/eseries_pxa_defconfig:# CONFIG_RT2X00 is not set > arch/arm/configs/igep0020_defconfig:CONFIG_RT2X00=m > arc

Re: [RFC/PATCH 1/2] usb_otg: compile fix

2010-01-07 Thread Olof Johansson
On Thu, Jan 07, 2010 at 09:03:11PM -0400, Francisco Alecrim wrote: > From: Francisco Alecrim > > include/linux/usb.h: In function 'usb_mark_last_busy': > include/linux/usb.h:561: error: 'struct usb_device' has no member named > 'last_busy' > > Option USB_OTG selects USB_SUSPEND but doesn't selec

Re: [PATCH 8/8] DSPBRIDGE: Use _IOxx macro to define ioctls

2010-01-07 Thread Nishanth Menon
Apologies on the spam, but a few points below for preventing a future ioctl change: Menon, Nishanth had written, on 01/07/2010 08:59 PM, the following: Ramirez Luna, Omar had written, on 01/07/2010 07:01 PM, the following: - Use standard convention to define ioctls. please warn in the commit

Re: [PATCH 8/8] DSPBRIDGE: Use _IOxx macro to define ioctls

2010-01-07 Thread Nishanth Menon
Ramirez Luna, Omar had written, on 01/07/2010 07:01 PM, the following: - Use standard convention to define ioctls. - Removed runtime check for ioctl matching table number. - Added __deprectaed marker to functions that are not used anymore. Currently 'DB' is used as identifier for dspbridge.

Re: [PATCH 6/8] DSPBRIDGE: Use dspbridge to initialize platform data

2010-01-07 Thread Nishanth Menon
Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following: Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions. ?? are you intending to state that dspbridge.

Re: [PATCH 4/8] DSPBRIDGE: Remove unused hDrvObject in bridge_[open|release]

2010-01-07 Thread Nishanth Menon
Omar Ramirez Luna had written, on 01/07/2010 07:00 PM, the following: This patch removes an unused variable in bridge_open and bridge_release functions, which reduces indentation. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/rmgr/drv_interface.c | 25 + 1 f

Re: [PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB

2010-01-07 Thread Nishanth Menon
Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following: From: Hari Kanigeri This patch increases the DMM from 64MB to 256MB. begs the question: Why? Signed-off-by: Hari Kanigeri Signed-off-by: Omar Ramirez Luna Signed-off-by: Leed Aguilar --- arch/arm/plat-omap/include/d

Re: [PATCH 2/8] DSPBRIDGE: sysfs entry for global driver state

2010-01-07 Thread Nishanth Menon
Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following: This patch creates a new sysfs entry to query the driver state without making any bridge direct call, this is useful to monitor driver state without creating any handle to bridge driver. why sysfs and not debugfs considering

[RFC/PATCH 2/2] fix compile for tahvo-usb.c

2010-01-07 Thread Francisco Alecrim
From: Francisco Alecrim drivers/cbus/tahvo-usb.c:138: undefined reference to 'usb_bus_start_enum' usb_bus_start_enum only exported if USB_OTG enabled Signed-off-by: Francisco Alecrim --- drivers/cbus/tahvo-usb.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers

[RFC/PATCH 1/2] usb_otg: compile fix

2010-01-07 Thread Francisco Alecrim
From: Francisco Alecrim include/linux/usb.h: In function 'usb_mark_last_busy': include/linux/usb.h:561: error: 'struct usb_device' has no member named 'last_busy' Option USB_OTG selects USB_SUSPEND but doesn't select PM(required by USB_SUSPEND) causing this compile error. Putting USB_SUSPEND as

[PATCH 8/8] DSPBRIDGE: Use _IOxx macro to define ioctls

2010-01-07 Thread Omar Ramirez Luna
- Use standard convention to define ioctls. - Removed runtime check for ioctl matching table number. - Added __deprectaed marker to functions that are not used anymore. Currently 'DB' is used as identifier for dspbridge. Added TODOs for removing the function table and, deprecated and not implemen

[PATCH 7/8] DSPBRIDGE: Fix header locations mach to plat

2010-01-07 Thread Omar Ramirez Luna
Fix header locations, replaced mach to plat Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/dspbridge.c|2 +- arch/arm/plat-omap/include/dspbridge/host_os.h |2 +- drivers/dsp/bridge/wmd/tiomap3430.c|2 +- 3 files changed, 3 insertions(+), 3 delet

[PATCH 6/8] DSPBRIDGE: Use dspbridge to initialize platform data

2010-01-07 Thread Omar Ramirez Luna
Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/Makefile |4 +++- 1 files changed, 3 insertions(+), 1

[PATCH 5/8] DSPBRIDGE: change to cpufreq_register_notifier for OPP changes

2010-01-07 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo This patch changes clk_notifier_unregister with cpufreq_unregister_notifier, which is used for OPP change notifications Signed-off-by: Fernando Guzman Lugo --- drivers/dsp/bridge/Kconfig |2 +- drivers/dsp/bridge/rmgr/drv_interface.c | 25 +

[PATCH 4/8] DSPBRIDGE: Remove unused hDrvObject in bridge_[open|release]

2010-01-07 Thread Omar Ramirez Luna
This patch removes an unused variable in bridge_open and bridge_release functions, which reduces indentation. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/rmgr/drv_interface.c | 25 + 1 files changed, 5 insertions(+), 20 deletions(-) diff --git a/drivers/dsp

[PATCH 2/8] DSPBRIDGE: sysfs entry for global driver state

2010-01-07 Thread Omar Ramirez Luna
This patch creates a new sysfs entry to query the driver state without making any bridge direct call, this is useful to monitor driver state without creating any handle to bridge driver. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/rmgr/drv_interface.c | 87 +

[PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB

2010-01-07 Thread Omar Ramirez Luna
From: Hari Kanigeri This patch increases the DMM from 64MB to 256MB. Signed-off-by: Hari Kanigeri Signed-off-by: Omar Ramirez Luna Signed-off-by: Leed Aguilar --- arch/arm/plat-omap/include/dspbridge/dmm.h |2 +- drivers/dsp/bridge/pmgr/dmm.c |8 2 files changed

[PATCH 1/8] DSPBRIDGE: Cleanup SSI handling - remove IO_ADDRESS

2010-01-07 Thread Omar Ramirez Luna
This patch cleans SSI clock preparation and also removes the dependency on IO_ADDRESS variants for easier maintenance. Signed-off-by: Omar Ramirez Luna --- arch/arm/plat-omap/include/dspbridge/drv.h |7 ++ drivers/dsp/bridge/services/clk.c | 30 ++- 2 f

[PATCH 0/8] misc patches

2010-01-07 Thread Omar Ramirez Luna
Next set of patches to be applied on top of sync point. Highlights: *** Ioctl numbers has changed, this will require an update on libbridge and clients accesing directly to the driver *** - IO_ADDRESS is replaced for ioremap. - DMM table is increased to hold up to 256 MB (in pages). Fernand

rt2x00 support not available for beagleboard

2010-01-07 Thread Sid Boyce
That's the same on all recent kernels. # grep RT2X00 arch/arm/configs/omap3_beagle_defconfig # # grep RT2X00 arch/arm/configs/* arch/arm/configs/eseries_pxa_defconfig:# CONFIG_RT2X00 is not set arch/arm/configs/igep0020_defconfig:CONFIG_RT2X00=m arch/arm/configs/igep0020_defconfig:CONFIG_RT2X00_LIB

[GIT PULL] OMAP clock/OPP fixes for 2.6.33-rc

2010-01-07 Thread Paul Walmsley
Hi Tony, The following changes since commit 6201a1542003f3e617e53003a780aab835c0f9d5: Cory Maccarrone (1): OMAP1 clock: Add missing clocks for OMAP 7xx are available in the git repository at: git://git.pwsan.com/linux-2.6 for_2.6.33rc_b Cory Maccarrone (1): OMAP1 clock: remov

Re: [PATCHV4 0/4] OMAP3630 Clock changes

2010-01-07 Thread Paul Walmsley
On Thu, 7 Jan 2010, Vishwanath BS wrote: > THis patch series has Clock changes related to OMAP3630. The major Clock > releated changes are > 1. DPLL4 type has changed to j type. > 2. Frequency Selection (FREQSEL) is no longer required for 3630 > 3. CLKSEL field width is increased for DPLL4 M2,

Re: [PATCHV4 3/4] OMAP3: Introduce 3630 DPLL4 HSDivider changes

2010-01-07 Thread Paul Walmsley
Hello Vishwanath, some more comments. On Thu, 7 Jan 2010, Vishwanath BS wrote: > DPLL4 HS Divider (M2, M3, M4, M5 and M6) field width has been increased by 1 > bit in 3630. > This patch has changes to accommodate this in CM dynamically based on chip > version. > Basically new clock nodes have

[PATCH v2] omap: zoom3: enable ehci support

2010-01-07 Thread Vikram Pandita
Zoom3 board has omap3630 EHCI port2 connected to a ULPI phy. GPIO_64 is connected to the PHY reset pin. Signed-off-by: Vikram Pandita Cc: Gadiyar, Anand --- History: v1: initial draft v2: fix minor header file include comment by Anand Gadiyar arch/arm/mach-omap2/board-zoom3.c | 15 ++

Re: [PATCH v2] omap: serial: fix coding style indentaion

2010-01-07 Thread Kevin Hilman
Vikram Pandita writes: > No logical code change > > Fix coding style indentaion as per checkpatch.pl > Fix multi-line comment style reported by Nishanth Menon > > Signed-off-by: Vikram Pandita > Cc: Menon, Nishanth Acked-by: Kevin Hilman > --- > arch/arm/mach-omap2/serial.c | 19 +

[PATCH v2] omap: serial: fix coding style indentaion

2010-01-07 Thread Vikram Pandita
No logical code change Fix coding style indentaion as per checkpatch.pl Fix multi-line comment style reported by Nishanth Menon Signed-off-by: Vikram Pandita Cc: Menon, Nishanth --- arch/arm/mach-omap2/serial.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff

RE: [PATCH 2/3] AM35xx: Introduce am35xx.h file

2010-01-07 Thread Hiremath, Vaibhav
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Friday, January 08, 2010 12:44 AM > To: Hiremath, Vaibhav > Cc: linux-omap@vger.kernel.org; t...@atomide.com; Govindarajan, > Sriramakrishnan > Subject: Re: [PATCH 2/3] AM35xx: Introduce am35xx.h file >

Re: [PATCH 05/12] omap1: Add 7xx clocks and pin muxes for SPI

2010-01-07 Thread Tony Lindgren
* Grazvydas Ignotas [100107 01:44]: > > > > --- a/arch/arm/mach-omap1/devices.c > > +++ b/arch/arm/mach-omap1/devices.c > > @@ -196,6 +198,38 @@ void __init omap1_init_mmc(struct > > omap_mmc_platform_data **mmc_data, > > > >  /*--

Re: [PATCH 2/3] AM35xx: Introduce am35xx.h file

2010-01-07 Thread Kevin Hilman
"Hiremath, Vaibhav" writes: >> -Original Message- >> From: Kevin Hilman [mailto:khil...@deeprootsystems.com] >> Sent: Thursday, January 07, 2010 5:20 AM >> To: Hiremath, Vaibhav >> Cc: linux-omap@vger.kernel.org; t...@atomide.com; Govindarajan, >> Sriramakrishnan >> Subject: Re: [PATCH 2/

Re: [PATCH] Generic TRITON power scripts for OMAP3 based boards.

2010-01-07 Thread Kevin Hilman
Lesly A M writes: > Changes to move the voltsetup_time & sleep/wakeup/warm_rest sequence moved to > new file. Need more description here, in particular, the obvious first question is "why?". Presumably to avoid duplicate scripts etc., but it's not at all clear from this description. Also plea

Re: [PATCH] omap: serial: fix coding style indentaion

2010-01-07 Thread Nishanth Menon
Pandita, Vikram had written, on 01/07/2010 12:49 PM, the following: Just fix coding style indentaion as per checkpatch No logical code change. Signed-off-by: Vikram Pandita --- arch/arm/mach-omap2/serial.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [rfc/rft/patch-v2.6.32-omap1+ 2/2] arm: omap: add missing __initdata to omap_board_config_kernel

2010-01-07 Thread Tony Lindgren
* Tomi Valkeinen [100107 03:29]: > On Wed, 2010-01-06 at 00:44 +0100, ext Tony Lindgren wrote: > > Tomi, > > > > * Ladislav Michl [091216 14:40]: > > > On Wed, Dec 16, 2009 at 11:52:35PM +0200, Felipe Balbi wrote: > > > > we still need to get rid of the OMAP_TAG_LCD, but while > > > > it's still

[PATCH] omap: serial: fix coding style indentaion

2010-01-07 Thread Vikram Pandita
Just fix coding style indentaion as per checkpatch No logical code change. Signed-off-by: Vikram Pandita --- arch/arm/mach-omap2/serial.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c index 8c

Re: [PATCH] Update Triton2 scripts

2010-01-07 Thread Kevin Hilman
Lesly A M writes: > Updated the sleep,wakeup & warm_reset sequence as recommended by David > Derrick. > Used broadcast command and changed the TYPE2 register, REMAP register for > 3430SDP board, > added the new script in zoom2 board file. > > VDD1, VDD2 and VPLL1 are remapped to turn off during

Re: [pm-wip-opp][PATCH] omap3: pm: sr: fix get_vddx_opp to use ceil

2010-01-07 Thread Kevin Hilman
Nishanth Menon writes: > commit ad248123 changed the behavior of get_vdd1_opp and get_vdd2_opp > to use exact frequencies causing a break in rx51. we re-introduce the > approximate search to maintain consistent behavior. > > The DPLL frequencies are expected to be the same as the OPP frequencies,

Re: [PATCHV4 4/4] OMAP3: add support for 192Mhz DPLL4M2 output

2010-01-07 Thread Paul Walmsley
Hello Vishwanath, some more comments: On Thu, 7 Jan 2010, Vishwanath BS wrote: > In 3630, DPLL4M2 o/p can be 96MH or 192MHz (for SGX to run at 192). This > patch has changes to support this feature. 96MHz clock is generated by > dividing 192Mhz clock by 2 using CM_CLKSEL_CORE register. > SGX c

Re: [PATCHV4 2/4] OMAP3: Remove FreqSel for 3630

2010-01-07 Thread Paul Walmsley
Hello Vishwanath, On Thu, 7 Jan 2010, Vishwanath BS wrote: > Frequency Selection field is no longer valid for OMAP3630. So remove > references to that. The code in the patch is fine, but this patch description doesn't seem to have anything to do with the code. Please fix and resend. > > Sign

Re: [PATCHV4 1/4] OMAP3: introduce DPLL4 Jtype

2010-01-07 Thread Paul Walmsley
Hello Vishwanath, some comments. On Thu, 7 Jan 2010, Vishwanath BS wrote: > DPLL4 for 3630 introduces a changed block called j type dpll, requiring > special divisor bits and additional reg fields. To allow for silicons to > use this, this is introduced as a flag and is enabled for 3630 silicon.

RE: [PATCH 0/4] Add I2C support to AM3517EVM

2010-01-07 Thread Hiremath, Vaibhav
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Thursday, January 07, 2010 5:22 AM > To: Hiremath, Vaibhav > Cc: linux-omap@vger.kernel.org; t...@atomide.com > Subject: Re: [PATCH 0/4] Add I2C support to AM3517EVM > > hvaib...@ti.com writes: > > > F

RE: [PATCH 2/3] AM35xx: Introduce am35xx.h file

2010-01-07 Thread Hiremath, Vaibhav
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Thursday, January 07, 2010 5:20 AM > To: Hiremath, Vaibhav > Cc: linux-omap@vger.kernel.org; t...@atomide.com; Govindarajan, > Sriramakrishnan > Subject: Re: [PATCH 2/3] AM35xx: Introduce am35xx.h file >

Re: problem with n810 boot up

2010-01-07 Thread green
Luke-Jr wrote at 2010-01-07 09:40 -0600: > On Thursday 07 January 2010 09:25:40 am Francisco Alecrim wrote: > > Luke-Jr wrote: > > > On Wednesday 06 January 2010 05:59:48 pm you wrote: > > >> Luke-Jr wrote: > > >>> Also, note my rootfs is Gentoo, not Maemo. Maemo will depend on DSME > > >>> which i

Re: [PATCH 0/10] OPP layer and additional cleanups.

2010-01-07 Thread Nishanth Menon
Dasgupta, Romit had written, on 01/07/2010 02:24 AM, the following: * OPP layer internals have moved to list based implementation. Is there a benefit of list based implementation? Actually, this is a question I have asked myself several times. The motivation behind list based implementation is

Re: problem with n810 boot up

2010-01-07 Thread Luke-Jr
On Thursday 07 January 2010 09:25:40 am Francisco Alecrim wrote: > Luke-Jr wrote: > > On Wednesday 06 January 2010 05:59:48 pm you wrote: > >> Luke-Jr wrote: > >>> Also, note my rootfs is Gentoo, not Maemo. Maemo will depend on DSME > >>> which is not being started with my modded linuxrc. > >> > >>

Re: [PATCH 8/10] OPP layer and additional cleanups

2010-01-07 Thread Nishanth Menon
Dasgupta, Romit had written, on 01/07/2010 02:58 AM, the following: Sripathy, Vishwanath wrote: Romit, With VDD1 OPP resource being removed, how are you maitaning link between MPU and DSP frequencies? I could not find such a link in the below code. May be I am missing something?? I have not l

Re: [PATCH] Generic TRITON power scripts for OMAP3 based boards.

2010-01-07 Thread Nishanth Menon
Manuel, Lesly Arackal had written, on 01/07/2010 04:32 AM, the following: Changes to move the voltsetup_time & sleep/wakeup/warm_rest sequence moved to new file. thanks for the same. Signed-off-by: Lesly A M Cc: n...@ti.com normally the format is: Cc: Nishanth Menon Cc: dderr...@ti.com C

Re: problem with n810 boot up

2010-01-07 Thread Francisco Alecrim
Luke-Jr wrote: > On Wednesday 06 January 2010 05:59:48 pm you wrote: >> Luke-Jr wrote: >>> Also, note my rootfs is Gentoo, not Maemo. Maemo will depend on DSME >>> which is not being started with my modded linuxrc. >> I'm using Mamona. Anyway,I did some tests before rootfs execution and I >> got th

Re: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

2010-01-07 Thread Nishanth Menon
Govindarajan, Sriramakrishnan had written, on 01/07/2010 06:30 AM, the following: From: Sriram OMAP platforms(like OMAP3530) include DSP or other co-processors for media acceleration. when carving out memory for the accelerators we can end up creating a hole in the memory map of sort: To hand

RE: [PATCH] OMAP3: hwmod: Adding flag to prevent caching of sysconfig register.

2010-01-07 Thread Gopinath, Thara
>>-Original Message- >>From: Paul Walmsley [mailto:p...@pwsan.com] >>Sent: Wednesday, January 06, 2010 6:02 AM >>To: Gopinath, Thara >>Cc: linux-omap@vger.kernel.org >>Subject: RE: [PATCH] OMAP3: hwmod: Adding flag to prevent caching of >>sysconfig register. >> >>On Wed, 23 Dec 2009, Gop

Re: [PATCH 5/9] omap3: pm: sr: replace get_opp with freq_to_opp

2010-01-07 Thread Nishanth Menon
Nishanth Menon had written, on 01/07/2010 06:15 AM, the following: Sripathy, Vishwanath said the following on 01/07/2010 02:35 AM: Nishant, Have you tested your opp patches on 3630? Apparently opp changes in wip branch does not even boot on ZOOM3 board. The original series was tested and rep

RE: [PATCH] OMAP: Exporting functions doing common register access

2010-01-07 Thread Aggarwal, Anuj
> > > In the interim, I would suggest that you remove the the clock source > and > > > receiver source change functions from omap-mcbsp.c, split them into > OMAP1 > > > and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mcbsp.c. > > > Expand struct omap_mcbsp_ops to add function pointers

Re: [PATCH 2/10] OPP layer and additional cleanups.

2010-01-07 Thread Romit Dasgupta
Menon, Nishanth wrote: > > > > Could you please start using git format-patch -s -M -o to generate patches? > > > > And you exposed struct omap_opp back to the public defeating the > > previous work :( Exposing struct omap_opp is ok. In fact I need this for adding/deleting and getting a handle on

Re: [PATCH 3/10] OPP layer and additional cleanups.

2010-01-07 Thread Romit Dasgupta
>> diff --git a/arch/arm/plat-omap/omap-pm-srf.c >> b/arch/arm/plat-omap/omap-pm-srf.c >> index f7bf353..0736d6a 100644 >> --- a/arch/arm/plat-omap/omap-pm-srf.c >> +++ b/arch/arm/plat-omap/omap-pm-srf.c >> @@ -25,10 +25,6 @@ >> #include >> #include >> >> -struct omap_opp *dsp_opps; >> -stru

[PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

2010-01-07 Thread Sriramakrishnan
From: Sriram OMAP platforms(like OMAP3530) include DSP or other co-processors for media acceleration. when carving out memory for the accelerators we can end up creating a hole in the memory map of sort: To handle such a memory configuration ARCH_HAS_HOLES_MEMORYMODEL has to be enabled. For fur

Re: [PATCH 5/9] omap3: pm: sr: replace get_opp with freq_to_opp

2010-01-07 Thread Nishanth Menon
Sripathy, Vishwanath said the following on 01/07/2010 02:35 AM: Nishant, Have you tested your opp patches on 3630? Apparently opp changes in wip branch does not even boot on ZOOM3 board. The original series was tested and reported with results. I have'nt had a chance to try with the newer pa

Re: OMAP: DSS2: DSI Driver: udelays/timeouts

2010-01-07 Thread Tomi Valkeinen
Hi, On Fri, 2009-12-11 at 13:46 +0100, ext Juha Leppanen wrote: > Hi, > > checking some patches thru www.kernel.org > > /drivers/video/omap2/dss/dsi.c > > I noticed in many places that if timeout happens, > while "read/status/check" is not done after the last Nth udelay. > Why not "check" after

Re: [RFC PATCH] OMAP: DSS2: RFBI driver: Cleanup "kfifo is full" test

2010-01-07 Thread Tomi Valkeinen
On Mon, 2009-12-14 at 04:18 +0100, ext Heikki Orsila wrote: > RFBI_CMD_FIFO_LEN_BYTES might not be a power-of-two, > but kfifo() allocates the size up to the next power of two, > which makes (RFBI_CMD_FIFO_LEN_BYTES - kfifo_len()) > look very dubious (possibly a negative value!). But this can neve

Re: dadd2bb931a08a4b6b17f9e82d9bbe7bedebbc98 breaks omapfb (old non-dss2)

2010-01-07 Thread Tomi Valkeinen
On Thu, 2010-01-07 at 12:05 +0100, Tomi Valkeinen wrote: > On Thu, 2009-12-17 at 15:51 +0100, ext Sergey Lapin wrote: > > On Wed, Dec 16, 2009 at 2:21 PM, Tomi Valkeinen > > wrote: > > > Hi, > > > > > > On Tue, 2009-12-15 at 17:01 +0100, ext Sergey Lapin wrote: > > >> On Tue, Dec 15, 2009 at 6:22

Re: [rfc/rft/patch-v2.6.32-omap1+ 2/2] arm: omap: add missing __initdata to omap_board_config_kernel

2010-01-07 Thread Tomi Valkeinen
On Wed, 2010-01-06 at 00:44 +0100, ext Tony Lindgren wrote: > Tomi, > > * Ladislav Michl [091216 14:40]: > > On Wed, Dec 16, 2009 at 11:52:35PM +0200, Felipe Balbi wrote: > > > we still need to get rid of the OMAP_TAG_LCD, but while > > > it's still there, let's kill the section mismatches. > >

RE: [PATCH] Generic TRITON power scripts for OMAP3 based boards.

2010-01-07 Thread Sripathy, Vishwanath
Shouldn't this be a patch series? I think this patch has dependency on previous patch. Vishwa > -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Lesly A M > Sent: Thursday, January 07, 2010 4:03 PM > To: linux-omap@vger

Re: dadd2bb931a08a4b6b17f9e82d9bbe7bedebbc98 breaks omapfb (old non-dss2)

2010-01-07 Thread Tomi Valkeinen
On Tue, 2010-01-05 at 18:32 +0100, ext Paul Walmsley wrote: > Hi Tomi, > > On Tue, 15 Dec 2009, Tomi Valkeinen wrote: > > > On Tue, 2009-12-15 at 10:58 +0100, ext Sergey Lapin wrote: > > > dadd2bb931a08a4b6b17f9e82d9bbe7bedebbc98 > > > OMAP: OMAPFB: add omapdss device > > > > > > The upcomin

Re: Question about omap_hsmmc driver

2010-01-07 Thread Enric Balletbò i Serra
Hi, The mux configuration is set at u-boot level and this works with kernel 2.6.28 so I suppose the mux configuration is setup correctly. Looking at driver I see new data in twl4030_hsmmc_info struct. Please, can you explain a bit the transceiver, ocr_mask and ext_clock ? Just for information,

Re: dadd2bb931a08a4b6b17f9e82d9bbe7bedebbc98 breaks omapfb (old non-dss2)

2010-01-07 Thread Tomi Valkeinen
On Thu, 2009-12-17 at 15:51 +0100, ext Sergey Lapin wrote: > On Wed, Dec 16, 2009 at 2:21 PM, Tomi Valkeinen > wrote: > > Hi, > > > > On Tue, 2009-12-15 at 17:01 +0100, ext Sergey Lapin wrote: > >> On Tue, Dec 15, 2009 at 6:22 PM, Tomi Valkeinen > >> wrote: > >> > Hi, > >> > > >> > On Tue, 2009-1

[PATCH] Generic TRITON power scripts for OMAP3 based boards.

2010-01-07 Thread Lesly A M
Changes to move the voltsetup_time & sleep/wakeup/warm_rest sequence moved to new file. Signed-off-by: Lesly A M Cc: n...@ti.com Cc: dderr...@ti.com Cc: sa...@linux.intel.com --- arch/arm/mach-omap2/Makefile | 12 ++- arch/arm/mach-omap2/board-3430sdp.c | 99 +--

[PATCH] Update Triton2 scripts

2010-01-07 Thread Lesly A M
Updated the sleep,wakeup & warm_reset sequence as recommended by David Derrick. Used broadcast command and changed the TYPE2 register, REMAP register for 3430SDP board, added the new script in zoom2 board file. VDD1, VDD2 and VPLL1 are remapped to turn off during sleep state. Changed RES_TYPE2 o

Re: [PATCH 05/12] omap1: Add 7xx clocks and pin muxes for SPI

2010-01-07 Thread Grazvydas Ignotas
> diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c > index 23ded2d..17ebb47 100644 > --- a/arch/arm/mach-omap1/devices.c > +++ b/arch/arm/mach-omap1/devices.c > @@ -14,6 +14,7 @@ >  #include >  #include >  #include > +#include > >  #include >  #include > @@ -23,6 +

RE: [Patch v4] OMAP: sDMA driver: descriptor autoloading feature

2010-01-07 Thread S, Venkatraman
> Venkatraman S wrote: > > On Wed, Jan 6, 2010 at 6:46 PM, Adrian Hunter > > > > wrote: > > > Venkatraman S wrote: > > > > > > > > On Tue, Dec 29, 2009 at 3:18 AM, Tony Lindgren > > > wrote: > > > > > > > > > > * Venkatraman S [091211 07:01]: > > > > > > > > > > > > Here is the most up

[PATCH] omap3: pm: Add T2 Keypad as a wakeup source

2010-01-07 Thread Lesly A M
Changes for setting the padconf value for sys_nirq line which is connected to T2 INTR1. This will fix the T2 keypad wakeup. Signed-off-by: Lesly A M Signed-off-by: Teerth Reddy --- arch/arm/mach-omap2/board-zoom-peripherals.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) d

RE: [PATCH 5/9] omap3: pm: sr: replace get_opp with freq_to_opp

2010-01-07 Thread Sripathy, Vishwanath
Yes Vijay tried with your OPP patches on 3630 ZOOM3 and it seems to work. Vishwa > -Original Message- > From: Dasgupta, Romit > Sent: Thursday, January 07, 2010 2:23 PM > To: Sripathy, Vishwanath > Cc: Menon, Nishanth; Kevin Hilman; linux-omap; Cousson, Benoit; Chikkature > Rajashekar, Ma

RE: [Patch v4] OMAP: sDMA driver: descriptor autoloading feature

2010-01-07 Thread Shilimkar, Santosh
From: adrian.hun...@nokia.com [mailto:adrian.hun...@nokia.com] Sent: Thursday, January 07, 2010 1:30 PM To: S, Venkatraman Cc: t...@atomide.com; li...@arm.linux.org.uk; Shilimkar, Santosh; khil...@deeprootsystems.com; linux-omap@vger.kernel.org; linux-ar

Re: [PATCH 8/10] OPP layer and additional cleanups

2010-01-07 Thread Romit Dasgupta
Sripathy, Vishwanath wrote: > Romit, > With VDD1 OPP resource being removed, how are you maitaning link between MPU > and DSP frequencies? I could not find such a link in the below code. May be I > am missing something?? I have not linked DSP and MPU frequencies as I thought it is possible to run

Re: [PATCH 5/9] omap3: pm: sr: replace get_opp with freq_to_opp

2010-01-07 Thread Romit Dasgupta
Sripathy, Vishwanath wrote: > Nishant, > Have you tested your opp patches on 3630? Apparently opp changes in wip > branch does not even boot on ZOOM3 board. > > Vishwa Vishwa, did you try on top of my OPP patches? Thanks, -Romit -- To unsubscribe from this list: send the line "unsubscr

RE: [PATCH 5/9] omap3: pm: sr: replace get_opp with freq_to_opp

2010-01-07 Thread Sripathy, Vishwanath
Nishant, Have you tested your opp patches on 3630? Apparently opp changes in wip branch does not even boot on ZOOM3 board. Vishwa > -Original Message- > From: Menon, Nishanth > Sent: Thursday, January 07, 2010 5:16 AM > To: Kevin Hilman > Cc: linux-omap; Cousson, Benoit; Chikkature Rajas

RE: [PATCH 8/10] OPP layer and additional cleanups

2010-01-07 Thread Sripathy, Vishwanath
Romit, With VDD1 OPP resource being removed, how are you maitaning link between MPU and DSP frequencies? I could not find such a link in the below code. May be I am missing something?? > -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.o

Re: [PATCH 0/10] OPP layer and additional cleanups.

2010-01-07 Thread Romit Dasgupta
>> * OPP layer internals have moved to list based implementation. > > Is there a benefit of list based implementation? Actually, this is a question I have asked myself several times. The motivation behind list based implementation is to accommodate introduction and revocation of OPPs.(Not just en