[PM-OPP][PATCH] OMAP: Add check for omap_device pointer before adding an opp

2010-07-24 Thread Thara Gopinath
This patch adds the check for whether a omap_device and in turn platform_device and device pointers exist for the device before adding it's opp table into the global table. This is because all the later accesses to the opp entries are based on dev pointer and hence there is no point in adding a

RE: [PATCH 12/20] OMAP: PM: create omap_devices for MPU, DSP, L3

2010-07-24 Thread Gopinath, Thara
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Gopinath, Thara Sent: Thursday, July 15, 2010 10:56 AM To: Paul Walmsley; linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org Cc: Kevin Hilman Subject: RE:

RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-24 Thread Shilimkar, Santosh
Good to see this driver on list. Few comments. -Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc: Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav;

RE: [RFC 2/8] TILER-DMM: Container manager interface and utility definitons

2010-07-24 Thread Shilimkar, Santosh
-Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc: Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav; Shilimkar, Santosh; Molnar, Lajos; Sin, David;

RE: [RFC 3/8] TILER-DMM: Sample TCM implementation: Simple TILER Allocator

2010-07-24 Thread Shilimkar, Santosh
-Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc: Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav; Shilimkar, Santosh; Ramachandra, Ravikiran; Molnar,

RE: [RFC 5/8] TILER-DMM: TILER interface file and documentation

2010-07-24 Thread Shilimkar, Santosh
-Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc: Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav; Shilimkar, Santosh; Molnar, Lajos; Sin, David

RE: [RFC 7/8] TILER-DMM: Main TILER driver implementation.

2010-07-24 Thread Shilimkar, Santosh
-Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc: Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav; Shilimkar, Santosh; Molnar, Lajos; Sin, David

RE: [RFC 0/8] TI TILER-DMM driver

2010-07-24 Thread Shilimkar, Santosh
David, -Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc: Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav; Shilimkar, Santosh; Sin, David Subject: [RFC

Re: [RFC 7/8] TILER-DMM: Main TILER driver implementation.

2010-07-24 Thread Russell King - ARM Linux
On Fri, Jul 23, 2010 at 06:22:27PM -0500, David Sin wrote: +struct platform_driver tiler_driver_ldm = { + .driver = { + .owner = THIS_MODULE, + .name = tiler, + }, + .probe = NULL, + .shutdown = NULL, + .remove = NULL, +}; What's the purpose of

Re: [RFC 4/8] TILER-DMM: TILER Memory Manager interface and implementation

2010-07-24 Thread Russell King - ARM Linux
On Fri, Jul 23, 2010 at 06:22:24PM -0500, David Sin wrote: +/* allocate and flush a page */ +static struct mem *alloc_mem(void) +{ + struct mem *m = kzalloc(sizeof(*m), GFP_KERNEL); + if (!m) + return NULL; + + m-pg = alloc_page(GFP_KERNEL | GFP_DMA); + if

Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-24 Thread Russell King - ARM Linux
On Fri, Jul 23, 2010 at 06:22:21PM -0500, David Sin wrote: +static struct platform_driver dmm_driver_ldm = { + .driver = { + .owner = THIS_MODULE, + .name = dmm, + }, + .probe = NULL, + .shutdown = NULL, + .remove = NULL, +}; What's the point

Re: [PATCH 06/11] ARM: omap: move omapfb_reserve_sdram() to .init.text

2010-07-24 Thread Uwe Kleine-König
On Fri, Jul 23, 2010 at 10:15:35PM +0100, Russell King - ARM Linux wrote: On Fri, Jul 23, 2010 at 09:58:29PM +0200, Uwe Kleine-König wrote: omapfb_reserve_sdram() is only called by omap1_map_common_io() and _omap2_map_common_io() that both live in .init.text. So this is save for

Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-24 Thread Russell King - ARM Linux
This is what I'd expect to see. This uses a hardware-upwards registration scheme, so by registering a 'dmm' device, when the driver for 'dmm' gets registered, it automatically registers with the next level up. However, you should think carefully about this kind of layered approach. Would it be

Re: [RFC 0/8] TI TILER-DMM driver

2010-07-24 Thread Hans Verkuil
Hi David, On Saturday 24 July 2010 01:22:20 David Sin wrote: TILER is a hardware block made by Texas Instruments. Its purpose is to organize video/image memory in a 2-dimensional fashion to limit memory bandwidth and facilitate 0 effort rotation and mirroring. The TILER driver

Re: [RFC 7/8] TILER-DMM: Main TILER driver implementation.

2010-07-24 Thread Hari Kanigeri
+s32 tiler_mmap_blk(struct tiler_block_t *blk, u32 offs, u32 size, +                             struct vm_area_struct *vma, u32 voffs) +{ +     u32 v, p, len; + +     /* don't allow mremap */ +     vma-vm_flags |= VM_DONTEXPAND | VM_RESERVED; Should we add VM_LOCKED as well considering

RE: [RFC 7/8] TILER-DMM: Main TILER driver implementation.

2010-07-24 Thread Shilimkar, Santosh
-Original Message- From: Hari Kanigeri [mailto:hari.kanig...@gmail.com] Sent: Saturday, July 24, 2010 7:12 PM To: Shilimkar, Santosh Cc: Sin, David; linux-arm-ker...@lists.arm.linux.org.uk; linux- o...@vger.kernel.org; Tony Lindgren; Russell King; Kanigeri, Hari; Ohad Ben-Cohen;

Re: [PATCH 0/5] omap:hwspinlock support-omap4

2010-07-24 Thread Cousson, Benoit
Hi Santosh, On 7/20/2010 4:12 PM, Kanigeri, Hari wrote: Santosh, Hari Kanigeri (1): omap:hwspinlocks-ensure the order of registration Simon Que (4): omap:hwmod-hwspinlock-enable omap:hwspinlock-define HWSPINLOCK base address I think you should fold patch 1/5 , 2/5 into patch 3/5.

RE: [PATCH 0/5] omap:hwspinlock support-omap4

2010-07-24 Thread Shilimkar, Santosh
-Original Message- From: Cousson, Benoit Sent: Saturday, July 24, 2010 8:35 PM To: Kanigeri, Hari Cc: Shilimkar, Santosh; Linux Omap; Tony Lindgren; Que, Simon Subject: Re: [PATCH 0/5] omap:hwspinlock support-omap4 Hi Santosh, On 7/20/2010 4:12 PM, Kanigeri, Hari wrote:

Re: [PATCH 0/5] omap:hwspinlock support-omap4

2010-07-24 Thread Cousson, Benoit
On 7/24/2010 5:35 PM, Shilimkar, Santosh wrote: From: Cousson, Benoit Sent: Saturday, July 24, 2010 8:35 PM Hi Santosh, On 7/20/2010 4:12 PM, Kanigeri, Hari wrote: Santosh, Hari Kanigeri (1): omap:hwspinlocks-ensure the order of registration Simon Que (4):

Re: [PATCH 3/5] omap:hwspinlock-added hwspinlock driver

2010-07-24 Thread Cousson, Benoit
Hi Simon and Hari, On 7/19/2010 6:50 PM, Kanigeri, Hari wrote: From: Simon Ques...@ti.com Created driver for OMAP hardware spinlock. This driver supports: - Reserved spinlocks for internal use - Dynamic allocation of unreserved locks - Lock, unlock, and trylock functions, with or without