RE: [PATCH] omap3: make coresight register save across OFF modes a sysfs option

2010-07-25 Thread Shilimkar, Santosh
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Alexander Shishkin > Sent: Monday, July 26, 2010 2:34 AM > To: Hari Kanigeri > Cc: Alexander Shishkin; linux-arm-ker...@lists.infradead.org; Tony > Lindgren; Russell King;

[PATCH] save and restore etm state across core OFF modes

2010-07-25 Thread Alexander Shishkin
This prevents ETM stalls whenever core enters OFF mode. Original patch author is Richard Woodruff . This version of the patch makes use of the ETM OS save/restore mechanism, which takes about 55 words in omap3_arm_context[] instead of 128. Also, saving ETM context can be switched on/off at runtime

Re: [PATCH] omap3: make coresight register save across OFF modes a sysfs option

2010-07-25 Thread Alexander Shishkin
On Mon, Jul 26, 2010 at 12:04:23 +0300, Alexander Shishkin wrote: > This adds a sysfs file at /sys/power/coresight_save which is used to > control if the ETM and debug components' states should be saved and > restored across OFF modes. Oops, I wanted to resend the previous patch, but it's getting

[PATCH] omap3: make coresight register save across OFF modes a sysfs option

2010-07-25 Thread Alexander Shishkin
This adds a sysfs file at /sys/power/coresight_save which is used to control if the ETM and debug components' states should be saved and restored across OFF modes. Signed-off-by: Alexander Shishkin Cc: Tony Lindgren Cc: Russell King Cc: Paul Walmsley Cc: Kevin Hilman Cc: linux-omap@vger.kerne

Re: [PATCH v3 3/7] DSPBRIDGE: do not call follow_page

2010-07-25 Thread Felipe Contreras
Hi, Just for the record, I found a problem in this patch. The next patch in the series overrides it, so it's not that important, unless somebody picks only this patch. On Thu, May 27, 2010 at 7:02 PM, Ohad Ben-Cohen wrote: > @@ -537,23 +606,30 @@ dsp_status proc_enum_nodes(void *hprocessor, void

Re: [PATCH 1/1] DSPBRIDGE: cache operation against kernel address instead of user's

2010-07-25 Thread Felipe Contreras
Hi, While investigating a bug in maemo[1] I found that this patch triggers it, I think I found the reason. It probably doesn't matter for upstream anymore. On Fri, Nov 6, 2009 at 3:34 PM, Hiroshi DOYU wrote: > @@ -690,14 +732,19 @@ static int memory_check_vma(unsigned long start, u32 > len) >

Re: [PATCH 6/7] save and restore etm state across core OFF modes

2010-07-25 Thread Alexander Shishkin
On Sun, Jul 25, 2010 at 12:34:22 -0600, Hari Kanigeri wrote: > > +config ENABLE_OFF_MODE_JTAG_ETM_DEBUG > > +       bool "Enable hardware emulation context save and restore" > > +       depends on ARCH_OMAP3 > > -- Shouldn't this be depends on OMAP3_EMU instead ? Not really. OMAP3_EMU will enable

Re: [PATCH 6/7] save and restore etm state across core OFF modes

2010-07-25 Thread Hari Kanigeri
> +config ENABLE_OFF_MODE_JTAG_ETM_DEBUG > +       bool "Enable hardware emulation context save and restore" > +       depends on ARCH_OMAP3 -- Shouldn't this be depends on OMAP3_EMU instead ? > +       default y -- As this is debug option, can you keep this "n" by default ? > +       help > +

[PATCH 7/7] omap3: make coresight register save across OFF modes a sysfs option

2010-07-25 Thread Alexander Shishkin
This adds a sysfs file at /sys/power/coresight_save which is used to control if the ETM and debug components' states should be saved and restored across OFF modes. Signed-off-by: Alexander Shishkin Cc: Tony Lindgren Cc: Russell King Cc: Paul Walmsley Cc: Kevin Hilman Cc: linux-omap@vger.kerne

[PATCH 5/7] omap3: move EMU peripheral addresses to a platform header

2010-07-25 Thread Alexander Shishkin
These addresses are also needed for the OFF code to save/restore the contexts of the EMU peripherals correctly. Signed-off-by: Alexander Shishkin Cc: Tony Lindgren Cc: Russell King Cc: Paul Walmsley Cc: Santosh Shilimkar Cc: Kevin Hilman Cc: linux-omap@vger.kernel.org Cc: linux-arm-ker...@li

[PATCH 6/7] save and restore etm state across core OFF modes

2010-07-25 Thread Alexander Shishkin
This prevents ETM stalls whenever core enters OFF mode. Original patch author is Richard Woodruff . This version of the patch makes use of the ETM OS save/restore mechanism, which takes about 55 words in omap3_arm_context[] instead of 128. Also, saving ETM context can be switched on/off at runtime

RE: [RFC 3/8] TILER-DMM: Sample TCM implementation: Simple TILER Allocator

2010-07-25 Thread Molnar, Lajos
> -Original Message- > From: Shilimkar, Santosh > Sent: Saturday, July 24, 2010 2:13 AM > > + kfree(tcm); > > + kfree(pvt); > If only one of the allocation was successful, then you > are freeing a NULL pointer. > May be have something like this > > tcm = kzalloc(sizeof(*tcm), G

Re: [PATCH v2 18/20] mmc: sdio: enable a default power off mode of the card

2010-07-25 Thread Ohad Ben-Cohen
On Sun, Jul 25, 2010 at 4:56 PM, Nicolas Pitre wrote: > On Sun, 25 Jul 2010, Ohad Ben-Cohen wrote: > >> On Thu, Jul 22, 2010 at 2:35 PM, Roger Quadros >> wrote: >> > On 07/21/2010 08:33 PM, ext Ohad Ben-Cohen wrote: >> >> >> >> Add support for an SDIO device to stay powered off even without >> >

Re: [PATCH v2 18/20] mmc: sdio: enable a default power off mode of the card

2010-07-25 Thread Nicolas Pitre
On Sun, 25 Jul 2010, Ohad Ben-Cohen wrote: > On Thu, Jul 22, 2010 at 2:35 PM, Roger Quadros > wrote: > > On 07/21/2010 08:33 PM, ext Ohad Ben-Cohen wrote: > >> > >> Add support for an SDIO device to stay powered off even without > >> the presence of an SDIO function driver. A host should explici

[RFC] ARM: DMA coherent allocator: align remapped addresses

2010-07-25 Thread Russell King - ARM Linux
The DMA coherent remap area is used to provide an uncached mapping of memory for coherency with DMA engines. Currently, we look for any free hole which our allocation will fit in with page alignment. However, this can lead to fragmentation of the area, and allows small allocations to cross L1 ent

Re: [PATCH v2 18/20] mmc: sdio: enable a default power off mode of the card

2010-07-25 Thread Ohad Ben-Cohen
On Thu, Jul 22, 2010 at 2:35 PM, Roger Quadros wrote: > On 07/21/2010 08:33 PM, ext Ohad Ben-Cohen wrote: >> >> Add support for an SDIO device to stay powered off even without >> the presence of an SDIO function driver. A host should explicitly >> ask for it by means of MMC_CAP_DONT_POWER_CARD, an

[PATCH] omap: zoom: add fixed regulator device for wl1271

2010-07-25 Thread Ohad Ben-Cohen
Add a fixed regulator vmmc device to enable power control of the wl1271 wlan device. Signed-off-by: Ohad Ben-Cohen --- This patch is a follow-up to a previous wl1271 discussion, thus all original recipients are CC'ed. arch/arm/mach-omap2/board-zoom-peripherals.c | 35 +

Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan

2010-07-25 Thread Ohad Ben-Cohen
On Fri, Jul 23, 2010 at 12:15 PM, Mark Brown wrote: > On Fri, Jul 23, 2010 at 02:13:38AM +0300, Ohad Ben-Cohen wrote: >> On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros >> wrote: >> > .dev_name       = "mmci-omap-hs.2" > >> I already set the .dev member of the consumer in a similar manner to >> h