Re: [PATCH v2 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-09-21 Thread Paul Walmsley
Hi Rajendra, On Fri, 17 Sep 2010, Rajendra Nayak wrote: From: Paul Walmsley p...@pwsan.com Add hwmod structures for I2C controllers on OMAP2420/2430. Looking at this series, patch 3 seems to be missing. Could you please investigate why? regards - Paul -- To unsubscribe from this list:

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-21 Thread Felipe Balbi
On Mon, Sep 20, 2010 at 09:46:34AM -0500, Igor Grinberg wrote: On 09/20/10 08:39, Felipe Balbi wrote: On Thu, Sep 16, 2010 at 04:12:06AM -0500, Igor Grinberg wrote: Yes it will, but even if the hub reset gpio is for some reason unavailable, we don't want to disable ehci completely... then

Re: [PATCH v2 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-09-21 Thread Paul Walmsley
On Fri, 17 Sep 2010, Rajendra Nayak wrote: From: Paul Walmsley p...@pwsan.com Add hwmod structures for I2C controllers on OMAP2420/2430. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Rajendra Nayak rna...@ti.com Some items that stick out in this patch that should be fixed:

Re: [PATCH v2 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-09-21 Thread Paul Walmsley
On Tue, 21 Sep 2010, Paul Walmsley wrote: Hi Rajendra, On Fri, 17 Sep 2010, Rajendra Nayak wrote: From: Paul Walmsley p...@pwsan.com Add hwmod structures for I2C controllers on OMAP2420/2430. Looking at this series, patch 3 seems to be missing. Could you please investigate why?

Re: [PATCH v2 2/5] OMAP3: hwmod: add I2C hwmods for OMAP3430

2010-09-21 Thread Paul Walmsley
On Fri, 17 Sep 2010, Rajendra Nayak wrote: Add hwmod structures for I2C controllers on OMAP3430. Also in this patch: +static struct omap_hwmod omap3xxx_i2c1_hwmod = { + .name = i2c1, + .mpu_irqs = i2c1_mpu_irqs, + .mpu_irqs_cnt = ARRAY_SIZE(i2c1_mpu_irqs), +

Re: [RFC v.4] omap: hwspinlock: Added hwspinlock driver

2010-09-21 Thread Cousson, Benoit
On 9/20/2010 7:30 PM, Kevin Hilman wrote: Ohad Ben-Coheno...@wizery.com writes: Hi Hari, On Thu, Aug 12, 2010 at 12:44 AM, Kanigeri, Harih-kanige...@ti.com wrote: +/* Attempt to acquire a spinlock once */ +int hwspinlock_trylock(struct hwspinlock *handle) +{ + int retval = 0; + +

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-09-21 Thread kishore kadiyala
Hi Benoit, On Tue, Sep 21, 2010 at 2:26 AM, Cousson, Benoit b-cous...@ti.com wrote: Hi Kishore On 9/18/2010 6:34 PM, Kadiyala, Kishore wrote: The offset handling implementation of omap4 mmc registers which was already present can't be reused once hwmod modifications are done for mmc

RE: [PATCH v2 2/5] OMAP3: hwmod: add I2C hwmods for OMAP3430

2010-09-21 Thread Nayak, Rajendra
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Tuesday, September 21, 2010 12:47 PM To: Nayak, Rajendra Cc: linux-omap@vger.kernel.org; Kevin Hilman Subject: Re: [PATCH v2 2/5] OMAP3: hwmod: add I2C hwmods for OMAP3430 On Fri, 17 Sep 2010, Rajendra Nayak

RE: [PATCH v2 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-09-21 Thread Paul Walmsley
Hi Rajendra, On Tue, 21 Sep 2010, Nayak, Rajendra wrote: -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Tuesday, September 21, 2010 12:39 PM To: Nayak, Rajendra Cc: linux-omap@vger.kernel.org; Kevin Hilman Subject: Re: [PATCH v2 1/5] OMAP2xxx: hwmod: add

RE: [PATCH v4 2/2] OMAP: DSS2: Use dss_features framework on DSS2 code

2010-09-21 Thread Taneja, Archit
Any more comments? Archit Taneja, Archit wrote: From: Archit Taneja arc...@ti.com Calls init functions of dss_features during dss_probe, and the following features are made omap independent: - number of managers, overlays - supported color modes for each overlay - supported

RE: [PATCH v2 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-09-21 Thread Paul Walmsley
On Tue, 21 Sep 2010, Paul Walmsley wrote: My original comment was somewhat inaccurate. Looking again at the 2430 TRM, it looks like the idlest_reg_id is correct, but that the prcm_reg_id is not quite correct, at least for the FCLKEN register - not currently used by hwmod. We may have to

RE: [Query] Garbled characters on gtkterm

2010-09-21 Thread DebBarma, Tarun Kanti
I'm not seeing these, just booted my n800 last night with the cbus patches from Felipe. I believe all I did was yes | ARCH=arm make oldconfig on the n8x0_defconfig that we still have around. I've seen things like that with some USB serial dongles earlier, I believe that the pl2303 based

[PATCH v2 00/10] OMAP2/TWL: Fix Sparse warnings

2010-09-21 Thread G, Manjunath Kondaiah
This v2 version of sparse fixes series has review comments incorporated which are archived at: http://www.spinics.net/lists/linux-omap/msg35427.html Out of total 11 patches in v1 series, three patches are dropped from this version since two patches are accepted and already applied in other

[PATCH v2 01/10] OMAP: mach-omap2: Fix incorrect assignment warnings

2010-09-21 Thread G, Manjunath Kondaiah
This patch fixes below sparse warnings for incorrect assignments. arch/arm/mach-omap2/control.c:195:16: warning: incorrect type in assignment (different address spaces) arch/arm/mach-omap2/control.c:195:16:expected unsigned int [usertype] *v_addr arch/arm/mach-omap2/control.c:195:16:got

[PATCH v2 02/10] OMAP: mach-omap2: Fix static declaration warnings

2010-09-21 Thread G, Manjunath Kondaiah
This patch fixes sparse warnings due to non declaration of static structures and variables. Sparse warning logs fixed: arch/arm/mach-omap2/control.c:88:6: warning: symbol 'omap3_secure_ram_storage' was not declared. Should it be static? n arch/arm/mach-omap2/timer-gp.c:50:22: warning: symbol

[PATCH v2 03/10] OMAP: mach-omap2: Fix static function warnings

2010-09-21 Thread G, Manjunath Kondaiah
This patch fixes sparse warnings due non declarations of static functions. arch/arm/mach-omap2/timer-gp.c:115:12: warning: symbol 'omap2_gp_clockevent_set_gptimer' was not declared. Should it be static? arch/arm/mach-omap2/powerdomain.c:993:5: warning: symbol 'pwrdm_set_lowpwrstchange' was not

[PATCH v2 04/10] OMAP: mach-omap2: Fix miscellaneous sparse warnings

2010-09-21 Thread G, Manjunath Kondaiah
This patch fixes miscellaneous sparse warnings in mach-omap2. arch/arm/mach-omap2/board-am3517evm.c:141:17: warning: Initializer entry defined twice arch/arm/mach-omap2/board-am3517evm.c:142:18: also defined here arch/arm/mach-omap2/irq.c:50:35: warning: Using plain integer as NULL pointer

[PATCH v2 05/10] OMAP: plat-omap: Fix static function warnings

2010-09-21 Thread G, Manjunath Kondaiah
This patch fixes sparse warnings due non declarations of static functions. arch/arm/plat-omap/sram.c:130:13: warning: symbol 'omap_detect_sram' was not declared. Should it be static? arch/arm/plat-omap/sram.c:216:13: warning: symbol 'omap_map_sram' was not declared. Should it be static?

[PATCH v2 06/10] OMAP: NAND: Fix static declaration warning

2010-09-21 Thread G, Manjunath Kondaiah
This patch fixes sparse warning for static declaration of variable use_dma drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. Should it be static? Signed-off-by: G, Manjunath Kondaiah manj...@ti.com Cc: linux-arm-ker...@lists.infradead.org Cc:

[PATCH v2 07/10] TWL CORE: Fix sparse warning

2010-09-21 Thread G, Manjunath Kondaiah
Fixes below sparse warning. drivers/mfd/twl-core.c:258:20: warning: symbol 'twl_map' was not declared. Should it be static? Signed-off-by: G, Manjunath Kondaiah manj...@ti.com Cc: linux-arm-ker...@lists.infradead.org Cc: Samuel Ortiz sa...@linux.intel.com Cc: Tony Lindgren t...@atomide.com Cc:

[PATCH v2 08/10] TWL IRQ: Fix fucntion declaration warnings

2010-09-21 Thread G, Manjunath Kondaiah
Fixes following sparse warnings for twl4030 and twl6030 irq files. drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static? drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not declared. Should it be static?

[PATCH v2 09/10] OMAP2/3: Convert write/read functions to raw read/write

2010-09-21 Thread G, Manjunath Kondaiah
Following sparse warnings exists due to use of writel/w and readl/w functions. This patch fixes the sparse warnings by converting readl/w functions usage into __raw_readl/__raw_readw functions. arch/arm/mach-omap2/board-omap3evm.c:77:12: warning: symbol '__v' shadows an earlier one

[PATCH v2 10/10] OMAP3: Keypad: Fix incorrect type initializer

2010-09-21 Thread G, Manjunath Kondaiah
The keypad matrix variable declaration is not matching with structure variable keymap declared in keypad_matrix.h. Due to this, following sparse warnings are generated with omap3_defconfig. arch/arm/mach-omap2/board-devkit8000.c:223:14: warning: incorrect type in initializer (different

Re: [PATCH V3 1/2] input: CMA3000 Accelerometer driver

2010-09-21 Thread Jonathan Cameron
On 09/21/10 06:46, Hemanth V wrote: - Original Message - From: Jonathan Cameron ker...@jic23.retrosnub.co.uk To: Dmitry Torokhov dmitry.torok...@gmail.com Cc: Hemanth V heman...@ti.com; linux-in...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-omap@vger.kernel.org Sent:

[PATCH v2] OMAP3: Keypad: Fix failure exit path in probe

2010-09-21 Thread G, Manjunath Kondaiah
The failure exit paths seems to be wrong in probe function. This patch corrects exit failure paths for error handling cases. Boot warning incase of request irq failure: [1.553985] twl4030_keypad twl4030_keypad: request_irq failed for irq no=369 [1.561157] [ cut here

[PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP

2010-09-21 Thread Yanick Saugy
The PIN which controls LCD's reset signal (VGA_nRESET/h_GPIO_96) was not configured as a GPIO. We had to modify the OMAP MUX, and select this PIN (CAM_XCLKA) as an output GPIO (OMAP_MUX_MODE4). (kernel 2.6.35) Be aware of changing this PIN will probably disable the camera, because it was

RE: [PATCH RESEND v4 1/4] omap3: nand: prefetch in irq mode support

2010-09-21 Thread Ghorai, Sukumar
Tony, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Ghorai, Sukumar Sent: Monday, September 20, 2010 7:01 PM To: Tony Lindgren Cc: linux-omap@vger.kernel.org; linux-...@lists.infradead.org; linux-arm-

RE: [PATCH v2 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-09-21 Thread Nayak, Rajendra
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Tuesday, September 21, 2010 1:36 PM To: Nayak, Rajendra Cc: linux-omap@vger.kernel.org; Kevin Hilman Subject: RE: [PATCH v2 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430 On Tue, 21 Sep 2010, Paul

[PATCH v7 6/6] OMAP: WDT: Use PM runtime APIs instead of clk FW APIs

2010-09-21 Thread Varadarajan, Charulatha
Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks, sysconfig settings instead of using clock FW APIs. Signed-off-by: Charulatha V ch...@ti.com --- drivers/watchdog/omap_wdt.c | 42 +++--- 1 files changed,

[PATCH v7 1/6] OMAP3: hwmod data: Add watchdog timer

2010-09-21 Thread Varadarajan, Charulatha
Add watchdog timer hwmod data for OMAP3 chip Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 66 1 files changed, 66 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c

[PATCH v7 4/6] OMAP4: hwmod data: Add watchdog timer

2010-09-21 Thread Varadarajan, Charulatha
From: Benoit Cousson b-cous...@ti.com Add watchdog timer hwmod data for OMAP4 chip Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 135 1 files changed, 135 insertions(+), 0

[PATCH v7 5/6] OMAP: WDT: Split OMAP1 and OMAP2PLUS device registration

2010-09-21 Thread Varadarajan, Charulatha
This patch splits omap_init_wdt() into separate omap_init_wdt() functions under mach-omap1 and mach-omap2 and set them up with subsys_initcall. Also it uses omap_device_build() API instead of platform_device_register() for watchdog timer device registration for OMAP2plus chips. For OMAP2plus

RE: [PATCH v2] OMAP3: Keypad: Fix failure exit path in probe

2010-09-21 Thread G, Manjunath Kondaiah
Hi, -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Tuesday, September 21, 2010 7:04 PM To: G, Manjunath Kondaiah Cc: linux-omap@vger.kernel.org; linux-in...@vger.kernel.org; Dmitry Torokhov; linux-arm-ker...@lists.infradead.org; Tony Lindgren

RE: [PATCH v6 00/13] OMAP: GPIO: Implement GPIO in hwmod way

2010-09-21 Thread Varadarajan, Charulatha
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, September 21, 2010 5:37 AM To: Varadarajan, Charulatha Cc: t...@atomide.com; linux-omap@vger.kernel.org; p...@pwsan.com; Cousson, Benoit; Nayak, Rajendra; Basak, Partha Subject: Re: [PATCH v6

[PATCH v3 0/5] Convert I2C driver to use omap_device/runtime PM

2010-09-21 Thread Rajendra Nayak
This series makes I2C device registration use hwmod and omap_device api's and converts the I2C driver to use runtime PM api's. Patches apply on the pm-core branch from Kevin's tree. v3 has minor review comment fixes over v2 The series is boot tested on a 2430sdp platform along with being tested

[PATCH v3 4/5] OMAP: I2C: split device registration and convert OMAP2+ to omap_device

2010-09-21 Thread Rajendra Nayak
From: Paul Walmsley p...@pwsan.com Split the OMAP1 and OMAP2+ platform_device build and register code. Convert the OMAP2+ variant to use omap_device. This patch was developed in collaboration with Rajendra Nayak rna...@ti.com. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Rajendra

[PATCH v3 2/5] OMAP3: hwmod: add I2C hwmods for OMAP3430

2010-09-21 Thread Rajendra Nayak
Add hwmod structures for I2C controllers on OMAP3430. This patch was developed in collaboration with Paul Walmsley p...@pwsan.com. Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@deeprootsystems.com ---

[PATCH v3 3/5] OMAP4: hwmod: add I2C hwmods for OMAP4430

2010-09-21 Thread Rajendra Nayak
Add hwmod structures for I2C controllers on OMAP4430. Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Benoit Cousson b-cous...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 237 1 files changed, 237 insertions(+), 0 deletions(-) diff --git

[PATCH v3 1/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-09-21 Thread Rajendra Nayak
From: Paul Walmsley p...@pwsan.com Add hwmod structures for I2C controllers on OMAP2420/2430. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com --- arch/arm/mach-omap2/cm-regbits-24xx.h |4 +

[PATCH v3 5/5] OMAP: I2C: Convert i2c driver to use PM runtime api's

2010-09-21 Thread Rajendra Nayak
This patch converts the i2c driver to use PM runtime apis Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Paul Walmsley p...@pwsan.com --- drivers/i2c/busses/i2c-omap.c | 67 + 1 files changed, 21

[PATCH] OMAP: hwmod: Enable module wakeup if in smartidle

2010-09-21 Thread Rajendra Nayak
If a module's OCP slave port is programmed to be in smartidle, its also necessary that they have module level wakeup enabled. Update _sysc_enable in hwmod framework to do this. Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Partha Basak p-bas...@ti.com Signed-off-by: Benoît Cousson

Re: [PATCH] OMAP4: HSMMC cmd line reset change

2010-09-21 Thread Tony Lindgren
* Madhusudhan madhu...@ti.com [100920 09:06]: Please don't use cpu_is_omap tests in the drivers, drivers should be generic. Instead, just pass a feature flag in the platform_data for this feature like HSMMC_REVERSE_RESET_LOGIC or similar. This is not a feature. It is like

Re: [PATCH RESEND v4 1/4] omap3: nand: prefetch in irq mode support

2010-09-21 Thread Tony Lindgren
* Ghorai, Sukumar s-gho...@ti.com [100918 11:16]: This handler should be in gpmc.c as it may be needed for other GPMC connected devices on the same system. You can use chained irq handlers to allow all the drivers to use the interrupt then. [Ghorai] You mean as this function used the

SMP_ON_UP? - Build break with custom minimal defconfig

2010-09-21 Thread Gadiyar, Anand
Hi all, I was trying to use current linux-omap master to put together a custom minimal defconfig for a beagleboard, and I'm seeing a compile error: CC init/main.o In file included from include/linux/highmem.h:9, from include/linux/pagemap.h:10, from

Re: SMP_ON_UP? - Build break with custom minimal defconfig

2010-09-21 Thread Tony Lindgren
* Gadiyar, Anand gadi...@ti.com [100921 08:41]: Hi all, I was trying to use current linux-omap master to put together a custom minimal defconfig for a beagleboard, and I'm seeing a compile error: CC init/main.o In file included from include/linux/highmem.h:9, from

Re: SMP_ON_UP? - Build break with custom minimal defconfig

2010-09-21 Thread Gadiyar, Anand
  CC      init/main.o In file included from include/linux/highmem.h:9,                  from include/linux/pagemap.h:10,                  from include/linux/mempolicy.h:70,                  from init/main.c:50:

Re: [PATCH 00/11] OMAP: Serial: Add omap-serial driver with platform support

2010-09-21 Thread Govindraj
SNIP Also the patch series updates various low level platform specific serial data to support omap-uarts with hwmod framework and adds support for uart4 on OMAP3630. This series is missing a couple things to work more broadly on all boards, specifically 3630-based boards. First, due to

[PATCH 1/5] omap3: Introduce CompuLab CM-T3517 module.

2010-09-21 Thread Igor Grinberg
Add basic suppot, enable uart and led. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/Kconfig |7 ++ arch/arm/mach-omap2/Makefile |1 + arch/arm/mach-omap2/board-cm-t3517.c | 109 ++

[PATCH 0/5] Support for CompuLab CM-T3517 modules

2010-09-21 Thread Igor Grinberg
CompuLab CM-T3517 module is based on AM3517 (Sitara) SoC. CM-T3517 supports on-board 256/128MB DDR2 DRAM, 512/128MB NAND flash, WIFI-BlueTooth combo chip, USB HUB, AC97 Codec, TouchScreen controller, RTC. This patch series add a basic support for CM-T3517 and some of its peripheral devices.

[PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-21 Thread Igor Grinberg
add support for hsusb host ports 1, 2 and on-module usb hub. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t3517.c | 50 ++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git

[PATCH 2/5] omap3: cm-t3517: add support for v3020 rtc.

2010-09-21 Thread Igor Grinberg
add support for v3020 rtc. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t3517.c | 36 ++ 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-cm-t3517.c

[PATCH 4/5] omap3: cm-t3517: add support for NAND flash

2010-09-21 Thread Igor Grinberg
add support for NAND flash. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t3517.c | 54 ++ 1 files changed, 54 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-cm-t3517.c

[PATCH 5/5] omap3: cm-t3517: add support for TI HECC

2010-09-21 Thread Igor Grinberg
add support for TI HECC. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t3517.c | 45 ++ 1 files changed, 45 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-cm-t3517.c

Re: [PATCH 0/3] OMAP: hwmod: Add hardreset and softreset management

2010-09-21 Thread Cousson, Benoit
Hi Paul, On 9/21/2010 7:03 AM, Paul Walmsley wrote: Hi Benoît, I regret the delay - Considering the job you did on that reset series, you are already forgiven :-) On Thu, 5 Aug 2010, Benoit Cousson wrote: Here are a reset management series. - The first patch will be removed as soon

[PATCH] ARM: fix build break due to typo in cacheflush.h

2010-09-21 Thread Anand Gadiyar
commit 9d85ac1e6 introduced a small typo. This causes the build to break when CONFIG_CPU_V7 is set and CONFIG_CPU_V6 and CONFIG_SMP_ON_UP are not. (log below) CC init/main.o In file included from include/linux/highmem.h:9, from include/linux/pagemap.h:10,

Re: [PATCH] ARM: fix build break due to typo in cacheflush.h

2010-09-21 Thread Tony Lindgren
* Anand Gadiyar gadi...@ti.com [100921 08:57]: commit 9d85ac1e6 introduced a small typo. This causes the build to break when CONFIG_CPU_V7 is set and CONFIG_CPU_V6 and CONFIG_SMP_ON_UP are not. (log below) CC init/main.o In file included from include/linux/highmem.h:9,

Re: [PATCH 0/3] OMAP: hwmod: Add hardreset and softreset management

2010-09-21 Thread Paul Walmsley
Hi Benoît, On Tue, 21 Sep 2010, Cousson, Benoit wrote: That's really good. The low level reset does indeed belong to PRM more than the hwmod core code. Thanks for the OMAP2/3 stuff as well, IVA people were starting to ping me for that support. I've just rebased my OMAP4 hwmods series on

Re: [PATCH] ARM: Handle __flush_icache_all for CONFIG_SMP_ON_UP

2010-09-21 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [100914 12:04]: Here's a patch for __flush_icache_all. I believe this is the last remaining patch we need. The only other thing I can think of are the conflicts with CONFIG_CPU_32v6K, on early ARM1136 and later ARM11 systems if somebody wants to compile a

Re: [PATCH 3/5] omap3: cm-t3517: add support for usb host.

2010-09-21 Thread Gadiyar, Anand
On Tue, Sep 21, 2010 at 9:33 PM, Igor Grinberg grinb...@compulab.co.il wrote: add support for hsusb host ports 1, 2 and on-module usb hub. Signed-off-by: Igor Grinberg grinb...@compulab.co.il ---  arch/arm/mach-omap2/board-cm-t3517.c |   50 ++ ... @@

Re: [PATCH v2] OMAP3: Keypad: Fix failure exit path in probe

2010-09-21 Thread Dmitry Torokhov
Hi, On Tue, Sep 21, 2010 at 07:11:01PM +0530, G, Manjunath Kondaiah wrote: Hi, -Original Message- From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Tuesday, September 21, 2010 7:04 PM To: G, Manjunath Kondaiah Cc: linux-omap@vger.kernel.org;

[PATCH 00/11] OMAP: hwmod: core patches for 2.6.37

2010-09-21 Thread Paul Walmsley
Hello, This series contains hwmod core fixes and improvements, and is intended for merging via Tony's tree for 2.6.37. The patches in this series are also available via git at git://git.pwsan.com/linux-2.6 hwmod_2.6.37 based on v2.6.36-rc5. regards, - Paul --- hwmod_2.6.37 textdata

[PATCH 04/11] OMAP4: prcm: Fix global warm reset bit position

2010-09-21 Thread Paul Walmsley
From: Rajeev Kulkarni raje...@ti.com OMAP4 platform has different register bits for Warm and Cold Resets. Write one into appropriate bits. Signed-off-by: Rajeev Kulkarni raje...@ti.com Cc: Leed Aguilar leed.agui...@ti.com [b-cous...@ti.com: Change the define with the proper one from omap4

[PATCH 08/11] OMAP2/3: PRM: add module hard reset support

2010-09-21 Thread Paul Walmsley
This patch adds hard-reset support for processor modules (e.g., DSP, IVA) on OMAP2/3 platforms. It's based on the OMAP4 hard-reset support that Benoît developed in the previous patch. This patch is a collaboration between Benoît Cousson b-cous...@ti.com and Paul Walmsley p...@pwsan.com.

[PATCH 09/11] OMAP: hwmod: Add hardreset management support

2010-09-21 Thread Paul Walmsley
From: Benoît Cousson b-cous...@ti.com Most processor IPs does have a hardreset signal controlled by the PRM. This is different of the softreset used for local IP reset from the SYSCONFIG register. The granularity can be much finer than orginal HWMOD, for ex, the IVA hwmod contains 3 reset lines,

[PATCH 07/11] OMAP4: PRM: add module hard reset support

2010-09-21 Thread Paul Walmsley
From: Benoît Cousson b-cous...@ti.com Most processor modules (e.g., DSP, IVA, IPU) on OMAPs can be reset under the control of the PRM. This patch adds an API for this purpose for OMAP4 devices: int omap4_prm_is_hardreset_asserted(void __iomem *rstctrl_reg, u8 shift); int

[PATCH 11/11] OMAP: hwmod: add an hardreset API for use by other core code

2010-09-21 Thread Paul Walmsley
Expose an hardreset API from hwmod in order to assert / deassert all the individual reset lines that belong to an hwmod. This API is needed by some of the more complicated processor drivers, e.g., DSP/Bridge, Syslink, etc. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Benoît Cousson

[PATCH 06/11] OMAP4: prcm: Add temporarily helper functions for rmw and read inside the PRM

2010-09-21 Thread Paul Walmsley
From: Benoit Cousson b-cous...@ti.com Since OMAP4 is using an absolute address, the current PRM accessors are not useable. OMAP4 adaptation for these API are currently ongoing, so define temp version until the proper ones are defined. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by:

[PATCH 10/11] OMAP: hwmod: Force a softreset during _setup

2010-09-21 Thread Paul Walmsley
From: Benoit Cousson b-cous...@ti.com Force the softreset of every IPs during the _setup phase. IPs that cannot support softreset or that should not be reset must set the HWMOD_INIT_NO_RESET flag in the hwmod struct. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Paul Walmsley

[PATCH 05/11] [PATCH] OMAP: hwmod: separate list locking and hwmod hardware locking

2010-09-21 Thread Paul Walmsley
From: Kevin Hilman khil...@ti.com Currently omap_hwmod_mutex is being used to protect both the list access/modification and concurrent access to hwmod functions. This patch separates these two types of locking. First, omap_hwmod_mutex is used only to protect access and modification of

[PATCH 01/11] OMAP: hwmod: Rename dma_ch to dma_req

2010-09-21 Thread Paul Walmsley
From: Benoit Cousson b-cous...@ti.com The dma request line attribute was named dma channel, which leads to confusion with the real dma channel definition. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@deeprootsystems.com ---

[PATCH 03/11] OMAP: hwmod: Fix omap_hwmod_reset wrong state test

2010-09-21 Thread Paul Walmsley
From: Liam Girdwood l...@slimlogic.co.uk The reset function wrongly used the state flag as a bit mask and was trying to re-enable after a reset. hwmod is still enabled for the PRCM point of view after a softreset so there is no need to re-enable. Remove the state check from omap_hwmod_reset

[PATCH 02/11] OMAP: hwmod: Do not disable clocks if hwmod already in idle

2010-09-21 Thread Paul Walmsley
From: Benoit Cousson b-cous...@ti.com The disable function was disabling clocks and dependencies from both enable and idle state. Since idle function is already disabling both, an enable - idle - disable sequence will try to disable twice the clocks and thus generate a Trying disable clock XXX

[PATCH] OMAP: hwmod: Fix softreset status check for some new OMAP4 IPs

2010-09-21 Thread Benoit Cousson
In OMAP3 a specific SYSSTATUS register was used to get the softreset status. Starting in OMAP4, some IPs does not have SYSSTATUS register and instead use the SYSC softreset bit to provide the status. Other cases might exist: - Some IPs like McBSP does have a softreset control but no reset status.

[PATCH] OMAP: hwmod: Fix softreset for modules with optional clocks

2010-09-21 Thread Benoit Cousson
Some modules (like GPIO, DSS...) require optionals clock to be enabled in order to complete the sofreset properly. Add a HWMOD_CONTROL_OPT_CLKS_IN_RESET flag to force all optional clocks to be enabled before reset. Disabled them once the reset is done. TODO: For the moment it is very hard to

[PATCH] OMAP: hwmod: softreset fixes with opt clocks

2010-09-21 Thread Benoit Cousson
Hi Paul, Here are some fixes for the softreset issues that were highlighted on some IPs like GPIO or DSS. For the moment they are still based on your previous series: git://git.pwsan.com/linux-2.6 hwmod_hardreset_dev If you are OK with these, I'll rebase that on top of your latest submission to

Re: [PATCH 03/10] OMAP3: PM: move device-specific special cases from PM core into CPUidle

2010-09-21 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Kevin, On Wed, 15 Sep 2010, Kevin Hilman wrote: In an effort to simplify the core idle path, move any device-specific special case handling from the core PM idle path into the CPUidle pre-idle checking path. This keeps the core,

Re: [PATCH] OMAP: hwmod: softreset fixes with opt clocks

2010-09-21 Thread Cousson, Benoit
On 9/21/2010 6:57 PM, Cousson, Benoit wrote: Hi Paul, Here are some fixes for the softreset issues that were highlighted on some IPs like GPIO or DSS. For the moment they are still based on your previous series: git://git.pwsan.com/linux-2.6 hwmod_hardreset_dev If you are OK with these, I'll

Re: [PATCH] OMAP: hwmod: softreset fixes with opt clocks

2010-09-21 Thread Paul Walmsley
Hi Benoît, On Tue, 21 Sep 2010, Benoit Cousson wrote: Here are some fixes for the softreset issues that were highlighted on some IPs like GPIO or DSS. For the moment they are still based on your previous series: git://git.pwsan.com/linux-2.6 hwmod_hardreset_dev If you are OK with these,

Re: [PATCH] OMAP: hwmod: Fix softreset for modules with optional clocks

2010-09-21 Thread Paul Walmsley
Hi Benoit, one minor comment here - On Tue, 21 Sep 2010, Benoit Cousson wrote: Some modules (like GPIO, DSS...) require optionals clock to be enabled in order to complete the sofreset properly. Add a HWMOD_CONTROL_OPT_CLKS_IN_RESET flag to force all optional clocks to be enabled before

Re: [PATCH] OMAP: hwmod: Fix softreset for modules with optional clocks

2010-09-21 Thread Cousson, Benoit
On 9/21/2010 7:07 PM, Paul Walmsley wrote: Hi Benoit, one minor comment here - On Tue, 21 Sep 2010, Benoit Cousson wrote: Some modules (like GPIO, DSS...) require optionals clock to be enabled in order to complete the sofreset properly. Add a HWMOD_CONTROL_OPT_CLKS_IN_RESET flag to force all

Re: [PATCH] OMAP: hwmod: softreset fixes with opt clocks

2010-09-21 Thread Cousson, Benoit
On 9/21/2010 7:05 PM, Paul Walmsley wrote: Hi Benoît, On Tue, 21 Sep 2010, Benoit Cousson wrote: Here are some fixes for the softreset issues that were highlighted on some IPs like GPIO or DSS. For the moment they are still based on your previous series: git://git.pwsan.com/linux-2.6

[PATCH] OMAP: hwmod: Handle opt clocks node using clk_add_alias

2010-09-21 Thread Benoit Cousson
From: Basak, Partha p-bas...@ti.com For every optional clock present per hwmod per omap-device, this function adds an entry in the clocks list of the form dev-id=dev_name, con-id=role, if an entry is already present in the list of the form dev-id=NULL, con-id=role. The function is called from

Re: [PATCH v6 00/13] OMAP: GPIO: Implement GPIO in hwmod way

2010-09-21 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: Varadarajan, Charulatha ch...@ti.com writes: This patch series makes OMAP2PLUS specific GPIO implemented in hwmod FW way. This is done by implementing GPIO module in platform device model. This patch series is generated on

Re: [PATCH] OMAP: hwmod: Enable module wakeup if in smartidle

2010-09-21 Thread Paul Walmsley
Hi Rajendra, On Tue, 21 Sep 2010, Rajendra Nayak wrote: If a module's OCP slave port is programmed to be in smartidle, its also necessary that they have module level wakeup enabled. Update _sysc_enable in hwmod framework to do this. Thanks, queued for 2.6.37 with a slightly modified

Re: [PATCH 00/11] OMAP: Serial: Add omap-serial driver with platform support

2010-09-21 Thread Kevin Hilman
Govindraj govindraj...@gmail.com writes: SNIP Also the patch series updates various low level platform specific serial data to support omap-uarts with hwmod framework and adds support for uart4 on OMAP3630. This series is missing a couple things to work more broadly on all boards,

Re: [PATCH] OMAP: hwmod: Enable module wakeup if in smartidle

2010-09-21 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Rajendra, On Tue, 21 Sep 2010, Rajendra Nayak wrote: If a module's OCP slave port is programmed to be in smartidle, its also necessary that they have module level wakeup enabled. Update _sysc_enable in hwmod framework to do this. Thanks, queued for

Re: [PATCH] OMAP: hwmod: Enable module wakeup if in smartidle

2010-09-21 Thread Paul Walmsley
On Tue, 21 Sep 2010, Kevin Hilman wrote: FWIW Acked-by: Kevin Hilman khil...@deeprootsystems.com as I'm using this for testing the various hwmod conversions. Thanks Kevin, added that in. I know you've been testing some of the other patches here too, so please let me know if you would

Re: [PATCH] usb: omap: ohci: Missing driver unregister in module exit

2010-09-21 Thread Greg KH
On Fri, Sep 17, 2010 at 09:43:16AM +0300, Felipe Balbi wrote: On Thu, Sep 16, 2010 at 06:39:20AM -0500, Munegowda, Keshava wrote: -Original Message- From: Munegowda, Keshava Sent: Tuesday, September 14, 2010 4:40 AM To: linux-...@vger.kernel.org; linux-omap@vger.kernel.org Cc:

Re: [PATCH] OMAP: hwmod: Handle opt clocks node using clk_add_alias

2010-09-21 Thread Paul Walmsley
Hi Partha, Benoît, On Tue, 21 Sep 2010, Benoit Cousson wrote: From: Basak, Partha p-bas...@ti.com For every optional clock present per hwmod per omap-device, this function adds an entry in the clocks list of the form dev-id=dev_name, con-id=role, if an entry is already present in the list

[PATCH] OMAP4: clock: Fix missing optional clocks

2010-09-21 Thread Benoit Cousson
Hi Paul, The previous OMAP4 clock data did not contain the nodes to allow the modules to enable the proper bit in the CLKCTRL register. This patch is based on kevin/pm-wip/hwmods-omap4 rebased on top of your hwmod_hardreset_dev branch + my reset-fixes series + Partha's patch... ...and that's

Re: [PATCH] OMAP: hwmod: Enable module wakeup if in smartidle

2010-09-21 Thread Paul Walmsley
On Tue, 21 Sep 2010, Kevin Hilman wrote: Paul Walmsley p...@pwsan.com writes: On Tue, 21 Sep 2010, Kevin Hilman wrote: FWIW Acked-by: Kevin Hilman khil...@deeprootsystems.com as I'm using this for testing the various hwmod conversions. Thanks Kevin, added that in. I know

[PATCH 1/4] omap4: pandaboard: remove unused hsmmc definition

2010-09-21 Thread David Anders
remove the second hsmmc definition as it is only used on the expansion header of the PandaBoard and can be mux for other functions. Signed-off-by: David Anders x0132...@ti.com Signed-off-by: Anand Gadiyar gadi...@ti.com --- arch/arm/mach-omap2/board-omap4panda.c |6 +- 1 files changed, 1

[PATCH 2/4] omap4: pandaboard: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-21 Thread David Anders
Avoid possible crash if CONFIG_MMC_OMAP_HS is not set. Signed-off-by: David Anders x0132...@ti.com Signed-off-by: Anand Gadiyar gadi...@ti.com --- arch/arm/mach-omap2/board-omap4panda.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

[PATCH 3/4] omap4: pandaboard: Adding card detect support for MMC1

2010-09-21 Thread David Anders
Adding card detect callback function and card detect configuration function for MMC1 Controller. Signed-off-by: David Anders x0132...@ti.com Signed-off-by: Anand Gadiyar gadi...@ti.com --- patch depends on https://patchwork.kernel.org/patch/189952/ arch/arm/mach-omap2/board-omap4panda.c |7

[PATCH 4/4] omap4: pandaboard: enable the ehci port on pandaboard

2010-09-21 Thread David Anders
The OMAP4 PandaBoard has EHCI port1 hooked up to an external SMSC3320 transciever. GPIO 1 is used to power on the transceiver and GPIO 62 for reset on the transceiver. Signed-off-by: David Anders x0132...@ti.com Signed-off-by: Anand Gadiyar gadi...@ti.com ---

[PATCH 0/4] omap4: pandaboard: machine cleanups

2010-09-21 Thread David Anders
PandaBoard machine file related cleanups. David Anders (4): omap4: pandaboard: remove unused hsmmc definition omap4: pandaboard: Fix the init if CONFIG_MMC_OMAP_HS is not set omap4: pandaboard: Adding card detect support for MMC1 omap4: pandaboard: enable the ehci port on pandaboard

Re: [PATCH v7 4/6] OMAP4: hwmod data: Add watchdog timer

2010-09-21 Thread Cousson, Benoit
Hi Charu, On 9/21/2010 3:37 PM, Varadarajan, Charulatha wrote: From: Benoit Coussonb-cous...@ti.com Add watchdog timer hwmod data for OMAP4 chip Signed-off-by: Benoit Coussonb-cous...@ti.com Signed-off-by: Charulatha Vch...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 135

Re: [PATCH] OMAP: hwmod: Enable module wakeup if in smartidle

2010-09-21 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: On Tue, 21 Sep 2010, Kevin Hilman wrote: Paul Walmsley p...@pwsan.com writes: On Tue, 21 Sep 2010, Kevin Hilman wrote: FWIW Acked-by: Kevin Hilman khil...@deeprootsystems.com as I'm using this for testing the various hwmod conversions.

Re: [PATCH v6 07/13] OMAP3: hwmod data: Add GPIO

2010-09-21 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: Add GPIO hwmod data for OMAP3 chip Signed-off-by: Charulatha V ch...@ti.com Signed-off-by: Rajendra Nayak rna...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 364 1 files changed, 364 insertions(+), 0

Re: [PATCH v6 00/13] OMAP: GPIO: Implement GPIO in hwmod way

2010-09-21 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Varadarajan, Charulatha ch...@ti.com writes: Varadarajan, Charulatha ch...@ti.com writes: This patch series makes OMAP2PLUS specific GPIO implemented in hwmod FW way. This is done by implementing GPIO module in platform device model.

  1   2   >