Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, On Tue, Oct 19, 2010 at 07:13:07PM -0500, Kevin Hilman wrote: One thing I don't like about this is that there is currently no way to 'select' as a module. Yeah, I remember suggesting to add "module" to Kconfig language which would do the job of selecting as module. -- balbi -- To unsubscr

Re: [PATCH v2 1/3] usb: fix Kconfig warning

2010-10-19 Thread Felipe Balbi
On Tue, Oct 19, 2010 at 05:03:26AM -0500, Felipe Contreras wrote: warning: (USB_MUSB_HDRC_HCD && USB_SUPPORT && USB_MUSB_HDRC && (USB_MUSB_HOST || USB_MUSB_OTG) && USB_GADGET_MUSB_HDRC || USB_MUSB_OTG && && USB && USB_GADGET && PM && EXPERIMENTAL) selects USB_OTG which has unmet direct dependenc

Re: linux-next - multi-omap image fails to boot on omap3/4

2010-10-19 Thread Gadiyar, Anand
> > > * Anand Gadiyar [101019 07:41]: >>> > >> Hi all, >>> > >> >>> > >> linux-next, as of 20101019, built with the omap2plus_defconfig fails >>> > >> to boot on omap3 and omap4. (I've disabled CONFIG_ARCH_OMAP2 or >>

[PATCH 2/2] arm: omap: zoom: substitute gpio number with symbolic name

2010-10-19 Thread Felipe Balbi
It's easier to understand what that number means and also avoids problems if we ever have to change it. Tested-by: Anand Gadiyar Signed-off-by: Felipe Balbi --- arch/arm/mach-omap2/board-zoom.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/boa

[PATCH 0/2] Combine zoom board-files

2010-10-19 Thread Felipe Balbi
Those boards are so similar that they don't deserve separate board files. Felipe Balbi (2): arm: omap: combine zoom2 and zoom3 board-files arm: omap: zoom: substitute gpio number with symbolic name arch/arm/mach-omap2/Makefile |4 +- .../arm/mach-omap2/{board-zoom2.

[PATCH 1/2] arm: omap: combine zoom2 and zoom3 board-files

2010-10-19 Thread Felipe Balbi
They are extremely similar anyway, let's get rid of one file. While at that, also remove the empty zoom_config variable. Tested-by: Anand Gadiyar Signed-off-by: Felipe Balbi --- arch/arm/mach-omap2/Makefile |4 +- .../arm/mach-omap2/{board-zoom2.c => board-zoom.c} |

RE: DSS2 crash with shutdown -h now

2010-10-19 Thread Taneja, Archit
Hi, linux-omap-ow...@vger.kernel.org wrote: > I'm using a 2.6.35 kernel, and the generic panel driver. > > I see this crash about 25% of the time, so I suspect a race condition. > > Is anyone else encountering this? > > Steve > > > Unmounting local filesystems... > Unhandled fault: external a

RE: [RFC v3][PATCH 0/4] OMAP: DSS2: Overlay Manager LCD2 support in DISPC

2010-10-19 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: > Hi, > > On Tue, 2010-10-05 at 13:55 +0200, ext Archit Taneja wrote: >> This patch series which incorporates changes in DSS2 to enable >> omap_dss_device instances to use the new Overlay Manager LCD2 in DISPC. >> >> On OMAP4, we have a new DISPC channel for Overlay Man

[PATCH] omap: mailbox - fix missing mbox owner assignment when creating queue

2010-10-19 Thread Fernando Guzman Lugo
mbox field of omap_mbox_queue structure is never assigned to the mailbox owner. Causing kernel panic when dereference it. Signed-off-by: Fernando Guzman Lugo --- arch/arm/plat-omap/mailbox.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/a

[PATCHv4 0/4] iovmm: fixes for iovmm module

2010-10-19 Thread Fernando Guzman Lugo
Version 4: * Changes in "iommu: create new api to set valid da range" - Validate range for fixed address. - Change way of change boundaries to avoid possible overflow instead of style : start + bytes >= end which start + end can overflow use style: end - start < bytes

[PATCHv4 3/4] iovmm: replace __iounmap with omap_iounmap

2010-10-19 Thread Fernando Guzman Lugo
Omap platform is omap_iounmap function. Signed-off-by: Fernando Guzman Lugo --- arch/arm/plat-omap/iovmm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 93a34d9..5489ca9 100644 --- a/arch/arm/plat-omap/iovm

[PATCHv4 4/4] iommu: create new api to set valid da range

2010-10-19 Thread Fernando Guzman Lugo
Some IOMMUs cannot use the whole 0x0 - 0x range. With this new API the valid range can be set. Signed-off-by: Fernando Guzman Lugo --- arch/arm/plat-omap/include/plat/iommu.h |3 +++ arch/arm/plat-omap/iommu.c | 29 + arch/arm/plat-omap/iovm

[PATCHv4 1/4] iovmm: no gap checking for fixed address

2010-10-19 Thread Fernando Guzman Lugo
If some fixed da address is wanted to be mapped and the page is freed but it is used as gap, the mapping will fail. This patch is fixing that and olny keeps the gap for not fixed address. Signed-off-by: Fernando Guzman Lugo --- arch/arm/plat-omap/iovmm.c |4 ++-- 1 files changed, 2 insertion

[PATCHv4 2/4] iovmm: add superpages support to fixed da address

2010-10-19 Thread Fernando Guzman Lugo
This patch adds superpages support to fixed ad address inside iommu_kmap function. Signed-off-by: Fernando Guzman Lugo --- arch/arm/plat-omap/iovmm.c | 62 +-- 1 files changed, 36 insertions(+), 26 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/

Re: [PATCH 3/3] omap: add hwspinlock device

2010-10-19 Thread Ryan Mallon
On 10/20/2010 12:53 PM, Kevin Hilman wrote: > Ohad Ben-Cohen writes: > >> On Tue, Oct 19, 2010 at 7:03 PM, Kevin Hilman >> wrote: +postcore_initcall(hwspinlocks_init); >>> >>> Any reason this needs to be a postcore_initcall? Are there users of >>> hwspinlocks this early in boot? >> >> i2c-

[PATCH 3/3 v2] OMAP3: remove OPP interfaces from OMAP PM layer

2010-10-19 Thread Nishanth Menon
From: Kevin Hilman With new OPP layer, OPP users will access OPP API directly instead of using OMAP PM layer, so remove all notions of OPPs from the OMAP PM layer. Signed-off-by: Nishanth Menon Signed-off-by: Kevin Hilman --- Retaining Kevin's original attribution arch/arm/mach-omap2/io.c

[PATCH 0/3 v2] omap: opp: Add opp data

2010-10-19 Thread Nishanth Menon
Rev2 of the original series since opp layer is moved to power for-next tree: http://marc.info/?l=linux-omap&m=128458780403670&w=2 This series introduces a layer to manage Operating Performance Points (OPPs) for OMAP SoCs. Based on kernel.org commit 51ea8a8. Depends on OPP layer patch from Rafael'

[PATCH 1/3 v2] omap: opp: add OMAP3 OPP table data and common init

2010-10-19 Thread Nishanth Menon
Add OPP data for OMAP34xx and OMAP36xx and initialization functions to populate OPP tables based on current SoC. introduce an OMAP generic opp initialization routine which OMAP3 and OMAP4+ SoCs can use to register their OPP definitions. Signed-off-by: Nishanth Menon Signed-off-by: Kevin Hilman -

[PATCH 2/3 v2] omap4: opp: add OPP table data

2010-10-19 Thread Nishanth Menon
This patch adds OPP tables for OMAP4. New file has been added to keep the OMAP4 opp tables and the registration of these tables with the generic opp framework by OMAP SoC OPP interface. Based on: http://dev.omapzoom.org/?p=santosh/kernel-omap4-base.git;a=blob;f=arch/arm/mach-omap2/opp44xx_data.c;h

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Tony Lindgren
* Kevin Hilman [101019 17:04]: > Tony Lindgren writes: > > > > This actually produces a booting omap2+ kernel with no .config > > at all. I've tested it with: > > > > $ echo CONFIG_ARCH_OMAP=y > .config > > $ yes "" | ARCH=arm make oldconfig > > > > So if you have something that's needed on almos

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Kevin Hilman
Tony Lindgren writes: > * Felipe Contreras [101019 13:43]: >> On Tue, Oct 19, 2010 at 6:05 PM, Felipe Balbi wrote: >> > On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras >> > wrote: >> >> There are two parts, one part is to fix the Kconfigs, and another was >> >> to come up with a way to re

Re: [PATCH] omap2plus: wdt: Fix boot warn when CONFIG_PM_RUNTIME=n

2010-10-19 Thread Kevin Hilman
"Varadarajan, Charulatha" writes: > Paul, Benoit, > > Please provide your input on this. > >> -Original Message- >> From: Kevin Hilman [mailto:khil...@deeprootsystems.com] >> Sent: Tuesday, October 12, 2010 11:57 PM >> To: Cousson, Benoit >> Cc: Varadarajan, Charulatha; Paul Walmsley; l

Re: [PATCH 3/3] omap: add hwspinlock device

2010-10-19 Thread Kevin Hilman
Ohad Ben-Cohen writes: > On Tue, Oct 19, 2010 at 7:03 PM, Kevin Hilman > wrote: >>> +postcore_initcall(hwspinlocks_init); >> >> Any reason this needs to be a postcore_initcall?  Are there users of >> hwspinlocks this early in boot? > > i2c-omap, which is subsys_initcall (the I2C bus is shared be

Re: linux-next - multi-omap image fails to boot on omap3/4

2010-10-19 Thread Gadiyar, Anand
On Wed, Oct 20, 2010 at 5:02 AM, Tony Lindgren wrote: > * Tony Lindgren [101019 15:48]: >> * Gadiyar, Anand [101019 11:26]: >> > On Tue, Oct 19, 2010 at 11:51 PM, Tony Lindgren wrote: >> > > * Anand Gadiyar [101019 07:41]: >> > >> Hi all, >>

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Tony Lindgren
* Felipe Contreras [101019 13:43]: > On Tue, Oct 19, 2010 at 6:05 PM, Felipe Balbi wrote: > > On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras > > wrote: > >> There are two parts, one part is to fix the Kconfigs, and another was > >> to come up with a way to replace the horrible defconfigs.

Re: linux-next - multi-omap image fails to boot on omap3/4

2010-10-19 Thread Tony Lindgren
* Tony Lindgren [101019 15:48]: > * Gadiyar, Anand [101019 11:26]: > > On Tue, Oct 19, 2010 at 11:51 PM, Tony Lindgren wrote: > > > * Anand Gadiyar [101019 07:41]: > > >> Hi all, > > >> > > >> linux-next, as of 20101019, built with the

Re: [PATCH 3/3] omap: add hwspinlock device

2010-10-19 Thread Grant Likely
On Tue, Oct 19, 2010 at 3:02 PM, Ohad Ben-Cohen wrote: > On Tue, Oct 19, 2010 at 7:03 PM, Kevin Hilman > wrote: >>> +postcore_initcall(hwspinlocks_init); >> >> Any reason this needs to be a postcore_initcall?  Are there users of >> hwspinlocks this early in boot? > > i2c-omap, which is subsys_ini

Re: [RFC v2 0/7] OMAP4: mux: Add the OMAP4430 ES1 & ES2 support

2010-10-19 Thread Tony Lindgren
* Benoit Cousson [101019 15:14]: > Hi Tony, > > Upon Nishanth request, here is the updated version... > > It takes into account your proposal to store partition > information in a partition structure instead of inside every pad entries. > The mechanism relies on the uniqueness of the pad name in

Re: linux-next - multi-omap image fails to boot on omap3/4

2010-10-19 Thread Tony Lindgren
* Gadiyar, Anand [101019 11:26]: > On Tue, Oct 19, 2010 at 11:51 PM, Tony Lindgren wrote: > > * Anand Gadiyar [101019 07:41]: > >> Hi all, > >> > >> linux-next, as of 20101019, built with the omap2plus_defconfig fails > >> to boot on omap3 a

[RFC v2 5/7] OMAP4: mux: Select CBL package for SDP4430 with ES1

2010-10-19 Thread Benoit Cousson
Signed-off-by: Benoit Cousson Cc: Tony Lindgren Cc: Paul Walmsley Cc: Kevin Hilman --- arch/arm/mach-omap2/Kconfig |1 + arch/arm/mach-omap2/board-4430sdp.c | 10 ++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mac

[RFC v2 7/7] OMAP4: mux: Select CBS package for SDP4430 with ES2

2010-10-19 Thread Benoit Cousson
Signed-off-by: Benoit Cousson Cc: Tony Lindgren Cc: Paul Walmsley Cc: Santosh Shilimkar Cc: Anand Gadiyar --- arch/arm/mach-omap2/Kconfig |1 + arch/arm/mach-omap2/board-4430sdp.c |6 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/Kco

[RFC v2 6/7] OMAP4: mux: Add CBS package data for OMAP4430 ES2

2010-10-19 Thread Benoit Cousson
Please note that the full muxmodes are re-defined for ES2 instead of using the subset. There are 81 differences among 204 pins. The subset fixup will have to iterate over the whole list for each subset entry, which can lead to an important number of iteration. On the other hand, it will take much m

[RFC v2 3/7] OMAP: mux: Add support for control module split in several partitions

2010-10-19 Thread Benoit Cousson
Starting on OMAP4, the pin mux configuration is located in two different partitions of the control module (CODE_PAD and WKUP_PAD). The first one is inside the core power domain whereas the second one is inside the wakeup. Add the capability to add any number of partition during board init time depe

[RFC v2 0/7] OMAP4: mux: Add the OMAP4430 ES1 & ES2 support

2010-10-19 Thread Benoit Cousson
Hi Tony, Upon Nishanth request, here is the updated version... It takes into account your proposal to store partition information in a partition structure instead of inside every pad entries. The mechanism relies on the uniqueness of the pad name in each partition to find the correct partition du

[RFC v2 1/7] OMAP: mux: Replace printk with pr_xxx macros

2010-10-19 Thread Benoit Cousson
Signed-off-by: Benoit Cousson Cc: Tony Lindgren Cc: Paul Walmsley Cc: Kevin Hilman --- arch/arm/mach-omap2/mux.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 074536a..

[RFC v2 2/7] OMAP3: RX-51: Temporary disable dynamic mux change for eMMC

2010-10-19 Thread Benoit Cousson
RX-51 board is using some low level function in order to change the padconf settings at runtime. Since these functions will not be usable anymore after the partition introduction, remove the code that use these code. As soon as a proper API will be proposed, this patch will be drop. Signed-off-by

DSS2 crash with shutdown -h now

2010-10-19 Thread Steve Sakoman
I'm using a 2.6.35 kernel, and the generic panel driver. I see this crash about 25% of the time, so I suspect a race condition. Is anyone else encountering this? Steve Unmounting local filesystems... Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa050040 Internal error: : 1028

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Ohad Ben-Cohen
On Tue, Oct 19, 2010 at 10:58 PM, Arnd Bergmann wrote: >> If a hwspinlock is taken over a long period of time, its other user >> (with which we try to achieve synchronization) might be polling the >> OMAP interconnect for too long (trying to take the hwspinlock) and >> thus preventing it to be use

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Arnd Bergmann
On Tuesday 19 October 2010 22:51:22 Ohad Ben-Cohen wrote: > >, which is generally discouraged > > in all places where you know if you need to disable interrupts or not. > > > > IMHO the default should be a version that only allows locks that don't get > > taken at IRQ time and consequently don't re

Re: [PATCH 3/3] omap: add hwspinlock device

2010-10-19 Thread Ohad Ben-Cohen
On Tue, Oct 19, 2010 at 7:03 PM, Kevin Hilman wrote: >> +postcore_initcall(hwspinlocks_init); > > Any reason this needs to be a postcore_initcall?  Are there users of > hwspinlocks this early in boot? i2c-omap, which is subsys_initcall (the I2C bus is shared between the A9 and the M3 on some OMAP

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Arnd Bergmann
On Tuesday 19 October 2010 22:43:34 Ohad Ben-Cohen wrote: > > Disabling irqs might be a concern as a source of RT latency. It > > might be better to make the caller responsible for managing local spin > > locks and irq disable/enable. > > This a coming from an hardware requirement, rather than a

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 6:05 PM, Felipe Balbi wrote: > On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras > wrote: >> There are two parts, one part is to fix the Kconfigs, and another was >> to come up with a way to replace the horrible defconfigs. Part two is >> mostly fixed thanks to 'make sa

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Ohad Ben-Cohen
On Tue, Oct 19, 2010 at 7:21 PM, Arnd Bergmann wrote: > On Monday 18 October 2010 09:44:33 Ohad Ben-Cohen wrote: >> +  int omap_hwspin_lock(struct omap_hwspinlock *hwlock, unsigned long >> *flags); >> ... >> +     The flags parameter is a pointer to where the interrupts state of the >> +     call

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Ohad Ben-Cohen
On Tue, Oct 19, 2010 at 7:01 PM, Grant Likely wrote: >> +  struct omap_hwspinlock *omap_hwspinlock_request(void); ... > ERR_PTR() is only appropriate when the caller actually cares about the > failure code and has different behaviour depending on the result. Agree; the hwspinlock users can surely

Re: [PATCH 9/9] arch: arm: fixed typos

2010-10-19 Thread Jiri Kosina
On Mon, 18 Oct 2010, Uwe Kleine-König wrote: > On Sat, Oct 16, 2010 at 11:00:05AM +0200, Andrea Gelmini wrote: > > Intialize, configuation, wakup, Managment, addres > I already fixed some of these in > > http://thread.gmane.org/gmane.linux.kernel/1030436/ > > Don't know why they didn't app

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Ohad Ben-Cohen
On Tue, Oct 19, 2010 at 6:58 PM, Kevin Hilman wrote: >> +      * This spin_trylock_irqsave serves two purposes: >> + >> +      * 1. Disable local interrupts and preemption, in order to >> +      *    minimize the period of time in which the hwspinlock >> +      *    is taken (so caller will not pr

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Ohad Ben-Cohen
On Tue, Oct 19, 2010 at 5:46 PM, Greg KH wrote: > On Mon, Oct 18, 2010 at 09:44:33AM +0200, Ohad Ben-Cohen wrote: >> +#else /* !CONFIG_OMAP_HWSPINLOCK */ >> + >> +static inline struct omap_hwspinlock *omap_hwspinlock_request(void) >> +{ >> +     return ERR_PTR(-ENOSYS); >> +} > > One note, do you

External SD card on nokia n810.

2010-10-19 Thread Maksim A. Boyko
> 2nd slot was fixed by the commit 214044b. I just tried and both internal > mmc and external microSD (=uSD) are working on current l-o head 8b4b015. > FYI: here is some info how to get access to N810 serial port pins. > Makes debugging much easier :-) > > http://bu3sch.de/joomla/index.php/nokia-n8

Re: linux-next - multi-omap image fails to boot on omap3/4

2010-10-19 Thread Gadiyar, Anand
On Tue, Oct 19, 2010 at 11:51 PM, Tony Lindgren wrote: > * Anand Gadiyar [101019 07:41]: >> Hi all, >> >> linux-next, as of 20101019, built with the omap2plus_defconfig fails >> to boot on omap3 and omap4. (I've disabled CONFIG_ARCH_OMAP2 or >> CONFIG

Re: linux-next: omap2plus_defconfig does not build

2010-10-19 Thread Gadiyar, Anand
On Tue, Oct 19, 2010 at 10:45 PM, Tony Lindgren wrote: > * Anand Gadiyar [101013 06:14]: >> Building omap2plus_defconfig (which enables support for >> OMAP2420/2430/OMAP3 >> and OMAP4 in one image), I get the following build error. >> >>   CC      arch/arm/kernel/swp_emulate.o >> /tmp/ccg979qz.s:

Re: linux-next - multi-omap image fails to boot on omap3/4

2010-10-19 Thread Tony Lindgren
* Anand Gadiyar [101019 07:41]: > Hi all, > > linux-next, as of 20101019, built with the omap2plus_defconfig fails > to boot on omap3 and omap4. (I've disabled CONFIG_ARCH_OMAP2 or > CONFIG_SWP_EMULATE to get the image to build). Building with only > ARCH_OMAP3 allows the

Re: [PATCH v2 2/3] usb: trivial Kconfig cleanups

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 8:50 PM, Greg KH wrote: > On Tue, Oct 19, 2010 at 08:15:19PM +0300, Felipe Contreras wrote: >> On Tue, Oct 19, 2010 at 6:51 PM, Greg KH wrote: >> > On Tue, Oct 19, 2010 at 01:03:27PM +0300, Felipe Contreras wrote: >> >> Note: USB_GADGET_MUSB_HDRC is already defined in usb/

Re: [PATCH v2 2/3] usb: trivial Kconfig cleanups

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 08:15:19PM +0300, Felipe Contreras wrote: > On Tue, Oct 19, 2010 at 6:51 PM, Greg KH wrote: > > On Tue, Oct 19, 2010 at 01:03:27PM +0300, Felipe Contreras wrote: > >> Note: USB_GADGET_MUSB_HDRC is already defined in usb/gadget. > >> > >> Signed-off-by: Felipe Contreras > >

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Arnd Bergmann
On Monday 18 October 2010 09:44:33 Ohad Ben-Cohen wrote: > + int omap_hwspin_lock(struct omap_hwspinlock *hwlock, unsigned long *flags); > ... > + The flags parameter is a pointer to where the interrupts state of the > + caller will be saved at. This seems to encourage sloppy coding: The

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Kevin Hilman
Ohad Ben-Cohen writes: > From: Simon Que > > Add driver for OMAP's Hardware Spinlock module. > > The OMAP Hardware Spinlock module, initially introduced in OMAP4, > provides hardware assistance for synchronization between the > multiple processors in the device (Cortex-A9, Cortex-M3 and > C64x+

Re: linux-next: omap2plus_defconfig does not build

2010-10-19 Thread Tony Lindgren
* Anand Gadiyar [101013 06:14]: > Building omap2plus_defconfig (which enables support for > OMAP2420/2430/OMAP3 > and OMAP4 in one image), I get the following build error. > > CC arch/arm/kernel/swp_emulate.o > /tmp/ccg979qz.s: Assembler messages: > /tmp/ccg979qz.s:343: Error: selected pro

Re: [PATCH v2 2/3] usb: trivial Kconfig cleanups

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 6:51 PM, Greg KH wrote: > On Tue, Oct 19, 2010 at 01:03:27PM +0300, Felipe Contreras wrote: >> Note: USB_GADGET_MUSB_HDRC is already defined in usb/gadget. >> >> Signed-off-by: Felipe Contreras > > Please describe _what_ trivial cleanups you did, and why you did them. > Ca

Re: [PATCH 3/3] omap: add hwspinlock device

2010-10-19 Thread Kevin Hilman
Ohad Ben-Cohen writes: > From: Simon Que > > Build and register an hwspinlock platform device. > > Although only OMAP4 supports the hardware spinlock module (for now), > it is still safe to run this initcall on all omaps, because hwmod lookup > will simply fail on hwspinlock-less platforms. > >

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Kevin Hilman
Anand Gadiyar writes: > On 10/19/2010 9:22 PM, Greg KH wrote: >> On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: >>> Add missing dependencies, and remove redundant ones, and select sensible >>> defaults. >>> >>> Signed-off-by: Felipe Contreras >>> --- >>> drivers/mfd/Kconfig

Re: [PATCH 3/3] omap: add hwspinlock device

2010-10-19 Thread Grant Likely
On Tue, Oct 19, 2010 at 11:03 AM, Kevin Hilman wrote: > Ohad Ben-Cohen writes: > >> From: Simon Que >> >> Build and register an hwspinlock platform device. >> >> Although only OMAP4 supports the hardware spinlock module (for now), >> it is still safe to run this initcall on all omaps, because hw

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Grant Likely
On Mon, Oct 18, 2010 at 1:44 AM, Ohad Ben-Cohen wrote: > From: Simon Que > > Add driver for OMAP's Hardware Spinlock module. > > The OMAP Hardware Spinlock module, initially introduced in OMAP4, > provides hardware assistance for synchronization between the > multiple processors in the device (Co

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Kevin Hilman
Ohad Ben-Cohen writes: > From: Simon Que > > Add driver for OMAP's Hardware Spinlock module. > > The OMAP Hardware Spinlock module, initially introduced in OMAP4, > provides hardware assistance for synchronization between the > multiple processors in the device (Cortex-A9, Cortex-M3 and > C64x+

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 09:42:17PM +0530, Anand Gadiyar wrote: > On 10/19/2010 9:22 PM, Greg KH wrote: > >On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: > >>Add missing dependencies, and remove redundant ones, and select sensible > >>defaults. > >> > >>Signed-off-by: Felipe Contr

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Anand Gadiyar
On 10/19/2010 9:22 PM, Greg KH wrote: On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: Add missing dependencies, and remove redundant ones, and select sensible defaults. Signed-off-by: Felipe Contreras --- drivers/mfd/Kconfig|3 ++- drivers/regulator/Kconfig |

Re: [PATCH v2 2/3] usb: trivial Kconfig cleanups

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 01:03:27PM +0300, Felipe Contreras wrote: > Note: USB_GADGET_MUSB_HDRC is already defined in usb/gadget. > > Signed-off-by: Felipe Contreras Please describe _what_ trivial cleanups you did, and why you did them. Care to resend? thanks, greg k-h -- To unsubscribe from th

Re: [PATCH v2 1/3] usb: fix Kconfig warning

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 01:28:09PM +0300, Felipe Balbi wrote: > On Tue, Oct 19, 2010 at 05:03:26AM -0500, Felipe Contreras wrote: > >warning: (USB_MUSB_HDRC_HCD && USB_SUPPORT && USB_MUSB_HDRC && > >(USB_MUSB_HOST || USB_MUSB_OTG) && USB_GADGET_MUSB_HDRC || USB_MUSB_OTG > >&& && USB && USB_GADGET

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-19 Thread Greg KH
On Mon, Oct 18, 2010 at 09:44:33AM +0200, Ohad Ben-Cohen wrote: > +#else /* !CONFIG_OMAP_HWSPINLOCK */ > + > +static inline struct omap_hwspinlock *omap_hwspinlock_request(void) > +{ > + return ERR_PTR(-ENOSYS); > +} One note, do you really want to fail if this option isn't built into the kern

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote: > Add missing dependencies, and remove redundant ones, and select sensible > defaults. > > Signed-off-by: Felipe Contreras > --- > drivers/mfd/Kconfig|3 ++- > drivers/regulator/Kconfig |1 + > drivers/usb/gadget/

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, (already at home so using personal email) On Tue, 19 Oct 2010 17:32:07 +0300, Felipe Contreras wrote: > There are two parts, one part is to fix the Kconfigs, and another was > to come up with a way to replace the horrible defconfigs. Part two is > mostly fixed thanks to 'make savedefconfig',

Re: [PATCH v2] omap4: pandaboard: fix up mmc card detect logic

2010-10-19 Thread Samuel Ortiz
Hi Nishanth, On Tue, Oct 19, 2010 at 09:50:25AM -0500, Nishanth Menon wrote: > From: Menon, Nishanth > > For MMC1 Controller, card detect interrupt source is > twl6030 which is non-gpio. The card detect call back function provides > card present/absent status by reading MMC Control register pres

Re: PATCH [0/4] perf: clean-up of power events API

2010-10-19 Thread Ingo Molnar
* Arjan van de Ven wrote: > >> for some time software needs to support both, especially if popular > >> distros > >> stick to an older kernel like *cough* RHEL6 > > > > Sure, you can support both. But as long as support for the _new_ events is > > included in PowerTop there's no need to keep

[PATCH v2] omap4: pandaboard: fix up mmc card detect logic

2010-10-19 Thread Nishanth Menon
From: Menon, Nishanth For MMC1 Controller, card detect interrupt source is twl6030 which is non-gpio. The card detect call back function provides card present/absent status by reading MMC Control register present on twl6030. This functionality was introduced in mfd tree on track to kernel.org Sy

linux-next - multi-omap image fails to boot on omap3/4

2010-10-19 Thread Anand Gadiyar
Hi all, linux-next, as of 20101019, built with the omap2plus_defconfig fails to boot on omap3 and omap4. (I've disabled CONFIG_ARCH_OMAP2 or CONFIG_SWP_EMULATE to get the image to build). Building with only ARCH_OMAP3 allows the resultant image to boot up on OMAP3. Likewise, an image

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
Hi Roger, On Tue, Oct 19, 2010 at 4:40 PM, Roger Quadros wrote: >> @@ -843,6 +841,7 @@ config USB_CDC_COMPOSITE >>  config USB_G_NOKIA >>        tristate "Nokia composite gadget" >>        depends on PHONET >> +       depends on USB_GADGET_MUSB_HDRC > > This is wrong. Is there a build problem or

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 2:52 PM, Felipe Balbi wrote: > On Tue, Oct 19, 2010 at 06:36:32AM -0500, Felipe Contreras wrote: >> >> That is actually the intention. > > so it's a bit messed up one :-p Why? It makes configurations simpler. >> It's the other way around. He wanted to get rid of defconfig

[PATCH] spi/omap2_mcspi: Verify TX reg is empty after TX only xfer with DMA

2010-10-19 Thread Ilkka Koskinen
In case of TX only with DMA, the driver assumes that the data has been transferred once DMA callback in invoked. However, SPI's shift register may still contain data. Thus, the driver is supposed to verify that the register is empty and the end of the SPI transfer has been reached. Signed-off-by:

Re: PATCH [0/4] perf: clean-up of power events API

2010-10-19 Thread Arjan van de Ven
On 10/19/2010 6:50 AM, Ingo Molnar wrote: * Arjan van de Ven wrote: On 10/19/2010 4:52 AM, Ingo Molnar wrote: * Peter Zijlstra wrote: On Tue, 2010-10-19 at 13:45 +0200, Ingo Molnar wrote: * Thomas Renninger wrote: Most definitely. It's no accident that it took such a long time for

Re: PATCH [0/4] perf: clean-up of power events API

2010-10-19 Thread Ingo Molnar
* Arjan van de Ven wrote: > On 10/19/2010 4:52 AM, Ingo Molnar wrote: > >* Peter Zijlstra wrote: > > > >>On Tue, 2010-10-19 at 13:45 +0200, Ingo Molnar wrote: > >>>* Thomas Renninger wrote: > >>> > >Most definitely. It's no accident that it took such a long time for this > >issue > >

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Roger Quadros
Hi Felipe, On 10/19/2010 01:03 PM, ext Felipe Contreras wrote: Add missing dependencies, and remove redundant ones, and select sensible defaults. Signed-off-by: Felipe Contreras --- drivers/mfd/Kconfig|3 ++- drivers/regulator/Kconfig |1 + drivers/usb/gadget/Kconfig |3

Re: PATCH [0/4] perf: clean-up of power events API

2010-10-19 Thread Arjan van de Ven
On 10/19/2010 4:52 AM, Ingo Molnar wrote: * Peter Zijlstra wrote: On Tue, 2010-10-19 at 13:45 +0200, Ingo Molnar wrote: * Thomas Renninger wrote: Most definitely. It's no accident that it took such a long time for this issue to be raised in the first place. It's a rare occurance - Do you

Re: [RFC v3][PATCH 0/4] OMAP: DSS2: Overlay Manager LCD2 support in DISPC

2010-10-19 Thread Tomi Valkeinen
Hi, On Tue, 2010-10-05 at 13:55 +0200, ext Archit Taneja wrote: > This patch series which incorporates changes in DSS2 to enable > omap_dss_device instances to use the new Overlay Manager LCD2 in > DISPC. > > On OMAP4, we have a new DISPC channel for Overlay Manager LCD2. This > channel's video p

Re: PATCH [0/4] perf: clean-up of power events API

2010-10-19 Thread Peter Zijlstra
On Tue, 2010-10-19 at 13:45 +0200, Ingo Molnar wrote: > > * Thomas Renninger wrote: > > > > Most definitely. It's no accident that it took such a long time for this > > > issue > > > to be raised in the first place. It's a rare occurance - > > > > Do you agree that this occurance happened now

Re: PATCH [0/4] perf: clean-up of power events API

2010-10-19 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Tue, 2010-10-19 at 13:45 +0200, Ingo Molnar wrote: > > > > * Thomas Renninger wrote: > > > > > > Most definitely. It's no accident that it took such a long time for > > > > this issue > > > > to be raised in the first place. It's a rare occurance - > > > > > > D

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, On Tue, Oct 19, 2010 at 06:36:32AM -0500, Felipe Contreras wrote: That is actually the intention. so it's a bit messed up one :-p It's the other way around. He wanted to get rid of defconfigs completely by moving the complexity to Kconfigs: Yes, but he was suggesting to add things like

Re: [PATCH 1/2] video: omap: vram: remove from normal memory

2010-10-19 Thread Tomi Valkeinen
On Tue, 2010-10-19 at 00:55 +0200, ext Tony Lindgren wrote: > * Tomi Valkeinen [101018 06:55]: > > On Mon, 2010-10-18 at 16:10 +0300, Tomi Valkeinen wrote: > > > Hi, > > > > > > On Fri, 2010-10-15 at 14:46 +0200, ext Felipe Contreras wrote: > > > > So that we can ioremap happily. > > > > > > > >

Re: PATCH [0/4] perf: clean-up of power events API

2010-10-19 Thread Ingo Molnar
* Thomas Renninger wrote: > > Most definitely. It's no accident that it took such a long time for this > > issue > > to be raised in the first place. It's a rare occurance - > > Do you agree that this occurance happened now and these events should get > cleaned > up before ARM and other arch

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 2:16 PM, Felipe Balbi wrote: > On Tue, Oct 19, 2010 at 05:59:58AM -0500, Felipe Contreras wrote: >> >> The USB_MUSB_HDRC dependency on NOP_USB_XCEIV || TWL4030_USB is >> already there, I'm just making it explicit. The rest are not >> dependencies, just sensible defaults, an

[PATCH 2/3] PERF(kernel): Cleanup power events

2010-10-19 Thread Thomas Renninger
New power trace events: power:processor_idle power:processor_frequency power:machine_suspend C-state/idle accounting events: power:power_start power:power_end are replaced with: power:processor_idle and power:power_frequency is replaced with: power:processor_frequency power:machine_su

[PATCH 1/3] PERF: Do not export power_frequency, but power_start event

2010-10-19 Thread Thomas Renninger
power_frequency moved to drivers/cpufreq/cpufreq.c which has to be compiled in, no need to export it. intel_idle can a be module though... Signed-off-by: Thomas Renninger CC: Linus Torvalds CC: Andrew Morton CC: Thomas Gleixner CC: Masami Hiramatsu CC: Frank Eigler CC: Steven Rostedt CC: K

[PATCH 3/3] PERF(userspace): Adjust perf timechart to the new power events

2010-10-19 Thread Thomas Renninger
The transition was rather smooth, only part I had to fiddle some time was the check whether a tracepoint/event is supported by the running kernel. builtin-timechart must only pass -e power:xy events which are supported by the running kernel. For this I added the tiny helper function: int is_valid_

Re: PATCH [0/4] perf: clean-up of power events API

2010-10-19 Thread Thomas Renninger
On Sunday 10 October 2010 14:19:28 Ingo Molnar wrote: > > * Arjan van de Ven wrote: > ... > > also I have to say that some events are more likely to change than others > > > > "function foo in the kernel called" is more likely to change than "the > > processor went to THIS frequency". The conc

RE: [PATCH] omap2plus: wdt: Fix boot warn when CONFIG_PM_RUNTIME=n

2010-10-19 Thread Varadarajan, Charulatha
Paul, > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Friday, October 15, 2010 12:08 AM > To: Varadarajan, Charulatha > Cc: Kevin Hilman; Cousson, Benoit; linux-omap@vger.kernel.org > Subject: RE: [PATCH] omap2plus: wdt: Fix boot warn when > CONFIG_PM_RUNTIME=n

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, On Tue, Oct 19, 2010 at 05:59:58AM -0500, Felipe Contreras wrote: The USB_MUSB_HDRC dependency on NOP_USB_XCEIV || TWL4030_USB is already there, I'm just making it explicit. The rest are not dependencies, just sensible defaults, and they are already in drivers/usb/musb/Kconfig, I'm just movi

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
On Tue, Oct 19, 2010 at 1:32 PM, Felipe Balbi wrote: > On Tue, Oct 19, 2010 at 05:03:28AM -0500, Felipe Contreras wrote: >> >> +       depends on (NOP_USB_XCEIV || TWL4030_USB) >> +       default y if ARCH_OMAP3 >> +       default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN > > it could be only

Re: [PATCH v3] TWL IRQ: Fix fucntion declaration warnings

2010-10-19 Thread Samuel Ortiz
Hi Uwe, On Tue, Oct 19, 2010 at 11:28:16AM +0200, Uwe Kleine-König wrote: > On Tue, Oct 19, 2010 at 11:06:14AM +0200, Samuel Ortiz wrote: > > Hi Manjunath, > > > > On Wed, Oct 06, 2010 at 03:26:59AM +0530, G, Manjunath Kondaiah wrote: > > > Fixes following sparse warnings for twl4030 and twl6030

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Balbi
Hi, On Tue, Oct 19, 2010 at 05:03:28AM -0500, Felipe Contreras wrote: + depends on (NOP_USB_XCEIV || TWL4030_USB) + default y if ARCH_OMAP3 + default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN it could be only me, but I see these kind of dependencies tend to disaster. The

Re: [PATCH v2 1/3] usb: fix Kconfig warning

2010-10-19 Thread Felipe Balbi
On Tue, Oct 19, 2010 at 05:03:26AM -0500, Felipe Contreras wrote: warning: (USB_MUSB_HDRC_HCD && USB_SUPPORT && USB_MUSB_HDRC && (USB_MUSB_HOST || USB_MUSB_OTG) && USB_GADGET_MUSB_HDRC || USB_MUSB_OTG && && USB && USB_GADGET && PM && EXPERIMENTAL) selects USB_OTG which has unmet direct dependenc

[PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-19 Thread Felipe Contreras
Add missing dependencies, and remove redundant ones, and select sensible defaults. Signed-off-by: Felipe Contreras --- drivers/mfd/Kconfig|3 ++- drivers/regulator/Kconfig |1 + drivers/usb/gadget/Kconfig |3 +-- drivers/usb/musb/Kconfig |6 ++ drivers/usb/otg/Kcon

[PATCH v2 1/3] usb: fix Kconfig warning

2010-10-19 Thread Felipe Contreras
warning: (USB_MUSB_HDRC_HCD && USB_SUPPORT && USB_MUSB_HDRC && (USB_MUSB_HOST || USB_MUSB_OTG) && USB_GADGET_MUSB_HDRC || USB_MUSB_OTG && && USB && USB_GADGET && PM && EXPERIMENTAL) selects USB_OTG which has unmet direct dependencies (USB_GADGET_OMAP && ARCH_OMAP_OTG && USB_OHCI_HCD) This doesn't

[PATCH v2 0/3] usb: generic Kconfig fixes

2010-10-19 Thread Felipe Contreras
This gets rid of some warnings, makes defconfigs smarter by having more proper dependencies, and general cleanups. BTW, this is the reason USB_GADGET_MUSB_HDRC sometimes is not selected: http://article.gmane.org/gmane.linux.kbuild.devel/5480 v2: comments by Felipe Balbi Felipe Contreras (3): u

  1   2   >