Re: [PATCH v5 2/3] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish

2010-11-10 Thread Adrian Hunter
On 11/11/10 01:30, ext Paul Walmsley wrote: Hello Adrian, On Wed, 10 Nov 2010, Adrian Hunter wrote: On 05/10/10 09:45, Peter Ujfalusi wrote: + if (cpu_is_omap34xx()&& (l& OMAP_DMA_CCR_SEL_SRC_DST_SYNC)) { + int i = 0; + u32 sys_cf; + + /* C

[PATCH 00/02] staging: tidspbridge: 2.6.37-rcX fixes

2010-11-10 Thread Omar Ramirez Luna
Hi Greg, Please consider the following patch set for tidspbridge driver in staging tree, the following has been tested on an omap3430 based board + gst-dsp environment. Many thanks to Felipe Contreras for piling this up, as I'm just propagating his patches. First two patches: 1. omap: dsp: remove

[PATCH 02/02] staging: tidspbridge: hardcode SCM macros while fix is upstreamed

2010-11-10 Thread Omar Ramirez Luna
From: Felipe Contreras On 2.6.37-rc1, omap platform internals for SCM have changed, so the build is broken again. drivers/staging/tidspbridge/core/tiomap3430.c:26: fatal error: plat/control.h: No such file or directory This is a totally ugly layer violation, but needed until omap_ctrl_set_d

[PATCH 01/02] omap: dsp: remove shm from normal memory

2010-11-10 Thread Omar Ramirez Luna
From: Felipe Contreras Also, don't be picky about the location, which incidentally fixes the build since MEMBLOCK_REAL_LIMIT is gone on 2.6.37. arch/arm/plat-omap/devices.c: In function 'omap_dsp_reserve_sdram_memblock': arch/arm/plat-omap/devices.c:287: error: 'MEMBLOCK_REAL_LIMIT' undeclar

Re: [RFC v2 4/7] OMAP4: mux: Add CBL package data for OMAP4430 ES1

2010-11-10 Thread Tony Lindgren
* Benoit Cousson [101019 15:14]: > Add data for OMAP4430 generated from HW pinout & register database. > The data set is split in two partitions for both core and wkup. We should drop patch 3/7 and merge the following patch to your 4/7 patch. Basically let's keep the omap_mux_read/write around f

Re: [PATCH 6/6] omap:clocks44x-add dummy clock for mailbox

2010-11-10 Thread Hari Kanigeri
Paul, On Wed, Nov 10, 2010 at 5:27 PM, Paul Walmsley wrote: > Hello Hari > > On Wed, 10 Nov 2010, Hari Kanigeri wrote: > >> In omap4, there is no explicit configuration register to enable mailbox >> clocks. >> Defining dummy clock for mailbox clock module to keep the mailbox driver >> backward c

Re: [PATCH v2 04/14] OMAP: Introduce API to register a device with a voltagedomain

2010-11-10 Thread Kevin Hilman
Thara Gopinath writes: > This patch adds an API in the voltage layer that > can be used during omap_device_build to register the built > device with the voltage domain. This API is to be typically called > only once per device during the device registeration. This approach > makes it easy during

Re: [PATCH V2] hwmon: twl4030: Driver for twl4030 madc module

2010-11-10 Thread Guenter Roeck
On Tue, Nov 09, 2010 at 04:20:57AM -0500, Keerthy wrote: > Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring > ADC. This driver monitors the real time conversion of analog signals like > battery temperature, battery type, battery level etc. User can also ask for > the con

Re: [PATCH 2/5] omap: control: add functions for DSP boot

2010-11-10 Thread Paul Walmsley
Hello Felipe, On Sun, 7 Nov 2010, Felipe Contreras wrote: > From: Paul Walmsley > > Add two functions for OMAP2430/OMAP3 IVA2 DSP boot control. These > registers wound up in the System Control Module. Other kernel code that > wishes to control the DSP's boot process should now use these funct

Re: [PATCH v5 2/3] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish

2010-11-10 Thread Paul Walmsley
Hello Adrian, On Wed, 10 Nov 2010, Adrian Hunter wrote: > On 05/10/10 09:45, Peter Ujfalusi wrote: > > > + if (cpu_is_omap34xx()&& (l& OMAP_DMA_CCR_SEL_SRC_DST_SYNC)) { > > + int i = 0; > > + u32 sys_cf; > > + > > + /* Configure No-Standby */ > > + l =

Re: [PATCH 6/6] omap:clocks44x-add dummy clock for mailbox

2010-11-10 Thread Paul Walmsley
Hello Hari On Wed, 10 Nov 2010, Hari Kanigeri wrote: > In omap4, there is no explicit configuration register to enable mailbox > clocks. > Defining dummy clock for mailbox clock module to keep the mailbox driver > backward compatible with previous omaps. If you split this off from the rest of y

Re: [PATCH v2] OMAP2+: PM: omap_device: API for set/get MSTANDBY mode

2010-11-10 Thread Paul Walmsley
Hello Manju, On Tue, 26 Oct 2010, G, Manjunath Kondaiah wrote: > Certain errata's in OMAP2+ processors will require disabling > master standby mode before completing on going operation. Without > this, the results will be unpredictable. > > Since current implementation of PM run time framework d

Re: [PATCH 0/6] [v2] OMAP: mailbox: enhancements and fixes

2010-11-10 Thread Cousson, Benoit
On 11/10/2010 9:16 PM, Hari Kanigeri wrote: Benoit, Resending correcting the subject format based on Benoit's comment and fixing the over-indentation pointed out by Sergei. Pure nitpicking: That's a pretty fast update... but then it should be a v3 :-) Have to do it fast to keep your attenti

Re: [PATCH 0/6] [v2] OMAP: mailbox: enhancements and fixes

2010-11-10 Thread Hari Kanigeri
Benoit, >> Resending correcting the subject format based on Benoit's comment and >> fixing the over-indentation pointed out by Sergei. > > Pure nitpicking: > That's a pretty fast update... but then it should be a v3 :-) Have to do it fast to keep your attention :). Since you are saying it is pure

Re: [PATCH v3 2/6] OMAP4: Adding voltage driver support

2010-11-10 Thread Kevin Hilman
Thara Gopinath writes: > OMAP4 has three scalable voltage domains vdd_mpu, vdd_iva > and vdd_core. This patch adds the voltage tables and other > configurable voltage processor and voltage controller > settings to control these three scalable domains in OMAP4. > > Signed-off-by: Thara Gopinath

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Felipe Balbi
Hi, On Wed, 2010-11-10 at 19:58 +0100, Cousson, Benoit wrote: > My point was that checkpatch is supposed to check patch... but it's true > that is can check the code as well. I was assuming that all the code in > mainline is supposed to be already checkpatch proof :-) > It seems that this is not

Re: [PATCH 0/6] [v2] OMAP: mailbox: enhancements and fixes

2010-11-10 Thread Cousson, Benoit
On 11/10/2010 7:00 PM, Hari Kanigeri wrote: Resending correcting the subject format based on Benoit's comment and fixing the over-indentation pointed out by Sergei. Pure nitpicking: That's a pretty fast update... but then it should be a v3 :-) Why does the cover letter not use the same format?

Re: [PATCH v4 7/9] OMAP3: PM: Adding debug support to Voltage and Smartreflex drivers

2010-11-10 Thread Kevin Hilman
Thara Gopinath writes: > This patch adds debug support to the voltage and smartreflex drivers. > This means a whole bunch of voltage processor and smartreflex > parameters are now visible through the pm debugfs. > The voltage parameters can be viewed at > /debug/voltage/vdd_/ > and the sm

Re: [PATCH v4 0/9] OMAP3: Adding Smartreflex and Voltage driver support

2010-11-10 Thread Kevin Hilman
"Gopinath, Thara" writes: [...] >>> >>>Also curious should: >>>"OMAP: OPP: twl/tps: Introduce TWL/TPS-specific code should probably be >>>" dropped with "OMAP3: PM: Register TWL4030 pmic info with the voltage" ? > > Hmm.. Last time I suggested moving the contents of this patch to > twl-core.c No

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Cousson, Benoit
On 11/10/2010 5:56 PM, Hari Kanigeri wrote: [...] Good point, thanks for pointing about consistency. I wasn't aware about the rule to use OMAP in caps. Well, I'm not sure there is any rule like that, it is just what was mostly used so far. My point was more about the text after the omap. B

Re: [PATCH v4 1/9] OMAP3: PM: Adding voltage driver support for OMAP3

2010-11-10 Thread Kevin Hilman
[resend with thinned out response, since original reply was determined to be spam by vger.kernel.org. wondering that tells me about my review style... ] Thara Gopinath writes: > This patch adds voltage driver support for OMAP3. The driver > allows configuring the voltage controller and volta

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Cousson, Benoit
On 11/10/2010 5:56 PM, Hari Kanigeri wrote: Benoit, Thanks for your comments. On Wed, Nov 10, 2010 at 10:40 AM, Cousson, Benoit wrote: Hi Hari, On 11/10/2010 1:45 PM, Hari Kanigeri wrote: Thanks to Rene Sapiens and Omar Ramirez for their inputs on initial patch set. http://www.mail-archive

Re: [PATCH v3 04/11] OMAP3: PM: Adding smartreflex device file.

2010-11-10 Thread Kevin Hilman
"Gopinath, Thara" writes: >>>"Gopinath, Thara" writes: >>> >>On Wed, 2010-09-22 at 20:15 +0530, Thara Gopinath wrote: >>> This patch adds support for device registration of various >>> smartreflex module present in the system. This patch introduces >>> the platform data for smart

[PATCH v2 5/6] OMAP: mailbox: add notification support for multiple readers

2010-11-10 Thread Hari Kanigeri
In the current mailbox driver, the mailbox internal pointer for callback can be directly manipulated by the Users, so a second User can easily corrupt the first user's callback pointer. The initial effort to correct this issue can be referred here: https://patchwork.kernel.org/patch/107520/ Along

[PATCH v2 4/6] OMAP: mailbox: send message in process context

2010-11-10 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full and there are pending messages in kifo, else send the message directly in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri --- arch/arm/plat-omap/mailbox.c |

[PATCH v2 1/6] OMAP: mailbox: change full flag per mailbox queue instead of global

2010-11-10 Thread Hari Kanigeri
From: Fernando Guzman Lugo As pointed by Ohad Ben-Cohen, the variable rq_full flag is a global variable, so if there are multiple mailbox users there will be conflics. Now there is a full flag per mailbox queue. Version 2: - Rebase to the latest. Version 3: - Remove spin_lock protection. When th

[PATCH v2 3/6] OMAP: mailbox: fix checkpatch warnings

2010-11-10 Thread Hari Kanigeri
Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 9ce3570..abfc495 100644 --- a/ar

[PATCH v2 2/6] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-10 Thread Hari Kanigeri
disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Signed-off-by: Hari Kanigeri --- arch/arm/mach-omap2/mailbox.c |5 - 1 files changed, 4 insertions(+), 1 deleti

[PATCH v2 6/6] OMAP4: clocks: add dummy clock for mailbox

2010-11-10 Thread Hari Kanigeri
In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver backward compatible with previous omaps. Signed-off-by: Hari Kanigeri --- arch/arm/mach-omap2/clock44xx_data.c |1 + 1 files changed, 1 ins

[PATCH 0/6] [v2] OMAP: mailbox: enhancements and fixes

2010-11-10 Thread Hari Kanigeri
Resending correcting the subject format based on Benoit's comment and fixing the over-indentation pointed out by Sergei. Thanks to Rene Sapiens and Omar Ramirez for their inputs on initial patch set. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg37278.html The patch set addresses the

Re: [PATCH v3 10/13] OMAP: DMA: Convert DMA library into DMA platform Driver

2010-11-10 Thread Kevin Hilman
"G, Manjunath Kondaiah" writes: >> >> > +#define OMAP_DMA4_LOGICAL_DMA_CH_COUNT 32 /* >> >> REVISIT: Is this 32 + 2? */ >> >> > + >> >> >> >> There are no users of this in this patch, all users are removed. >> > >> > This macro is used in hwmod data base. Do you mean hard coding this >> >

Re: [PATCH 2/5] omap-aes: DMA initialization fixes for OMAP off mode

2010-11-10 Thread Felipe Balbi
Hi, On Wed, 2010-11-10 at 19:26 +0200, Dmitry Kasatkin wrote: > diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c > index 9d65611..04cab70 100644 > --- a/drivers/crypto/omap-aes.c > +++ b/drivers/crypto/omap-aes.c > @@ -99,7 +99,7 @@ struct omap_aes_reqctx { > struct omap_aes_dev

RE: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 9:56 PM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Peter Ujfalusi; > Cousson, Benoit; Shilimkar, Santosh > Su

[PATCH 4/4] omap-sham: removed redundunt locking

2010-11-10 Thread Dmitry Kasatkin
Locking for queuing and dequeuing is combined. test_and_set_bit() is also replaced with checking under dd->lock. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 47 +++ 1 files changed, 21 insertions(+), 26 deletions(-) diff --git a/driv

[PATCH 3/4] omap-sham: error handling improved

2010-11-10 Thread Dmitry Kasatkin
Introduces DMA error handling. DMA error is returned as a result code of the hash request. Clients needs to handle error codes and may repeat hash calculation attempt. Also in the case of DMA error, SHAM module is set to be re-initialized again. It significantly improves stability against possibl

[PATCH 2/4] omap-sham: DMA initialization fixes for off mode

2010-11-10 Thread Dmitry Kasatkin
DMA parameters for constant data were initialized during driver probe(). It seems that those settings sometimes are lost when devices goes to off mode. This patch makes DMA initialization just before use. It solves off mode problems. Fixes: NB#202786 - Aegis & SHA1 block off mode changes Signed-o

[PATCH 0/4]v2 omap-sham off mode and error handling fixes.

2010-11-10 Thread Dmitry Kasatkin
Please ignore previous patch set. Some old patches appeared there... Dmitry Kasatkin (4): omap-sham: uses digest buffer in request context omap-sham: DMA initialization fixes for off mode omap-sham: error handling improved omap-sham: removed redundunt locking drivers/crypto/omap-sham.c |

[PATCH 1/4] omap-sham: uses digest buffer in request context

2010-11-10 Thread Dmitry Kasatkin
Currently driver storred digest results in req->results provided by the client. But some clients do not set it until final() call. It leads to crash. Changed to use internal buffer to store temporary digest results. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 11 ---

Re: [PATCH v3 01/13] OMAP: DMA: Replace read/write macros with functions

2010-11-10 Thread Kevin Hilman
"G, Manjunath Kondaiah" writes: >> -Original Message- >> From: Kevin Hilman [mailto:khil...@deeprootsystems.com] >> Sent: Wednesday, November 10, 2010 9:33 PM >> To: G, Manjunath Kondaiah >> Cc: linux-omap@vger.kernel.org; >> linux-arm-ker...@lists.infradead.org; Cousson, Benoit; >> Sh

Re: BeagleBoard not resuming from uart with latest pm-core ?

2010-11-10 Thread Kevin Hilman
Jean Pihet writes: > l-o is currently broken wrt to suspend and idle. > Solutions are being worked on for the moment. > > Kevin, are there solutions available yet? The solution to your previous problem (ensuring runtime PM transitions work during system PM) is included in my pm-core branch, but

[PATCH 7/7] omap-sham: removed redundunt locking

2010-11-10 Thread Dmitry Kasatkin
Locking for queuing and dequeuing is combined. test_and_set_bit() is also replaced with checking under dd->lock. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 47 +++ 1 files changed, 21 insertions(+), 26 deletions(-) diff --git a/driv

[PATCH 5/7] omap-sham: DMA initialization fixes for off mode

2010-11-10 Thread Dmitry Kasatkin
DMA parameters for constant data were initialized during driver probe(). It seems that those settings sometimes are lost when devices goes to off mode. This patch makes DMA initialization just before use. It solves off mode problems. Fixes: NB#202786 - Aegis & SHA1 block off mode changes Signed-o

[PATCH 6/7] omap-sham: error handling improved

2010-11-10 Thread Dmitry Kasatkin
Introduces DMA error handling. DMA error is returned as a result code of the hash request. Clients needs to handle error codes and may repeat hash calculation attempt. Also in the case of DMA error, SHAM module is set to be re-initialized again. It significantly improves stability against possibl

[PATCH 4/7] omap-sham: uses digest buffer in request context

2010-11-10 Thread Dmitry Kasatkin
Currently driver storred digest results in req->results provided by the client. But some clients do not set it until final() call. It leads to crash. Changed to use internal buffer to store temporary digest results. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 11 ---

[PATCH 2/7] crypto: omap-sham - omap sha1 & md5 driver

2010-11-10 Thread Dmitry Kasatkin
Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. - implements async crypto API using dma and cpu. - supports multiple sham instances if available - hmac - concurrent requests Signed-off-by: Dmitry Kas

[PATCH 3/7] omap-sham: OMAP macros corrected

2010-11-10 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/devices.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index beac46c..79dbf04 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/de

[PATCH 1/7] crypto: updates omap sham device related platform code

2010-11-10 Thread Dmitry Kasatkin
- registration with multi OMAP kernels support - clocks Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-omap2/clock2430_data.c |2 +- arch/arm/mach-omap2/clock3xxx_data.c |2 +- arch/arm/mach-omap2/devices.c

[PATCH 0/7] omap-sham off mode and error handling fixes.

2010-11-10 Thread Dmitry Kasatkin
Dmitry Kasatkin (7): crypto: updates omap sham device related platform code crypto: omap-sham - omap sha1 & md5 driver omap-sham: OMAP macros corrected omap-sham: uses digest buffer in request context omap-sham: DMA initialization fixes for off mode omap-sham: error handling improved

[PATCH 4/5] omap-aes: error handling implementation improved

2010-11-10 Thread Dmitry Kasatkin
Previous version had not error handling. Request could remain uncompleted. Also in the case of DMA error, FLAGS_INIT is unset and accelerator will be initialized again. Buffer size allignment is checked. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 135 ++

[PATCH 5/5] omap-aes: unnecessary code removed

2010-11-10 Thread Dmitry Kasatkin
Key and IV should always be set before AES operation. So no need to check if it has changed or not. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 64 +++- 1 files changed, 16 insertions(+), 48 deletions(-) diff --git a/drivers/crypto/om

[PATCH 3/5] omap-aes: redundant locking is removed

2010-11-10 Thread Dmitry Kasatkin
Submitting request involved double locking for enqueuing and dequeuing. Now it is done under the same lock. FLAGS_BUSY is now handled under the same lock. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 68 1 files changed, 31 insert

[PATCH 1/5] crypto: omap-aes: change in prevention of OCP bus error

2010-11-10 Thread Dmitry Kasatkin
Suggested to use udelay() instead of nop as on the higher core frequencies it might not be enough time. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-a

[PATCH 2/5] omap-aes: DMA initialization fixes for OMAP off mode

2010-11-10 Thread Dmitry Kasatkin
DMA parameters for constant data were initialized during driver probe(). It seems that those settings sometimes are lost when devices goes to off mode. This patch makes DMA initialization just before use. It solves off mode problems. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c |

[PATCH 0/5] omap-aes off mode and error handling fixes

2010-11-10 Thread Dmitry Kasatkin
Dmitry Kasatkin (5): crypto: omap-aes: change in prevention of OCP bus error omap-aes: DMA initialization fixes for OMAP off mode omap-aes: redundant locking is removed omap-aes: error handling implementation improved omap-aes: unnecessary code removed drivers/crypto/omap-aes.c | 269 +

RE: [PATCH v3 10/13] OMAP: DMA: Convert DMA library into DMA platform Driver

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 9:54 PM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, Benoit; > Shilimkar, Santosh > Subject: Re: [PATCH

RE: [PATCH v3 01/13] OMAP: DMA: Replace read/write macros with functions

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 9:33 PM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, Benoit; > Shilimkar, Santosh > Subject: Re: [PATCH

Re: [PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition

2010-11-10 Thread Grant Likely
On Wed, Nov 10, 2010 at 9:41 AM, Gregory CLEMENT wrote: > On 11/10/2010 04:57 PM, Grant Likely wrote: >> >> On Wed, Nov 10, 2010 at 11:32:59AM +0100, Gregory CLEMENT wrote: >>> >>> When SPI wake up from OFF mode, CS is in the wrong state: force it >>> to the inactive state. >>> >>> During the syst

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Hari Kanigeri
Benoit, Thanks for your comments. On Wed, Nov 10, 2010 at 10:40 AM, Cousson, Benoit wrote: > Hi Hari, > > On 11/10/2010 1:45 PM, Hari Kanigeri wrote: >> >> Thanks to Rene Sapiens and Omar Ramirez for their inputs on initial patch >> set. >> http://www.mail-archive.com/linux-omap@vger.kernel.org/

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Cousson, Benoit
Hari, I forgot one comment. Since this series is a v2, every patches subject should contain the [PATCH v2 x/6]. FYI, patchwork will not track the cover letter, so we will miss that version information in the real patches. I forgot as well this subject: mailbox: change full flag per mail

Re: [PATCH 3/6] omap:mailbox-fix checkpatch warnings

2010-11-10 Thread Sergei Shtylyov
Hello. Hari Kanigeri wrote: Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c in

Re: [PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition

2010-11-10 Thread Gregory CLEMENT
On 11/10/2010 04:57 PM, Grant Likely wrote: On Wed, Nov 10, 2010 at 11:32:59AM +0100, Gregory CLEMENT wrote: When SPI wake up from OFF mode, CS is in the wrong state: force it to the inactive state. During the system life, I monitored the CS behavior using a oscilloscope. I also activated debug

Re: [PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Cousson, Benoit
Hi Hari, On 11/10/2010 1:45 PM, Hari Kanigeri wrote: Thanks to Rene Sapiens and Omar Ramirez for their inputs on initial patch set. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg37278.html The patch set addresses the following review comments from Rene and Omar. http://www.mail-arch

Re: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature

2010-11-10 Thread Kevin Hilman
"G, Manjunath Kondaiah" writes: [...] >> > + if (omap_type() == OMAP3430_REV_ES1_0) >> > + SET_DMA_ERRATA(DMA_ERRATA_i88); >> > + >> > + /* >> > + * Errata 3.2/3.3: sometimes 0 is returned if CSAC/CDAC is >> >> This doesn't look like a unique errata identifier. Chapter 3 >> is us

Re: [PATCH v3 10/13] OMAP: DMA: Convert DMA library into DMA platform Driver

2010-11-10 Thread Kevin Hilman
"G, Manjunath Kondaiah" writes: >> -Original Message- >> From: Kevin Hilman [mailto:khil...@deeprootsystems.com] >> Sent: Wednesday, November 10, 2010 3:56 AM >> To: G, Manjunath Kondaiah >> Cc: linux-omap@vger.kernel.org; >> linux-arm-ker...@lists.infradead.org; Cousson, Benoit; >> Sh

Re: [PATCH v3 13/13] OMAP: PM: DMA: Enable runtime pm

2010-11-10 Thread Kevin Hilman
"G, Manjunath Kondaiah" writes: >> "G, Manjunath Kondaiah" writes: >> >> > Enable runtime pm and use pm_runtime_get and pm_runtime_put >> > for OMAP DMA driver. >> > >> > Signed-off-by: G, Manjunath Kondaiah >> > Cc: Benoit Cousson >> > Cc: Kevin Hilman >> > Cc: Santosh Shilimkar >> > --- >

Re: BeagleBoard not resuming from uart with latest pm-core ?

2010-11-10 Thread Jean Pihet
Hi Thomas, l-o is currently broken wrt to suspend and idle. Solutions are being worked on for the moment. Kevin, are there solutions available yet? Regards, Jean On Wed, Nov 10, 2010 at 4:44 PM, Thomas Petazzoni wrote: > Hello, > > I've updated my tree to the last pm-core branch today (I'm at

Re: [PATCH v3 01/13] OMAP: DMA: Replace read/write macros with functions

2010-11-10 Thread Kevin Hilman
"G, Manjunath Kondaiah" writes: [...] >> > + if (reg > OMAP1_CH_COMMON_START) >> > + __raw_writew(val, dma_base + >> > + (reg_map_omap1[reg] + 0x40 * lch)); >> > + else >> > + __raw_writew(val, dma_base + >> reg_map_om

Re: [PATCH v2 1/2] spi: Add hook on suspend/resume for spi master

2010-11-10 Thread Grant Likely
On Wed, Nov 10, 2010 at 11:32:54AM +0100, Gregory CLEMENT wrote: > Some spi masters need to do some actions when system is going to suspend > or when it will be resumed. > Spi driver offer possibility to handle suspend and resume only for device. > Spi master will do its suspend actions after the d

Re: [PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition

2010-11-10 Thread Grant Likely
On Wed, Nov 10, 2010 at 11:32:59AM +0100, Gregory CLEMENT wrote: > When SPI wake up from OFF mode, CS is in the wrong state: force it > to the inactive state. > > During the system life, I monitored the CS behavior using a > oscilloscope. I also activated debug in omap2_mcspi, so I saw when > driv

BeagleBoard not resuming from uart with latest pm-core ?

2010-11-10 Thread Thomas Petazzoni
Hello, I've updated my tree to the last pm-core branch today (I'm at commit 42289e226ec996a13ab8a2aaef5ad9dda61ee57e), and I've built the omap2plus_defconfig with no change (except adding an initramfs). On my BeagleBoard, I enable the wakeup from UART in /sys/devices/platform/omap/omap-hsuart.2/tt

Re: [PATCH V3 1/2] input: CMA3000 Accelerometer driver

2010-11-10 Thread Hemanth V
- Original Message - From: "Murphy, Dan" +static ssize_t cma3000_store_attr_grange(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct platform_device *pdev = to_plat

Re: [PATCH 1/3] OMAP: DSS2: Add generic DPI panel display driver

2010-11-10 Thread Tomi Valkeinen
Hi, On Tue, 2010-11-09 at 18:12 +0100, ext Bryan Wu wrote: > Generic DPI panel driver includes the driver and 4 similar panel > configurations. It > will match the panel name which is passed from platform data and setup the > right configurations. > > With generic DPI panel driver, we can remove

RE: [PATCH v3 00/13] OMAP: DMA: hwmod and DMA as platform device

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 4:42 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, Benoit; > Shilimkar, Santosh > Subject: Re: [PATCH

RE: [PATCH v3 10/13] OMAP: DMA: Convert DMA library into DMA platform Driver

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 4:59 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, Benoit; > Shilimkar, Santosh > Subject: Re: [PATCH v

RE: [PATCH v3 10/13] OMAP: DMA: Convert DMA library into DMA platform Driver

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 3:56 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, Benoit; > Shilimkar, Santosh > Subject: Re: [PATCH

RE: [PATCH v3 13/13] OMAP: PM: DMA: Enable runtime pm

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: linux-omap-ow...@vger.kernel.org > [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Kevin Hilman > Sent: Wednesday, November 10, 2010 4:18 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson,

RE: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 3:43 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Peter Ujfalusi; > Cousson, Benoit; Shilimkar, Santosh > Subj

RE: [PATCH v3 08/13] OMAP1: DMA: Introduce DMA driver as platform device

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 3:54 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, Benoit; > Shilimkar, Santosh > Subject: Re: [PATCH

RE: [PATCH v3 01/13] OMAP: DMA: Replace read/write macros with functions

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Wednesday, November 10, 2010 3:08 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, Benoit; > Shilimkar, Santosh > Subject: Re: [PATCH

RE: [PATCH v4 01/13] OMAP: DMA: Replace read/write macros with functions

2010-11-10 Thread G, Manjunath Kondaiah
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, November 09, 2010 6:11 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, Benoit; Kevin > Hilman; Shilimkar, Santosh > Subject: Re: [PATC

Re: [PATCH v5 2/3] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish

2010-11-10 Thread Adrian Hunter
On 05/10/10 09:45, Peter Ujfalusi wrote: Implement the suggested workaround for OMAP3 regarding to sDMA draining issue, when the channel is disabled on the fly. This errata affects the following configuration: sDMA transfer is source synchronized Buffering is enabled SmartStandby is selected. Th

Re: [PATCH v5 2/3] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish

2010-11-10 Thread Adrian Hunter
On 05/10/10 09:45, Peter Ujfalusi wrote: Implement the suggested workaround for OMAP3 regarding to sDMA draining issue, when the channel is disabled on the fly. This errata affects the following configuration: sDMA transfer is source synchronized Buffering is enabled SmartStandby is selected. Th

RE: Mistral AM37x (with AM3715) devel board networking broken

2010-11-10 Thread Premi, Sanjeev
> -Original Message- > From: linux-omap-ow...@vger.kernel.org > [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Gadiyar, Anand > Sent: Tuesday, November 09, 2010 10:32 AM > To: Rick Bronson > Cc: linux-omap@vger.kernel.org; Premi, Sanjeev > Subject: Re: Mistral AM37x (with AM3715) d

RE: Mistral AM37x (with AM3715) devel board networking broken

2010-11-10 Thread Premi, Sanjeev
> -Original Message- > From: Rick Bronson [mailto:r...@efn.org] > Sent: Tuesday, November 09, 2010 10:24 AM > To: linux-omap@vger.kernel.org > Cc: Premi, Sanjeev > Subject: RE: Mistral AM37x (with AM3715) devel board networking broken > > Hi Sanjeev, > > Thanks much for the help. > >

Re: [PATCH 1/3] OMAP: VRAM: improve VRAM error prints

2010-11-10 Thread Paul Mundt
On Wed, Nov 10, 2010 at 11:45:18AM +0200, Tomi Valkeinen wrote: > Improve the error prints to give more information about the offending > address & size. > > Signed-off-by: Tomi Valkeinen 1-3 queued for .37, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the

[PATCH v2 1/2] spi: Add hook on suspend/resume for spi master

2010-11-10 Thread Gregory CLEMENT
Some spi masters need to do some actions when system is going to suspend or when it will be resumed. Spi driver offer possibility to handle suspend and resume only for device. Spi master will do its suspend actions after the devices and will do its resume action before the devices. Signed-off-by:

[PATCH v2 0/2] Put the OMAP2 SPI CS in inactive state when returning from suspend

2010-11-10 Thread Gregory CLEMENT
We notice that when system wake up from OFF mode, then CS is in inactive state until the first SPI transfer. For our design it lead to some conflict on this I/O. Inactive state for CS when there is no transfer should be the correct behavior: this is the purpose of these patches. * Change from

[PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition

2010-11-10 Thread Gregory CLEMENT
When SPI wake up from OFF mode, CS is in the wrong state: force it to the inactive state. During the system life, I monitored the CS behavior using a oscilloscope. I also activated debug in omap2_mcspi, so I saw when driver disable the clocks and restore context when device is not used. Each

Re: [PATCH 1/3] OMAP: VRAM: improve VRAM error prints

2010-11-10 Thread Paul Mundt
On Wed, Nov 10, 2010 at 02:04:14PM +0200, Tomi Valkeinen wrote: > On Wed, 2010-11-10 at 12:51 +0100, ext Paul Mundt wrote: > > On Wed, Nov 10, 2010 at 11:45:18AM +0200, Tomi Valkeinen wrote: > > > Improve the error prints to give more information about the offending > > > address & size. > > > > >

Re: [PATCH 1/3] OMAP: VRAM: improve VRAM error prints

2010-11-10 Thread Tomi Valkeinen
On Wed, 2010-11-10 at 12:51 +0100, ext Paul Mundt wrote: > On Wed, Nov 10, 2010 at 11:45:18AM +0200, Tomi Valkeinen wrote: > > Improve the error prints to give more information about the offending > > address & size. > > > > Signed-off-by: Tomi Valkeinen > > 1-3 queued for .37, thanks. They wer

[PATCH 5/6] omap:mailbox-add notification support for multiple readers

2010-11-10 Thread Hari Kanigeri
In the current mailbox driver, the mailbox internal pointer for callback can be directly manipulated by the Users, so a second User can easily corrupt the first user's callback pointer. The initial effort to correct this issue can be referred here: https://patchwork.kernel.org/patch/107520/ Along

[PATCH 1/6] mailbox: change full flag per mailbox queue instead of global

2010-11-10 Thread Hari Kanigeri
From: Fernando Guzman Lugo As pointed by Ohad Ben-Cohen, the variable rq_full flag is a global variable, so if there are multiple mailbox users there will be conflics. Now there is a full flag per mailbox queue. Version 2: - Rebase to the latest. Version 3: - Remove spin_lock protection. When th

[PATCH 4/6] omap:mailbox-send message in process context

2010-11-10 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full and there are pending messages in kifo, else send the message directly in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri --- arch/arm/plat-omap/mailbox.c |

[PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Hari Kanigeri
Thanks to Rene Sapiens and Omar Ramirez for their inputs on initial patch set. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg37278.html The patch set addresses the following review comments from Rene and Omar. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg37626.html https:/

[PATCH 3/6] omap:mailbox-fix checkpatch warnings

2010-11-10 Thread Hari Kanigeri
Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 9ce3570..ed960c1 100644 --- a/ar

[PATCH 2/6] omap:mailbox: fix rx interrupt disable in omap4

2010-11-10 Thread Hari Kanigeri
disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Signed-off-by: Hari Kanigeri --- arch/arm/mach-omap2/mailbox.c |5 - 1 files changed, 4 insertions(+), 1 deleti

[PATCH 6/6] omap:clocks44x-add dummy clock for mailbox

2010-11-10 Thread Hari Kanigeri
In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver backward compatible with previous omaps. Signed-off-by: Hari Kanigeri --- arch/arm/mach-omap2/clock44xx_data.c |1 + 1 files changed, 1 ins

[PATCH 2/3] OMAP: VRAM: Fix boot-time memory allocation

2010-11-10 Thread Tomi Valkeinen
Use memblock_free() and memblock_remove() to remove the allocated or reserved VRAM area from normal kernel memory. This is a slightly modified version of patches from Felipe Contreras and Namhyung Kim. Reported-by: Felipe Contreras Reported-by: Namhyung Kim Signed-off-by: Tomi Valkeinen --- d

[PATCH 1/3] OMAP: VRAM: improve VRAM error prints

2010-11-10 Thread Tomi Valkeinen
Improve the error prints to give more information about the offending address & size. Signed-off-by: Tomi Valkeinen --- drivers/video/omap2/vram.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/vram.c b/drivers/video/omap2/vram.c index fed

[PATCH 3/3] OMAP: DSS: Fix documentation regarding 'vram' kernel parameter

2010-11-10 Thread Tomi Valkeinen
The DSS documentation didn't mention the option to give the VRAM start address. Signed-off-by: Tomi Valkeinen --- Documentation/arm/OMAP/DSS |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/arm/OMAP/DSS b/Documentation/arm/OMAP/DSS index 0af0e9e..888ae

  1   2   >