Re: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

2010-11-26 Thread Måns Rullgård
Hiremath, Vaibhav hvaib...@ti.com writes: -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@nokia.com] Sent: Wednesday, November 24, 2010 10:01 PM To: Hiremath, Vaibhav Cc: Tomi Valkeinen; linux-omap@vger.kernel.org Subject: Re: OMAP:DSS: possible bug in WAITFOR_VSYNC

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Ohad Ben-Cohen
On Fri, Nov 26, 2010 at 6:59 AM, Olof Johansson o...@lixom.net wrote: +#define pr_fmt(fmt)    %s: fmt, __func__ Not used. Yes, it is, check out how the pr_* macros are implemented: #define pr_info(fmt, ...) \ printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) I use it to ensure that the

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-26 Thread Clemens Ladisch
Laurent Pinchart wrote: On Thursday 25 November 2010 10:38:05 Clemens Ladisch wrote: MEDIA_ENTITY_TYPE_NODE_ALSA_PCM MEDIA_ENTITY_TYPE_NODE_ALSA_MIDI MEDIA_ENTITY_TYPE_SUBDEV_ALSA_CONTROL I agree about PCM and MIDI, but I'm not sure about controls. If controls are part of an

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Russell King - ARM Linux
On Fri, Nov 26, 2010 at 10:53:10AM +0200, Ohad Ben-Cohen wrote: +int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned long *flags) +{ +     int ret; + +     if (unlikely(!hwlock)) { +             pr_err(invalid hwlock\n); These kind of errors can get very spammy

RE: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread ext-srikar.1.bhavanarayana
+#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE) The ifdefs here aren't really saving much... In the same file board-rx51-peripheral.c,Under these rx51_display_device is defined as extern and also in board-rx51-video.c the under same #defines Complete display functionality

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Srikar
On 11/25/2010 06:11 PM, ext Mark Brown wrote: On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote: +static struct regulator_consumer_supply rx51_vdac_supply[] = { +{ +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE) The ifdefs here aren't really saving much... Currently

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Ohad Ben-Cohen
On Fri, Nov 26, 2010 at 11:18 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Nov 26, 2010 at 10:53:10AM +0200, Ohad Ben-Cohen wrote: +int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned long *flags) +{ +     int ret; + +     if (unlikely(!hwlock)) {

Re: [PATCH] OMAP: DSS2: Clean up DISPC color mode validation checks

2010-11-26 Thread Tomi Valkeinen
Hi, On Thu, 2010-11-25 at 17:58 +0530, ext Archit Taneja wrote: The supported set of color modes varies for different DISPC pipelines(plane) and omap version. This makes the checks for validation of a color mode more complicated as new omap versions are added. A dss_feature function is

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Russell King - ARM Linux
On Fri, Nov 26, 2010 at 12:16:39PM +0200, Ohad Ben-Cohen wrote: On Fri, Nov 26, 2010 at 11:18 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Nov 26, 2010 at 10:53:10AM +0200, Ohad Ben-Cohen wrote: +int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned

[PATCH] OMAP3_IVA_MASK should use OMAP3_IVA_SHIFT instead of OMAP3_SGX_SHIFT

2010-11-26 Thread Arno Steffen
Signed-off-by: Arno Steffen arno.stef...@googlemail.com --- arch/arm/mach-omap2/control.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h index b6c6b7c..5325297 100644 --- a/arch/arm/mach-omap2/control.h +++

RE: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

2010-11-26 Thread Hiremath, Vaibhav
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Måns Rullgård Sent: Friday, November 26, 2010 2:09 PM To: linux-omap@vger.kernel.org Subject: Re: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl Hiremath, Vaibhav

RE: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

2010-11-26 Thread Hiremath, Vaibhav
-Original Message- From: Hiremath, Vaibhav Sent: Friday, November 26, 2010 5:34 PM To: 'Måns Rullgård'; linux-omap@vger.kernel.org Subject: RE: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-

Re: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

2010-11-26 Thread Ville Syrjälä
On Fri, Nov 26, 2010 at 05:38:11PM +0530, ext Hiremath, Vaibhav wrote: -Original Message- From: Hiremath, Vaibhav Sent: Friday, November 26, 2010 5:34 PM To: 'Måns Rullgård'; linux-omap@vger.kernel.org Subject: RE: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Mark Brown
On Fri, Nov 26, 2010 at 11:56:35AM +0200, Srikar wrote: On 11/25/2010 06:11 PM, ext Mark Brown wrote: On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote: +static struct regulator_consumer_supply rx51_vdac_supply[] = { + { +#if defined(CONFIG_FB_OMAP2) ||

RE: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

2010-11-26 Thread Hiremath, Vaibhav
-Original Message- From: Ville Syrjälä [mailto:ville.syrj...@nokia.com] Sent: Friday, November 26, 2010 6:26 PM To: Hiremath, Vaibhav Cc: Måns Rullgård; linux-omap@vger.kernel.org; linux-fb...@vger.kernel.org Subject: Re: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl On Fri, Nov

Re: OMAP:DSS: possible bug in WAITFOR_VSYNC ioctl

2010-11-26 Thread Felipe Contreras
On Fri, Nov 26, 2010 at 2:55 PM, Ville Syrjälä ville.syrj...@nokia.com wrote: On Fri, Nov 26, 2010 at 05:38:11PM +0530, ext Hiremath, Vaibhav wrote: With this finding, in case of OMAP3 we have to use OMAPFB_WAITFORGO (breaking standard applications). Applications using the standard fbdev API

Re: [RFC/PATCH v6 00/12] Media controller (core and V4L2)

2010-11-26 Thread Laurent Pinchart
Hi Mark, On Thursday 25 November 2010 15:28:04 Mark Brown wrote: On Thu, Nov 25, 2010 at 03:28:07AM +0100, Laurent Pinchart wrote: I want to emphasize that the media controller API does *not* replace the V4L, DVB or ALSA APIs. It complements them. Overall this looks relatively good and

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-11-26 Thread Laurent Pinchart
Hi Mark, On Thursday 25 November 2010 16:49:52 Mark Brown wrote: On Thu, Nov 25, 2010 at 04:40:41PM +0100, Laurent Pinchart wrote: On Thursday 25 November 2010 14:36:50 Mark Brown wrote: On Thu, Nov 25, 2010 at 03:28:10AM +0100, Laurent Pinchart wrote: + MEDIA_LINK_FLAG_ACTIVE

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-11-26 Thread Mark Brown
On Fri, Nov 26, 2010 at 03:13:36PM +0100, Laurent Pinchart wrote: On Thursday 25 November 2010 16:49:52 Mark Brown wrote: On Thu, Nov 25, 2010 at 04:40:41PM +0100, Laurent Pinchart wrote: It's supposed to reflect whether the link can carry data. Think of the active flag as a valve on a

[PATCH 1/7] omap3630: nand: fix device size to work in polled mode

2010-11-26 Thread Sukumar Ghorai
zoom3 and 3630-sdp having the x16 nand device. This patch configure gpmc as x16 and select the currect function in driver for polled mode (without prefetch enable) transfer. Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/board-flash.c |3 +++ 1 files changed, 3

[PATCH 2/7] omap3: nand: configurable transfer type per board

2010-11-26 Thread Sukumar Ghorai
nand transfer type (sDMA, Polled, prefetch) can be select from board file, enabling all transfer type in driver, by default. this helps in multi-omap build and to select different transfer type for different board. Signed-off-by: Sukumar Ghorai s-gho...@ti.com ---

[PATCH v6 0/7] nand prefetch-irq support and ecc layout chanage

2010-11-26 Thread Sukumar Ghorai
The following set of patches applies on linux-2.6. The main motivations behind this patch series are - 1. support NAND I/O in irq mode. 2. support of different ECC schema. 3. also to make ecc layout as like in romcode ecc layout v6: configurable transfer type from board

[PATCH v6 6/7] omap: nand: ecc layout select from board file

2010-11-26 Thread Sukumar Ghorai
This patch makes it possible to select sw or hw (different layout options) ecc scheme supported by omap nand driver. And hw ecc layout selected for sdp and zoom boards, by default. Signed-off-by: Vimal Singh vimalsi...@ti.com Signed-off-by: Sukumar Ghorai s-gho...@ti.com ---

[PATCH v6 5/7] omap3: nand: configurable fifo threshold to gain the throughput

2010-11-26 Thread Sukumar Ghorai
Configure the FIFO THREASHOLD value different for read and write to keep busy both filling and to drain out of FIFO at reading and writing. Signed-off-by: Vimal Singh vimalsi...@ti.com Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/gpmc.c | 11 +++

[PATCH v6 7/7] omap: nand: making ecc layout as compatible with romcode ecc

2010-11-26 Thread Sukumar Ghorai
This patch overrides nand ecc layout and bad block descriptor (for 8-bit device) to support hw ecc in romcode layout. So as to have in sync with ecc layout throughout; i.e. x-loader, u-boot and kernel. This patch also enables to use romcode ecc for spd and zoom, by default. This enables to flash

[PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc

2010-11-26 Thread Sukumar Ghorai
add support the irq mode in GPMC. gpmc_init() function move after omap_init_irq() as it has dependecy on irq. Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/board-2430sdp.c|1 + arch/arm/mach-omap2/board-3430sdp.c|1 +

[PATCH v6 4/7] omap3: nand: prefetch in irq mode support

2010-11-26 Thread Sukumar Ghorai
This patch enable prefetch-irq mode for nand transfer(read, write) Signed-off-by: Vimal Singh vimalsi...@ti.com Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/board-flash.c |3 + arch/arm/plat-omap/include/plat/nand.h |4 +- drivers/mtd/nand/omap2.c

[PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check

2010-11-26 Thread Vasiliy Kulikov
clk_get() returns ERR_PTR() on error, not NULL. Signed-off-by: Vasiliy Kulikov seg...@openwall.com --- Cannot compile this driver, so it is not tested at all. arch/arm/plat-omap/counter_32k.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Inventra Highspeed Dual Role Controller on TI OMAP 3503

2010-11-26 Thread Elvis Dowson
Hi, Is the Inventra Highspeed Dual Role Controller silicon IP available on the TI OMAP 3503? The kernel config help documentation mentions only TI OMAP 353x and I'm not sure if that implies that it isn't present in the TI OMAP 3503 processor. Elvis Dowson -- To unsubscribe from this

Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51

2010-11-26 Thread Tony Lindgren
* Mark Brown broo...@opensource.wolfsonmicro.com [101126 04:50]: On Fri, Nov 26, 2010 at 11:56:35AM +0200, Srikar wrote: On 11/25/2010 06:11 PM, ext Mark Brown wrote: On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote: +static struct regulator_consumer_supply rx51_vdac_supply[] = {

RE: [PATCH v6 0/7] nand prefetch-irq support and ecc layout chanage

2010-11-26 Thread Ghorai, Sukumar
Hello Grazvydas Charles, Would you please check this series in you setup and please update the status or any issue you observe? Regards, Ghorai -Original Message- From: Ghorai, Sukumar Sent: Friday, November 26, 2010 9:05 PM To: linux-omap@vger.kernel.org Cc:

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Olof Johansson
On Fri, Nov 26, 2010 at 12:18:49AM -0700, Grant Likely wrote: On Thu, Nov 25, 2010 at 9:59 PM, Olof Johansson o...@lixom.net wrote: On Tue, Nov 23, 2010 at 05:38:57PM +0200, Ohad Ben-Cohen wrote: +#define pr_fmt(fmt)    %s: fmt, __func__ Not used. pr_fmt() is a magic #define that

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Ohad Ben-Cohen
On Fri, Nov 26, 2010 at 12:45 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Nov 26, 2010 at 12:16:39PM +0200, Ohad Ben-Cohen wrote: On Fri, Nov 26, 2010 at 11:18 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Nov 26, 2010 at 10:53:10AM +0200, Ohad

Re: [PATCH ver. 3] PM: add synchronous runtime interface for interrupt handlers

2010-11-26 Thread Rafael J. Wysocki
On Thursday, November 25, 2010, Alan Stern wrote: This patch (as1431c) makes the synchronous runtime-PM interface suitable for use in interrupt handlers. Subsystems can call the new pm_runtime_irq_safe() function to tell the PM core that a device's runtime_suspend and runtime_resume callbacks

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Russell King - ARM Linux
On Sat, Nov 27, 2010 at 12:18:55AM +0200, Ohad Ben-Cohen wrote: But then there's the other (quite reasonable) claim that says we shouldn't crash the machine because of a non fatal bug: if a crappy driver messes up, the user (not the developer) will most probably prefer the machine to keep

[PATCH] omap: zoom: wl1271 slot is MMC_CAP_POWER_OFF_CARD

2010-11-26 Thread Ohad Ben-Cohen
This patch complements ed919b0 mmc: sdio: fix runtime PM anomalies by introducing MMC_CAP_POWER_OFF_CARD by declaring MMC_CAP_POWER_OFF_CARD on the ZOOM's wl1271 mmc slot. This is required in order not to break runtime PM support for the wl1271 sdio driver. Signed-off-by: Ohad Ben-Cohen

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread David Brownell
On Fri, 2010-11-26 at 09:34 +0200, Ohad Ben-Cohen wrote: On Thu, Nov 25, 2010 at 10:22 PM, David Brownell davi...@pacbell.net wrote: So there's no strong reason to think this is actually ggeneric. Function names no longer specify OMAP, but without other hardware under the interface,