On 6/3/2011 4:40 AM, Kevin Hilman wrote:
Santosh Shilimkarsantosh.shilim...@ti.com writes:
Current OMAP2PLUS CPUfreq tagret() functions returns when all
the CPU's are not online. This will break DVFS when secondary
CPUs are offlined.
The intention of that check was just avoid CPU frequency
On Fri, Jun 03, 2011 at 02:12:47AM +0200, Laurent Pinchart wrote:
Hi Russell,
On Wednesday 01 June 2011 16:03:06 Russell King - ARM Linux wrote:
On Wed, Jun 01, 2011 at 03:50:50PM +0200, Laurent Pinchart wrote:
In the specific iovmm case, the driver uses the sglist API to build a
list
On 6/3/2011 8:14 AM, Menon, Nishanth wrote:
On Thu, Jun 2, 2011 at 09:51, Santosh Shilimkar
santosh.shilim...@ti.com wrote:
Current OMAP2PLUS CPUfreq tagret() functions returns when all
the CPU's are not online. This will break DVFS when secondary
CPUs are offlined.
The intention of that
* Peter Ujfalusi peter.ujfal...@ti.com [110602 09:11]:
On Wednesday 01 June 2011 16:38:23 Tony Lindgren wrote:
But you could easily remove all the board specific struct
twl4030_codec_data and struct twl4030_codec_audio_data entries by adding a
default audio init option to omap_pmic_init for
On 6/3/2011 11:56 AM, Santosh Shilimkar wrote:
On 6/3/2011 4:40 AM, Kevin Hilman wrote:
Santosh Shilimkarsantosh.shilim...@ti.com writes:
Current OMAP2PLUS CPUfreq tagret() functions returns when all
the CPU's are not online. This will break DVFS when secondary
CPUs are offlined.
The
On Fri, Jun 3, 2011 at 3:12 AM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Russell,
On Wednesday 01 June 2011 16:03:06 Russell King - ARM Linux wrote:
On Wed, Jun 01, 2011 at 03:50:50PM +0200, Laurent Pinchart wrote:
In the specific iovmm case, the driver uses the sglist
Hi,
This patch set implements runtime PM adaptation for OMAP DSS driver.
The bulk of the code is in the OMAP: DSS2: Use PM runtime HWMOD support
patch, which is a bit too large for comfort, but I haven't found out ways to
split it up.
All DSS HW modules now handle enabling and disabling of the
get_context_loss_count functions return context loss count as u32, and
zero means an error. However, zero is also returned when context has
never been lost and could also be returned when the context loss count
has wrapped and goes to zero.
Change the functions to return an int, with negative
If ULPS exit fails, and the following reset fails also, Taal driver was
left in state where it thinks DSI is enabled while it really isn't,
leading to crash.
This patch checks the return value of taal_panel_reset, and if that
fails, ulps_enabled is left true, causing the driver to retry ulps exit
LANEx_ULPS_SIG2 bits are left on after entering ULPS. This doesn't cause
any problems currently, as DSI HW is reset when it is enabled. However,
if the reset is not done, operation fails if the bits are still set.
So reset the bits after entering ULPS to ensure operation even without
HW reset.
Get and put for dpll4_m4_ck was handled in dss_init/dss_exit. Move the
code to dss_get/put_clocks(), which is a better place to handle it.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
drivers/video/omap2/dss/dss.c | 52
1 files changed, 26
Both dss.c and dsi.c had a probe function, which was almost a dummy one,
calling dss_init() and dsi_init().
Remove the init functions by moving the initialization code into probe
functions.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
drivers/video/omap2/dss/dsi.c | 30 ++---
DSS enables core clocks for the duration of initialization to avoid
unnecessary context saves and restores.
With PM runtime the clocks cannot be handled in this way, outside the
dss module drivers. Thus we need to remove the optimization.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
The initialization order of the DSS modules is important when pm_runtime
support is implemented. Currently RFBI is initialized before DISPC,
which will cause problems with pm_runtime as RFBI uses DISPC.
Change the init order so that DISPC is before RFBI.
Signed-off-by: Tomi Valkeinen
The function to get device's context loss count has changed from
omap_pm_get_last_off_on_transaction_id() to
omap_pm_get_dev_context_loss_count()
Change name of the function pointer in omapdss.h accordingly, and use
the term context loss count instead of context id in the code.
Restructure the
Initialize get_context_loss_count in the DSS board data to
omap_pm_get_dev_context_loss_count, so that omapdss driver can use it.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/display.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git
DSI PLL requires sys_clk to function, and DPI enables sys_clk when it
wants to use DSI PLL. However, DSI PLL code already handles enabling
sys_clk, so DPI's sys_clk code is extra.
Remove the unneeded sys_clk handling from dpi.c.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
OMAP3430 requires an 96MHz clock to VENC's DAC, but no other OMAP needs
it.
Add a new feature, FEAT_VENC_REQUIRES_TV_DAC_CLK, which tells if the
clock is needed on this platform, and use that feature in venc.c to
decide if the clock needs enabling.
Signed-off-by: Tomi Valkeinen
OMAP2 doesn't have CPR, PRELOAD nor FIR_COEF_V registers. Add new
feature definitions for those, and check the feature before accessing
those registers.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
drivers/video/omap2/dss/dispc.c| 145
CONFIG_OMAP2_DSS_SLEEP_BEFORE_RESET is used to avoid an unclear bug at
DSS reset time. The pm runtime will handle reset in the future, and this
code has to be removed. Hopefully we won't see this error anymore.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
Add DSS optional clocks to HWMOD data for OMAP2430.
Cc: Benoit Cousson b-cous...@ti.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git
Add missing DSS optional clocks to HWMOD data for OMAP4xxx.
Add HWMOD_CONTROL_OPT_CLKS_IN_RESET flag for dispc to fix dispc reset.
Cc: Benoit Cousson b-cous...@ti.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 40
Currently dss.c does all the low level clock handling in the DSS, and
thus it contains pointers to all the clocks. This allows dss.c to dump
the clock information for all the clocks.
With pm_runtime this is no longer the case, as each submodule will
handle its clocks independently. Thus remove
Add DSS optional clocks to HWMOD data for OMAP3xxx.
Cc: Benoit Cousson b-cous...@ti.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 37 ++-
1 files changed, 35 insertions(+), 2 deletions(-)
diff --git
Some of the optional clocks for dss_core are not needed. Remove them.
Cc: Benoit Cousson b-cous...@ti.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git
opt_clock_available() is no longer needed, so remove it.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/display.c | 12
include/video/omapdss.h |2 --
2 files changed, 0 insertions(+), 14 deletions(-)
diff --git
dispc.c enables and disables clocks in almost every function to make
sure the clocks are enabled when the function is called. This is rather
unoptimal way to handle the problem.
With pm_runtime other components have to call dispc_runtime_get() to
enable dispc clocks before calling any other dispc
Add DSS optional clocks to HWMOD data for OMAP2420.
Cc: Benoit Cousson b-cous...@ti.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2420_data.c | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git
oh_core variable is no longer used, so it and its initialization can be
removed.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/display.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/arch/arm/mach-omap2/display.c
dss.c only saves 1 register (3 in OMAP3) so the extra overhead from
need_ctx_restore co. is probably bigger than the time spent saving and
restoring those few registers every time.
So remove the code from dss.c and restore context every time dss has
been off.
Signed-off-by: Tomi Valkeinen
omapdss driver now gets the clocks via hwmod opt clocks, so clock
aliases for omapdss_dss are no longer needed.
Cc: Benoit Cousson b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/clock44xx_data.c | 10 +-
1
The current method of saving and restoring the context could cause a
restore before saving, effectively restoring zero values to registers.
Add ctx_valid field to indicate if the saved context is valid and can be
restored.
Also restructure the code to save the ctx_loss_count in save_context(),
The current method of saving and restoring the context could cause a
restore before saving, effectively restoring zero values to registers.
Add ctx_valid field to indicate if the saved context is valid and can be
restored.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
Hi,
On Thu, 2011-06-02 at 20:23 +0530, ext Santosh Shilimkar wrote:
Missed Kevin in cc. :(
Sorry about that.
Original Message
Subject: [PATCH] OMAP2+: CPUfreq: Allow the CPU scaling when secondary
CPUs are offline.
Date: Thu, 2 Jun 2011 20:21:10 +0530
From: Santosh
Kevin,
On Thu, May 26, 2011 at 05:18, Kevin Hilman khil...@ti.com wrote:
Tarun Kanti DebBarma tarun.ka...@ti.com writes:
From: Charulatha V ch...@ti.com
With register offsets now defined for respective OMAP versions
we can get rid of cpu_class_* checks. In addition, organized
common
Fix warnings emitted by some versions of gcc:
drivers/power/twl4030_charger.c:490: warning: overflow in implicit constant
conversion
drivers/power/twl4030_charger.c:498: warning: overflow in implicit constant
conversion
While at it, also fix module_param permissions and a typo in my name.
Nishant,
On 6/3/2011 12:09 PM, Santosh Shilimkar wrote:
On 6/3/2011 8:14 AM, Menon, Nishanth wrote:
On Thu, Jun 2, 2011 at 09:51, Santosh Shilimkar
santosh.shilim...@ti.com wrote:
Current OMAP2PLUS CPUfreq tagret() functions returns when all
the CPU's are not online. This will break DVFS when
On 6/3/2011 2:01 PM, Santosh Shilimkar wrote:
On 6/3/2011 11:56 AM, Santosh Shilimkar wrote:
On 6/3/2011 4:40 AM, Kevin Hilman wrote:
[...]
Can do that as well.
After re-looking at this, seems not straight forward. This check is
not for cpufreqdriver_init time but per-CPU init functions
Current OMAP2PLUS CPUfreq tagret() functions returns when all
the CPU's are not online. This breaks CPUfreq when secondary CPUs
are offlined on SMP system.
The intention of that check was just avoid CPU frequency change
during the window when CPU becomes online but it's cpufreq_init is
not done
Hi Tony,
On 05/31/11 16:04, Tony Lindgren wrote:
* Igor Grinberg grinb...@compulab.co.il [110508 00:17]:
cm-t3730 is basically the same board as cm-t35, but has DM3730 SoC
assembled and therefore some changes are required.
+static void cm_t35_mux_init(void)
+{
+int mux_mode =
On Friday 03 June 2011 11:08:22 Tony Lindgren wrote:
Yeah if it gets big then a separate file is better. Also, if we have
a common init function for twl, then it's easy to add the board specific
device tree initialization to that too and just leave out the calls to
omap_pmic_init from
Varadarajan, Charulatha ch...@ti.com writes:
Kevin,
On Thu, May 26, 2011 at 05:18, Kevin Hilman khil...@ti.com wrote:
Tarun Kanti DebBarma tarun.ka...@ti.com writes:
From: Charulatha V ch...@ti.com
With register offsets now defined for respective OMAP versions
we can get rid of
On Friday 03 June 2011, Ohad Ben-Cohen wrote:
First stab at iommu consolidation:
Hi Ohad,
Great to see your progress here!
- Migrate OMAP's iommu driver to the generic iommu API. With this in hand,
users can now start using the generic iommu layer instead of calling
omap-specific iommu
Tomi Valkeinen tomi.valkei...@ti.com writes:
get_context_loss_count functions return context loss count as u32, and
zero means an error. However, zero is also returned when context has
never been lost and could also be returned when the context loss count
has wrapped and goes to zero.
Tomi Valkeinen tomi.valkei...@ti.com writes:
Use PM runtime and HWMOD support to handle enabling and disabling of DSS
modules.
Each DSS module will have get and put functions which can be used to
enable and disable that module. The functions use pm_runtime and hwmod
opt-clocks to enable the
Nishanth Menon n...@ti.com writes:
Every PMIC has it's own eccentricities, For example, one of the
PMIC has MSB set to 1 for a specific function - voltage enable!
using an hardcoded value specific for TWL when copied over to
such an implementation causes the system to crash as the MSB bit
Hi Nishanth,
Kevin Hilman khil...@ti.com writes:
[...]
So rather than take this patch, I'm just going to fold the following
diff into OMAP3+: VC: abstract out channel configuration in voltdm_b.
I'll also update the changelog noting that the TRM is wrong here in that
it describes CORE as
Hi Kevin,
On Fri, 2011-06-03 at 09:45 -0700, Kevin Hilman wrote:
Tomi Valkeinen tomi.valkei...@ti.com writes:
Use PM runtime and HWMOD support to handle enabling and disabling of DSS
modules.
Each DSS module will have get and put functions which can be used to
enable and disable that
On Wednesday 01 June 2011 16:47:21 Krishnamoorthy, Balaji T wrote:
+int twl6040_reg_read(struct twl6040 *twl6040, unsigned int reg)
+{
+ int ret;
+ u8 val = 0;
+
+ mutex_lock(twl6040-io_mutex);
+ ret = twl_i2c_read_u8(TWL_MODULE_AUDIO_VOICE, val, reg);
Can
omap_nand_platform_data fields 'options', 'gpio_irq', 'nand_setup' and
'dma_channel' are never referenced by the NAND driver, yet various
board files are initializing those fields. This is both incorrect and
confusing, so remove them. This allows to get rid of a global
variable in gpmc-nand.c.
Commit d5ce2b65 omap3630: nand: fix device size to work in polled mode
changed values for .devsize in nand platform data, now we have to pass
NAND_BUSWIDTH_16 instead of '1' to select 16bit NAND.
Update pandora's platform data accordingly, also specify appropriate
transfer type.
Signed-off-by:
On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas nota...@gmail.com wrote:
omap_nand_platform_data fields 'options', 'gpio_irq', 'nand_setup' and
'dma_channel' are never referenced by the NAND driver, yet various
board files are initializing those fields. This is both incorrect and
confusing,
The USB enable GPIO has been in beagleboard xM revision C
The USER button has been moved since beagleboard xM
Also, board specific initialization has been moved to beagle_config struct
and initialized in omap3_beagle_init_rev. Default values in struct are for xMC.
Signed-off-by: Joel A Fernandes
On Sat, Jun 4, 2011 at 12:14 AM, Vimal Singh vimal.neww...@gmail.com wrote:
On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas nota...@gmail.com wrote:
-static int omap2_nand_gpmc_retime(void)
+static int omap2_nand_gpmc_retime(struct omap_nand_platform_data
*gpmc_nand_data)
{
Tomi Valkeinen tomi.valkei...@ti.com writes:
Hi Kevin,
On Fri, 2011-06-03 at 09:45 -0700, Kevin Hilman wrote:
Tomi Valkeinen tomi.valkei...@ti.com writes:
Use PM runtime and HWMOD support to handle enabling and disabling of DSS
modules.
Each DSS module will have get and put
Nishanth Menon n...@ti.com writes:
Patch OMAP3+: VC: abstract out channel configuration abstracts out
VC channel configuration. However, TRM has it's little surprises such
as the following for channel_cfg:
CFG_CHANNEL_SABIT(0)
CFG_CHANNEL_RAV BIT(1)
CFG_CHANNEL_RAC BIT(2)
56 matches
Mail list logo
