Hi Manjunath,
Comments below. I left in a lot of context for the new folks that
I've cc'd (Tony and Kevin).
On Sat, Jul 16, 2011 at 2:07 PM, G, Manjunath Kondaiah wrote:
> On Thu, Jul 14, 2011 at 4:45 AM, Grant Likely
> wrote:
>>> > +static void __init omap3_init(void)
>>> > +{
>>> > +
ps: posting again since my mailer has triggered the mail in html format hence
it does not reach some mailing lists.
Hi Grant,
>
On Thu, Jul 14, 2011 at 4:45 AM, Grant Likely wrote:
>>
>> On Thu, Jul 14, 2011 at 7:06 AM, G, Manjunath Kondaiah
>> wrote:
>> >
>> > The generic board file is create
On Sat, Jul 16, 2011 at 01:45:50PM +0530, Tarun Kanti DebBarma wrote:
> Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync()
> for enabling/disabling clocks appropriately. Remove syscore_ops and
> instead use dev_pm_ops now.
>
...
> @@ -481,6 +483,22 @@ static int omap_gpio_request
On Sat, Jul 16, 2011 at 01:45:45PM +0530, Tarun Kanti DebBarma wrote:
> With register offsets now defined for respective OMAP versions we can get rid
> of cpu_class_* checks. This function now has common initialization code for
> all OMAP versions. Initialization specific to OMAP16xx has been moved
Hello.
On 16-07-2011 3:44, Vikram Pandita wrote:
From: Vikram Pandita
This patch enables the DMA mode1 RX support.
This feature is enabled based on the short_not_ok flag passed from
gadget drivers.
This will result in a thruput performance gain of around
40% for USB mass-storage/mtp use
From: Charulatha V
Use regs->pinctrl field instead of using the macro OMAP1510_GPIO_PIN_CONTROL
Signed-off-by: Charulatha V
---
arch/arm/mach-omap1/gpio15xx.c |1 +
arch/arm/plat-omap/include/plat/gpio.h |1 +
drivers/gpio/gpio-omap.c |8 +++-
3 files chan
Simplify omap2_gpio_prepare_for_idle() and omap2_gpio_resume_after_idle()
by moving most of the stuff to *_pm_runtime_suspend() and *_pm_runtime_resume().
Also, omap_gpio_suspend() and omap_gpio_resume() optimized to operate per
GPIO bank instead of operating on entire list every time.
Signed-off
From: Charulatha V
Even when bank->width is 16, all the OMAP1 registers are 4-byte aligned, so just
use a 4-byte read. The 'enabled' mask is already taking care to mask for bank
width.
Signed-off-by: Charulatha V
Signed-off-by: Tarun Kanti DebBarma
---
drivers/gpio/gpio-omap.c |2 --
1
Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync()
for enabling/disabling clocks appropriately. Remove syscore_ops and
instead use dev_pm_ops now.
Signed-off-by: Charulatha V
Signed-off-by: Tarun Kanti DebBarma
---
drivers/gpio/gpio-omap.c | 100 ++
There is no need to operate on all the banks every time the function is called.
Just operate on the current bank passed by the framework.
Signed-off-by: Tarun Kanti DebBarma
---
drivers/gpio/gpio-omap.c | 53 +
1 files changed, 25 insertions(+), 28 d
From: Charulatha V
The only bank->type (method) used in the OMAP GPIO driver is MPUIO type as they
need to be handled separately. Identify the same using a flag and remove all
METHOD_* macros.
Signed-off-by: Charulatha V
---
arch/arm/mach-omap1/gpio15xx.c |3 +--
arch/arm/mach-omap
From: Charulatha V
In all OMAP1 SoCs, the MPUIO bank width is 16 bits. But, in OMAP7xx,
it is wrongly initialised to 32. Fix this.
Signed-off-by: Charulatha V
---
arch/arm/mach-omap1/gpio7xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap1/gpio7xx
Getting rid of ifdefs within the function by adding register offset intctrl
and associating OMAP_GPIO_INT_CONTROL in respective SoC specific files.
Also, use wkup_status register consistently instead of referring to wakeup
clear and wakeup set register offsets.
Signed-off-by: Charulatha V
Sig
With register offsets now defined for respective OMAP versions we can get rid
of cpu_class_* checks. This function now has common initialization code for
all OMAP versions. Initialization specific to OMAP16xx has been moved within
omap16xx_gpio_init().
Signed-off-by: Tarun Kanti DebBarma
Signed-o
It is not required to use hard-coded offsets any more in context save and
restore functions and instead use the generic offsets which have been correctly
initialized during device registration.
Signed-off-by: Tarun Kanti DebBarma
Signed-off-by: Charulatha V
---
arch/arm/mach-omap2/gpio.c
By adding level and edge detection register offsets and then initializing them
correctly according to OMAP versions during device registrations we can now
remove
lot of revision checks in these functions.
Signed-off-by: Tarun Kanti DebBarma
Signed-off-by: Charulatha V
---
arch/arm/mach-omap2/g
From: Charulatha V
mpuio_init() function is defined under #ifdefs. It is required only in case
of MPUIO bank type and only when PM operations are supported by it.
This is applicable only in case of OMAP16xx SoC's MPUIO GPIO bank type.
For all the other cases it is a dummy function. Hence clean up
Wakeup istatus register offset initialized according to OMAP versions
during device registration. Use this to avoid version checks.
Starting with OMAP4, legacy registers should not be used in combination
with the updated regsiters. Use wkup_status register consistently for
all SoCs wherever applica
From: Charulatha V
Remove cpu-is checks while enabling/disabling OMAP GPIO module during a gpio
request/free.
Signed-off-by: Charulatha V
---
arch/arm/mach-omap2/gpio.c |2 +
arch/arm/plat-omap/include/plat/gpio.h |1 +
drivers/gpio/gpio-omap.c | 53
From: Charulatha V
Non-wakeup GPIOs are available only in OMAP2. Avoid cpu_is checks by making
non_wakeup_gpios as part of pdata.
Signed-off-by: Charulatha V
---
arch/arm/mach-omap2/gpio.c |8
arch/arm/plat-omap/include/plat/gpio.h |1 +
drivers/gpio/gpio-omap.c
From: Charulatha V
Modify omap_gpio_prepare_for_idle() & omap_gpio_resume_after_idle() functions
to handle save context & restore context respectively in the OMAP GPIO driver
itself instead of calling these functions from pm specific files.
For this, in gpio_prepare_for_idle(), call *_get_context
From: Charulatha V
The gpio_bank_count is the count of number of GPIO devices in a SoC. Remove this
dependency from the driver by using list. Also remove the dependency on array of
pointers to gpio_bank struct of all GPIO devices.
Signed-off-by: Charulatha V
---
arch/arm/mach-omap1/gpio15xx.c
From: Charulatha V
Currently gpio_context array used to save gpio bank's context, is used only for
OMAP3 architecture. Move gpio_context as part of gpio_bank structure so that it
can be specific to each gpio bank and can be used for any OMAP architecture
Signed-off-by: Charulatha V
---
drivers
From: Charulatha V
In omap3, save/restore context is implemented for GPIO banks 2-6 as GPIO bank1
is in wakeup domain. Instead of identifying bank's power domain by bank id,
use 'loses_context' flag which is filled by pwrdm_can_ever_lose_context()
during dev_init.
For getting the powerdomain poi
From: Charulatha V
The context lost count is modified in omap_sram_idle() path when
pwrdm_post_transition() is called. But pwrdm_post_transition() is called
only after omap_gpio_resume_after_idle() is called. Correct this so that
context lost count is modified before calling omap_gpio_resume_afte
This series is continuation of cleanup of OMAP GPIO driver and fixes.
The cleanup include getting rid of cpu_is_* checks wherever possible,
use of gpio_bank list instead of static array, use of unique platform
specific value associated data member to OMAP platforms to avoid
cpu_is_* checks. The ser
Hello Hemant,
On Wed, 13 Jul 2011, Pedanekar, Hemant wrote:
> Any comments on the hwmod and clock patch sets?
I haven't forgotten about these patches.
Here are a few questions:
- Are there are public documents about what interconnect is used on these
chips? Is it a SonicsMX, an Arteris NOC,
Spot-checking this...
On Fri, 25 Mar 2011, Hemant Pedanekar wrote:
> +static struct clk uart1_fck = {
> + .name = "uart1_fck",
> + .parent = &sysclk10_ck,
> + .ops= &clkops_omap2_dflt,
> + .enable_reg = TI816X_CM_ALWON_UART_0_CLKCTRL,
> + .en
On Fri, 25 Mar 2011, Hemant Pedanekar wrote:
> This patch adds data for various clock domains and power domains in TI816X.
>
> Note that at present this is not exhaustive and need to add missing domains.
>
> Signed-off-by: Hemant Pedanekar
> ---
> arch/arm/mach-omap2/clockdomains816x.h | 167
Hi Paul,
On 7/15/2011 1:03 AM, Paul Walmsley wrote:
cc'ing Patrick
Hi Rajendra, Santosh,
some comments here:
On Wed, 13 Jul 2011, Santosh Shilimkar wrote:
While using clockdomain force wakeup method, not waiting for powerdomain
to be effectively ON may end up locking the clockdomain FSM unt
On 7/15/2011 12:54 AM, Paul Walmsley wrote:
On Wed, 13 Jul 2011, Santosh Shilimkar wrote:
From: Rajendra Nayak
Program all powerdomain target state as ON; This is to
prevent domains from hitting low power states (if bootloader
has target states set to something other than ON) and potentially
e
31 matches
Mail list logo
