Re: [RFC/PATCH 6/7] OMAP: omap_device: device register functions now take platform_device pointer

2011-07-22 Thread Grant Likely
On Thu, Jul 21, 2011 at 04:52:17PM -0700, Kevin Hilman wrote: The internal device register functions do not need or use any omap_device internals, so pass in a platform_device pointer instead of an omap_device pointer. Signed-off-by: Kevin Hilman khil...@ti.com FWIW, all 6 of these cleanups

Offline for next few weeks

2011-07-22 Thread Tony Lindgren
Hi all, FYI, now that the merge window is open, I'll be offline for a few weeks as soon as possible. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2] MTD: Nand: use MTD_NAND_OMAP2 for OMAP4

2011-07-22 Thread Artem Bityutskiy
On Wed, 2011-07-20 at 09:28 +0200, Jan Weitzel wrote: use MTD_NAND_OMAP2 also for OMAP4 arch. testes wit omap4430 Signed-off-by: Jan Weitzel j.weit...@phytec.de --- v2: add menuconfig description Pushed to l2-mtd-2.6.git, thanks. -- Best Regards, Artem Bityutskiy -- To unsubscribe from

Re: [PATCH] OMAP: omap_device: replace _find_by_pdev() with to_omap_device()

2011-07-22 Thread Felipe Balbi
On Thu, Jul 21, 2011 at 04:52:11PM -0700, Kevin Hilman wrote: The omap_device layer currently has two ways of getting an omap_device pointer from a platform_device pointer. Replace current usage of _find_by_pdev() with to_omap_device() since to_omap_device() is more familiar to the existing

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-22 Thread Felipe Balbi
Hi, On Thu, Jul 21, 2011 at 04:52:13PM -0700, Kevin Hilman wrote: Board code should not touch omap_device internals. To get the MPU/IVA devices, use existing APIs: omap2_get_mpu_device(), omap2_get_iva_device(). Signed-off-by: Kevin Hilman khil...@ti.com ---

Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices

2011-07-22 Thread Felipe Balbi
On Thu, Jul 21, 2011 at 04:52:14PM -0700, Kevin Hilman wrote: For converting from struct device to platform_device, and from platform_device to struct device, there are existing macros. Use them instead of manual use of container_of(). Signed-off-by: Kevin Hilman khil...@ti.com ---

Re: [PATCH 2/2] OMAP2+: PM: SR: add suspend/resume handlers

2011-07-22 Thread Felipe Balbi
Hi, On Fri, Jul 22, 2011 at 12:55:53AM -0500, Nishanth Menon wrote: Suspend and Resume paths are safe enough to do it in the standard LDM suspend/resume handlers where one can sleep. Add suspend/resume handlers for SmartReflex. Signed-off-by: Nishanth Menon n...@ti.com ---

RE: [RFC PATCHv5 1/7] HSI: hsi: Introducing HSI framework

2011-07-22 Thread Carlos Chinea
Hi Sjur, Sorry for the long delay. My comments below: On Tue, 2011-06-28 at 15:05 +0200, ext Sjur BRENDELAND wrote: -- cut-- Will multiple read queued operations result in chained DMA operations, or single read operations? Well, it is up to you, but my initial idea is that the

Re: [RFC PATCHv5 1/7] HSI: hsi: Introducing HSI framework

2011-07-22 Thread Felipe Balbi
Hi, On Fri, Jul 22, 2011 at 01:43:36PM +0300, Carlos Chinea wrote: +/** + * hsi_flush - Flush all pending transactions on the client's port + * @cl: Pointer to the HSI client + * + * This function will destroy all pending hsi_msg in the port and reset + * the HW port so

Re: [RFC PATCHv5 1/7] HSI: hsi: Introducing HSI framework

2011-07-22 Thread Carlos Chinea
Hi Felipe, :) On Fri, 2011-07-22 at 14:01 +0300, ext Felipe Balbi wrote: Hi, On Fri, Jul 22, 2011 at 01:43:36PM +0300, Carlos Chinea wrote: +/** + * hsi_flush - Flush all pending transactions on the client's port + * @cl: Pointer to the HSI client + * + * This

Re: [RFC PATCHv5 1/7] HSI: hsi: Introducing HSI framework

2011-07-22 Thread Felipe Balbi
Hi, On Fri, Jul 22, 2011 at 02:51:12PM +0300, Carlos Chinea wrote: Hi Felipe, hello there :-) are you already using pm_runtime ? You could put that logic grouped in runtime_suspend()/runtime_resume() calls and from the driver, just call pm_runtime_put()/pm_runtime_get_sync() whenever

Re: [PATCH] arm: omap: usb: clock enable typo fix in usbhs driver

2011-07-22 Thread Felipe Balbi
Hi, On Tue, Jul 19, 2011 at 07:41:43PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com $SUBJECT is quite weird. First, this is not a patch on arch/arm/*omap*/ so arm: omap: is already wrong. Also, enable typo fix is quite werid. Something like: mfd: omap-usb-host:

Re: [PATCH] arm: omap: usb: clock enable typo fix in usbhs driver

2011-07-22 Thread Munegowda, Keshava
On Fri, Jul 22, 2011 at 5:52 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Jul 19, 2011 at 07:41:43PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com $SUBJECT is quite weird. First, this is not a patch on arch/arm/*omap*/ so arm: omap: is already wrong.

Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1

2011-07-22 Thread Kishore Kadiyala
On Fri, Jul 22, 2011 at 12:59 AM, Bryan Buckley bryan.buck...@ti.com wrote: Remove OMAP4_USBC1_ICUSB_PWRDNZ_MASK during enable/disable PWRDNZ mode for MMC1_PBIAS and associated extended-drain MMC1 I/O cell. This is in accordance with the control module programming guide. This fixes a bug where

Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices

2011-07-22 Thread Sergei Shtylyov
Hello. On 22-07-2011 3:52, Kevin Hilman wrote: For converting from struct device to platform_device, and from platform_device to struct device, You mean from platform_device to omap_device? there are existing macros. Use them instead of manual use of container_of(). Signed-off-by:

Re: [RFC PATCHv5 1/7] HSI: hsi: Introducing HSI framework

2011-07-22 Thread Carlos Chinea
On Fri, 2011-07-22 at 15:05 +0300, ext Felipe Balbi wrote: Hi, On Fri, Jul 22, 2011 at 02:51:12PM +0300, Carlos Chinea wrote: Hi Felipe, hello there :-) are you already using pm_runtime ? You could put that logic grouped in runtime_suspend()/runtime_resume() calls and from the

[PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()

2011-07-22 Thread Keshava Munegowda
From: Keshava Munegowda keshava_mgo...@ti.com usbhs_disable function was invoking clk_enable() instead of clk_disable(), thus only increasing the clock usage counter and preventing this particular clock from being ever turned off. Because of this, the power domain of omap4 the USB Host subsystem

Re: [PATCH] OMAP: omap_device: replace pr_* prints with dev_*

2011-07-22 Thread Grazvydas Ignotas
On Thu, Jul 21, 2011 at 8:39 PM, Kevin Hilman khil...@ti.com wrote:                if (act_lat odpl-activate_lat) {                        odpl-activate_lat_worst = act_lat;                        if (odpl-flags OMAP_DEVICE_LATENCY_AUTO_ADJUST) {                                

Re: [PATCH 2/2] OMAP2+: PM: SR: add suspend/resume handlers

2011-07-22 Thread Menon, Nishanth
On Fri, Jul 22, 2011 at 04:13, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Jul 22, 2011 at 12:55:53AM -0500, Nishanth Menon wrote: Suspend and Resume paths are safe enough to do it in the standard LDM suspend/resume handlers where one can sleep. Add suspend/resume handlers for SmartReflex.

[PATCH 1/2] of: address: use resource_size helper

2011-07-22 Thread Felipe Balbi
that should be the approved way of calculating the size of resources. No functional changes. Cc: Grant Likely grant.lik...@secretlab.ca Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/of/address.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/of/address.c

[PATCH 2/2] arm: omap: mark dt_compat __initconst

2011-07-22 Thread Felipe Balbi
we have a special section for const data which is only needed during init, that's __initconst. Use that instead of __initdata which is for non-const data. Cc: Grant Likely grant.lik...@secretlab.ca Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/mach-omap2/board-igep0020.c|2 +-

Re: [PATCH] OMAP: omap_device: replace pr_* prints with dev_*

2011-07-22 Thread Kevin Hilman
Grazvydas Ignotas nota...@gmail.com writes: On Thu, Jul 21, 2011 at 8:39 PM, Kevin Hilman khil...@ti.com wrote:                if (act_lat odpl-activate_lat) {                        odpl-activate_lat_worst = act_lat;                        if (odpl-flags OMAP_DEVICE_LATENCY_AUTO_ADJUST) {

Re: [PATCH 2/2] OMAP2+: PM: SR: add suspend/resume handlers

2011-07-22 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Suspend and Resume paths are safe enough to do it in What is 'it' ? the standard LDM suspend/resume handlers where one can sleep. Add suspend/resume handlers for SmartReflex. Minor comments on the code below, but this changelog doesn't read well, or at

Re: [PATCH 1/2] OMAP3+: PM: SR: use put_sync_suspend for disabling

2011-07-22 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: From: Colin Cross ccr...@google.com omap_sr_disable_reset_volt is called with irqs off in omapx_enter_sleep, as part of idle sequence, this eventually calls sr_disable and pm_runtime_put_sync. pm_runtime_put_sync calls rpm_idle, which will enable

Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices

2011-07-22 Thread Kevin Hilman
Hi Sergei, Sergei Shtylyov sshtyl...@mvista.com writes: On 22-07-2011 3:52, Kevin Hilman wrote: For converting from struct device to platform_device, and from platform_device to struct device, You mean from platform_device to omap_device? Yes indeed, thanks. Updated patch below (only

[RFC/PATCH] PM / Runtime: allow _put_sync() from interrupts-disabled context

2011-07-22 Thread Kevin Hilman
Currently the use of pm_runtime_put_sync() is not safe from interrupts-disabled context because rpm_idle() will release the spinlock and enable interrupts for the idle callbacks. This enables interrupts during a time where interrupts were expected to be disabled, and can have strange side effects

[RFC/PATCH v2] PM / Runtime: allow _put_sync() from interrupts-disabled context

2011-07-22 Thread Kevin Hilman
Currently the use of pm_runtime_put_sync() is not safe from interrupts-disabled context because rpm_idle() will release the spinlock and enable interrupts for the idle callbacks. This enables interrupts during a time where interrupts were expected to be disabled, and can have strange side effects

[GIT PULL] Power management updates for 3.1

2011-07-22 Thread Rafael J. Wysocki
Hi Linus, Please pull power management updates for 3.1 from: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/suspend-2.6.git for-linus They include: * Introduction of core PM code to support power domains and related modifications of the ARM shmobile platform which is its first user

Re: [PATCHv5 01/11] OMAP: prcm: switch to a chained IRQ handler mechanism

2011-07-22 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Introduce a chained interrupt handler mechanism for the PRCM interrupt, so that individual PRCM event can cleanly be handled by handlers in separate drivers. We do this by introducing PRCM event names, which are then matched to the particular PRCM interrupt

Re: [PATCHv5 04/11] OMAP2+: hwmod: add support for PAD wakeup interrupts

2011-07-22 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: OMAP hwmod now provides a service routine to parse pending wakeup events and to call registered ISR whenever active wakeups are detected. This routine is called directly from PRCM interrupt handler. Signed-off-by: Tero Kristo t-kri...@ti.com Nice! ---

Re: [PATCHv5 01/11] OMAP: prcm: switch to a chained IRQ handler mechanism

2011-07-22 Thread Felipe Balbi
Hi, On Fri, Jul 22, 2011 at 03:58:26PM -0700, Kevin Hilman wrote: [snip] -static irqreturn_t prcm_interrupt_handler (int irq, void *dev_id) -{ - u32 irqenable_mpu, irqstatus_mpu; - int c = 0; - - irqenable_mpu = omap2_prm_read_mod_reg(OCP_MOD, -

Re: [PATCHv5 05/11] TEMP: OMAP3: pm: remove serial resume / idle calls from idle path

2011-07-22 Thread Felipe Balbi
Hi, On Tue, Jul 05, 2011 at 01:27:51PM +0300, Tero Kristo wrote: This is no longer needed as it will be handled within serial driver itself. Signed-off-by: Tero Kristo t-kri...@ti.com isn't this introducing a regression ? Should this, maybe, be merged into next patch ? -- balbi

Re: [PATCH] mfd: twl6030-pwm.c needs MODULE_LICENSE

2011-07-22 Thread Felipe Balbi
Hi, (adding linux-omap to the loop) On Fri, Jul 22, 2011 at 05:17:08PM -0700, Randy Dunlap wrote: From: Randy Dunlap rdun...@xenotime.net twl6030_pwm: module license 'unspecified' taints kernel. Signed-off-by: Randy Dunlap rdun...@xenotime.net Cc: Hemanth V heman...@ti.com FWIW: