Hello Tero,
a few comments on this patch:
On Mon, 25 Jul 2011, Tero Kristo wrote:
> Introduce a chained interrupt handler mechanism for the PRCM
> interrupt, so that individual PRCM event can cleanly be handled by
> handlers in separate drivers. We do this by introducing PRCM event
> names, whic
We may as well fix this potential leak so we don't have to listen to
the static checkers complain.
Signed-off-by: Dan Carpenter
---
Btw. This function returns -EBUSY on success. Was that really what
you want?
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index 432df53..d
Hi,
On Fri, Aug 26, 2011 at 12:21:13PM +0300, Dan Carpenter wrote:
> We may as well fix this potential leak so we don't have to listen to
> the static checkers complain.
>
> Signed-off-by: Dan Carpenter
applied, thanks
--
balbi
signature.asc
Description: Digital signature
* Dan Carpenter | 2011-08-26 12:21:13 [+0300]:
>Btw. This function returns -EBUSY on success. Was that really what
>you want?
At that time yes. The idea was to enable the self-test mode of the core
and let it do transfers forth and back and see if it works. There is
also no off switch. I wasn't
Hi,
On Fri, Aug 26, 2011 at 12:32:40PM +0200, Sebastian Andrzej Siewior wrote:
> * Dan Carpenter | 2011-08-26 12:21:13 [+0300]:
>
> >Btw. This function returns -EBUSY on success. Was that really what
> >you want?
>
> At that time yes. The idea was to enable the self-test mode of the core
> and
On Friday 26 August 2011, David Gibson wrote:
> Seriously, how many times do I have to say it?
>
>
> Using _byname in drivers DOES NOT require adding names to the DT.
>
>
> All it needs is some glue logic to attach names as the device tree is
> read. This is properly thought of as part of the
On Thu, 25 Aug 2011, Arnd Bergmann wrote:
> It's not at all about whether the Linux codein drivers/of supports this
> or not, adding it would be trivial. The point is that it would be
> *wrong* to add it because there already exists a way to identify every
> resource in the device tree and we shou
From: Ravi B
The usb subsystem (usbss) in ti81xx has two musb interfaces. There are three
irqs and three address spaces for usbss, musb0 and musb1 respectively. Created
one hwmod with three irq and memory resources.
Cc: Benoit Cousson
Cc: Keshava Munegowda
Signed-off-by: Ajay Kumar Gupta
Sign
From: Ravi B
Adding musb support in ti814 EVM board file.
Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Ravi B
---
arch/arm/mach-omap2/board-ti8148evm.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-ti8148evm.c
b/arch/arm/m
From: Ravi B
Added musb support for ti816x platform which has two instances of musb
interface and uses CPPI4.1 DMA. The current patch set adds support for
single instance and in PIO mode only.
Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Ravi B
---
arch/arm/mach-omap2/usb-musb.c |3 +++
Adding ti81xx_musb_phy_power() which will be used by musb driver through
its function pointer in board_data.
Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Ravi B
---
arch/arm/mach-omap2/omap_phy_internal.c | 24 +++
arch/arm/plat-omap/include/plat/usb.h | 32 +
From: Ravi B
Adding musb support in ti816 EVM board file.
Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Ravi B
---
arch/arm/mach-omap2/board-ti8168evm.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-ti8168evm.c
b/arch/arm/m
This patch set adds support for musb interface for TI81XX platforms and
are dependent on recent patch series from Hemant Pedanekar at [1] and [2].
TI81XX platform has dual musb instances, uses CPPI4.1 DMA and has built in
usb PHY. The current set of patches supports only the first interface and
in
From: Ravi B
TI81XX platform has two musb interfaces and uses CPPI4.1 DMA engine.
It has builtin USB PHYs as AM35x. The current set of patches adds support
for one instance and only in PIO mode.
Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Ravi B
---
drivers/usb/musb/Kconfig |6 +
d
On Thu, Aug 25, 2011 at 9:26 PM, Guenter Roeck
wrote:
> On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote:
>> On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote:
>> > On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck
>> > wrote:
>> > > On Wed, Aug 24, 2011 at 10:37:12AM -0400, Keerthy
On Wed, Aug 24, 2011 at 01:08:07PM -0400, Ohad Ben-Cohen wrote:
> Ohad Ben-Cohen (7):
> omap: iommu: migrate to the generic IOMMU API
> omap: iommu/iovmm: move to dedicated iommu folder
> omap: iommu: stop exporting local functions
> omap: iommu: PREFETCH_IOTLB cleanup
> omap: iovmm: remo
Hello.
On 26-08-2011 15:11, Ajay Kumar Gupta wrote:
From: Ravi B
Adding musb support in ti816 EVM board file.
Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Ravi B
As far as I know, full name is required in signoff.
---
arch/arm/mach-omap2/board-ti8168evm.c | 15 ++
Hello.
On 26-08-2011 15:11, Ajay Kumar Gupta wrote:
From: Ravi B
Adding musb support in ti814 EVM board file.
Signed-off-by: Ajay Kumar Gupta
Signed-off-by: Ravi B
---
arch/arm/mach-omap2/board-ti8148evm.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
dif
Hi,
>
> On 26-08-2011 15:11, Ajay Kumar Gupta wrote:
>
> > From: Ravi B
>
> > Adding musb support in ti816 EVM board file.
>
> > Signed-off-by: Ajay Kumar Gupta
> > Signed-off-by: Ravi B
>
> As far as I know, full name is required in signoff.
Ok.
>
> > ---
> > arch/arm/mach-omap2/boa
On Fri, Aug 26, 2011 at 2:25 PM, Roedel, Joerg wrote:
> Applied all to arm/omap, thanks Ohad. I also put a commit on-top which
> finished the mutex->spin_lock conversion. Looks like one call-place was
> missed. See attached patch.
>
> commit 4234541f1a64d9dc6d489cf8f614dc01c62360f6
> Author: Joerg
Hello,
During system_wide_suspend pm runtime is disabled.
I.e. __pm_runtime_disable is called from __device_suspend.
Now, if a wakeup interrupt is triggered and the wakeup device irq handler
is called even before device_resume and pm_runtime_enable happens,
the device irq_handler proceeds to enabl
On Friday 26 August 2011 01:53 AM, Kevin Hilman wrote:
Santosh writes:
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote:
From: Charulatha V
Currently gpio_context array used to save gpio bank's context, is used only for
OMAP3 architecture. Move gpio_context as part of gpio_ban
On 8/26/2011 12:58 PM, Arnd Bergmann wrote:
On Friday 26 August 2011, David Gibson wrote:
Seriously, how many times do I have to say it?
[...]
Insisting that the names come from the DT is to mistakenly think of
the DT as an extension of the kernel's internal interfaces, instead of
as the ext
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
Add device name to OMAP2 dmtimer fclk nodes so that the fclk nodes can be
retrieved by doing a clk_get with the corresponding device pointers or
device names.
Signed-off-by: Tarun Kanti DebBarma
Acked-by: Cousson, Benoit
---
Looks go
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
From: Thara Gopinath
Convert OMAP1 dmtimers into a platform devices and then registers with
device model framework so that it can be bound to corresponding driver.
Signed-off-by: Thara Gopinath
Signed-off-by: Tarun Kanti DebBarma
Acke
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
Add routines to converts dmtimers to platform devices. The device data
is obtained from hwmod database of respective platform and is registered
to device model after successful binding to driver.
In addition, capability attribute of eac
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
Add dmtimer platform driver functions which include:
(1) platform driver initialization
(2) driver probe function
(3) driver remove function
Signed-off-by: Tarun Kanti DebBarma
Signed-off-by: Thara Gopinath
Acked-by: Cousson, Benoit
--
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
Register timer devices by going through hwmod database using
hwmod API. The driver probes each of the registered devices.
Functionality which are already performed by hwmod framework
are removed from timer code. New set of timers presen
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
OMAP4 has two groups of timers: version 1 timers are 1, 2, 10,
while the rest of the timers, 3-9, 11 are version 2 timers.
The version information is required by the driver so that they
could be handled correctly by it.
Signed-off-by:
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
Add pm_runtime feature to dmtimer whereby _get_sync() is called within
omap_dm_timer_enable(), _put_sync() is called in omap_dm_timer_disable().
Signed-off-by: Tarun Kanti DebBarma
[p-bas...@ti.com: added pm_runtime logic in probe()]
S
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
The low-level read and write access routines wait on write-pending register
in posted mode to make sure that previous write is complete on respective
registers. This waiting is done in an infinite while loop. Now it is being
modified to
On Fri, Aug 26, 2011 at 12:58:32PM +0200, Arnd Bergmann wrote:
> On Friday 26 August 2011, David Gibson wrote:
> > Seriously, how many times do I have to say it?
> >
> >
> > Using _byname in drivers DOES NOT require adding names to the DT.
> >
> >
> > All it needs is some glue logic to attach n
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
Since the spinlock is not used in any interrupt context we can
replace it with mutex instead.
Signed-off-by: Tarun Kanti DebBarma
---
Patch looks good but change log doesn't reflect it.
Do you want to say that below API's are not used
On Friday 26 August 2011, David Gibson wrote:
> If you open code it this way then yes, it's silly. But what about
> something like this:
>
> static struct of_device_id foodevice_of_match[] __devinitdata = {
> { .compatible = "foocorp,foodevice1234",
> .resource_names = {"base_re
On Friday 26 August 2011, Arnd Bergmann wrote:
> On Friday 26 August 2011, David Gibson wrote:
> > If you open code it this way then yes, it's silly. But what about
> > something like this:
> >
> > static struct of_device_id foodevice_of_match[] __devinitdata = {
> > { .compatible = "fooc
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
In driver probe use sys_timer_reserved to identify which all timers
have already been used for clocksource and clockevent. Mark all those
timers as reserved so that no one else can use them.
Signed-off-by: Tarun Kanti DebBarma
---
Loo
On Friday 15 July 2011 05:35 PM, Tarun Kanti DebBarma wrote:
Define context register structure and make it member of struct omap_dm_timer.
Also define two routines to save and restore dmtimer context to be used
subsequently.
Signed-off-by: Tarun Kanti DebBarma
---
arch/arm/plat-omap/dmtimer.c
From: Anand Gadiyar
This patch enables the DMA mode1 RX support for endpoints
that use BULK transactions. This will result in a throughput
increase of around 30-40% for BULK transfers
(mass-storage/mtp/ptp usecases)
Tested: Mass-storage, MTP, PTP, ADB, RNDIS gadgets
Signed-off-by: Anand Gadiyar
On Friday 15 July 2011 05:35 PM, Tarun Kanti DebBarma wrote:
Clock is enabled only when timer is started and disabled when the the timer
is stopped. Therefore before accessing registers in functions clock is enabled
and then disabled back at the end of access.
Context save and restore functions a
On Friday 26 August 2011 09:04 PM, Santosh wrote:
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
Since the spinlock is not used in any interrupt context we can
replace it with mutex instead.
Signed-off-by: Tarun Kanti DebBarma
---
Patch looks good but change log doesn't reflect i
On Fri, 2011-08-26 at 07:17 -0400, J, KEERTHY wrote:
> On Thu, Aug 25, 2011 at 9:26 PM, Guenter Roeck
> wrote:
> > On Thu, 2011-08-25 at 10:06 -0400, Guenter Roeck wrote:
> >> On Thu, Aug 25, 2011 at 06:30:07AM -0400, J, KEERTHY wrote:
> >> > On Wed, Aug 24, 2011 at 10:46 PM, Guenter Roeck
> >> >
Building the OMAP vout driver resulted in the following message:
WARNING: vmlinux.o(.data+0x38084): Section mismatch in reference
from the variable omap_vout_driver to the function
.init.text:omap_vout_probe()
The variable omap_vout_driver references
the funct
I'm not sure who's responsible for this, but the nonblocking MMC stuff is
broken on OMAPs HSMMC:
mmcblk0: error -84 transferring data, sector 149201, nr 64, cmd response 0x900,
card status 0xb00
mmcblk0: retrying using single block re
Santosh writes:
> On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
>> Add pm_runtime feature to dmtimer whereby _get_sync() is called within
>> omap_dm_timer_enable(), _put_sync() is called in omap_dm_timer_disable().
>>
>> Signed-off-by: Tarun Kanti DebBarma
>> [p-bas...@ti.com: adde
+ Balaji,
On Friday 26 August 2011 09:49 PM, Russell King - ARM Linux wrote:
I'm not sure who's responsible for this, but the nonblocking MMC stuff is
broken on OMAPs HSMMC:
mmcblk0: error -84 transferring data, sector 149201, nr 64, cmd response 0x900,
card status 0xb00
mmcblk0: retrying usin
On Friday 26 August 2011 09:53 PM, Kevin Hilman wrote:
Santosh writes:
On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
Add pm_runtime feature to dmtimer whereby _get_sync() is called within
omap_dm_timer_enable(), _put_sync() is called in omap_dm_timer_disable().
Signed-off-by:
On Thu, Aug 25, 2011 at 04:17:31PM +0200, Rafael J. Wysocki wrote:
> On Thursday, August 25, 2011, Mark Brown wrote:
> > On Tue, Aug 23, 2011 at 11:31:54PM +0200, Rafael J. Wysocki wrote:
> >
> > > Perhaps. Still, that requires some policy to be put into drivers,
> > > which I don't think is enti
On Fri, Aug 26, 2011 at 11:25:13AM +0900, MyungJoo Ham wrote:
> On Fri, Jul 1, 2011 at 12:11 AM, wrote:
> > @@ -129,19 +146,19 @@ static const struct file_operations pm_qos_power_fops
> > = {
> > /* unlocked internal variant */
> > static inline int pm_qos_get_value(struct pm_qos_object *o)
>
Russell King - ARM Linux wrote on Friday, August 26, 2011 12:22 AM:
> On Fri, Aug 26, 2011 at 12:06:20AM +0530, Pedanekar, Hemant wrote:
>> Russell King - ARM Linux wrote on Thursday, August 25, 2011 3:53 PM:
>>
>>> On Thu, Aug 25, 2011 at 09:35:07AM +0530, Pedanekar, Hemant wrote:
E.g., on
On Fri, 26 Aug 2011, Govindraj.R wrote:
> Hello,
>
> During system_wide_suspend pm runtime is disabled.
> I.e. __pm_runtime_disable is called from __device_suspend.
> Now, if a wakeup interrupt is triggered and the wakeup device irq handler
> is called even before device_resume and pm_runtime_ena
> -Original Message-
> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
> ow...@vger.kernel.org] On Behalf Of Govindraj
> Sent: Thursday, August 25, 2011 6:46 AM
> To: Coelho, Luciano
> Cc: linux-ker...@vger.kernel.org; linux-omap@vger.kernel.org; Thomas
> Gleixner; Sebastian And
On Friday, August 26, 2011, Govindraj.R wrote:
> Hello,
>
> During system_wide_suspend pm runtime is disabled.
> I.e. __pm_runtime_disable is called from __device_suspend.
> Now, if a wakeup interrupt is triggered and the wakeup device irq handler
> is called even before device_resume and pm_runti
On Friday, August 26, 2011, mark gross wrote:
> On Fri, Aug 26, 2011 at 11:25:13AM +0900, MyungJoo Ham wrote:
> > On Fri, Jul 1, 2011 at 12:11 AM, wrote:
> > > @@ -129,19 +146,19 @@ static const struct file_operations
> > > pm_qos_power_fops = {
> > > /* unlocked internal variant */
> > > stat
Shubhrajyoti D writes:
> Under some error conditions the i2c driver may do a reset.
> Adding a reset field and support in the device-specific code.
>
> Signed-off-by: Shubhrajyoti D
Needs update/rebase to apply against my for_3.2/i2c-cleanup branch...
[...]
> diff --git a/include/linux/i2c-om
Shubhrajyoti D writes:
> - The reset in the driver at init is not needed anymore as the
>hwmod framework takes care of reseting it.
> - Reset is removed from omap_i2c_init, which was called
>not only during probe, but also after time out and error handling.
>device_reset were added
Michael Jones writes:
> commit 20d5d5514981f9a68832bffb27a698545ecba77a (OMAP2: PM debug:
> remove register dumping) left some code lying around which doesn't
> do anything. Clean it up.
>
> Signed-off-by: Michael Jones
Thanks, queueing for v3.2 (branch: for_3.2/pm-cleanup)
Kevin
P.S., apolog
Hi Nishanth,
"Menon, Nishanth" writes:
> here is my quick feedback:
>
>
> On Wed, Aug 3, 2011 at 10:29, Tero Kristo wrote:
>>
>> This patch separates board specific voltage and oscillator ramp / setup
>> times from the core code. Things changed:
>>
>> - on/sleep/ret/off voltage setup moved from
Hi,
On Fri, Aug 26, 2011 at 04:41:48PM +0530, Ajay Kumar Gupta wrote:
> @@ -57,6 +58,10 @@ config USB_MUSB_AM35X
> tristate "AM35x"
> depends on ARCH_OMAP
>
> +config USB_MUSB_TI81XX
> + bool "TI81XX"
> + depends on SOC_OMAPTI81XX
this *must* be tristate. I can't emphasize e
Alen,
On Saturday 27 August 2011 12:06 AM, Alan Stern wrote:
On Fri, 26 Aug 2011, Govindraj.R wrote:
Hello,
During system_wide_suspend pm runtime is disabled.
I.e. __pm_runtime_disable is called from __device_suspend.
Now, if a wakeup interrupt is triggered and the wakeup device irq handler
i
59 matches
Mail list logo