Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers

2012-09-28 Thread Jon Hunter
On 09/28/2012 01:51 PM, Vaibhav Hiremath wrote: [snip] > Jon, > > Sorry for delayed response, But I tried using your omap_test application > to validate this patch series, but it is failing for me. > > How did you test it? Are you running same test application at your end? > > I am debugging

Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers

2012-09-28 Thread Jon Hunter
On 09/28/2012 01:51 PM, Vaibhav Hiremath wrote: > > > On 9/26/2012 10:23 PM, Jon Hunter wrote: >> >> On 09/20/2012 06:53 PM, Tony Lindgren wrote: >>> * Benoit Cousson [120919 19:24]: Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver ch

Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers

2012-09-28 Thread Jon Hunter
On 09/28/2012 01:51 PM, Vaibhav Hiremath wrote: > > > On 9/26/2012 10:23 PM, Jon Hunter wrote: >> >> On 09/20/2012 06:53 PM, Tony Lindgren wrote: >>> * Benoit Cousson [120919 19:24]: Hi Tony, I was about to take the DTS patch, but was wondering if you will pull the driver ch

Re: [PATCH RESEND 0/5] ARM: dts: AM33XX: Add device tree data

2012-09-28 Thread Matt Porter
On Wed, Sep 19, 2012 at 04:46:52PM -0500, Benoit Cousson wrote: > + Matt > > On 9/19/2012 4:28 PM, AnilKumar, Chimata wrote: > >On Thu, Sep 20, 2012 at 02:53:38, Cousson, Benoit wrote: > >>+ Paul > >> > >>Hi Anil, > >> > >>Thanks for the rebase / repost. I'll pulled the full series if Paul is OK

Re: Which git to clone for testing prior to submitting bugs?

2012-09-28 Thread linux
On 09/28/2012 12:18 PM, Robert Nelson wrote: Ah, so looking at the config, ARCH switched to omapdrm... It kinda works in v3.5.x, but i'd wait till a few more releases... So, based on that config, they have both "CONFIG_FB_OMAP2" and "CONFIG_DRM_OMAP" enabled.. That's a no-no... CONFIG_DRM_OMAP

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 8:42 PM, Cousson, Benoit wrote: > On 9/28/2012 3:07 AM, ABRAHAM, KISHON VIJAY wrote: >> >> Hi, >> >> On Fri, Sep 28, 2012 at 4:18 AM, Cousson, Benoit wrote: >>> >>> On 9/27/2012 7:24 AM, Rob Herring wrote: On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY w

[PATCH v2 1/7] uio: uio_pruss: replace private SRAM API with genalloc

2012-09-28 Thread Matt Porter
Remove the use of the private DaVinci SRAM API in favor of genalloc. The pool to be used is provided by platform data. Signed-off-by: Matt Porter --- drivers/uio/Kconfig |1 + drivers/uio/uio_pruss.c | 24 +--- include/linux/platform_

[PATCH v2 4/7] ARM: davinci: Add support for an L3RAM gen_pool

2012-09-28 Thread Matt Porter
L3RAM (shared SRAM) is needed for use by several drivers. This creates a genalloc pool and a hook for the platform code to provide the struct gen_pool * in platform data. Signed-off-by: Matt Porter --- arch/arm/mach-davinci/include/mach/common.h |2 ++ arch/arm/mach-davinci/include/mach/sram

[PATCH v2 5/7] ARM: davinci: Add support for PRUSS on DA850

2012-09-28 Thread Matt Porter
Adds PRUSS clock, registers the L3RAM pool, and registers the platform device for uio_pruss on DA850. Signed-off-by: Matt Porter --- arch/arm/mach-davinci/board-da850-evm.c| 12 + arch/arm/mach-davinci/da850.c |9 arch/arm/mach-davinci/devices-da8xx.c | 66

[PATCH v2 6/7] ARM: omap: add DT support for deasserting hardware reset lines

2012-09-28 Thread Matt Porter
This optional binding extension allows specification of a hwmod and associate hardware reset line which should be deasserted for the device to be functional. The implementation works for reference as to the problem that exists for utilizing uio_pruss on AM33xx but is suboptimal. The problem is tha

[PATCH v2 3/7] uio: dt: add TI PRUSS binding

2012-09-28 Thread Matt Porter
Adds a DT binding definition for the TI PRUSS. Signed-off-by: Matt Porter --- Documentation/devicetree/bindings/uio/pruss.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/uio/pruss.txt diff --git a/Documentation/devicetree/bind

[PATCH v2 2/7] uio: uio_pruss: add support for am33xx

2012-09-28 Thread Matt Porter
Adds DT, pinctrl, and runtime PM support to enable AM33xx. Signed-off-by: Matt Porter --- drivers/uio/Kconfig |4 +-- drivers/uio/uio_pruss.c | 90 +-- 2 files changed, 73 insertions(+), 21 deletions(-) diff --git a/drivers/uio/Kconfig b/dri

[PATCH v2 0/7] uio_pruss cleanup and platform support

2012-09-28 Thread Matt Porter
Changes since v1: - Replaced uio_pruss private SRAM API use with genalloc - Added DA850 platform device and clock support - Added DA850 L3 RAM gen_pool support - Split out DT binding This series enables uio_pruss on both DA850 and AM33xx. The driver previously was n

[PATCH v2 7/7] ARM: dts: AM33xx PRUSS support

2012-09-28 Thread Matt Porter
Adds a pruss node and an example of use on Beaglebone. Signed-off-by: Matt Porter --- arch/arm/boot/dts/am335x-bone.dts |4 arch/arm/boot/dts/am33xx.dtsi | 11 +++ 2 files changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x

Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

2012-09-28 Thread Jon Hunter
On 09/28/2012 10:54 AM, Russell King - ARM Linux wrote: > On Fri, Sep 28, 2012 at 08:05:38AM -0700, Tony Lindgren wrote: >> * Shilimkar, Santosh [120928 08:02]: >>> On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren wrote: * Lokesh Vutla [120928 06:41]: > Move plat/dma.h header to pla

Re: [RFC PATCH 1/3] uio: uio_pruss: port to AM33xx

2012-09-28 Thread Matt Porter
On Wed, Sep 26, 2012 at 02:10:19PM -0700, Greg Kroah-Hartman wrote: > On Wed, Sep 26, 2012 at 09:44:29AM -0400, Matt Porter wrote: > > Add ifdefery hacks to only use SRAM on Davinci. This > > needs to be cleaned up with a sane generic SRAM allocator > > (like the DT based driver available that can'

Re: Which git to clone for testing prior to submitting bugs?

2012-09-28 Thread Robert Nelson
On Fri, Sep 28, 2012 at 1:49 PM, wrote: > On 09/27/2012 01:41 PM, Robert Nelson wrote: >> >> On Thu, Sep 27, 2012 at 3:16 PM, wrote: >>> >>> On 09/27/2012 12:39 PM, Robert Nelson wrote: >>> > > So, i would first look at the config (zcat /proc/config.gz) between > those two releases,

Re: [RFC PATCH 1/3] uio: uio_pruss: port to AM33xx

2012-09-28 Thread Matt Porter
On Thu, Sep 27, 2012 at 01:51:18AM +0200, Hans J. Koch wrote: > On Wed, Sep 26, 2012 at 09:44:29AM -0400, Matt Porter wrote: > > Add ifdefery hacks to only use SRAM on Davinci. This > > needs to be cleaned up with a sane generic SRAM allocator > > (like the DT based driver available that can't be u

Re: [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers

2012-09-28 Thread Vaibhav Hiremath
On 9/26/2012 10:23 PM, Jon Hunter wrote: > > On 09/20/2012 06:53 PM, Tony Lindgren wrote: >> * Benoit Cousson [120919 19:24]: >>> Hi Tony, >>> >>> I was about to take the DTS patch, but was wondering if you will pull >>> the driver changes for 3.7. >> >> I suggest that you do a separate branch

Re: Which git to clone for testing prior to submitting bugs?

2012-09-28 Thread linux
On 09/27/2012 01:41 PM, Robert Nelson wrote: On Thu, Sep 27, 2012 at 3:16 PM, wrote: On 09/27/2012 12:39 PM, Robert Nelson wrote: So, i would first look at the config (zcat /proc/config.gz) between those two releases, and if the arch developers added any more patches to it.. It looks l

Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

2012-09-28 Thread Russell King - ARM Linux
On Fri, Sep 28, 2012 at 08:05:38AM -0700, Tony Lindgren wrote: > * Shilimkar, Santosh [120928 08:02]: > > On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren wrote: > > > > > > * Lokesh Vutla [120928 06:41]: > > > > Move plat/dma.h header to platform_data/dma-omap.h as > > > > part of the single zIma

Re: Help needed with remaining plat headers

2012-09-28 Thread Jon Hunter
Hi Tony, On 09/27/2012 03:26 PM, Tony Lindgren wrote: > Please see below a status update on the remaining problem > plat headers. > > Note that all patches should be against current linux next > in this case. > [snip] >> dmtimer.h > > Jon, can you do a patch for dmtimer.h? Yes, I will look i

Re: [PATCH] arm: omap: move OMAP USB platform data to

2012-09-28 Thread Tony Lindgren
* Felipe Balbi [120928 00:08]: > In order to make single zImage work for ARM architecture, > we need to make sure we don't depend on private headers. > > Move USB platform_data to The new standard seems to be subsystem-soc.h, so usb-omap.h :) > and keep only internal functions in . Can the re

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-28 Thread Cousson, Benoit
On 9/28/2012 3:07 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Fri, Sep 28, 2012 at 4:18 AM, Cousson, Benoit wrote: On 9/27/2012 7:24 AM, Rob Herring wrote: On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: On 09/06/2012 09:57 AM, K

Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

2012-09-28 Thread Shilimkar, Santosh
On Fri, Sep 28, 2012 at 8:35 PM, Tony Lindgren wrote: > * Shilimkar, Santosh [120928 08:02]: >> On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren wrote: >> > >> > * Lokesh Vutla [120928 06:41]: >> > > Move plat/dma.h header to platform_data/dma-omap.h as >> > > part of the single zImage work. >> >

Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

2012-09-28 Thread Tony Lindgren
* Shilimkar, Santosh [120928 08:02]: > On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren wrote: > > > > * Lokesh Vutla [120928 06:41]: > > > Move plat/dma.h header to platform_data/dma-omap.h as > > > part of the single zImage work. > > > > Hmm there's no platform data in this header, just > > expo

Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

2012-09-28 Thread Shilimkar, Santosh
On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren wrote: > > * Lokesh Vutla [120928 06:41]: > > Move plat/dma.h header to platform_data/dma-omap.h as > > part of the single zImage work. > > Hmm there's no platform data in this header, just > exported things for drivers to use. So it should not > be

Re: Converting vrfb.c

2012-09-28 Thread Tony Lindgren
* Tomi Valkeinen [120928 05:05]: > Hi, > > I'm a bit at loss how to deal with drivers/video/omap2/vrfb.c. > > VRFB is part of the SDRAM controller on OMAP2 and OMAP3. vrfb.c uses the > following functions from sdrc.h: > > omap2_sms_write_rot_control(); > omap2_sms_write_rot_size(); > omap2_sms_

Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

2012-09-28 Thread Tony Lindgren
* Lokesh Vutla [120928 06:41]: > Move plat/dma.h header to platform_data/dma-omap.h as > part of the single zImage work. Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data. Maybe it should be #include for now? Reg

Re: Powering OMAP's pins

2012-09-28 Thread Tony Lindgren
* Tomi Valkeinen [120927 23:15]: > On Thu, 2012-09-27 at 11:51 -0700, Tony Lindgren wrote: > > * Tony Lindgren [120927 11:45]: > > > * Tomi Valkeinen [120927 00:20]: > > > > > > > I could be mistaken how to HW works (but it does work like that for > > > > dss), but sounds to me that uart and gp

[PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

2012-09-28 Thread Lokesh Vutla
Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work. Signed-off-by: Lokesh Vutla Acked-by : Santosh Shilimkar --- arch/arm/mach-omap1/board-h2.c |2 +- arch/arm/mach-omap1/board-h3.c |

[PATCH 3/4] ARM: OMAP: Move omap_reserve() locally to mach-omap1/2

2012-09-28 Thread Lokesh Vutla
omap_reserve() is a stub for omap1. So creating a stub locally in mach-omap1. And moving the definition to mach-omap2. This helps in moving plat/omap_secure.h local to mach-omap2 Signed-off-by: Lokesh Vutla Acked-by : Santosh Shilimkar --- arch/arm/mach-omap1/common.h |3 +++ ar

[PATCH 4/4] ARM: OMAP: Move plat/omap-secure.h locally to mach-omap2

2012-09-28 Thread Lokesh Vutla
Moving plat/omap-secure.h locally to mach-oamp2/ as part of single zImage work Signed-off-by: Lokesh Vutla Acked-by : Santosh Shilimkar --- arch/arm/mach-omap2/common.c |2 +- arch/arm/mach-omap2/omap-secure.c |1 - arch/arm/mach-omap2/omap-secure.h

[PATCH 0/4] ARM: OMAP: Move plat/dma*.h,omap-secure.h headers as part of single zImage work

2012-09-28 Thread Lokesh Vutla
Patch 1: Dropping the file plat/dma44xx.h as none of the dma channel definitions are used. Patch 2: Moving plat/dma.h to platform_data/dma-omap.h Patch 3: Move omap_reserve() locally to mach-omap1/2 This helps in moving plat/omap-secure.h locally to mach-om

[PATCH 1/4] ARM: OMAP: DMA: Removing plat/dma-44xx.h

2012-09-28 Thread Lokesh Vutla
None of the DMA channel definitions defined in plat/dma-44xx.h are used. So removing it. Signed-off-by: Lokesh Vutla Acked-by : Santosh Shilimkar --- arch/arm/plat-omap/include/plat/dma-44xx.h | 147 arch/arm/plat-omap/include/plat/dma.h |3 - 2 files chan

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:32 PM, Felipe Balbi wrote: > On Fri, Sep 28, 2012 at 06:23:15PM +0530, Kishon Vijay Abraham I wrote: >> Added dwc3 support for dwc3 core and update the documentation with >> device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Docu

Re: [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:29 PM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 28, 2012 at 06:23:13PM +0530, Kishon Vijay Abraham I wrote: >> Add an API in the omap glue layer to write to the mailbox register which >> can be used by comparator driver(twl). To pass the detection of the attached >>

Re: [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:28 PM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 28, 2012 at 06:23:11PM +0530, Kishon Vijay Abraham I wrote: >> Before accessing any register, runtime API's should be invoked to enable >> the clocks. runtime API's are added here to prevent abort during register >> ac

Re: [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 6:27 PM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 28, 2012 at 06:23:10PM +0530, Kishon Vijay Abraham I wrote: >> Used of_platform_populate() to populate dwc3 core platform_device >> from device tree data. Since now the allocation of unique device id is >> handled be o

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-28 Thread Felipe Balbi
On Fri, Sep 28, 2012 at 06:23:15PM +0530, Kishon Vijay Abraham I wrote: > Added dwc3 support for dwc3 core and update the documentation with > device tree binding information. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 24 > +

Re: [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox

2012-09-28 Thread Felipe Balbi
Hi, On Fri, Sep 28, 2012 at 06:23:13PM +0530, Kishon Vijay Abraham I wrote: > Add an API in the omap glue layer to write to the mailbox register which > can be used by comparator driver(twl). To pass the detection of the attached > device (signified by VBUS, ID) to the dwc3 core, dwc3 core has to

Re: [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-09-28 Thread Felipe Balbi
Hi, On Fri, Sep 28, 2012 at 06:23:10PM +0530, Kishon Vijay Abraham I wrote: > Used of_platform_populate() to populate dwc3 core platform_device > from device tree data. Since now the allocation of unique device id is > handled be of_*, removed the call to dwc3_get_device_id. > > Signed-off-by: Ki

Re: [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks

2012-09-28 Thread Felipe Balbi
Hi, On Fri, Sep 28, 2012 at 06:23:11PM +0530, Kishon Vijay Abraham I wrote: > Before accessing any register, runtime API's should be invoked to enable > the clocks. runtime API's are added here to prevent abort during register > access. > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/

[PATCH 5/6] usb: dwc3-omap: Minor fixes to get dt working

2012-09-28 Thread Kishon Vijay Abraham I
Includes few minor fixes in dwc3-omap like populating the compatible string in a correct way, extracting the utmi-mode property properly and changing the index of get_irq since irq of core is removed from hwmod entry. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c |6

[PATCH 0/6] usb: dwc3-omap: add dt support

2012-09-28 Thread Kishon Vijay Abraham I
This patch series adds dt support to dwc3 core and fixes few minor stuff in dwc3-omap glue to get dwc3 working. While at that it also uses *of_platform* to create the child device (dwc3-core) and fixes to use runtime API's to enable clock and write to SYSCONFIG register. This patch series is deve

[PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-09-28 Thread Kishon Vijay Abraham I
Used of_platform_populate() to populate dwc3 core platform_device from device tree data. Since now the allocation of unique device id is handled be of_*, removed the call to dwc3_get_device_id. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 63 +++-

[PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-28 Thread Kishon Vijay Abraham I
Added dwc3 support for dwc3 core and update the documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/dwc3.txt | 24 drivers/usb/dwc3/core.c| 14 -- 2 fi

[PATCH 3/6] usb: dwc3-omap: Remove explicit writes to SYSCONFIG register

2012-09-28 Thread Kishon Vijay Abraham I
The runtime API's takes care of setting the SYSCONFIG register with appropriate values. Hence explicit writes to SYSCONFIG register is removed. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/

[PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks

2012-09-28 Thread Kishon Vijay Abraham I
Before accessing any register, runtime API's should be invoked to enable the clocks. runtime API's are added here to prevent abort during register access. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/driv

[PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox

2012-09-28 Thread Kishon Vijay Abraham I
Add an API in the omap glue layer to write to the mailbox register which can be used by comparator driver(twl). To pass the detection of the attached device (signified by VBUS, ID) to the dwc3 core, dwc3 core has to write to the mailbox regiter. Signed-off-by: Kishon Vijay Abraham I --- drivers/

Re: [PATCH V3 0/3] OMAPDSS: Enable dynamic debug printing

2012-09-28 Thread Mahapatra, Chandrabhanu
On Fri, Sep 28, 2012 at 5:04 PM, Tomi Valkeinen wrote: > On Fri, 2012-09-28 at 15:53 +0530, Chandrabhanu Mahapatra wrote: >> Hi everyone, >> this patch series aims at cleaning up of DSS of printk()'s enabled with >> dss_debug and replace them with generic dynamic debug printing. >> >> The 1st patc

Converting vrfb.c

2012-09-28 Thread Tomi Valkeinen
Hi, I'm a bit at loss how to deal with drivers/video/omap2/vrfb.c. VRFB is part of the SDRAM controller on OMAP2 and OMAP3. vrfb.c uses the following functions from sdrc.h: omap2_sms_write_rot_control(); omap2_sms_write_rot_size(); omap2_sms_write_rot_physical_ba(); There are no other dependenc

Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Tomi Valkeinen
On Fri, 2012-09-28 at 17:00 +0530, Mahapatra, Chandrabhanu wrote: > > I think you could just do: > > > > #ifdef DSS_SUBSYS_NAME > > #ifdef pr_fmt > > #undef pr_fmt > > #endif > > #define pr_fmt(fmt) DSS_SUBSYS_NAME ": " fmt > > #endif > > > > For the case where there's no DSS_SUBSYS_NAME, there's

Re: [PATCH V3 0/3] OMAPDSS: Enable dynamic debug printing

2012-09-28 Thread Tomi Valkeinen
On Fri, 2012-09-28 at 15:53 +0530, Chandrabhanu Mahapatra wrote: > Hi everyone, > this patch series aims at cleaning up of DSS of printk()'s enabled with > dss_debug and replace them with generic dynamic debug printing. > > The 1st patch > * moved DEBUG flag definition to Makefile > The 2nd patch

Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Mahapatra, Chandrabhanu
On Fri, Sep 28, 2012 at 4:52 PM, Tomi Valkeinen wrote: > On Fri, 2012-09-28 at 15:53 +0530, Chandrabhanu Mahapatra wrote: >> The printk in DSSDBG function definition is replaced with dynamic debug >> enabled >> pr_debug(). The use of dynamic debugging provides more flexibility as each >> debug >

Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Tomi Valkeinen
On Fri, 2012-09-28 at 15:53 +0530, Chandrabhanu Mahapatra wrote: > The printk in DSSDBG function definition is replaced with dynamic debug > enabled > pr_debug(). The use of dynamic debugging provides more flexibility as each > debug > statement can be enabled or disabled dynamically on basis of

Re: [PATCH 1/6] OMAPDSS: add omapdss_version

2012-09-28 Thread Tomi Valkeinen
On Fri, 2012-09-28 at 16:30 +0530, Archit Taneja wrote: > On Friday 28 September 2012 04:05 PM, Tomi Valkeinen wrote: > > Add new enum, omapdss_version, that is used to tell which DSS hardware > > version the SoC has. This enum is initialized during platform init, and > > passed in the platform dat

Re: [PATCH 1/6] OMAPDSS: add omapdss_version

2012-09-28 Thread Archit Taneja
On Friday 28 September 2012 04:05 PM, Tomi Valkeinen wrote: Add new enum, omapdss_version, that is used to tell which DSS hardware version the SoC has. This enum is initialized during platform init, and passed in the platform data to omapdss driver. Note that the versions are not "continuous", t

Re: [PATCH 1/6] OMAPDSS: add omapdss_version

2012-09-28 Thread Tomi Valkeinen
On Fri, 2012-09-28 at 13:35 +0300, Tomi Valkeinen wrote: > Add new enum, omapdss_version, that is used to tell which DSS hardware > version the SoC has. This enum is initialized during platform init, and > passed in the platform data to omapdss driver. > > Note that the versions are not "continuou

Re: [PATCH] ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()

2012-09-28 Thread Jean Pihet
On Thu, Sep 27, 2012 at 7:54 AM, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function voltdm_lookup() returns NULL > not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. > > dpatch engine is used to auto generate this patch. > (https

Re: [PATCH] ARM: OMAP2+: SmartReflex: fix return value check in sr_dev_init()

2012-09-28 Thread Jean Pihet
Hello, On Thu, Sep 27, 2012 at 7:54 AM, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function voltdm_lookup() returns NULL > not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. > > dpatch engine is used to auto generate this patch.

[PATCH 6/6] OMAPDSS: remove includes

2012-09-28 Thread Tomi Valkeinen
cpu_is_* calls are no longer used in omapdss, so the includes for can be removed. Signed-off-by: Tomi Valkeinen --- drivers/video/omap2/dss/dss.c |2 -- drivers/video/omap2/dss/dss_features.c |1 - 2 files changed, 3 deletions(-) diff --git a/drivers/video/omap2/dss/dss.c b/dr

[PATCH 5/6] OMAPDSS: HDMI: use omapdss_version

2012-09-28 Thread Tomi Valkeinen
Use omapdss_version in hdmi.c to select the proper hdmi features. Signed-off-by: Tomi Valkeinen --- drivers/video/omap2/dss/dss_features.c | 14 -- drivers/video/omap2/dss/dss_features.h |3 ++- drivers/video/omap2/dss/hdmi.c |3 ++- 3 files changed, 16 insertions(+

[PATCH 4/6] OMAPDSS: DSS: use omapdss_version

2012-09-28 Thread Tomi Valkeinen
Use omapdss_version in dss.c to select the proper dss features. Signed-off-by: Tomi Valkeinen --- drivers/video/omap2/dss/dss.c | 37 +++-- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/ds

[PATCH 3/6] OMAPDSS: DISPC: use omapdss_version

2012-09-28 Thread Tomi Valkeinen
Use omapdss_version in dispc.c to select the proper dispc features. Signed-off-by: Tomi Valkeinen --- drivers/video/omap2/dss/dispc.c | 41 ++- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/om

[PATCH 2/6] OMAPDSS: use omapdss_version in dss_features.c

2012-09-28 Thread Tomi Valkeinen
Pass the omapdss_version to dss_features.c and use it to select the proper dss features. Signed-off-by: Tomi Valkeinen --- drivers/video/omap2/dss/core.c |2 +- drivers/video/omap2/dss/dss_features.c | 49 +--- drivers/video/omap2/dss/dss_features.h |

[PATCH 1/6] OMAPDSS: add omapdss_version

2012-09-28 Thread Tomi Valkeinen
Add new enum, omapdss_version, that is used to tell which DSS hardware version the SoC has. This enum is initialized during platform init, and passed in the platform data to omapdss driver. Note that the versions are not "continuous", that is, you cannot check if the version is less or greater tha

[PATCH 0/6] OMAPDSS: remove cpu_is_* calls

2012-09-28 Thread Tomi Valkeinen
Hi, This series adds an omapdss_version enum that is passed via platform data to omapdss driver. This version identifier is then used instead of cpu_is_*() calls. After these, omapdss no longer contains any plat/ or mach/ includes. omapfb, vrfb and vram still do, though. Tomi Tomi Valkeinen (6

[PATCH V3 3/3] OMAPDSS: Remove dss_debug variable

2012-09-28 Thread Chandrabhanu Mahapatra
The debug prints in omap_dispc_unregister_isr() and _dsi_print_reset_status() are replaced with dynamic debug enabled pr_debug(). So, as the final dependency on dss_debug variable is replaced with dyndbg, the dss_debug variable is removed. Signed-off-by: Chandrabhanu Mahapatra --- drivers/video/

[PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Chandrabhanu Mahapatra
The printk in DSSDBG function definition is replaced with dynamic debug enabled pr_debug(). The use of dynamic debugging provides more flexibility as each debug statement can be enabled or disabled dynamically on basis of source filename, line number, module name etc. by writing to a control file i

[PATCH V3 1/3] OMAPDSS: Move definition of DEBUG flag to Makefile

2012-09-28 Thread Chandrabhanu Mahapatra
In OMAPDSS the DEBUG flag is set only after the OMAPDSS module is called, for which the debugging capabilities are available only after its proper initialization. As a result of which tracking of bugs prior to or during initial process becomes difficult. So, the definition of DEBUG is being moved t

[PATCH V3 0/3] OMAPDSS: Enable dynamic debug printing

2012-09-28 Thread Chandrabhanu Mahapatra
Hi everyone, this patch series aims at cleaning up of DSS of printk()'s enabled with dss_debug and replace them with generic dynamic debug printing. The 1st patch * moved DEBUG flag definition to Makefile The 2nd patch * replaces printk() in DSSDBG definition with pr_debug() * removes DSSDBGF

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 28, 2012 at 4:18 AM, Cousson, Benoit wrote: > On 9/27/2012 7:24 AM, Rob Herring wrote: >> >> On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: >>> >>> Hi, >>> >>> On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring >>> wrote: On 09/06/2012 09:57 AM, Kishon Vijay Abraham I w

Re: Help needed with remaining plat headers

2012-09-28 Thread Vutla, Lokesh
Hi Peter, On Fri, Sep 28, 2012 at 2:24 PM, Peter Ujfalusi wrote: > On 09/27/2012 12:57 PM, Vutla, Lokesh wrote: >>> clkdev_omap.h >>> clock.h >>> common.h >>> cpu.h >>> dma-44xx.h >>> dma.h >> As a part of clean up I am looking at dma.h and dma-44xx.h files >> ll send you patches once cleanup and

Re: [PATCH v2 1/2] usb: phy: add a new driver for usb3 phy

2012-09-28 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Sep 27, 2012 at 7:48 PM, Russell King - ARM Linux wrote: > On Thu, Sep 27, 2012 at 07:34:07PM +0530, Kishon Vijay Abraham I wrote: >> +static int omap5_usb_phy_power(struct omap_usb *phy, bool on) >> +{ >> + u32 val; >> + unsigned long rate; >> + struct clk *sys_clk; >> +

Re: Help needed with remaining plat headers

2012-09-28 Thread Peter Ujfalusi
On 09/27/2012 12:57 PM, Vutla, Lokesh wrote: >> clkdev_omap.h >> clock.h >> common.h >> cpu.h >> dma-44xx.h >> dma.h > As a part of clean up I am looking at dma.h and dma-44xx.h files > ll send you patches once cleanup and testing is done. One note for the dma.h, dma-44xx.h: The audio drivers used

[PATCH] arm: omap: move OMAP USB platform data to

2012-09-28 Thread Felipe Balbi
In order to make single zImage work for ARM architecture, we need to make sure we don't depend on private headers. Move USB platform_data to and keep only internal functions in . Signed-off-by: Felipe Balbi --- Compile tested only. arch/arm/mach-omap2/usb-host.c | 1 +

linux-next ASOC build break ? (Was... Re: Help needed with remaining plat headers)

2012-09-28 Thread Shilimkar, Santosh
+ Peter, Liam in case they haven't seen the issue yet. On Fri, Sep 28, 2012 at 12:28 PM, Vutla, Lokesh wrote: > Hi, > I see a module build failure in linux-next tree. > Any one else facing this issue or I am missing something. > Using master branch on > git://git.kernel.org/pub/scm/linux/kernel/g