Hi Paul,
-Original Message-
From: Paul Walmsley [mailto:p...@pwsan.com]
Sent: Tuesday, February 12, 2013 12:09 PM
To: J, KEERTHY
Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org
Subject: RE: [PATCH] ARM: OMAP: Clock: Remove CK_* flags
On Tue, 12 Feb 2013, J,
Hello,
I have a few comments on the devicetree binding and the way it's parsed.
+static const struct of_device_id dbx500_mailbox_match[] = {
+ { .compatible = stericsson,db8500-mailbox,
+ .data = (void *)db8500_mboxes,
+ },
+ { .compatible =
Add the needed sections to enable audio support and related pin mux on
Devkit8000 when booted with DT blob.
Signed-off-by: Anil Kumar anilk...@gmail.com
---
This patch is based on top of kernel 3.8-rc5 and
the following patches.
Peter Ujfalusi:-
ASoC: twl4030: Correct the support for Voice port
Hi Jon
On Mon, Feb 11, 2013 at 7:21 PM, Jon Hunter jon-hun...@ti.com wrote:
This is being call from the mach-omap2/board-generic.c file on boot.
Where are you suggesting this is called from?
I was suggesting this could be called in gpmc_probe_dt() in gpmc.c.
Instead of using
This patchset is v2 of the small cleanup consisting in:
* mark some functions as 'static' when appropriate
* remove an unused function from gpmc.c
* improve error messages when a CS request fails
* migrate to dev_err and dev_warn
Changelog from v1:
* fix gpmc_cs_reserved to return a boolean
Santosh Shilimkar santosh.shilim...@ti.com writes:
On Saturday 09 February 2013 02:49 AM, Kevin Hilman wrote:
Santosh Shilimkar santosh.shilim...@ti.com writes:
Current CPU PM code code make use of common cpu_suspend() path for all the
CPU power states which is not optimal. In fact
This patch marks a bunch of functions that are local
to gpmc.c file only as static.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
---
arch/arm/mach-omap2/gpmc.c | 14 +++---
arch/arm/mach-omap2/gpmc.h |7 ---
2 files changed, 7 insertions(+), 14 deletions(-)
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
---
arch/arm/mach-omap2/gpmc.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index ffe3e1e..bd3bc93 100644
--- a/arch/arm/mach-omap2/gpmc.c
If CS request fails the current error message is rather unhelpful.
Fix it by printing the failing chip select and the error code.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
---
arch/arm/mach-omap2/gpmc-nand.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Currently gpmc_cs_reserved() return value is somewhat inconsistent,
returning a negative value on an error condition, a positive value
if the chip select is reserved and zero if it's available.
Fix this by returning a boolean value as the function name suggests:
* true if the chip select is
If CS request fails the current error message is rather unhelpful.
Fix it by printing the failing chip select and the error code.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
---
arch/arm/mach-omap2/gpmc-onenand.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
---
arch/arm/mach-omap2/gpmc-onenand.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/gpmc-onenand.c
b/arch/arm/mach-omap2/gpmc-onenand.c
index 0ee5317..4771945 100644
---
Since the condition is not an error but a warning, replace
printk KERN_ERR with dev_warn.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
---
arch/arm/mach-omap2/gpmc-onenand.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
This check is done before the call to gpmc_cs_reserved() and
gpmc_cs_set_reserved() and it's redundant to do it again in each
function. This simplifies the code a bit.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
---
arch/arm/mach-omap2/gpmc.c | 10 +-
1 files
Paul Walmsley p...@pwsan.com writes:
On Sun, 30 Dec 2012, Paul Walmsley wrote:
There shouldn't be any need to jump to SRAM code if the OMAP CORE
clockdomain (and consequently the SDRAM controller and CORE PLL) stays
active during MPU WFI. The SRAM code should only be needed when the RAM
On 02/12/2013 01:26 AM, Peter Ujfalusi wrote:
On 02/11/2013 09:22 PM, Jon Hunter wrote:
Good point. I just noticed that none of my omap2+ board were booting and
on omap3/4 I was the panic in the twl code. I can't say that I checked
the panic on omap2, so may be that was another problem?
Do
On 02/12/2013 04:07 AM, Samuel Ortiz wrote:
Hi Jon,
On Mon, Feb 11, 2013 at 02:26:19PM -0600, Jon Hunter wrote:
Commit 8a6aaa3 (mfd: twl-core: Collect global variables behind one
private structure (global)) removed the variable inuse that is used
to determine if the device has been
On 02/12/2013 09:18 AM, Ezequiel Garcia wrote:
This patchset is v2 of the small cleanup consisting in:
* mark some functions as 'static' when appropriate
* remove an unused function from gpmc.c
* improve error messages when a CS request fails
* migrate to dev_err and dev_warn
* Olof Johansson o...@lixom.net [130211 19:51]:
If the ethernet driver is not selected, you otherwise get:
arch/arm/mach-omap2/board-h4.c:237:12: warning: 'is_gpmc_muxed' defined but
not used [-Wunused-function]
I guess it could be argued that the device setup should/could always
be done
On Fri, Feb 01, 2013 at 01:22:52PM -0500, Matt Porter wrote:
Adds a dma_request_slave_channel_compat() wrapper which accepts
both the arguments from dma_request_channel() and
dma_request_slave_channel(). Based on whether the driver is
instantiated via DT, the appropriate channel request call
* Paul Walmsley p...@pwsan.com [130211 20:02]:
Commit c1d1cd597fc77af3086470f8627d77f52f7f8b6c (ARM: OMAP2+:
omap_device: remove obsolete pm_lats and early_device code) missed a
few omap_device_build() calls that aren't included as part of the default
OMAP2+ Kconfig, omap2plus_defconfig.
* Jon Hunter jon-hun...@ti.com [130212 08:36]:
On 02/12/2013 09:18 AM, Ezequiel Garcia wrote:
This patchset is v2 of the small cleanup consisting in:
* mark some functions as 'static' when appropriate
* remove an unused function from gpmc.c
* improve error messages when a CS request
On Tue, 12 Feb 2013, Tony Lindgren wrote:
Thanks, I'll apply this into omap-for-v3.9/pm-wfi as the breaking
commit is already in arm-soc/for-next.
OK thanks. Looks like I'll have one more fix for one of the commits in
arm-soc/for-next; working on it now.
- Paul
--
To unsubscribe from this
The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7:
Linux 3.8-rc6 (2013-02-01 12:08:14 +1100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap
tags/omap-for-v3.9/soc-signed
for you to fetch changes up to
On Tue, Feb 12, 2013 at 09:12:53AM -0800, Tony Lindgren wrote:
* Jon Hunter jon-hun...@ti.com [130212 08:36]:
On 02/12/2013 09:18 AM, Ezequiel Garcia wrote:
This patchset is v2 of the small cleanup consisting in:
* mark some functions as 'static' when appropriate
* remove an
* Ezequiel Garcia ezequiel.gar...@free-electrons.com [130212 10:29]:
On Tue, Feb 12, 2013 at 09:12:53AM -0800, Tony Lindgren wrote:
* Jon Hunter jon-hun...@ti.com [130212 08:36]:
On 02/12/2013 09:18 AM, Ezequiel Garcia wrote:
This patchset is v2 of the small cleanup consisting in:
On Tue, Feb 12, 2013 at 10:43:25AM -0800, Tony Lindgren wrote:
* Ezequiel Garcia ezequiel.gar...@free-electrons.com [130212 10:29]:
On Tue, Feb 12, 2013 at 09:12:53AM -0800, Tony Lindgren wrote:
* Jon Hunter jon-hun...@ti.com [130212 08:36]:
On 02/12/2013 09:18 AM, Ezequiel Garcia
This patchset is v3 of the small cleanup consisting in:
* mark some functions as 'static' when appropriate
* remove an unused function from gpmc.c
* improve error messages when a CS request fails
* migrate to dev_err and dev_warn
Changes from v2:
* add a commit message to some trivial
This patch marks a bunch of functions that are local
to gpmc.c file only as static.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
Reviewed-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/mach-omap2/gpmc.c | 14 +++---
arch/arm/mach-omap2/gpmc.h |7 ---
2 files
This function is not used anywhere, so it's safe to remove it.
This means less code to maintain.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
Reviewed-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/mach-omap2/gpmc.c |7 ---
1 files changed, 0 insertions(+), 7
Currently gpmc_cs_reserved() return value is somewhat inconsistent,
returning a negative value on an error condition, a positive value
if the chip select is reserved and zero if it's available.
Fix this by returning a boolean value as the function name suggests:
* true if the chip select is
If CS request fails the current error message is rather unhelpful.
Fix it by printing the failing chip select and the error code.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
Reviewed-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/mach-omap2/gpmc-nand.c |3 ++-
1 files
If CS request fails the current error message is rather unhelpful.
Fix it by printing the failing chip select and the error code.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
Reviewed-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/mach-omap2/gpmc-onenand.c |3 ++-
1 files
Do this becasue dev_err() is preferred over pr_err() and because
it will match gpmc-nand, thus the code shows looks more consistent.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
Reviewed-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/mach-omap2/gpmc-onenand.c |7 ---
Since the condition is not an error but a warning, replace
printk KERN_ERR with dev_warn.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
Reviewed-by: Jon Hunter jon-hun...@ti.com
---
arch/arm/mach-omap2/gpmc-onenand.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This check is done before the call to gpmc_cs_reserved() and
gpmc_cs_set_reserved() and it's redundant to do it again in each
function. This simplifies the code a bit.
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
Reviewed-by: Jon Hunter jon-hun...@ti.com
---
Hi Mark,
Thanks for your comments.
On 02/12/2013 11:39 AM, Mark Rutland wrote:
Hello,
I have a few comments on the devicetree binding and the way it's parsed.
+static const struct of_device_id dbx500_mailbox_match[] = {
+ { .compatible = stericsson,db8500-mailbox,
+
Commit 17b7e7d33530e2bbd3bdc90f4db09b91cfdde2bb (ARM: OMAP4:
clock/hwmod data: start to remove some IP block control clocks)
introduced a regression preventing the L3INIT clockdomain of OMAP4
systems from entering idle. This in turn prevented these systems from
entering full chip clock-stop.
On Tue, 12 Feb 2013, J, KEERTHY wrote:
Heh :-). It narrowed down to this patch:
commit 17b7e7d33530e2bbd3bdc90f4db09b91cfdde2bb
Author: Paul Walmsley p...@pwsan.com
Date: Sat Jan 26 00:48:54 2013 -0700
ARM: OMAP4: clock/hwmod data: start to remove some IP block control
clocks
NeilBrown ne...@suse.de writes:
On Mon, 21 Jan 2013 13:38:59 +0200 Igor Grinberg grinb...@compulab.co.il
wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Neil,
On 01/21/13 11:28, NeilBrown wrote:
The standard suspend sequence involves runtime_resuming
devices before
From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 12 Feb 2013 01:22:17 +0530
This patch series implements Dual EMAC mode implementation of CPSW
which acts as two standalone EMAC by segregating the switch using VIDs
and port VLAN
Mugunthan V N (3):
driver: net: ethernet: davinci_cpdma:
commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted
the initcalls here, but did not #include soc.h where the omap
inicalls are defined.
To fix, #include soc.h
Signed-off-by: Kevin Hilman khil...@linaro.org
---
Tony, the patch that broke this was introduced in your
Hi,
On Fri, Jan 25, 2013 at 08:10:05AM +, Paul Walmsley wrote:
On Fri, 25 Jan 2013, Aaro Koskinen wrote:
There is a long-standing bug that OHCI USB host controller does
not respond on 1710, because of wrong clock definitions. See e.g.
On Tue, Feb 12, 2013 at 10:11:01AM -0800, Tony Lindgren wrote:
The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7:
Linux 3.8-rc6 (2013-02-01 12:08:14 +1100)
are available in the git repository at:
Hi Aaro, Tony,
On Wed, 13 Feb 2013, Aaro Koskinen wrote:
On Fri, Jan 25, 2013 at 08:10:05AM +, Paul Walmsley wrote:
On Fri, 25 Jan 2013, Aaro Koskinen wrote:
There is a long-standing bug that OHCI USB host controller does
not respond on 1710, because of wrong clock definitions.
On Tue, Feb 12, 2013 at 11:54:36PM +, Paul Walmsley wrote:
I didn't send any more v3.8-rc fixes after you posted your patch, due to:
http://www.spinics.net/lists/arm-kernel/msg221817.html
Will it go to 3.9?
Yep, it's queued for early v3.9-rc.
Great, thanks,
A.
--
To unsubscribe
On Tue, 12 Feb 2013 13:03:36 -0800 Kevin Hilman khil...@linaro.org wrote:
NeilBrown ne...@suse.de writes:
On Mon, 21 Jan 2013 13:38:59 +0200 Igor Grinberg grinb...@compulab.co.il
wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Neil,
On 01/21/13 11:28, NeilBrown
* Olof Johansson o...@lixom.net [130212 15:40]:
On Tue, Feb 12, 2013 at 10:11:01AM -0800, Tony Lindgren wrote:
The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7:
Linux 3.8-rc6 (2013-02-01 12:08:14 +1100)
are available in the git repository at:
* Kevin Hilman khil...@linaro.org [130212 14:27]:
commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted
the initcalls here, but did not #include soc.h where the omap
inicalls are defined.
To fix, #include soc.h
Thanks, this should be already fixed in arm-soc/for-next. I might
have
NeilBrown ne...@suse.de writes:
On Tue, 12 Feb 2013 13:03:36 -0800 Kevin Hilman khil...@linaro.org wrote:
NeilBrown ne...@suse.de writes:
[...]
My patch was fixing a real hang when musb was built-in (or loaded), in
host-mode (mini-A cable attached) but no devices attached. I just tried
-Original Message-
From: Paul Walmsley [mailto:p...@pwsan.com]
Sent: Wednesday, February 13, 2013 2:19 AM
To: J, KEERTHY
Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org
Subject: RE: [PATCH] ARM: OMAP: Clock: Remove CK_* flags
On Tue, 12 Feb 2013, J, KEERTHY
On Tuesday 12 February 2013 08:48 PM, Kevin Hilman wrote:
Santosh Shilimkar santosh.shilim...@ti.com writes:
On Saturday 09 February 2013 02:49 AM, Kevin Hilman wrote:
Santosh Shilimkar santosh.shilim...@ti.com writes:
Current CPU PM code code make use of common cpu_suspend() path for all
Clean up McPDM driver with devm_ function.
Signed-off-by: Sebastien Guiriec s-guir...@ti.com
---
sound/soc/omap/omap-mcpdm.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc/omap/omap-mcpdm.c
index 5ca11bd..079f277
Clean up dmic code with devm_request_and_ioremap function.
Signed-off-by: Sebastien Guiriec s-guir...@ti.com
---
sound/soc/omap/omap-dmic.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
index
54 matches
Mail list logo
