Re: [PATCH v8 3/6] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe

2013-10-12 Thread Brian Norris
Hi Pekon, On 10/12/2013 04:58 PM, Gupta, Pekon wrote: From: Brian Norris [mailto:computersforpe...@gmail.com] On Fri, Oct 11, 2013 at 07:06:40PM +0530, Pekon Gupta wrote: [...] Why do you even need the #ifdef's for the #include's? It is not harmful to include headers for stuff that is only co

Re: [PATCH v8 0/6] mtd:nand:omap2: clean-up of supported ECC schemes

2013-10-12 Thread Brian Norris
Hi Pekon, On 10/12/2013 03:26 PM, Gupta, Pekon wrote: I will try to summarize the standing of your patch series. Patches 1 and 2 look good and have addressed all of the DT maintainers' comments, AFAICT. They are ready to go in, except that the following patches are not ready; they should proba

RE: [PATCH v8 3/6] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe

2013-10-12 Thread Gupta, Pekon
Hi Brian, Thanks for such detailed review, please see some replies below.. > From: Brian Norris [mailto:computersforpe...@gmail.com] > > On Fri, Oct 11, 2013 at 07:06:40PM +0530, Pekon Gupta wrote: [...] > Why do you even need the #ifdef's for the #include's? It is not harmful > to include header

RE: [PATCH v8 0/6] mtd:nand:omap2: clean-up of supported ECC schemes

2013-10-12 Thread Gupta, Pekon
Hi Brain, > > Hi Pekon, > > I will try to summarize the standing of your patch series. > > Patches 1 and 2 look good and have addressed all of the DT maintainers' > comments, AFAICT. They are ready to go in, except that the following > patches are not ready; they should probably go in together.

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

2013-10-12 Thread Paul Walmsley
On Sat, 12 Oct 2013, Lokesh Vutla wrote: > Seems you missed this patch. Please consider this for this merge window. > Patch 2/2 is already taken by Paul. > Without this patch AM335x boot will crash as I mentioned in my cover letter. That won't happen since this patch from Suman got merged: http:

Re: [PATCH 00/11] ARM: OMAP2+: CM cleanup series

2013-10-12 Thread Paul Walmsley
Hi On Sat, 12 Oct 2013, Tero Kristo wrote: > Hmm what? No it doesn't have any dependency. At most, there could be merge > conflicts between the two, as this is completely separated set. Thanks, looks like I accidentally mixed this set with your other one. - Paul -- To unsubscribe from this lis

Re: [PATCH v2 1/2] ARM: dts: dra7-evm: Add mmc1 node for micro-sd support

2013-10-12 Thread Balaji T K
On Saturday 12 October 2013 12:46 AM, Benoit Cousson wrote: Hi Balaji, On 11/10/2013 18:44, Balaji T K wrote: On Thursday 10 October 2013 12:21 AM, Sekhar Nori wrote: On Monday 07 October 2013 09:55 PM, Balaji T K wrote: Add mmc1 dt node to dra7-evm board. Input for ldo1 regulator is controll

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

2013-10-12 Thread Lokesh Vutla
Hi Benoit, On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote: > Add the AM33xx RNG module's device tree data. > Also add Documentation file describing the data > for the RNG module. Seems you missed this patch. Please consider this for this merge window. Patch 2/2 is already taken by Paul. Wi

Re: [PATCHv7 00/36] ARM: OMAP: clock data conversion to DT

2013-10-12 Thread Tero Kristo
On 10/12/2013 01:37 AM, Paul Walmsley wrote: On Fri, 11 Oct 2013, Tero Kristo wrote: Oh yea, one additional note you probably have missed. Mike asked us to fall back to vendor specific bindings at around v6 or so of this set. Take a look at v8, we have dropped the use of generic bindings, we ar

Re: [PATCH v2] ARM: OMAP2+: wakeupgen: AM43x adaptation

2013-10-12 Thread Afzal Mohammed
Hi Tony, On Wednesday 09 October 2013 12:42 PM, Afzal Mohammed wrote: > AM43x has 224 interrupts and 7 banks, make it as maximum values. Keep > default values as earlier, if am43x is detected, update interrupts and > banks accordingly. > > Also AM43x has only one cpu, ensure that clearing bitmask

Re: [PATCH 00/11] ARM: OMAP2+: CM cleanup series

2013-10-12 Thread Tero Kristo
On 10/12/2013 05:19 AM, Paul Walmsley wrote: Hi On Fri, 11 Oct 2013, Tero Kristo wrote: A small cleanup set for CM. This basically gets rid of the omap2_cm_* register accesses from the random code locations, and gathers these under cm2xxx.c and cm3xxx.c. This is done in preparation for creatin

Re: [GIT PULL] ARM: OMAP2+: hwmod changes for v3.13

2013-10-12 Thread Afzal Mohammed
Hi Paul, On Friday 11 October 2013 10:30 PM, Paul Walmsley wrote: > The following changes since commit d0e639c9e06d44e713170031fe05fb60ebe680af: > > Linux 3.12-rc4 (2013-10-06 14:00:20 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/pjw/

[PATCH v6 11/11] ARM: OMAP2+: AM43x PRCM init

2013-10-12 Thread Afzal Mohammed
From: Ambresh K Initialise AM43x HWMOD, powerdomains and clockdomains. Signed-off-by: Ambresh K Signed-off-by: Afzal Mohammed Acked-by: Rajendra Nayak Acked-by: Tony Lindgren --- arch/arm/mach-omap2/io.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/mach-omap2/io.c b/ar

[PATCH v6 08/11] ARM: OMAP2+: hwmod: AM43x support

2013-10-12 Thread Afzal Mohammed
Add hwmod support for IP's that are present in AM43x, but not in AM335x. AM43x additional ones added here are, 1. synctimer 2. timer8-11 3. ehrpwm3-5 4. spi2-4 5. gpio4-5 AM43x pruss interconnect which is different as compared to AM335x, has been taken care. And register offsets for same hwmod's

[PATCH v6 10/11] ARM: OMAP2+: AM43x: PRCM kbuild

2013-10-12 Thread Afzal Mohammed
Build AM43x power domain, clock domain and hwmod data. Many of AM43x IP's and interconnects are similar as that in AM335x, hence AM335x hwmod data is being reused with necessary changes. Earlier the plan was to reuse AM335x specific PRCM code, but as AM43x PRCM register layout is much similar to

[PATCH v6 06/11] ARM: OMAP2+: PM: AM43x powerdomain data

2013-10-12 Thread Afzal Mohammed
From: Ambresh K Add the data file to describe all power domains in AM43x SoC. OMAP4 powerdomain operations is being reused here. Signed-off-by: Ambresh K Signed-off-by: Afzal Mohammed Acked-by: Rajendra Nayak Acked-by: Tony Lindgren --- arch/arm/mach-omap2/powerdomain.h | 1 + a

[PATCH v6 03/11] ARM: OMAP2+: hwmod: AM335x: runtime register update

2013-10-12 Thread Afzal Mohammed
Most of IP's in AM335x is present on AM43x and so in those cases both will use same hwmod database (except for a few cases where clock related details differ), but there is difference w.r.t register offset between these. Update register offsets at runtime based on the SoC detected to help in sharin

[PATCH v6 09/11] ARM: OMAP2+: hwmod: AM43x operations

2013-10-12 Thread Afzal Mohammed
Reuse OMAP4 operations on AM43x. Context related ops are not used on AM43x, as this would not add value when using DT and AM43x is DT only boot. This additionally helps not to add context register offset for each hwmod. Signed-off-by: Ambresh K Signed-off-by: Afzal Mohammed Acked-by: Rajendra N

[PATCH v6 05/11] ARM: OMAP2+: PRCM: AM43x definitions

2013-10-12 Thread Afzal Mohammed
Add AM43x CMINST, CDOFFS, RM_RSTST & RM_RSTCTRL definitions - minimal ones that would be used. Signed-off-by: Afzal Mohammed Acked-by: Rajendra Nayak Acked-by: Tony Lindgren --- arch/arm/mach-omap2/prcm43xx.h | 141 + 1 file changed, 141 insertions(+) c

[PATCH v6 07/11] ARM: OMAP2+: CM: AM43x clockdomain data

2013-10-12 Thread Afzal Mohammed
From: Ambresh K Add the data file to describe clock domains in AM43x SoC. OMAP4 clockdomain operations is being reused here. Signed-off-by: Ambresh K Signed-off-by: Afzal Mohammed Acked-by: Rajendra Nayak Acked-by: Tony Lindgren --- arch/arm/mach-omap2/clockdomain.h | 2 + arch/

[PATCH v6 04/11] ARM: OMAP2+: hwmod: AM335x: remove static register offs

2013-10-12 Thread Afzal Mohammed
Hwmod common to AM43x and AM335x has register offsets different. It is now updated based on SoC detection at run time, hence remove statically initialized ones. Signed-off-by: Afzal Mohammed Acked-by: Rajendra Nayak Acked-by: Tony Lindgren --- .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c

[PATCH v6 01/11] ARM: OMAP2+: CM: cm_inst offset s16->u16

2013-10-12 Thread Afzal Mohammed
From: Ankur Kishore Most of the AM43x CM reg address offsets are with MSB bit '1' (on 16-bit value) leading to arithmetic miscalculations while calculating CLOCK ENABLE register's address because cm_inst field was a type of "const s16", so make it "const u16". Also modify relevant functions so a

[PATCH v6 00/11] ARM: OMAP2+: AM43x PRCM basic support

2013-10-12 Thread Afzal Mohammed
Hi Paul, This series adds PRCM support (except clock tree) for AM43x SoC's. Please consider this for inclusion in the coming merge window. This series has been tested on real silicon in AM43x EPOS EVM board with the help of Tero's DT clock series and booted to prompt. This has been tested on AM33