Re: [PATCH] ARM: dts: N900: GPIO key definitions

2013-10-27 Thread Pavel Machek
On Tue 2013-10-22 14:49:38, Sebastian Reichel wrote: Add device tree node for the GPIO keys provided by the N900 board. This is a simple conversion of the existing board code. Signed-off-by: Sebastian Reichel s...@debian.org Reviewed-by: Pavel Machek pa...@ucw.cz -- (english)

Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support

2013-10-27 Thread Pavel Machek
Hi! Add device tree support for twl4030 keypad driver and update the Documentation with twl4030 keypad device tree binding information. Tested on Nokia N900. It looks pretty good. +++ b/Documentation/devicetree/bindings/input/twl4030-keypad.txt @@ -0,0 +1,31 @@ +* TWL4030's Keypad

Re: [PATCH] ARM: dts: N900: GPIO key definitions

2013-10-27 Thread Sebastian Reichel
On Sun, Oct 27, 2013 at 12:17:28PM +0100, Pavel Machek wrote: On Tue 2013-10-22 14:49:38, Sebastian Reichel wrote: Add device tree node for the GPIO keys provided by the N900 board. This is a simple conversion of the existing board code. Signed-off-by: Sebastian Reichel s...@debian.org

Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support

2013-10-27 Thread Sebastian Reichel
Hi Pavel, On Sun, Oct 27, 2013 at 12:17:15PM +0100, Pavel Machek wrote: Add device tree support for twl4030 keypad driver and update the Documentation with twl4030 keypad device tree binding information. Tested on Nokia N900. It looks pretty good. Thanks. + * keypad,num-rows and

Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support

2013-10-27 Thread Pavel Machek
Hi! + * keypad,num-rows and keypad,num-columns are required. Is keypad, prefix neccessary here? See Documentation/devicetree/bindings/input/matrix-keymap.txt +Optional Properties specific to linux: +- linux,keypad-no-autorepeat: do no enable autorepeat feature. do not

Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support

2013-10-27 Thread Tony Lindgren
* Pavel Machek pa...@ucw.cz [131027 04:48]: +#if IS_ENABLED(CONFIG_OF) I'm probably missing something here, but why not #ifdef CONFIG_OF? I have been told for other drivers, that IS_ENABLED() is the prefered way to check for configuration these days. CONFIG_OF can not be module,

Re: [PATCH 1/6] ARM: OMAP2+: Remove board-4430sdp.c

2013-10-27 Thread Javier Martinez Canillas
Hi Tomi, On Mon, Jul 22, 2013 at 11:40 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 08/07/13 17:21, Russell King - ARM Linux wrote: Also looks like the nonfunctional video stuff is even more nonfunctional than usual: omapdss DSI error: can't get VDDS_DSI regulator omapdss HDMI error:

[PATCH 1/4] wl1251: split wl251 platform data to a separate structure

2013-10-27 Thread Sebastian Reichel
From: Luciano Coelho coe...@ti.com Move the wl1251 part of the wl12xx platform data structure into a new structure specifically for wl1251. Change the platform data built-in block and board files accordingly. Cc: Tony Lindgren t...@atomide.com Signed-off-by: Luciano Coelho coe...@ti.com

[PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-10-27 Thread Sebastian Reichel
Move the power GPIO handling from the board code into the driver. This is a dependency for device tree support. Signed-off-by: Sebastian Reichel s...@debian.org --- arch/arm/mach-omap2/board-omap3pandora.c | 2 ++ arch/arm/mach-omap2/board-rx51-peripherals.c | 11 ++

[PATCH 0/4] wl1251 device tree support

2013-10-27 Thread Sebastian Reichel
Hi, The following patchset adds device tree support to the spi variant of the wl1251 driver. Some notes: The first patch is from Luciano's wilink DT support patchset [0]. The third patch (vio regulator support) is optional. N900's wifi also worked without this patch, but its probably cleaner

[PATCH 3/4] wl1251: spi: add vio regulator support

2013-10-27 Thread Sebastian Reichel
This patch adds support for requesting the regulator powering the vio pin. The patch also adds the regulator for the all boards using the wl1251 in spi mode (only the Nokia N900). Signed-off-by: Sebastian Reichel s...@debian.org --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++

[PATCH 4/4] wl1251: spi: add device tree support

2013-10-27 Thread Sebastian Reichel
Add device tree support for the spi variant of wl1251 and document the binding. Signed-off-by: Sebastian Reichel s...@debian.org --- .../devicetree/bindings/net/wireless/ti,wl1251.txt | 36 ++ drivers/net/wireless/ti/wl1251/spi.c | 23 ++ 2 files

Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support

2013-10-27 Thread Sebastian Reichel
On Sun, Oct 27, 2013 at 05:23:48AM -0700, Tony Lindgren wrote: * Pavel Machek pa...@ucw.cz [131027 04:48]: +#if IS_ENABLED(CONFIG_OF) I'm probably missing something here, but why not #ifdef CONFIG_OF? I have been told for other drivers, that IS_ENABLED() is the prefered way to

Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-10-27 Thread Sebastian Reichel
On Sun, Oct 27, 2013 at 08:24:16PM +0400, Alexander Shiyan wrote: Move the power GPIO handling from the board code into the driver. This is a dependency for device tree support. Signed-off-by: Sebastian Reichel s...@debian.org --- arch/arm/mach-omap2/board-omap3pandora.c | 2 ++

[RFC 3/4] ASoC: Allow Aux Codecs to be specified using DT

2013-10-27 Thread Sebastian Reichel
This patch adds support for specifying auxiliary codecs and codec configuration via device tree phandles. This change adds new fields to snd_soc_aux_dev and snd_soc_codec_conf and adds support for the changes to SoC core methods. Signed-off-by: Sebastian Reichel s...@debian.org ---

[RFC 1/4] ASoC: omap: rx51: Use snd_soc_register_card

2013-10-27 Thread Sebastian Reichel
From: Pali Rohár pali.ro...@gmail.com This patch converts the rx51 ASoC module to use snd_soc_register_card. It also adds module alias to support driver autoloading. Signed-off-by: Pali Rohár pali.ro...@gmail.com Signed-off-by: Sebastian Reichel s...@debian.org --- sound/soc/omap/rx51.c | 49

[RFC 4/4] ASoC: RX-51: Add DT support to sound driver

2013-10-27 Thread Sebastian Reichel
This patch adds device tree support to the Nokia N900 audio driver. It also removes GPIO defines and gets them from platform data / device tree, since some GPIO numbers may be different with DT boot. The binding also changes a helper function in omap-mcbsp, which is currently only used by the

[RFC 2/4] ARM: OMAP: rx51: Register audio device

2013-10-27 Thread Sebastian Reichel
From: Pali Rohár pali.ro...@gmail.com This patch adds support for the audio chip to the legacy boardcode of the Nokia N900. Signed-off-by: Pali Rohár pali.ro...@gmail.com Signed-off-by: Sebastian Reichel s...@debian.org --- arch/arm/mach-omap2/board-rx51-peripherals.c | 11 +++ 1 file

[RFC 0/4] DT support for rx51-audio

2013-10-27 Thread Sebastian Reichel
Hi, This patchset adds DT support in rx51-audio. I tested it on the Nokia N900 and was able to play sound with aplay using earphones and earspeaker. The Loudspeakers did not work. I don't know the reason. The patchset consists of 4 patches: 1. convert rx51-audio to snd_soc_register_card() 2.

[PATCH 3/3] omap2: gpmc: Move legacy GPMC width setting

2013-10-27 Thread Ezequiel Garcia
After the introduction of gpmc_set_legacy(), move the GPMC width setting to be done inside it. Currently, in the DT probed case, this is (wrongly) done twice: first at gpmc_read_settings_dt(), and then based in the NAND width setting. Fix this and use only the value obtained from the DT.

[PATCH 1/3] omap2: gpmc: Move initialization outside the gpmc_t condition

2013-10-27 Thread Ezequiel Garcia
This commit moves a bunch of initialization previously enclosed under a 'if (gpmc_t)' check, to be outside such condition. These initializations are not related to gpmc_t (timings) in any way so it's nonsense to enclose them under such check. Signed-off-by: Ezequiel Garcia

[PATCH 2/3] omap2: gpmc: Introduce gpmc_set_legacy()

2013-10-27 Thread Ezequiel Garcia
Introduce a helper function to complete the setting of some GPMC parameters, only used when the gpmc is probed from a board file. As such, it will go away once the DT conversion is completed. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-nand.c |

[PATCH 0/3] omap2: Assorted GPMC cleanups

2013-10-27 Thread Ezequiel Garcia
(I'm CCing the MTD list, because GPMC is the memory controller used for NOR, NAND and OneNAND devices). Hi all, Just a small patchset containing two small cleanups and a minor fix for the GPMC memory controller. The first two are cleanups and can be considered as preparation work for the fix.