Re: [PATCH 0/5] Add more device nodes for am43x-epos-evm

2013-11-27 Thread Sathya Prakash
On Wednesday 27 November 2013 01:00 PM, Sourav Poddar wrote: The patch series adds support for enabling pwm backlight, i2c2, spi and matrix gpio keys on am43x-gp-evm. Seems a typo - series is for epos evm. Done on top of 3.13-rc1 + tero clock series(1) [1]:

Re: [PATCH 0/5] Add more device nodes for am43x-epos-evm

2013-11-27 Thread Sourav Poddar
On Wednesday 27 November 2013 01:38 PM, Sathya Prakash wrote: On Wednesday 27 November 2013 01:00 PM, Sourav Poddar wrote: The patch series adds support for enabling pwm backlight, i2c2, spi and matrix gpio keys on am43x-gp-evm. Seems a typo - series is for epos evm. Yes, true. The series if

Re: [PATCHv10 41/41] ARM: OMAP3: use DT clock init if DT data is available

2013-11-27 Thread Tero Kristo
On 11/26/2013 07:44 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [131126 00:10]: OMAP3 platforms support both DT and non-DT boot at the moment, make the clock init work according to the used setup. We're making omap3 to be DT only as well, so it might make sense to drop the omap3

Re: [PATCHv10 31/41] ARM: OMAP2+: clock: add support for regmap

2013-11-27 Thread Tero Kristo
On 11/26/2013 07:40 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [131126 00:10]: Using regmap is required for isolating the actual memory access from the clock code. Now, the driver providing the support for the clock IP block can provide a regmap for this purpose. Signed-off-by:

[PATCH] ARM: OMAP2+: Powerdomain: Fix unchecked dereference of arch_pwrdm

2013-11-27 Thread Rajendra Nayak
Commit 'cd8abed' ARM: OMAP2+: Powerdomain: Remove the need to always have a voltdm associated to a pwrdm leads to the following Smatch complaint: arch/arm/mach-omap2/powerdomain.c:131 _pwrdm_register() error: we previously assumed 'arch_pwrdm' could be null (see line 105) So, fix the

Re: [PATCH] mfd: twl-core: Clean up module by removing twl603x pdata handling

2013-11-27 Thread Lee Jones
On Thu, 21 Nov 2013, Ruslan Ruslichenko wrote: Since currently nobody uses TWL603x platform data and all new Hmm... when you say nobody, how did you come to this conclusion? Without digging into it and probably not that relevant, it appears there is some references to it in platform data

Re: [PATCH v6] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-27 Thread Sekhar Nori
+ Kevin On Monday 25 November 2013 11:04 PM, Joel Fernandes wrote: On 11/17/2013 04:19 PM, Daniel Mack wrote: This patch makes the edma driver resume correctly after suspend. Tested on an AM33xx platform with cyclic audio streams and omap_hsmmc. All information can be reconstructed by

Re: [PATCH v6] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-27 Thread Daniel Mack
On 11/27/2013 02:22 PM, Sekhar Nori wrote: + Kevin On Monday 25 November 2013 11:04 PM, Joel Fernandes wrote: On 11/17/2013 04:19 PM, Daniel Mack wrote: This patch makes the edma driver resume correctly after suspend. Tested on an AM33xx platform with cyclic audio streams and omap_hsmmc.

Re: [PATCH v6] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-27 Thread Sekhar Nori
+ Kevin On Monday 18 November 2013 03:49 AM, Daniel Mack wrote: This patch makes the edma driver resume correctly after suspend. Tested on an AM33xx platform with cyclic audio streams and omap_hsmmc. All information can be reconstructed by already known runtime information. As we now use

Re: [PATCH v6] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-27 Thread Daniel Mack
Hi Sekhar, On 11/27/2013 02:35 PM, Sekhar Nori wrote: On Monday 18 November 2013 03:49 AM, Daniel Mack wrote: +static int edma_pm_suspend(struct device *dev) +{ +int j, r; + +r = pm_runtime_get_sync(dev); +if (IS_ERR_VALUE(r)) { So IS_ERR_VALUE() is only for functions which

[PATCH] i2c: omap: raw read and write endian fix

2013-11-27 Thread Taras Kondratiuk
From: Victor Kamensky victor.kamen...@linaro.org All OMAP IP blocks expect LE data, but CPU may operate in BE mode. Need to use endian neutral functions to read/write h/w registers. I.e instead of __raw_read[lw] and __raw_write[lw] functions code need to use read[lw]_relaxed and write[lw]_relaxed

[PATCH v7] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-27 Thread Daniel Mack
This patch makes the edma driver resume correctly after suspend. Tested on an AM33xx platform with cyclic audio streams and omap_hsmmc. All information can be reconstructed by already known runtime information. As we now use some functions that were previously only used from __init context,

Re: [PATCH v6] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-27 Thread Sekhar Nori
On Wednesday 27 November 2013 07:17 PM, Daniel Mack wrote: Hi Sekhar, On 11/27/2013 02:35 PM, Sekhar Nori wrote: On Monday 18 November 2013 03:49 AM, Daniel Mack wrote: +static int edma_pm_suspend(struct device *dev) +{ + int j, r; + + r = pm_runtime_get_sync(dev); + if

Re: HYP Kernel boot requirements

2013-11-27 Thread Lorenzo Pieralisi
On Tue, Nov 26, 2013 at 09:49:10PM +, Santosh Shilimkar wrote: On Tuesday 26 November 2013 12:37 PM, Dave Martin wrote: On Tue, Nov 26, 2013 at 09:47:13AM -0500, Santosh Shilimkar wrote: On Tuesday 26 November 2013 09:13 AM, Catalin Marinas wrote: On Mon, Nov 25, 2013 at 07:44:08PM

[PATCH v2] ARM: OMAP4/highbank: Flush L2 cache before disabling

2013-11-27 Thread Taras Kondratiuk
Kexec disables outer cache before jumping to reboot code, but it doesn't flush it explicitly. Flush is done implicitly inside of l2x0_disable(). But some SoC's override default .disable handler and don't flush cache. This may lead to a corrupted memory during Kexec reboot on these platforms. This

musb host mode suspend mode

2013-11-27 Thread Michael Trimarchi
Hi Felipe, I'm trying to understand how dpll_usb and vbus should work in suspend mode. What I have in my kernel 3.0.31 from ti is that if I suspend the device with id pin ground and no device connected I have: - vbus 5v - dpll_usb locked problem so l3domain can not suspend If I have the id pin

Re: [PATCH 1/2] ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx

2013-11-27 Thread Balaji T K
On Thursday 21 November 2013 10:57 PM, Dan Murphy wrote: On 11/21/2013 10:58 AM, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [131121 05:51]: pin mux wl12xx_gpio and wl12xx_pins should be part of omap4_pmx_core and not omap4_pmx_wkup. So, move wl12xx_* to omap4_pmx_core. Fix the

Re: [PATCH 1/2] ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx

2013-11-27 Thread Balaji T K
On Wednesday 27 November 2013 03:25 AM, Tony Lindgren wrote: * Dan Murphy dmur...@ti.com [131121 09:28]: On 11/21/2013 10:58 AM, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [131121 05:51]: pin mux wl12xx_gpio and wl12xx_pins should be part of omap4_pmx_core and not omap4_pmx_wkup. So,

Re: [PATCH 1/2] ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx

2013-11-27 Thread Tony Lindgren
* Balaji T K balaj...@ti.com [131127 08:30]: On Wednesday 27 November 2013 03:25 AM, Tony Lindgren wrote: * Dan Murphy dmur...@ti.com [131121 09:28]: On 11/21/2013 10:58 AM, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [131121 05:51]: pin mux wl12xx_gpio and wl12xx_pins should be part of

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-27 Thread Balaji T K
On Tuesday 26 November 2013 04:16 AM, Tony Lindgren wrote: * Andreas Fenkart afenk...@gmail.com [131125 05:30]: --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -452,10 +475,23 @@ static int omap_hsmmc_gpio_init(struct omap_mmc_platform_data *pdata) } else

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-27 Thread Tony Lindgren
* Balaji T K balaj...@ti.com [131127 09:00]: On Tuesday 26 November 2013 04:16 AM, Tony Lindgren wrote: This patch we can now make a bit more generic with the recent addition of interrupts-extended property that's now merged in mainline tree :) We can optionally pass two interrupts to

RE: [PATCH v2 1/3] power_supply: Add power_supply notifier

2013-11-27 Thread Tc, Jenny
Subject: [PATCH v2 1/3] power_supply: Add power_supply notifier This patch adds a notifier chain to the power_supply. This notifier helps drivers in other subsystem to listen to changes in power supply subsystem. This would help to take some actions in those drivers on changing the

Re: [PATCH 1/8] net: smc91x: Fix device tree based configuration so it's usable

2013-11-27 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [131116 07:17]: Here's what I was thinking with the reg-io-width-mask. Anybody have comments on using reg-io-width vs reg-io-width-mask? ... --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -,11 +2234,31 @@ static int

[PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support

2013-11-27 Thread Jarkko Nikula
This adds typical McBSP2-TWL4030 audio description to the legacy Beagle Board. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/boot/dts/omap3-beagle.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/omap3-beagle.dts

[PATCH 03/13] mfd: menelaus: convert to threaded irq

2013-11-27 Thread Felipe Balbi
we don't need that extra workqueue when we have generic threaded irq handlers support. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/mfd/menelaus.c

[PATCH 01/13] mfd: menelaus: drop __exit section annotation

2013-11-27 Thread Felipe Balbi
we could build that as a driver. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index ad25bfa..975ff9e 100644 --- a/drivers/mfd/menelaus.c +++

[PATCH 12/13] mfd: menelaus: switch all children to threaded_irq

2013-11-27 Thread Felipe Balbi
now that we have our own irq_chip, all children can use traditional request_threaded_irq(). While at that, also remove so functions which became unused. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 161 +++-- 1 file changed,

[PATCH 10/13] mfd: menelaus: pass menelaus_chip argument to menelaus - time helpers

2013-11-27 Thread Felipe Balbi
time_to_menelaus() and menelaus_to_time() are static and can easily receive a struct menelaus_chip pointer argument. After this patch, the_menelaus is only used on exported functions which are currently being used by board-n8x0.c. Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH 11/13] mfd: menelaus: start to use irqdomain

2013-11-27 Thread Felipe Balbi
introduce an irq_chip and irq_domain for menelaus driver. Following patches will convert uses to traditional request_threaded_irq(). Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 109 + 1 file changed, 109 insertions(+)

[PATCH 08/13] mfd: menelaus: pass menelaus_chip pointer to add/remove irq functions

2013-11-27 Thread Felipe Balbi
those functions are static and can receive a menelaus_chip pointer very easily. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 57 ++ 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/menelaus.c

[PATCH 04/13] mfd: menelaus: remove unnecessary loop

2013-11-27 Thread Felipe Balbi
we can let irqs refire and give the scheduler a chance to choose when we should be scheduled. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 43 +++ 1 file changed, 19 insertions(+), 24 deletions(-) diff --git

[PATCH 13/13] mfd: menelaus: remove unnecessary definition

2013-11-27 Thread Felipe Balbi
menelaus_i2c_driver isn't referenced on probe, just remove that unnecessary line. No functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index e7006e4..376f01d

[PATCH 09/13] mfd: menelaus: pass menelaus_chip pointer to get/set voltage

2013-11-27 Thread Felipe Balbi
those functions are static and can easily receive a menelaus_chip pointer argument. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 50 +++--- 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/menelaus.c

[PATCH 05/13] mfd: menelaus: use for_each_set_bit()

2013-11-27 Thread Felipe Balbi
that macro just helps removing some extra line of code and hides ffs() calls. while at that, also fix a variable shadowing bug where 'int irq' was being redeclared inside inner loop while it was also argument to interrupt handler. Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH 06/13] mfd: menelaus: pass menelaus pointer as argument to enable/disable irq

2013-11-27 Thread Felipe Balbi
we want to, eventually, get rid of the global the_menelaus pointer, so let's start passing menelaus as argument to some function calls and slowly phase out the_menelaus global pointer. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 48

[PATCH 07/13] mfd: menelaus: limit the usage of the_menelaus

2013-11-27 Thread Felipe Balbi
pass a menelaus_chip pointer as argument to most functions so we can minimize the usage of the global the_menelaus pointer. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 265 ++--- 1 file changed, 142 insertions(+), 123

[PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-27 Thread Felipe Balbi
few cleanups on the old menelaus driver. I don't have HW to test these patches, maybe Aaro can help here ? cheers Felipe Balbi (13): mfd: menelaus: drop __exit section annotation mfd: menelaus: switch over to module_i2c_driver mfd: menelaus: convert to threaded irq mfd: menelaus: remove

[PATCH 02/13] mfd: menelaus: switch over to module_i2c_driver

2013-11-27 Thread Felipe Balbi
just a macro to remove some boilerplate code, no functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index

Re: [PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-27 Thread Aaro Koskinen
On Wed, Nov 27, 2013 at 01:06:44PM -0600, Felipe Balbi wrote: few cleanups on the old menelaus driver. I don't have HW to test these patches, maybe Aaro can help here ? Hmm, I got: [1.33] Unable to handle kernel NULL pointer dereference at virtual address [1.34] pgd =

Re: [PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-27 Thread Felipe Balbi
Hi, On Wed, Nov 27, 2013 at 10:02:47PM +0200, Aaro Koskinen wrote: On Wed, Nov 27, 2013 at 01:06:44PM -0600, Felipe Balbi wrote: few cleanups on the old menelaus driver. I don't have HW to test these patches, maybe Aaro can help here ? Hmm, I got: [1.33] Unable to handle kernel

Re: [PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-27 Thread Aaro Koskinen
Hi, On Wed, Nov 27, 2013 at 02:11:49PM -0600, Felipe Balbi wrote: On Wed, Nov 27, 2013 at 10:02:47PM +0200, Aaro Koskinen wrote: On Wed, Nov 27, 2013 at 01:06:44PM -0600, Felipe Balbi wrote: few cleanups on the old menelaus driver. I don't have HW to test these patches, maybe Aaro can

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

2013-11-27 Thread Jarkko Nikula
Hi Chris On Tue, 26 Nov 2013 18:33:50 -0500 Chris Ball c...@laptop.org wrote: Hi Tony, On Mon, Nov 18 2013, Tony Lindgren wrote: We are wrongly relying on device id for the DMA configuration which can lead to wrong DMA channel being selected. Fix the issue by using the standard

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Pali Rohár
On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: 2 seems more generic to me, but as rx51-battery is missing the functionality to send events on temperature change, I guess 1 will be easier to implement. The temperature must be polled anyway, if the ADC does not support

[PATCH RESEND v2] ARM: OMAPFB: panel-sony-acx565akm: fix bad unlock balance

2013-11-27 Thread Aaro Koskinen
When booting Nokia N900 smartphone with v3.12 + omap2plus_defconfig (LOCKDEP enabled) and CONFIG_DISPLAY_PANEL_SONY_ACX565AKM enabled, the following BUG is seen during the boot: [7.302154] = [7.307128] [ BUG: bad unlock balance detected! ] [

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

2013-11-27 Thread Tony Lindgren
* Jarkko Nikula jarkko.nik...@bitmer.com [131127 12:55]: Hi Chris On Tue, 26 Nov 2013 18:33:50 -0500 Chris Ball c...@laptop.org wrote: Hi Tony, On Mon, Nov 18 2013, Tony Lindgren wrote: We are wrongly relying on device id for the DMA configuration which can lead to wrong DMA

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

2013-11-27 Thread Chris Ball
Hi, On Wed, Nov 27 2013, Jarkko Nikula wrote: Can you enlighten me what's the proper way to get patches to mmc since I cannot figure out working methodology from MAINTAINERS file? Sorry about this, Jarkko. Since I don't have omap.c hardware, I'm generally going to wait for a

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

2013-11-27 Thread Tony Lindgren
* Chris Ball c...@laptop.org [131127 13:48]: Hi, On Wed, Nov 27 2013, Jarkko Nikula wrote: Can you enlighten me what's the proper way to get patches to mmc since I cannot figure out working methodology from MAINTAINERS file? Sorry about this, Jarkko. Since I don't have omap.c

Re: [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support

2013-11-27 Thread Tony Lindgren
* Jarkko Nikula jarkko.nik...@bitmer.com [131127 10:48]: This adds typical McBSP2-TWL4030 audio description to the legacy Beagle Board. Nice to see that work almost out of the box :) BTW, I just noticed that sound/soc/omap/Kconfig has depends on OMAP_MUX. The OMAP_MUX option will be dropped

pm_runtime functions and IS_ERR_VALUE (was Re: [PATCH v6] ARM: omap: edma: add suspend suspend/resume hooks)

2013-11-27 Thread Nishanth Menon
Change in subject line + wider forum On 19:24-20131127, Sekhar Nori wrote: On Wednesday 27 November 2013 07:17 PM, Daniel Mack wrote: On 11/27/2013 02:35 PM, Sekhar Nori wrote: On Monday 18 November 2013 03:49 AM, Daniel Mack wrote: +static int edma_pm_suspend(struct device *dev

Re: Status of 1GHz support on am37xx

2013-11-27 Thread Mark A. Greer
On Tue, Nov 26, 2013 at 09:49:27AM -0600, Nishanth Menon wrote: On 11/25/2013 05:35 PM, Tony Lindgren wrote: * Mark A. Greer mgr...@animalcreek.com [131122 15:02]: Hello. I was wondering what that the status of 1GHz support for the am37xx is. It looks like smartreflex/avs and ABB

Re: [PATCH 1/2] ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx

2013-11-27 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [131127 08:49]: * Balaji T K balaj...@ti.com [131127 08:30]: On Wednesday 27 November 2013 03:25 AM, Tony Lindgren wrote: * Dan Murphy dmur...@ti.com [131121 09:28]: On 11/21/2013 10:58 AM, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [131121 05:51]:

Re: [pandaboard] wl12xx borked after one up/down cycle

2013-11-27 Thread Tony Lindgren
* Tobias Jakobi tjak...@math.uni-bielefeld.de [131026 14:58]: And another one: https://bugzilla.kernel.org/show_bug.cgi?id=63821 OK this one turned out to be a pin mux issue probably caused by a mismerge while rebasing patches for v3.10. See the thread [PATCH 0/2] ARM: dts: omap4: Fix pin

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Sebastian Reichel
On Wed, Nov 27, 2013 at 10:16:47PM +0100, Pali Rohár wrote: On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: 2 seems more generic to me, but as rx51-battery is missing the functionality to send events on temperature change, I guess 1 will be easier to implement. The

Re: [PATCHv10 00/41] ARM: TI SoC clock DT conversion

2013-11-27 Thread Nishanth Menon
On 11/26/2013 02:05 AM, Tero Kristo wrote: Hi, Changes compared to v9: - rebased on top of 3.13-rc1 - modified the low level clk register API to provide SoC specific clk_readl and clk_writel support which can be registered during boot, TI SoC variant uses regmap on low level - dropped

Re: [PATCH] ARM: OMAP2+: Powerdomain: Fix unchecked dereference of arch_pwrdm

2013-11-27 Thread Nishanth Menon
On 11/27/2013 05:57 AM, Rajendra Nayak wrote: Commit 'cd8abed' ARM: OMAP2+: Powerdomain: Remove the need to always have a voltdm associated to a pwrdm leads to the following Smatch complaint: arch/arm/mach-omap2/powerdomain.c:131 _pwrdm_register() error: we previously assumed

Re: [PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-27 Thread Felipe Balbi
Hi, On Wed, Nov 27, 2013 at 10:46:21PM +0200, Aaro Koskinen wrote: Hi, On Wed, Nov 27, 2013 at 02:11:49PM -0600, Felipe Balbi wrote: On Wed, Nov 27, 2013 at 10:02:47PM +0200, Aaro Koskinen wrote: On Wed, Nov 27, 2013 at 01:06:44PM -0600, Felipe Balbi wrote: few cleanups on the old

Re: [PATCH 09/17] spi/spi.h: Add mem variable in spi master.

2013-11-27 Thread Sourav Poddar
On Tuesday 26 November 2013 06:50 PM, Mark Brown wrote: On Tue, Nov 26, 2013 at 06:35:35PM +0530, Sourav Poddar wrote: On Tuesday 26 November 2013 06:31 PM, Mark Brown wrote: Is this really generic enough to put here rather than in the driver data? The thought behind this was that if a master

Re: [PATCH 06/17] spi/qspi: Add support to switc to memory mapped operation.

2013-11-27 Thread Sourav Poddar
On Tuesday 26 November 2013 06:27 PM, Mark Brown wrote: On Tue, Nov 26, 2013 at 01:05:02PM +0530, Sourav Poddar wrote: +void enable_qspi_memory_mapped(struct ti_qspi *qspi) +void disable_qspi_memory_mapped(struct ti_qspi *qspi) These are driver internal functions so they should be static.

Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-27 Thread Sourav Poddar
On Tuesday 26 November 2013 05:54 PM, Mark Brown wrote: On Tue, Nov 26, 2013 at 04:47:49PM +0530, Sourav Poddar wrote: I have added reg-names property in dt bindings. (17/17) patch of this series has that info. Do device tree binding changes early on in the series rather than at the end, one

Re: [PATCH 02/17] spi/spi.h: Add configure from slave support.

2013-11-27 Thread Sourav Poddar
On Tuesday 26 November 2013 05:51 PM, Mark Brown wrote: On Tue, Nov 26, 2013 at 04:51:53PM +0530, Sourav Poddar wrote: On Tuesday 26 November 2013 03:59 PM, Mark Brown wrote: + void(*configure_from_slave)(struct spi_device *spi, u8 *val); Clearly this is far too unstructured to be

Re: [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

2013-11-27 Thread Sourav Poddar
Hi Mark, On Tuesday 26 November 2013 06:41 PM, Mark Brown wrote: On Tue, Nov 26, 2013 at 01:05:08PM +0530, Sourav Poddar wrote: Idea is to enable memory mapped by default at the end of the probe, if the control reaches the transfer api, then the operation is not a memory mapped one. Hence, we

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Pali Rohár
On Thursday 28 November 2013 01:25:50 Sebastian Reichel wrote: On Wed, Nov 27, 2013 at 10:16:47PM +0100, Pali Rohár wrote: On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: 2 seems more generic to me, but as rx51-battery is missing the functionality to send events on

[PATCH V2] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-11-27 Thread anaumann
From: Andreas Naumann anaum...@ultratronik.de This is a hard to reproduce problem which leads to non-functional USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit e25bec160158abe86c276d7d206264afc3646281, which introduces save/restore of OTG_INTERFSEL over suspend. Since the resume