Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Heikki Krogerus
Hi, On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus I think setup instead of tune is much more clear and reusable. I think setup will look more like first time setting up the phy, which is rather served by init callback. This

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Kishon Vijay Abraham I
On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: Hi, On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: Hi, Thanks for reviewing this. On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: Some PHY controllers may need to tune

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi, On Wed, Dec 11, 2013 at 1:39 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: Hi, On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus I think setup instead of tune is much more clear and reusable. I think setup will

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi Kishon, On Wed, Dec 11, 2013 at 1:47 PM, Kishon Vijay Abraham I kis...@ti.com wrote: On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: Hi, On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: Hi, Thanks for reviewing this. On Tue, Dec

Re: [PATCH v3 04/10] usb: dwc3: use quirks to know if a particualr platform doesn't have PHY

2013-12-11 Thread Heikki Krogerus
Hi, On Mon, Dec 09, 2013 at 11:26:04AM +0200, Heikki Krogerus wrote: Can you guys explain why is something like this needed? Like with clocks and gpios, the device drivers shouldn't need to care any more if the platform has the phys or not. -ENODEV tells you your platform Shouldn't we

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Heikki Krogerus
Hi again, On Wed, Dec 11, 2013 at 02:02:43PM +0530, Vivek Gautam wrote: On Wed, Dec 11, 2013 at 1:39 PM, Heikki Krogerus heikki.kroge...@linux.intel.com wrote: On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus I think setup

Re: [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain

2013-12-11 Thread Lee Jones
On Tue, 10 Dec 2013, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [131210 10:39]: Introduce an irq_chip and irq_domain for menelaus driver. Following patches will convert uses to traditional request_threaded_irq(). While at that, some better error handling had to be

Re: [PATCH v3 04/10] usb: dwc3: use quirks to know if a particualr platform doesn't have PHY

2013-12-11 Thread Kishon Vijay Abraham I
On Wednesday 11 December 2013 02:23 PM, Heikki Krogerus wrote: Hi, On Mon, Dec 09, 2013 at 11:26:04AM +0200, Heikki Krogerus wrote: Can you guys explain why is something like this needed? Like with clocks and gpios, the device drivers shouldn't need to care any more if the platform has the

Re: [PATCH v3 07/15] mfd: menelaus: Limit the usage of the_menelaus

2013-12-11 Thread Lee Jones
On Tue, 10 Dec 2013, Felipe Balbi wrote: On Tue, Dec 10, 2013 at 08:57:01AM +, Lee Jones wrote: Pass a menelaus_chip pointer as argument to most functions so we can minimize the usage of the global the_menelaus pointer. Tested-by: Aaro Koskinen aaro.koski...@iki.fi

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-11 Thread Uwe Kleine-König
On Mon, Dec 02, 2013 at 09:42:54PM -0600, Felipe Balbi wrote: we could build that as a driver. What is that. How can it not be a driver? Do you mean modular? In that case there is no problem, the only thing that doesn't work is unloading the module. Best regards Uwe Signed-off-by: Felipe

Re: [PATCH v3 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-11 Thread Uwe Kleine-König
On Mon, Dec 09, 2013 at 10:21:11AM -0600, Felipe Balbi wrote: We could build that driver as a dynamically-linked module. ups, only saw now the v3 after I commented on v2. So you addressed a part of my comment already. Still building that driver as a module also works without this patch, right? So

[PATCH 0/2] net: smc91x: add DT flags for legacy platforms

2013-12-11 Thread Nishanth Menon
Hi, SMC91x driver has been converted to device tree, however users of older lan91c94 based platform need description provided previously by platform_data. Without this, ethernet fails to function on these platforms. For example, on SDP2430: Before: http://pastebin.mozilla.org/3753793 After:

[PATCH 2/2] ARM: dts: omap2430-sdp: add flags for ethernet functionality

2013-12-11 Thread Nishanth Menon
Ethernet transition from board file to dts missed the required pdata conversion. So fix the same. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/boot/dts/omap2430-sdp.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/omap2430-sdp.dts

[PATCH 1/2] net: smc91x: Read hardware behavior flags from device tree

2013-12-11 Thread Nishanth Menon
commit 682a169 (smc91x: add devicetree support) introduced basic device tree support in the form of identifier match. However, platform_data flags equivalent was not introduced, nor was an appropriate bindings document introduced. In many legacy platforms such as Texas Instrument's SDP2430,

Re: [RFC PATCH v3 2/8] mmc: omap_hsmmc: handle vcc and vcc_aux independently

2013-12-11 Thread Ulf Hansson
On 10 December 2013 12:48, Balaji T K balaj...@ti.com wrote: On Tuesday 10 December 2013 04:39 PM, Ulf Hansson wrote: On 21 November 2013 15:20, Balaji T K balaj...@ti.com wrote: handle vcc and vcc_aux independently to reduce indent. Signed-off-by: Balaji T K balaj...@ti.com ---

Re: [PATCHv2 00/10] Add memory mapped support for ti qspi, m25p80 serial flash.

2013-12-11 Thread Marek Vasut
On Wednesday, December 11, 2013 at 05:18:45 AM, Sourav Poddar wrote: Hi Marek, On Tuesday 10 December 2013 06:19 PM, Marek Vasut wrote: On Friday, December 06, 2013 at 03:24:41 PM, Sourav Poddar wrote: The patch series aims to add memory mapped support for TI qspi contoller and also add

Re: [PATCHv2 00/10] Add memory mapped support for ti qspi, m25p80 serial flash.

2013-12-11 Thread Mark Brown
On Wed, Dec 11, 2013 at 11:44:22AM +0100, Marek Vasut wrote: On Wednesday, December 11, 2013 at 05:18:45 AM, Sourav Poddar wrote: I did a quad mode support for m25p80 which easily got cloned into the new spi framework. Same can be done for the memory mapped support too The quad mode

need help to configure IRQ on gpio 139 pandaboard using device tree

2013-12-11 Thread Denis CIOCCA
Hi everybody, I'm trying to configure an IRQ on pandaboard using device tree but I'm not able to understand how I can do it. I want to configure the the gpio_139 pin and without device tree my command was: OMAP4_MUX(MCSPI1_SIMO, OMAP_MUX_MODE3 | OMAP_PIN_INPUT_PULLUP), I need to associate it

Re: [PATCH] ARM: OMAPFB: panel-sony-acx565akm: fix missing unlock in acx565akm_panel_power_on()

2013-12-11 Thread Tomi Valkeinen
Hi, On 2013-12-06 14:55, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function acx565akm_panel_power_on() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn A fix for this has already been

Re: need help to configure IRQ on gpio 139 pandaboard using device tree

2013-12-11 Thread menon.nisha...@gmail.com
On Wed, Dec 11, 2013 at 8:28 AM, Denis CIOCCA denis.cio...@st.com wrote: Hi everybody, I'm trying to configure an IRQ on pandaboard using device tree but I'm not able to understand how I can do it. I want to configure the the gpio_139 pin and without device tree my command was:

Re: [PATCH 1/2] net: smc91x: Read hardware behavior flags from device tree

2013-12-11 Thread Tony Lindgren
* Nishanth Menon n...@ti.com [131211 02:23]: --- /dev/null +++ b/Documentation/devicetree/bindings/net/smsc91x.txt @@ -0,0 +1,45 @@ +* Smart Mixed-Signal Connectivity (SMSC) LAN91c94/91c111 Controller + +Required properties: +- compatible : Should be one of: + smsc,lan91c94 +

Re: need help to configure IRQ on gpio 139 pandaboard using device tree

2013-12-11 Thread Denis CIOCCA
Hi Nishant, Thank you very much for your suggestions! Now I understand how it works...(I hope) :D BUT, now I've checked the client-irq in an i2c driver and the value is still 0... What I have to check? Thanks, Denis On 12/11/2013 04:39 PM, menon.nisha...@gmail.com wrote: On Wed, Dec 11,

Re: need help to configure IRQ on gpio 139 pandaboard using device tree

2013-12-11 Thread Nishanth Menon
On 12/11/2013 10:25 AM, Denis CIOCCA wrote: BUT, now I've checked the client-irq in an i2c driver and the value is still 0... I missed this: and it works, but I don't know how I can set the interrupt using: interrupts = GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH; /* example */ snip What I have

Re: [PATCH 1/2] net: smc91x: Read hardware behavior flags from device tree

2013-12-11 Thread Nishanth Menon
On Wed, Dec 11, 2013 at 10:04 AM, Tony Lindgren t...@atomide.com wrote: * Nishanth Menon n...@ti.com [131211 02:23]: --- /dev/null +++ b/Documentation/devicetree/bindings/net/smsc91x.txt @@ -0,0 +1,45 @@ +* Smart Mixed-Signal Connectivity (SMSC) LAN91c94/91c111 Controller + +Required

Re: [PATCH v5 3/7] regulator: add pbias regulator support

2013-12-11 Thread Mark Brown
On Tue, Dec 10, 2013 at 08:04:58PM +0530, Balaji T K wrote: pbias register controls internal power supply to sd card i/o pads in most OMAPs (OMAP2-5, DRA7). Control bits for selecting voltage level and enabling/disabling are in the same PBIAS register. This looks OK from a regulator API point

Re: [PATCH 05/26] ARM: OMAP2+: add omapdss_init_of()

2013-12-11 Thread Laurent Pinchart
Hi Tomi, On Wednesday 04 December 2013 14:28:32 Tomi Valkeinen wrote: omapdss driver uses a omapdss platform device to pass platform specific function pointers and DSS hardware version from the arch code to the driver. This device is needed also when booting with DT. This patch adds

Re: [PATCH 06/26] OMAPDSS: if dssdev-name==NULL, use alias

2013-12-11 Thread Laurent Pinchart
Hi Tomi, On Wednesday 04 December 2013 14:28:33 Tomi Valkeinen wrote: To avoid the need for a nickname property for each display, change the display registration so that the display's alias (i.e. display0 etc) will be used for the dssdev-name if the display driver didn't provide a name.

Re: [PATCH 10/26] OMAPDSS: add of helpers

2013-12-11 Thread Laurent Pinchart
Hi Tomi, On Wednesday 04 December 2013 14:28:37 Tomi Valkeinen wrote: Add helpers to get ports and endpoints from DT data. While all the functions in dss-of.c might be useful for panel drivers if they need to parse full port/endpoint data, at the moment we only need a few of them outside

Re: [PATCH 13/26] ARM: omap3.dtsi: add omapdss information

2013-12-11 Thread Laurent Pinchart
Hi Tomi, On Monday 09 December 2013 14:45:25 Tomi Valkeinen wrote: On 2013-12-05 19:05, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [131204 04:31]: Description missing.. But other than that can you please check that the latest patch I posted in thread [PATCH] ARM:

[PATCH 1/2] net: eth: davinci_cpdma: 64-bit phys/dma_addr_t cleanup

2013-12-11 Thread Olof Johansson
Silences the below warnings when building with ARM_LPAE enabled, which gives longer dma_addr_t by default: drivers/net/ethernet/ti/davinci_cpdma.c: In function 'cpdma_desc_pool_create': drivers/net/ethernet/ti/davinci_cpdma.c:182:3: warning: passing argument 3 of 'dma_alloc_attrs' from

[PATCH 2/2] net: eth: davinci_cpdma: Mark a local variable static

2013-12-11 Thread Olof Johansson
Only used locally. Found by sparse. Signed-off-by: Olof Johansson o...@lixom.net --- drivers/net/ethernet/ti/davinci_cpdma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index

Re: [PATCH 06/26] OMAPDSS: if dssdev-name==NULL, use alias

2013-12-11 Thread Laurent Pinchart
Hi Tomi, On Thursday 12 December 2013 00:13:01 Laurent Pinchart wrote: On Wednesday 04 December 2013 14:28:33 Tomi Valkeinen wrote: To avoid the need for a nickname property for each display, change the display registration so that the display's alias (i.e. display0 etc) will be used for

[PATCH] net: eth: cpsw: 64-bit phys_addr_t and sparse cleanup

2013-12-11 Thread Olof Johansson
Minor fix for printk format of a phys_addr_t, and the switch of two local functions to static since they're not used outside of the file. Signed-off-by: Olof Johansson o...@lixom.net --- Missed this one with the previous 64-bit phys_addr_t fix. Feel free to fold it in, or apply separately.

[PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-11 Thread Grazvydas Ignotas
This is a hard to reproduce problem which leads to non-functional USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit e25bec160158abe86c omap2+: save and restore OTG_INTERFSEL, which introduces save/restore of OTG_INTERFSEL over suspend. Since the resume function is also called early

Re: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-11 Thread David Cohen
On Thu, Dec 12, 2013 at 02:20:59AM +0200, Grazvydas Ignotas wrote: This is a hard to reproduce problem which leads to non-functional USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit e25bec160158abe86c omap2+: save and restore OTG_INTERFSEL, which introduces save/restore of

Re: [PATCH 00/26] OMAPDSS: DT support (Christmas edition)

2013-12-11 Thread Laurent Pinchart
Hi Tomi, On Wednesday 04 December 2013 14:28:27 Tomi Valkeinen wrote: Hi, Here's a new version for DT support to OMAP Display Subsystem. See http://article.gmane.org/gmane.linux.ports.arm.omap/102689 for the intro of the previous version, which contains thoughts about the related problems.

Re: [PATCH 1/2] net: eth: davinci_cpdma: 64-bit phys/dma_addr_t cleanup

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:51:20 -0800 Silences the below warnings when building with ARM_LPAE enabled, which gives longer dma_addr_t by default: drivers/net/ethernet/ti/davinci_cpdma.c: In function 'cpdma_desc_pool_create':

Re: [PATCH] net: eth: cpsw: 64-bit phys_addr_t and sparse cleanup

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:58:07 -0800 Minor fix for printk format of a phys_addr_t, and the switch of two local functions to static since they're not used outside of the file. Signed-off-by: Olof Johansson o...@lixom.net Applied. -- To unsubscribe from

Re: [PATCH 2/2] net: eth: davinci_cpdma: Mark a local variable static

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:51:21 -0800 Only used locally. Found by sparse. Signed-off-by: Olof Johansson o...@lixom.net Applied. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

[PATCH 1/2] drivers: net: cpsw: fix dt probe for one port ethernet

2013-12-11 Thread Felipe Balbi
From: Mugunthan V N mugunthan...@ti.com When only one port of the two port is pinned out, then dt probe is failing because second port phy is not found. fixing this by checking the number of slaves and breaking the loop. Signed-off-by: Mugunthan V N mugunthan...@ti.com Signed-off-by: Felipe

[PATCH 2/2] drivers: net: cpsw: fix for cpsw crash when build as modules

2013-12-11 Thread Felipe Balbi
From: Mugunthan V N mugunthan...@ti.com When CPSW and Davinci MDIO are build as modules, CPSW crashes when accessing CPSW registers in CPSW probe. The same is working in built-in as the CPSW clocks are enabled in Davindi MDIO probe, SO Enabling the clocks before accessing the version register and

Re: [PATCHv2 09/10] arm: dts: dra7: Add qspi device.

2013-12-11 Thread Sourav Poddar
Hi Mark, On Tuesday 10 December 2013 04:01 PM, Mark Brown wrote: On Tue, Dec 10, 2013 at 09:55:15AM +0530, Sourav Poddar wrote: I posted this for review along with other code changes. I will post them seperately to Benoit. Please wait until the driver updates have been reviewed. I was

Re: [PATCH 05/26] ARM: OMAP2+: add omapdss_init_of()

2013-12-11 Thread Tomi Valkeinen
On 2013-12-12 01:10, Laurent Pinchart wrote: Hi Tomi, On Wednesday 04 December 2013 14:28:32 Tomi Valkeinen wrote: omapdss driver uses a omapdss platform device to pass platform specific function pointers and DSS hardware version from the arch code to the driver. This device is needed also

Re: [PATCH 06/26] OMAPDSS: if dssdev-name==NULL, use alias

2013-12-11 Thread Tomi Valkeinen
On 2013-12-12 01:56, Laurent Pinchart wrote: Hi Tomi, On Thursday 12 December 2013 00:13:01 Laurent Pinchart wrote: On Wednesday 04 December 2013 14:28:33 Tomi Valkeinen wrote: To avoid the need for a nickname property for each display, change the display registration so that the display's

Re: [PATCH 10/26] OMAPDSS: add of helpers

2013-12-11 Thread Tomi Valkeinen
On 2013-12-12 01:19, Laurent Pinchart wrote: Hi Tomi, On Wednesday 04 December 2013 14:28:37 Tomi Valkeinen wrote: Add helpers to get ports and endpoints from DT data. While all the functions in dss-of.c might be useful for panel drivers if they need to parse full port/endpoint data, at

Re: [PATCHv2 07/10] drivers: mtd: m25p80: Adapt driver to support memory mapped read.

2013-12-11 Thread Huang Shijie
On Fri, Dec 06, 2013 at 07:54:48PM +0530, Sourav Poddar wrote: Adapt driver to do a memory mapped read. @@ -109,6 +109,7 @@ struct m25p { u8 program_opcode; u8 *command; enum read_type flash_read; + void __iomem